125164 2013-12-03 10:21:58 -0800 ANGLE fails to build with trunk clang: unused constant kTraceBufferLen 2013-12-03 11:28:38 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates commit-queue dino kondapallykalyan roger_fong oldest_to_newest 955960 0 dbates 2013-12-03 10:21:58 -0800 The constant kTraceBufferLen is only referenced in code guarded by the macro define TRACE_ENABLED. And trunk clang identifies that this constant is unused otherwise. We should only define this constant when building with TRACE_ENABLED. 955962 1 218303 dbates 2013-12-03 10:23:39 -0800 Created attachment 218303 Patch 955969 2 dbates 2013-12-03 10:33:28 -0800 Filed ANGLE bug for this issue: <https://code.google.com/p/angleproject/issues/detail?id=534>. 956002 3 dbates 2013-12-03 11:28:38 -0800 Committed r160018: <http://trac.webkit.org/changeset/160018> 218303 2013-12-03 10:23:39 -0800 2013-12-03 10:49:28 -0800 Patch bug-125164-20131203102341.patch text/plain 1435 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNDgxNzc0NWRhYTI2MGE4MTQ0Njc5MzIxNzAyYmJmYTgzN2RkYmU5NS4uOTg1YjUyYzI3YzFi NTExZmRhNTIzZjkzNGM2ZjVhOWIwOGMyMTZjMSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEyLTAzICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFw cGxlLmNvbT4KKworICAgICAgICBBTkdMRSBmYWlscyB0byBidWlsZCB3aXRoIHRydW5rIGNsYW5n OiB1bnVzZWQgY29uc3RhbnQga1RyYWNlQnVmZmVyTGVuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUxNjQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIHRoZSBkZWZpbml0aW9uIG9mIHRoZSBjb25z dGFudCBrVHJhY2VCdWZmZXJMZW4gdW5kZXIgdGhlIG1hY3JvCisgICAgICAgIGd1YXJkIFRSQUNF X0VOQUJMRUQgc2luY2UgaXQncyBvbmx5IHJlZmVyZW5jZWQgaW4gY29kZSBndWFyZGVkIGJ5Cisg ICAgICAgIFRSQUNFX0VOQUJMRUQuCisKKyAgICAgICAgKiBzcmMvY29tcGlsZXIvZGVidWcuY3Bw OgorCiAyMDEzLTExLTIxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmVtb3ZlIEFOR0xFR2VuZXJhdGVkIGZyb20gV2luZG93cyBidWlsZC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9kZWJ1Zy5j cHAgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvZGVidWcuY3BwCmluZGV4 IDZhN2IwNDI1MTI3NjRhZWMwZmY2YWE3MmUyODFjNmM0ZDljMWEzZjYuLjM4ZDU1YWNhZjY3YWZh MmUxMDI4OTVjNDY5NGM1OTc5NWQ3N2I1MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL3NyYy9jb21waWxlci9kZWJ1Zy5jcHAKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2NvbXBpbGVyL2RlYnVnLmNwcApAQCAtMTQsOSArMTQsOSBAQAogI2luY2x1ZGUgImNv bXBpbGVyL0luaXRpYWxpemVQYXJzZUNvbnRleHQuaCIKICNpbmNsdWRlICJjb21waWxlci9QYXJz ZUNvbnRleHQuaCIKIAorI2lmZGVmIFRSQUNFX0VOQUJMRUQKIHN0YXRpYyBjb25zdCBpbnQga1Ry YWNlQnVmZmVyTGVuID0gMTAyNDsKIAotI2lmZGVmIFRSQUNFX0VOQUJMRUQKIGV4dGVybiAiQyIg ewogdm9pZCBUcmFjZShjb25zdCBjaGFyICpmb3JtYXQsIC4uLikgewogICAgIGlmICghZm9ybWF0 KSByZXR1cm47Cg==