125163 2013-12-03 10:15:28 -0800 [CSS Shapes] Remove explicit numbering from BasicShape::Type and CSSBasicShape::Type enums 2013-12-04 14:16:05 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98664 89256 1 zoltan zoltan commit-queue esprehn+autocc glenn gyuyoung.kim kondapallykalyan macpherson menard oldest_to_newest 955954 0 zoltan 2013-12-03 10:15:28 -0800 I don't see any reason to have explicit numbering for the Type enum in our [CSS]BasicShape classes. I removed numbering, which will decrease the merge conflicts on Type changes. 955955 1 218301 zoltan 2013-12-03 10:17:57 -0800 Created attachment 218301 proposed patch 956576 2 218301 rwlbuis 2013-12-04 13:41:18 -0800 Comment on attachment 218301 proposed patch LGTM. 956600 3 218301 commit-queue 2013-12-04 14:16:03 -0800 Comment on attachment 218301 proposed patch Clearing flags on attachment: 218301 Committed r160126: <http://trac.webkit.org/changeset/160126> 956601 4 commit-queue 2013-12-04 14:16:05 -0800 All reviewed patches have been landed. Closing bug. 218301 2013-12-03 10:17:57 -0800 2013-12-04 14:16:03 -0800 proposed patch enumremove.patch text/plain 2842 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2OTg0NmUzLi5mZDU2NmE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTItMDMgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NTUyBTaGFwZXNdIFJlbW92ZSBleHBsaWNpdCBudW1iZXJpbmcgZnJvbSBCYXNpY1No YXBlOjpUeXBlIGFuZCBDU1NCYXNpY1NoYXBlOjpUeXBlIGVudW1zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUxNjMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIGRvbid0IHNlZSBhbnkgcmVhc29uIHRv IGhhdmUgZXhwbGljaXQgbnVtYmVyaW5nIGZvciB0aGUgVHlwZSBlbnVtIGluIG91ciBbQ1NTXUJh c2ljU2hhcGUgY2xhc3Nlcy4KKyAgICAgICAgSSByZW1vdmVkIG51bWJlcmluZywgd2hpY2ggd2ls bCBkZWNyZWFzZSBmb3IgaW5zdGFuY2UgdGhlIG1lcmdlIGNvbmZsaWN0cyBvbiBUeXBlIGNoYW5n ZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAg ICAgKiBjc3MvQ1NTQmFzaWNTaGFwZXMuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvQmFz aWNTaGFwZXMuaDoKKwogMjAxMy0xMi0wMyAgRnLDqWTDqXJpYyBXYW5nICA8ZnJlZC53YW5nQGZy ZWUuZnI+CiAKICAgICAgICAgQWRkIGFuIE1hdGhNTFNlbGVjdEVsZW1lbnQgY2xhc3MgdG8gaW1w bGVtZW50IDxtYWN0aW9uPiBhbmQgPHNlbWFudGljcz4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTQmFzaWNTaGFwZXMuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NCYXNpY1No YXBlcy5oCmluZGV4IDdlMmVhZTMuLmU5MGY5ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NCYXNpY1NoYXBlcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NCYXNpY1No YXBlcy5oCkBAIC00MSwxNCArNDEsMTQgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgQ1NT QmFzaWNTaGFwZSA6IHB1YmxpYyBSZWZDb3VudGVkPENTU0Jhc2ljU2hhcGU+IHsKIHB1YmxpYzoK ICAgICBlbnVtIFR5cGUgewotICAgICAgICBDU1NCYXNpY1NoYXBlUmVjdGFuZ2xlVHlwZSA9IDEs Ci0gICAgICAgIENTU0RlcHJlY2F0ZWRCYXNpY1NoYXBlQ2lyY2xlVHlwZSA9IDIsCi0gICAgICAg IENTU0RlcHJlY2F0ZWRCYXNpY1NoYXBlRWxsaXBzZVR5cGUgPSAzLAotICAgICAgICBDU1NCYXNp Y1NoYXBlUG9seWdvblR5cGUgPSA0LAotICAgICAgICBDU1NCYXNpY1NoYXBlSW5zZXRSZWN0YW5n bGVUeXBlID0gNSwKLSAgICAgICAgQ1NTQmFzaWNTaGFwZUNpcmNsZVR5cGUgPSA2LAotICAgICAg ICBDU1NCYXNpY1NoYXBlRWxsaXBzZVR5cGUgPSA3LAotICAgICAgICBDU1NCYXNpY1NoYXBlSW5z ZXRUeXBlID0gOAorICAgICAgICBDU1NCYXNpY1NoYXBlUmVjdGFuZ2xlVHlwZSwKKyAgICAgICAg Q1NTRGVwcmVjYXRlZEJhc2ljU2hhcGVDaXJjbGVUeXBlLAorICAgICAgICBDU1NEZXByZWNhdGVk QmFzaWNTaGFwZUVsbGlwc2VUeXBlLAorICAgICAgICBDU1NCYXNpY1NoYXBlUG9seWdvblR5cGUs CisgICAgICAgIENTU0Jhc2ljU2hhcGVJbnNldFJlY3RhbmdsZVR5cGUsCisgICAgICAgIENTU0Jh c2ljU2hhcGVDaXJjbGVUeXBlLAorICAgICAgICBDU1NCYXNpY1NoYXBlRWxsaXBzZVR5cGUsCisg ICAgICAgIENTU0Jhc2ljU2hhcGVJbnNldFR5cGUKICAgICB9OwogCiAgICAgdmlydHVhbCBUeXBl IHR5cGUoKSBjb25zdCA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3R5bGUvQmFzaWNTaGFwZXMuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9CYXNp Y1NoYXBlcy5oCmluZGV4IGJkMDkyZGUuLjg3MTJhZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9CYXNpY1NoYXBlcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9CYXNpY1NoYXBlcy5oCkBAIC00NywxNCArNDcsMTQgQEAgcHVibGljOgog ICAgIHZpcnR1YWwgfkJhc2ljU2hhcGUoKSB7IH0KIAogICAgIGVudW0gVHlwZSB7Ci0gICAgICAg IEJhc2ljU2hhcGVSZWN0YW5nbGVUeXBlID0gMSwKLSAgICAgICAgRGVwcmVjYXRlZEJhc2ljU2hh cGVDaXJjbGVUeXBlID0gMiwKLSAgICAgICAgRGVwcmVjYXRlZEJhc2ljU2hhcGVFbGxpcHNlVHlw ZSA9IDMsCi0gICAgICAgIEJhc2ljU2hhcGVQb2x5Z29uVHlwZSA9IDQsCi0gICAgICAgIEJhc2lj U2hhcGVJbnNldFJlY3RhbmdsZVR5cGUgPSA1LAotICAgICAgICBCYXNpY1NoYXBlQ2lyY2xlVHlw ZSA9IDYsCi0gICAgICAgIEJhc2ljU2hhcGVFbGxpcHNlVHlwZSA9IDcsCi0gICAgICAgIEJhc2lj U2hhcGVJbnNldFR5cGUgPSA4CisgICAgICAgIEJhc2ljU2hhcGVSZWN0YW5nbGVUeXBlLAorICAg ICAgICBEZXByZWNhdGVkQmFzaWNTaGFwZUNpcmNsZVR5cGUsCisgICAgICAgIERlcHJlY2F0ZWRC YXNpY1NoYXBlRWxsaXBzZVR5cGUsCisgICAgICAgIEJhc2ljU2hhcGVQb2x5Z29uVHlwZSwKKyAg ICAgICAgQmFzaWNTaGFwZUluc2V0UmVjdGFuZ2xlVHlwZSwKKyAgICAgICAgQmFzaWNTaGFwZUNp cmNsZVR5cGUsCisgICAgICAgIEJhc2ljU2hhcGVFbGxpcHNlVHlwZSwKKyAgICAgICAgQmFzaWNT aGFwZUluc2V0VHlwZQogICAgIH07CiAKICAgICBlbnVtIFJlZmVyZW5jZUJveCB7Cg==