125148 2013-12-03 04:27:06 -0800 Remove function from TextChecker 2013-12-03 09:12:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tgergely.u-szeged webkit-unassigned commit-queue eric galpeter glenn oldest_to_newest 955855 0 tgergely.u-szeged 2013-12-03 04:27:06 -0800 There is a FIXME: in webkitpy/style/checkers/text.py to remove the process_file_data function. 955864 1 218286 tgergely.u-szeged 2013-12-03 04:40:29 -0800 Created attachment 218286 patch It simply moves the function to the unit tests. This is the only place where it is used. 955924 2 218286 commit-queue 2013-12-03 09:12:30 -0800 Comment on attachment 218286 patch Clearing flags on attachment: 218286 Committed r160006: <http://trac.webkit.org/changeset/160006> 955925 3 commit-queue 2013-12-03 09:12:32 -0800 All reviewed patches have been landed. Closing bug. 218286 2013-12-03 04:40:29 -0800 2013-12-03 09:12:30 -0800 patch text_style_checker_fixme.patch text/plain 2931 tgergely.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxODU0 ZDI5Li44ZDA3OGUzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMtMTItMDMgIFRhbWFzIEdlcmdlbHkgIDx0Z2Vy Z2VseS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCisgICAgICAgIFJlbW92ZSBmdW5j dGlvbiBmcm9tIFRleHRDaGVja2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjUxNDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgcHJvY2Vzc19maWxlX2RhdGEgaXMgdXNlZCBvbmx5IGZyb20gdGhl IHVuaXQgdGVzdHMsIHNvIGl0IGlzIHNpbXBseSBtb3ZlZCB0aGVyZS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvdGV4dC5weToKKyAgICAgICAgKFRleHRDaGVj a2VyLmNoZWNrKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL3Rl eHRfdW5pdHRlc3QucHk6CisgICAgICAgIChUZXh0U3R5bGVUZXN0Q2FzZS5wcm9jZXNzX2ZpbGVf ZGF0YSk6CisgICAgICAgIChUZXh0U3R5bGVUZXN0Q2FzZS5hc3NlcnROb0Vycm9yKToKKyAgICAg ICAgKFRleHRTdHlsZVRlc3RDYXNlLmFzc2VydEVycm9yKToKKwogMjAxMy0xMi0wMiAgRmlsaXAg UGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIHJ1bi1qc2Mtc3RyZXNzLXRlc3Rz IHNob3VsZCBhbGxvdyBmb3IgdGVzdHMgdGhhdCBoYXZlIGEgZGlyZWN0b3J5IGNvbnRhaW5pbmcg LmpzIGZpbGVzIG5lc3RlZCB3aXRoaW4gYSBkaXJlY3RvcnkgY29udGFpbmluZyB0aGUgZGF0YQpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy90ZXh0LnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy90ZXh0LnB5CmluZGV4IDEx NDc2NTguLjM1YTI1ZWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvdGV4dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL3RleHQucHkKQEAgLTQyLDEwICs0MiwzIEBAIGNsYXNzIFRleHRDaGVja2VyKG9iamVjdCk6 CiAKICAgICBkZWYgY2hlY2soc2VsZiwgbGluZXMpOgogICAgICAgICBzZWxmLl90YWJfY2hlY2tl ci5jaGVjayhsaW5lcykKLQotCi0jIEZJWE1FOiBSZW1vdmUgdGhpcyBmdW5jdGlvbiAocmVxdWly ZXMgcmVmYWN0b3JpbmcgdW5pdCB0ZXN0cykuCi1kZWYgcHJvY2Vzc19maWxlX2RhdGEoZmlsZW5h bWUsIGxpbmVzLCBlcnJvcik6Ci0gICAgY2hlY2tlciA9IFRleHRDaGVja2VyKGZpbGVuYW1lLCBl cnJvcikKLSAgICBjaGVja2VyLmNoZWNrKGxpbmVzKQotCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL3RleHRfdW5pdHRlc3QucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL3RleHRfdW5pdHRlc3QucHkKaW5kZXggMDFlMzcz YS4uZDA3ZWFmZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy90ZXh0X3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvdGV4dF91bml0dGVzdC5weQpAQCAtMzYsNiArMzYsMTAgQEAgZnJvbSB0ZXh0IGlt cG9ydCBUZXh0Q2hlY2tlcgogY2xhc3MgVGV4dFN0eWxlVGVzdENhc2UodW5pdHRlc3QuVGVzdENh c2UpOgogICAgICIiIlRlc3RDYXNlIGZvciB0ZXh0X3N0eWxlLnB5IiIiCiAKKyAgICBkZWYgcHJv Y2Vzc19maWxlX2RhdGEoc2VsZiwgZmlsZW5hbWUsIGxpbmVzLCBlcnJvcik6CisgICAgICAgIGNo ZWNrZXIgPSBUZXh0Q2hlY2tlcihmaWxlbmFtZSwgZXJyb3IpCisgICAgICAgIGNoZWNrZXIuY2hl Y2sobGluZXMpCisKICAgICBkZWYgYXNzZXJ0Tm9FcnJvcihzZWxmLCBsaW5lcyk6CiAgICAgICAg ICIiIkFzc2VydHMgdGhhdCB0aGUgc3BlY2lmaWVkIGxpbmVzIGhhcyBubyBlcnJvcnMuIiIiCiAg ICAgICAgIHNlbGYuaGFkX2Vycm9yID0gRmFsc2UKQEAgLTQ0LDcgKzQ4LDcgQEAgY2xhc3MgVGV4 dFN0eWxlVGVzdENhc2UodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgIiIiUmVjb3Jk cyBpZiBhbiBlcnJvciBvY2N1cnMuIiIiCiAgICAgICAgICAgICBzZWxmLmhhZF9lcnJvciA9IFRy dWUKIAotICAgICAgICB0ZXh0X3N0eWxlLnByb2Nlc3NfZmlsZV9kYXRhKCcnLCBsaW5lcywgZXJy b3JfZm9yX3Rlc3QpCisgICAgICAgIHNlbGYucHJvY2Vzc19maWxlX2RhdGEoJycsIGxpbmVzLCBl cnJvcl9mb3JfdGVzdCkKICAgICAgICAgc2VsZi5hc3NlcnRGYWxzZShzZWxmLmhhZF9lcnJvciwg JyVzIHNob3VsZCBub3QgaGF2ZSBhbnkgZXJyb3JzLicgJSBsaW5lcykKIAogICAgIGRlZiBhc3Nl cnRFcnJvcihzZWxmLCBsaW5lcywgZXhwZWN0ZWRfbGluZV9udW1iZXIpOgpAQCAtNTcsNyArNjEs NyBAQCBjbGFzcyBUZXh0U3R5bGVUZXN0Q2FzZSh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAg ICAgICBzZWxmLmFzc2VydEVxdWFsKCd3aGl0ZXNwYWNlL3RhYicsIGNhdGVnb3J5KQogICAgICAg ICAgICAgc2VsZi5oYWRfZXJyb3IgPSBUcnVlCiAKLSAgICAgICAgdGV4dF9zdHlsZS5wcm9jZXNz X2ZpbGVfZGF0YSgnJywgbGluZXMsIGVycm9yX2Zvcl90ZXN0KQorICAgICAgICBzZWxmLnByb2Nl c3NfZmlsZV9kYXRhKCcnLCBsaW5lcywgZXJyb3JfZm9yX3Rlc3QpCiAgICAgICAgIHNlbGYuYXNz ZXJ0VHJ1ZShzZWxmLmhhZF9lcnJvciwgJyVzIHNob3VsZCBoYXZlIGFuIGVycm9yIFt3aGl0ZXNw YWNlL3RhYl0uJyAlIGxpbmVzKQogCiAK