125140 2013-12-03 01:54:20 -0800 Debug build fix : Add '<algorithm>' for 'std::is_sorted' after r159965. 2013-12-03 09:46:41 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 125104 1 seokju seokju andersca commit-queue ossy oldest_to_newest 955817 0 seokju 2013-12-03 01:54:20 -0800 WebKit/Source/WebKit2/Shared/APIClient.h:64:16: error: ‘is_sorted’ is not a member of ‘std’ ASSERT(std::is_sorted(interfaceSizes.begin(), interfaceSizes.end())); See : http://www.cplusplus.com/reference/algorithm/is_sorted/ 955818 1 218278 seokju 2013-12-03 01:56:50 -0800 Created attachment 218278 Patch 955819 2 seokju 2013-12-03 01:57:14 -0800 CC'ing andersca 955820 3 seokju 2013-12-03 01:59:37 -0800 @andersca Could you please review it? 955884 4 218278 ossy 2013-12-03 06:33:54 -0800 Comment on attachment 218278 Patch It is a trivial buildfix, we don't need WK2 owner review. 955887 5 218278 commit-queue 2013-12-03 06:59:18 -0800 Comment on attachment 218278 Patch Clearing flags on attachment: 218278 Committed r160002: <http://trac.webkit.org/changeset/160002> 955888 6 commit-queue 2013-12-03 06:59:19 -0800 All reviewed patches have been landed. Closing bug. 955943 7 ap 2013-12-03 09:46:41 -0800 It would be better to include the header unconditionally. A conditional include: - takes more space on screen, so it's harder to read the code; - makes release and debug builds more different, so issues like this will be more likely to occur in the future. 218278 2013-12-03 01:56:50 -0800 2013-12-03 06:59:18 -0800 Patch bug-125140-20131203185648.patch text/plain 1136 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5OTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzE1YTYwNDZjMjVmNzkw N2ZlNTM1ODA4Mzc1NzUwNjZhODc2ZTdhYi4uY2VhMzA0NGQ5NWMwMDVmODdjMDk5YWU2MDExYTM3 NGU5MWE3NmU0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTEyLTAzICBTZW9r anUgS3dvbiAgPHNlb2tqdUB3ZWJraXQub3JnPgorCisgICAgICAgIERlYnVnIGJ1aWxkIGZpeCA6 IEFkZCAnPGFsZ29yaXRobT4nIGZvciAnc3RkOjppc19zb3J0ZWQnIGFmdGVyIHIxNTk5NjUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUxNDAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9B UElDbGllbnQuaDoKKwogMjAxMy0xMi0wMiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxp YS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4ZXMgZm9yIEdDQy11c2luZyBwb3J0cyBhZnRlciBy MTU5OTY1IGFuZCBsYXRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSUNs aWVudC5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSUNsaWVudC5oCmluZGV4IGM3NDVjOTVk NmJkZmJlMzM4ZTdlYjgxOWVlZTczYjE3NWU4YTJjMTguLjBjYWIxNDJmYmE0OTlkMjAxMTZiNjgx NGViMjQ4OGU3NmIxNmJkOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUElD bGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJQ2xpZW50LmgKQEAgLTI5LDYg KzI5LDEwIEBACiAjaW5jbHVkZSAiQVBJQ2xpZW50VHJhaXRzLmgiCiAjaW5jbHVkZSA8YXJyYXk+ CiAKKyNpZiAhQVNTRVJUX0RJU0FCTEVECisjaW5jbHVkZSA8YWxnb3JpdGhtPiAvLyBzdGQ6Omlz X3NvcnRlZAorI2VuZGlmCisKIC8vIEZJWE1FOiBUcmFuc2l0aW9uIGFsbCBjbGllbnRzIGZyb20g V2ViS2l0OjpBUElDbGllbnQgdG8gQVBJOjpDbGllbnQuCiBuYW1lc3BhY2UgQVBJIHsKIAo=