125106 2013-12-02 14:44:40 -0800 Add CachedPage null checks 2013-12-02 14:53:32 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson oldest_to_newest 955594 0 beidson 2013-12-02 14:44:40 -0800 Add CachedPage null checks Some of PageCache.cpp null checks the CachedPage of the HistoryItems it manipulates... but some places don't. They all should. 955599 1 218218 beidson 2013-12-02 14:48:22 -0800 Created attachment 218218 Patch v1 955605 2 beidson 2013-12-02 14:53:32 -0800 http://trac.webkit.org/changeset/159970 218218 2013-12-02 14:48:22 -0800 2013-12-02 14:50:16 -0800 Patch v1 patch text/plain 2997 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNGNiOTg4Li5iYmI4MmNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMTItMDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIEFkZCBtb3JlIENhY2hlZFBhZ2UgbnVsbCBjaGVja3MKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTEwNgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgc29tZSBmdW5jdGlvbnMgaW4gUGFnZUNh Y2hlLmNwcCBudWxsLWNoZWNrIHRoZSBDYWNoZWRQYWdlcyBpbiBIaXN0b3J5SXRlbXMuCisKKyAg ICAgICAgRXZlcnkgcGFydCB0aGF0IG1hbmlwdWxhdGVzIHRoZSBDYWNoZWRQYWdlIHNob3VsZC4K KworICAgICAgICAqIGhpc3RvcnkvUGFnZUNhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBh Z2VDYWNoZTo6bWFya1BhZ2VzRm9yVmlzdGVkTGlua1N0eWxlUmVjYWxjKToKKyAgICAgICAgKFdl YkNvcmU6OlBhZ2VDYWNoZTo6bWFya1BhZ2VzRm9yRnVsbFN0eWxlUmVjYWxjKToKKyAgICAgICAg KFdlYkNvcmU6OlBhZ2VDYWNoZTo6bWFya1BhZ2VzRm9yRGV2aWNlU2NhbGVDaGFuZ2VkKToKKyAg ICAgICAgKFdlYkNvcmU6OlBhZ2VDYWNoZTo6bWFya1BhZ2VzRm9yQ2FwdGlvblByZWZlcmVuY2Vz Q2hhbmdlZCk6CisKIDIwMTMtMTItMDIgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxl LmNvbT4KIAogICAgICAgICBBWDogQ3Jhc2ggYXQgV2ViQ29yZTo6Y29tbW9uVHJlZVNjb3BlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAKaW5kZXggMDljZjM4Ny4uNjM2OTdiMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNwcApAQCAtMzkwLDE1ICszOTAsMTcgQEAgaW50 IFBhZ2VDYWNoZTo6ZnJhbWVDb3VudCgpIGNvbnN0CiAKIHZvaWQgUGFnZUNhY2hlOjptYXJrUGFn ZXNGb3JWaXN0ZWRMaW5rU3R5bGVSZWNhbGMoKQogewotICAgIGZvciAoSGlzdG9yeUl0ZW0qIGN1 cnJlbnQgPSBtX2hlYWQ7IGN1cnJlbnQ7IGN1cnJlbnQgPSBjdXJyZW50LT5tX25leHQpCi0gICAg ICAgIGN1cnJlbnQtPm1fY2FjaGVkUGFnZS0+bWFya0ZvclZpc3RlZExpbmtTdHlsZVJlY2FsYygp OworICAgIGZvciAoSGlzdG9yeUl0ZW0qIGN1cnJlbnQgPSBtX2hlYWQ7IGN1cnJlbnQ7IGN1cnJl bnQgPSBjdXJyZW50LT5tX25leHQpIHsKKyAgICAgICAgaWYgKGN1cnJlbnQtPm1fY2FjaGVkUGFn ZSkKKyAgICAgICAgICAgIGN1cnJlbnQtPm1fY2FjaGVkUGFnZS0+bWFya0ZvclZpc3RlZExpbmtT dHlsZVJlY2FsYygpOworICAgIH0KIH0KIAogdm9pZCBQYWdlQ2FjaGU6Om1hcmtQYWdlc0ZvckZ1 bGxTdHlsZVJlY2FsYyhQYWdlKiBwYWdlKQogewogICAgIGZvciAoSGlzdG9yeUl0ZW0qIGN1cnJl bnQgPSBtX2hlYWQ7IGN1cnJlbnQ7IGN1cnJlbnQgPSBjdXJyZW50LT5tX25leHQpIHsKICAgICAg ICAgQ2FjaGVkUGFnZSogY2FjaGVkUGFnZSA9IGN1cnJlbnQtPm1fY2FjaGVkUGFnZS5nZXQoKTsK LSAgICAgICAgaWYgKCZwYWdlLT5tYWluRnJhbWUoKSA9PSAmY2FjaGVkUGFnZS0+Y2FjaGVkTWFp bkZyYW1lKCktPnZpZXcoKS0+ZnJhbWUoKSkKKyAgICAgICAgaWYgKGNhY2hlZFBhZ2UgJiYgJnBh Z2UtPm1haW5GcmFtZSgpID09ICZjYWNoZWRQYWdlLT5jYWNoZWRNYWluRnJhbWUoKS0+dmlldygp LT5mcmFtZSgpKQogICAgICAgICAgICAgY2FjaGVkUGFnZS0+bWFya0ZvckZ1bGxTdHlsZVJlY2Fs YygpOwogICAgIH0KIH0KQEAgLTQwOSw3ICs0MTEsNyBAQCB2b2lkIFBhZ2VDYWNoZTo6bWFya1Bh Z2VzRm9yRGV2aWNlU2NhbGVDaGFuZ2VkKFBhZ2UqIHBhZ2UpCiB7CiAgICAgZm9yIChIaXN0b3J5 SXRlbSogY3VycmVudCA9IG1faGVhZDsgY3VycmVudDsgY3VycmVudCA9IGN1cnJlbnQtPm1fbmV4 dCkgewogICAgICAgICBDYWNoZWRQYWdlKiBjYWNoZWRQYWdlID0gY3VycmVudC0+bV9jYWNoZWRQ YWdlLmdldCgpOwotICAgICAgICBpZiAoJnBhZ2UtPm1haW5GcmFtZSgpID09ICZjYWNoZWRQYWdl LT5jYWNoZWRNYWluRnJhbWUoKS0+dmlldygpLT5mcmFtZSgpKQorICAgICAgICBpZiAoY2FjaGVk UGFnZSAmJiAmcGFnZS0+bWFpbkZyYW1lKCkgPT0gJmNhY2hlZFBhZ2UtPmNhY2hlZE1haW5GcmFt ZSgpLT52aWV3KCktPmZyYW1lKCkpCiAgICAgICAgICAgICBjYWNoZWRQYWdlLT5tYXJrRm9yRGV2 aWNlU2NhbGVDaGFuZ2VkKCk7CiAgICAgfQogfQpAQCAtNDE4LDggKzQyMCwxMCBAQCB2b2lkIFBh Z2VDYWNoZTo6bWFya1BhZ2VzRm9yRGV2aWNlU2NhbGVDaGFuZ2VkKFBhZ2UqIHBhZ2UpCiAjaWYg RU5BQkxFKFZJREVPX1RSQUNLKQogdm9pZCBQYWdlQ2FjaGU6Om1hcmtQYWdlc0ZvckNhcHRpb25Q cmVmZXJlbmNlc0NoYW5nZWQoKQogewotICAgIGZvciAoSGlzdG9yeUl0ZW0qIGN1cnJlbnQgPSBt X2hlYWQ7IGN1cnJlbnQ7IGN1cnJlbnQgPSBjdXJyZW50LT5tX25leHQpCi0gICAgICAgIGN1cnJl bnQtPm1fY2FjaGVkUGFnZS0+bWFya0ZvckNhcHRpb25QcmVmZXJlbmNlc0NoYW5nZWQoKTsKKyAg ICBmb3IgKEhpc3RvcnlJdGVtKiBjdXJyZW50ID0gbV9oZWFkOyBjdXJyZW50OyBjdXJyZW50ID0g Y3VycmVudC0+bV9uZXh0KSB7CisgICAgICAgIGlmIChjdXJyZW50LT5tX2NhY2hlZFBhZ2UpCisg ICAgICAgICAgICBjdXJyZW50LT5tX2NhY2hlZFBhZ2UtPm1hcmtGb3JDYXB0aW9uUHJlZmVyZW5j ZXNDaGFuZ2VkKCk7CisgICAgfQogfQogI2VuZGlmCiAK