12510 2007-01-31 11:37:45 -0800 Uninitialized member being used before set 2007-01-31 20:35:35 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 dacarson dacarson oldest_to_newest 29705 0 dacarson 2007-01-31 11:37:45 -0800 In the function: void Marquee::updateMarqueeStyle() the value m_totalLoops is being tested before it has been set for the first time. The test case that can be used to see this is: LayoutTests/fast/css/MarqueeLayoutTest.html 29707 1 dacarson 2007-01-31 11:44:31 -0800 Call stack: ==14403== Conditional jump or move depends on uninitialised value(s) ==14403== at 0x7ADCDD4: WebCore::Marquee::updateMarqueeStyle() (RenderLayer.cpp:2115) ==14403== by 0x7AE0071: WebCore::RenderLayer::styleChanged() (RenderLayer.cpp:1928) ==14403== by 0x7AB8804: WebCore::RenderBox::setStyle(WebCore::RenderStyle*) (RenderBox.cpp:148) ==14403== by 0x7AA8A5E: WebCore::RenderBlock::setStyle(WebCore::RenderStyle*) (RenderBlock.cpp:111) ==14403== by 0x7953F12: WebCore::Node::createRendererIfNeeded() (Node.cpp:912) ==14403== by 0x7945644: WebCore::Element::attach() (Element.cpp:558) ==14403== by 0x79F8827: WebCore::HTMLParser::insertNode(WebCore::Node*, bool) (HTMLParser.cpp:288) ==14403== by 0x79FA3BC: WebCore::HTMLParser::parseToken(WebCore::Token*) (HTMLParser.cpp:220) 29702 2 dacarson 2007-01-31 11:45:41 -0800 Line numbers in call stack out of sync with ToT, but error still exists. 29696 3 12831 dacarson 2007-01-31 12:24:06 -0800 Created attachment 12831 patch 29689 4 12831 darin 2007-01-31 13:09:57 -0800 Comment on attachment 12831 patch r=me 29529 5 sam 2007-01-31 20:35:35 -0800 Landed in r19323. 12831 2007-01-31 12:24:06 -0800 2007-01-31 13:09:57 -0800 patch marquee.txt text/plain 1122 dacarson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxOTMwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMDEtMzEgIGRhY2Fyc29uICA8ZGFjYXJzb25AZ21haWwuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC1maXgg aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MTAKKyAgICAgICAgSW5p dGlhbGl6ZSB0aGUgdmFyaWFibGUgbV90b3RhbExvb3BzCisgICAgICAgIElzIHRlc3RlZCBieSBM YXlvdXRUZXN0cy9mYXN0L2Nzcy9NYXJxdWVlTGF5b3V0VGVzdC5odG1sCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWFycXVlZTo6TWFy cXVlZSk6CisKIDIwMDctMDEtMzEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIC0gZml4IGJ1aWxkCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShyZXZp c2lvbiAxOTMwNikKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjA1Miw2ICsyMDUyLDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6c3VzcGVuZE1h cnF1ZWVzKCkKIAogTWFycXVlZTo6TWFycXVlZShSZW5kZXJMYXllciogbCkKICAgICA6IG1fbGF5 ZXIobCksIG1fY3VycmVudExvb3AoMCkKKyAgICAsIG1fdG90YWxMb29wcygwKQogICAgICwgbV90 aW1lcih0aGlzLCAmTWFycXVlZTo6dGltZXJGaXJlZCkKICAgICAsIG1fc3RhcnQoMCksIG1fZW5k KDApLCBtX3NwZWVkKDApLCBtX3Jlc2V0KGZhbHNlKQogICAgICwgbV9zdXNwZW5kZWQoZmFsc2Up LCBtX3N0b3BwZWQoZmFsc2UpLCBtX2RpcmVjdGlvbihNQVVUTykK