125074 2013-12-02 05:05:55 -0800 [GTK] Fails to build with freetype 2.5.1 2013-12-02 09:46:26 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned agomez cgarcia commit-queue d-r eric.carlson kenneth mario mrobinson nick.diego schenney tony zan oldest_to_newest 955342 0 berto 2013-12-02 05:05:55 -0800 FreeType 2.5.1 changed the header file layout: http://sourceforge.net/projects/freetype/files/freetype2/2.5.1/ Now all headers went from /usr/include/freetype2/freetype/ to /usr/include/freetype2/. At least HarfBuzzFaceCairo.cpp looks for the headers in the old path so it doesn't build. This is apparently not the official way to include FreeType, as explained in the link above: "Applications that use [...] the documented way for header inclusion [...] don't need any change to the source code." 955343 1 agomez 2013-12-02 05:06:48 -0800 Giving it a look ... 955357 2 zan 2013-12-02 06:08:13 -0800 The GTK port relies on pkg-config to provide the correct inclusion directory, so I'm interested where this goes wrong. 955364 3 berto 2013-12-02 06:25:59 -0800 (In reply to comment #2) > The GTK port relies on pkg-config to provide the correct inclusion > directory, so I'm interested where this goes wrong. Apparently we're including the freetype headers in an unsupported way. We should use FT_FREETYPE_H, FT_TRUETYPE_TABLES_H, etc. I think Andrés is testing the changes and will upload a patch soon. 955380 4 agomez 2013-12-02 07:56:20 -0800 Confirmed after upgrading freetype6 jhbuild module to 2.5.1 and trying to build: CXX Source/WebCore/platform/graphics/freetype/libPlatform_la-SimpleFontDataFreeType.lo ../../Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:47:31: fatal error: freetype/tttables.h: No such file or directory compilation terminated. make[1]: *** [Source/WebCore/platform/graphics/freetype/libPlatform_la-SimpleFontDataFreeType.lo] Error 1 make[1]: Leaving directory `/opt/webkit/WebKit.git/WebKitBuild/Release' make: *** [all] Error 2 955392 5 218175 agomez 2013-12-02 08:48:39 -0800 Created attachment 218175 Patch 955397 6 berto 2013-12-02 09:04:46 -0800 (In reply to comment #5) > Created an attachment (id=218175) [details] > Patch lgtm 955409 7 218175 cgarcia 2013-12-02 09:21:14 -0800 Comment on attachment 218175 Patch I guess this affects the stable branch too. 955411 8 agomez 2013-12-02 09:24:04 -0800 (In reply to comment #7) > (From update of attachment 218175 [details]) > I guess this affects the stable branch too. Yes, I think it makes sense to cherry-pick it. 955412 9 berto 2013-12-02 09:24:43 -0800 (In reply to comment #8) > (In reply to comment #7) > > (From update of attachment 218175 [details] [details]) > > I guess this affects the stable branch too. > > Yes, I think it makes sense to cherry-pick it. It does, I can reproduce it in Debian with freetype from sid. 955421 10 218175 commit-queue 2013-12-02 09:46:22 -0800 Comment on attachment 218175 Patch Clearing flags on attachment: 218175 Committed r159939: <http://trac.webkit.org/changeset/159939> 955422 11 commit-queue 2013-12-02 09:46:26 -0800 All reviewed patches have been landed. Closing bug. 218175 2013-12-02 08:48:39 -0800 2013-12-02 09:46:22 -0800 Patch bug-125074-20131202184838.patch text/plain 3094 agomez U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY1ZDA2OGRmNzk1NGQ4 NTkwYzY0NzkxZTY0YzM2MzhhMmQ1NWZmZC4uOWI3Y2RmZDE4ZDA3NmY4NDQyMGFkNGRmMDBjYTVh NWJhMWZlOTMwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTEyLTAyICBBbmRy ZXMgR29tZXogIDxhZ29tZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBGYWlscyB0byBi dWlsZCB3aXRoIGZyZWV0eXBlIDIuNS4xCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjUwNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGcmVlVHlwZSBzcGVjaWZpZXMgYSBjYW5vbmljYWwgd2F5IG9mIGlu Y2x1ZGluZyB0aGVpciBvd24KKyAgICAgICAgaGVhZGVycy4gTm93LCB3ZSBhcmUgZm9sbG93aW5n IHRoaXMgcmVjb21tZW5kYXRpb24gc28gdGhlCisgICAgICAgIGNvbXBpbGF0aW9uIHdvbid0IGJl IGJyb2tlbiBhZ2FpbiBkdWUgdG8gYW4gdXBncmFkZSBpbiBGZWVUeXBlJ3MKKyAgICAgICAgaW5j bHVkaW5nIHBhdGhzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9u dFBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9m cmVldHlwZS9TaW1wbGVGb250RGF0YUZyZWVUeXBlLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9oYXJmYnV6ei9IYXJmQnV6ekZhY2VDYWlyby5jcHA6CisKIDIwMTMtMTEtMjQgIEJy YWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIERhdGFiYXNlUHJvY2Vz czogQWRkICJVbmlxdWVJREJEYXRhYmFzZSIgdGhhdCBtdWx0aXBsZSBXZWJQcm9jZXNzZXMgY2Fu IGNvbm5lY3QgdG8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwCmlu ZGV4IDMzZDFkMjYzNjgzMWMwZTcxOTkwNzNjNmQxMGE1ZDZiMzVmYTgzZDAuLjU1Y2Q5Y2VkMGZk OWRiMWZhOTMzODlmMmIzYTljZDMwODNhZTY2Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRm b3JtRGF0YUZyZWVUeXBlLmNwcApAQCAtMjksNyArMjksOCBAQAogI2luY2x1ZGUgPGNhaXJvLWZ0 Lmg+CiAjaW5jbHVkZSA8Y2Fpcm8uaD4KICNpbmNsdWRlIDxmb250Y29uZmlnL2ZjZnJlZXR5cGUu aD4KLSNpbmNsdWRlIDxmcmVldHlwZS90dHRhYmxlcy5oPgorI2luY2x1ZGUgPGZ0MmJ1aWxkLmg+ CisjaW5jbHVkZSBGVF9UUlVFVFlQRV9UQUJMRVNfSAogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0 cmluZy5oPgogCiAjaWYgIVBMQVRGT1JNKEVGTCkgJiYgIVBMQVRGT1JNKE5JWCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL1NpbXBsZUZvbnRE YXRhRnJlZVR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5 cGUvU2ltcGxlRm9udERhdGFGcmVlVHlwZS5jcHAKaW5kZXggN2ZmMTE0YjYwYmJjZTk0MjZmNzMx NWUzOWJiNTYxMzYyMzQwNGVlNi4uODBjNDA0MmZhYTNlY2NhMjZmMWQxMjAxYmU0NDY2MWU1ZGMy OGE4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5 cGUvU2ltcGxlRm9udERhdGFGcmVlVHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZnJlZXR5cGUvU2ltcGxlRm9udERhdGFGcmVlVHlwZS5jcHAKQEAgLTQ0LDgg KzQ0LDkgQEAKICNpbmNsdWRlIDxjYWlyby1mdC5oPgogI2luY2x1ZGUgPGNhaXJvLmg+CiAjaW5j bHVkZSA8Zm9udGNvbmZpZy9mY2ZyZWV0eXBlLmg+Ci0jaW5jbHVkZSA8ZnJlZXR5cGUvdHR0YWJs ZXMuaD4KLSNpbmNsdWRlIDxmcmVldHlwZS90dHRhZ3MuaD4KKyNpbmNsdWRlIDxmdDJidWlsZC5o PgorI2luY2x1ZGUgRlRfVFJVRVRZUEVfVEFCTEVTX0gKKyNpbmNsdWRlIEZUX1RSVUVUWVBFX1RB R1NfSAogI2luY2x1ZGUgPHVuaWNvZGUvbm9ybWx6ci5oPgogI2luY2x1ZGUgPHd0Zi9NYXRoRXh0 cmFzLmg+CiAjaW5jbHVkZSA8d3RmL3VuaWNvZGUvVW5pY29kZS5oPgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpGYWNlQ2Fpcm8u Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpG YWNlQ2Fpcm8uY3BwCmluZGV4IGVjYWFmYzE4NDEwMTc3ZGE4NDJmZmUyZWM4ZDFjOGNjMmYzOWI1 ZjUuLjUyYjkyNDAzNzhhYTA3NGI3ZjgxNDY1NDFkYzUxMWQxYzE1ZTZmZDQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0hhcmZCdXp6RmFjZUNh aXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9I YXJmQnV6ekZhY2VDYWlyby5jcHAKQEAgLTM5LDggKzM5LDkgQEAKICNpbmNsdWRlICJUZXh0RW5j b2RpbmcuaCIKICNpbmNsdWRlIDxjYWlyby1mdC5oPgogI2luY2x1ZGUgPGNhaXJvLmg+Ci0jaW5j bHVkZSA8ZnJlZXR5cGUvZnJlZXR5cGUuaD4KLSNpbmNsdWRlIDxmcmVldHlwZS90dHRhYmxlcy5o PgorI2luY2x1ZGUgPGZ0MmJ1aWxkLmg+CisjaW5jbHVkZSBGVF9GUkVFVFlQRV9ICisjaW5jbHVk ZSBGVF9UUlVFVFlQRV9UQUJMRVNfSAogI2luY2x1ZGUgPGhiLmg+CiAjaW5jbHVkZSA8d3RmL3Rl eHQvQ1N0cmluZy5oPgogCg==