125067 2013-12-02 01:30:10 -0800 mips path could be merged with arm/sh4 path in nativeForGenerator and privateCompileCTINativeCall 2013-12-03 02:25:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fu gergely kilvadyb msaboff palfia oldest_to_newest 955286 0 jbriance 2013-12-02 01:30:10 -0800 In nativeForGenerator and privateCompileCTINativeCall functions, CPU(MIPS) path could be merged with CPU(ARM) || CPU(SH4) path to reduce architecture specific code. Moreover, this is likely to fix a potential issue in mips port: with current implementation Callee is put in MIPSRegisters::a2 instead of MIPSRegisters::a1 (argumentGPR1). 955287 1 218152 jbriance 2013-12-02 01:32:25 -0800 Created attachment 218152 Merge mips and arm/sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions. I don't see regressions on my mips board with this patch, but I'd like to have a feedback from homejinni or mips guys before putting it into the commit queue. 955338 2 kilvadyb 2013-12-02 04:45:26 -0800 (In reply to comment #1) > Created an attachment (id=218152) [details] > Merge mips and arm/sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions. > > I don't see regressions on my mips board with this patch, but I'd like to have a feedback from homejinni or mips guys before putting it into the commit queue. I am on holiday so I can check/test it tomorrow. And I will definitely :) 955339 3 jbriance 2013-12-02 04:51:34 -0800 (In reply to comment #2) > I am on holiday so I can check/test it tomorrow. And I will definitely :) Thanks! I won't request commit queue before your feedback then.. and enjoy your day off :) About the MIPSRegisters::a2 thing, perhaps it's just used as a temp register so I'm not sure it could fix something. 955389 4 218152 msaboff 2013-12-02 08:43:57 -0800 Comment on attachment 218152 Merge mips and arm/sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions. Looks fine. Will cq+ after kilvadyb@homejinni.com provides results from testing. 955812 5 kilvadyb 2013-12-03 01:47:03 -0800 (In reply to comment #4) > (From update of attachment 218152 [details]) > Looks fine. Will cq+ after kilvadyb@homejinni.com provides results from testing. Looks good to me also, no more regressions with this patch.(In reply to comment #4) > (From update of attachment 218152 [details]) > Looks fine. Will cq+ after kilvadyb@homejinni.com provides results from testing. Looks good to me also, no more regressions with this patch. a2 was used as a temporary scratch register in the previous code and now argumentGPR1 == a1 is the scratch reg on MIPS which is also fine. 955815 6 jbriance 2013-12-03 01:50:14 -0800 (In reply to comment #5) > Looks good to me also, no more regressions with this patch. a2 was used as a temporary scratch register in the previous code and now argumentGPR1 == a1 is the scratch reg on MIPS which is also fine. Great, I'm requesting commit queue then. Thanks! 955832 7 218152 commit-queue 2013-12-03 02:25:32 -0800 Comment on attachment 218152 Merge mips and arm/sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions. Clearing flags on attachment: 218152 Committed r159995: <http://trac.webkit.org/changeset/159995> 955833 8 commit-queue 2013-12-03 02:25:34 -0800 All reviewed patches have been landed. Closing bug. 218152 2013-12-02 01:32:25 -0800 2013-12-03 02:25:32 -0800 Merge mips and arm/sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions. bug-125067.patch text/plain 6666 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5OTIwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTEyLTAyICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIE1lcmdlIG1pcHMgYW5kIGFybS9zaDQgcGF0aHMgaW4gbmF0aXZlRm9yR2VuZXJhdG9y IGFuZCBwcml2YXRlQ29tcGlsZUNUSU5hdGl2ZUNhbGwgZnVuY3Rpb25zLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MDY3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqaXQvSklUT3Bjb2RlczMyXzY0 LmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjpwcml2YXRlQ29tcGlsZUNUSU5hdGl2ZUNhbGwpOgor ICAgICAgICAqIGppdC9UaHVua0dlbmVyYXRvcnMuY3BwOgorICAgICAgICAoSlNDOjpuYXRpdmVG b3JHZW5lcmF0b3IpOgorCiAyMDEzLTExLTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CiAKICAgICAgICAgRmluYWxseSByZW1vdmUgdGhvc2UgREZHX0VOQUJMRSB0aGluZ3MKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2RlczMyXzY0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMzMl82NC5jcHAJKHJl dmlzaW9uIDE1OTkxMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2RlczMy XzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzQsNyArNzQsNyBAQCBKSVQ6OkNvZGVSZWYgSklU Ojpwcml2YXRlQ29tcGlsZUNUSU5hdGl2CiAKICAgICBhZGRQdHIoVHJ1c3RlZEltbTMyKDE2IC0g c2l6ZW9mKHZvaWQqKSksIHN0YWNrUG9pbnRlclJlZ2lzdGVyKTsKIAotI2VsaWYgQ1BVKEFSTSkg fHwgQ1BVKFNINCkKKyNlbGlmIENQVShBUk0pIHx8IENQVShTSDQpIHx8IENQVShNSVBTKQogICAg IC8vIExvYWQgY2FsbGVyIGZyYW1lJ3Mgc2NvcGUgY2hhaW4gaW50byB0aGlzIGNhbGxmcmFtZSBz byB0aGF0IHdoYXRldmVyIHdlIGNhbGwgY2FuIGdldCB0byBpdHMgZ2xvYmFsIGRhdGEuCiAgICAg ZW1pdEdldENhbGxlckZyYW1lRnJvbUNhbGxGcmFtZUhlYWRlclB0cihyZWdUMik7CiAgICAgZW1p dEdldEZyb21DYWxsRnJhbWVIZWFkZXJQdHIoSlNTdGFjazo6U2NvcGVDaGFpbiwgcmVnVDEsIHJl Z1QyKTsKQEAgLTgzLDYgKzgzLDExIEBAIEpJVDo6Q29kZVJlZiBKSVQ6OnByaXZhdGVDb21waWxl Q1RJTmF0aXYKICAgICBwcmVzZXJ2ZVJldHVybkFkZHJlc3NBZnRlckNhbGwocmVnVDMpOyAvLyBD YWxsZWUgcHJlc2VydmVkCiAgICAgZW1pdFB1dFJldHVyblBDVG9DYWxsRnJhbWVIZWFkZXIocmVn VDMpOwogCisjaWYgQ1BVKE1JUFMpCisgICAgLy8gQWxsb2NhdGUgc3RhY2sgc3BhY2UgZm9yICh1 bnVzZWQpIDE2IGJ5dGVzICg4LWJ5dGUgYWxpZ25lZCkgZm9yIDQgYXJndW1lbnRzLgorICAgIHN1 YlB0cihUcnVzdGVkSW1tMzIoMTYpLCBzdGFja1BvaW50ZXJSZWdpc3Rlcik7CisjZW5kaWYKKwog ICAgIC8vIENhbGxpbmcgY29udmVudGlvbiBpcyBmKGFyZ3VtZW50R1BSMCwgYXJndW1lbnRHUFIx LCAuLi4pLgogICAgIC8vIEhvc3QgZnVuY3Rpb24gc2lnbmF0dXJlIGlzIGYoRXhlY1N0YXRlKiku CiAgICAgbW92ZShjYWxsRnJhbWVSZWdpc3RlciwgYXJndW1lbnRHUFIwKTsKQEAgLTk0LDM3ICs5 OSwxMCBAQCBKSVQ6OkNvZGVSZWYgSklUOjpwcml2YXRlQ29tcGlsZUNUSU5hdGl2CiAgICAgLy8g Y2FsbCB0aGUgZnVuY3Rpb24KICAgICBuYXRpdmVDYWxsID0gY2FsbCgpOwogCi0gICAgcmVzdG9y ZVJldHVybkFkZHJlc3NCZWZvcmVSZXR1cm4ocmVnVDMpOwotI2VsaWYgQ1BVKE1JUFMpCi0gICAg Ly8gTG9hZCBjYWxsZXIgZnJhbWUncyBzY29wZSBjaGFpbiBpbnRvIHRoaXMgY2FsbGZyYW1lIHNv IHRoYXQgd2hhdGV2ZXIgd2UgY2FsbCBjYW4KLSAgICAvLyBnZXQgdG8gaXRzIGdsb2JhbCBkYXRh LgotICAgIGVtaXRHZXRDYWxsZXJGcmFtZUZyb21DYWxsRnJhbWVIZWFkZXJQdHIocmVnVDApOwot ICAgIGVtaXRHZXRGcm9tQ2FsbEZyYW1lSGVhZGVyUHRyKEpTU3RhY2s6OlNjb3BlQ2hhaW4sIHJl Z1QxLCByZWdUMCk7Ci0gICAgZW1pdFB1dENlbGxUb0NhbGxGcmFtZUhlYWRlcihyZWdUMSwgSlNT dGFjazo6U2NvcGVDaGFpbik7Ci0KLSAgICBwcmVzZXJ2ZVJldHVybkFkZHJlc3NBZnRlckNhbGwo cmVnVDMpOyAvLyBDYWxsZWUgcHJlc2VydmVkCi0gICAgZW1pdFB1dFJldHVyblBDVG9DYWxsRnJh bWVIZWFkZXIocmVnVDMpOwotCi0gICAgLy8gQ2FsbGluZyBjb252ZW50aW9uOiAgICAgIGYoYTAs IGExLCBhMiwgYTMpOwotICAgIC8vIEhvc3QgZnVuY3Rpb24gc2lnbmF0dXJlOiBmKEV4ZWNTdGF0 ZSopOwotCi0gICAgLy8gQWxsb2NhdGUgc3RhY2sgc3BhY2UgZm9yIDE2IGJ5dGVzICg4LWJ5dGUg YWxpZ25lZCkKLSAgICAvLyAxNiBieXRlcyAodW51c2VkKSBmb3IgNCBhcmd1bWVudHMKLSAgICBz dWJQdHIoVHJ1c3RlZEltbTMyKDE2KSwgc3RhY2tQb2ludGVyUmVnaXN0ZXIpOwotCi0gICAgLy8g U2V0dXAgYXJnMAotICAgIG1vdmUoY2FsbEZyYW1lUmVnaXN0ZXIsIE1JUFNSZWdpc3RlcnM6OmEw KTsKLQotICAgIC8vIENhbGwKLSAgICBlbWl0R2V0RnJvbUNhbGxGcmFtZUhlYWRlclB0cihKU1N0 YWNrOjpDYWxsZWUsIE1JUFNSZWdpc3RlcnM6OmEyKTsKLSAgICBsb2FkUHRyKEFkZHJlc3MoTUlQ U1JlZ2lzdGVyczo6YTIsIE9CSkVDVF9PRkZTRVRPRihKU0Z1bmN0aW9uLCBtX2V4ZWN1dGFibGUp KSwgcmVnVDIpOwotICAgIG1vdmUocmVnVDAsIGNhbGxGcmFtZVJlZ2lzdGVyKTsgLy8gRWFnZXJs eSByZXN0b3JlIGNhbGxlciBmcmFtZSByZWdpc3RlciB0byBhdm9pZCBsb2FkaW5nIGZyb20gc3Rh Y2suCi0gICAgCi0gICAgLy8gY2FsbCB0aGUgZnVuY3Rpb24KLSAgICBuYXRpdmVDYWxsID0gY2Fs bCgpOwotCisjaWYgQ1BVKE1JUFMpCiAgICAgLy8gUmVzdG9yZSBzdGFjayBzcGFjZQogICAgIGFk ZFB0cihUcnVzdGVkSW1tMzIoMTYpLCBzdGFja1BvaW50ZXJSZWdpc3Rlcik7CisjZW5kaWYKIAog ICAgIHJlc3RvcmVSZXR1cm5BZGRyZXNzQmVmb3JlUmV0dXJuKHJlZ1QzKTsKICNlbHNlCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCShyZXZp c2lvbiAxNTk5MTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9y cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0Myw3ICszNDMsNyBAQCBzdGF0aWMgTWFjcm9Bc3Nl bWJsZXJDb2RlUmVmIG5hdGl2ZUZvckdlCiAKICAgICBqaXQucmVzdG9yZVJldHVybkFkZHJlc3NC ZWZvcmVSZXR1cm4oSlNJbnRlcmZhY2VKSVQ6OnJlZ1QzKTsKIAotI2VsaWYgQ1BVKEFSTSkgfHwg Q1BVKFNINCkKKyNlbGlmIENQVShBUk0pIHx8IENQVShTSDQpIHx8IENQVShNSVBTKQogICAgIC8v IExvYWQgY2FsbGVyIGZyYW1lJ3Mgc2NvcGUgY2hhaW4gaW50byB0aGlzIGNhbGxmcmFtZSBzbyB0 aGF0IHdoYXRldmVyIHdlIGNhbGwgY2FuIGdldCB0byBpdHMgZ2xvYmFsIGRhdGEuCiAgICAgaml0 LmVtaXRHZXRDYWxsZXJGcmFtZUZyb21DYWxsRnJhbWVIZWFkZXJQdHIoSlNJbnRlcmZhY2VKSVQ6 OnJlZ1QyKTsKICAgICBqaXQuZW1pdEdldEZyb21DYWxsRnJhbWVIZWFkZXJQdHIoSlNTdGFjazo6 U2NvcGVDaGFpbiwgSlNJbnRlcmZhY2VKSVQ6OnJlZ1QxLCBKU0ludGVyZmFjZUpJVDo6cmVnVDIp OwpAQCAtMzUyLDYgKzM1MiwxMSBAQCBzdGF0aWMgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmIG5hdGl2 ZUZvckdlCiAgICAgaml0LnByZXNlcnZlUmV0dXJuQWRkcmVzc0FmdGVyQ2FsbChKU0ludGVyZmFj ZUpJVDo6cmVnVDMpOyAvLyBDYWxsZWUgcHJlc2VydmVkCiAgICAgaml0LmVtaXRQdXRSZXR1cm5Q Q1RvQ2FsbEZyYW1lSGVhZGVyKEpTSW50ZXJmYWNlSklUOjpyZWdUMyk7CiAKKyNpZiBDUFUoTUlQ UykKKyAgICAvLyBBbGxvY2F0ZSBzdGFjayBzcGFjZSBmb3IgKHVudXNlZCkgMTYgYnl0ZXMgKDgt Ynl0ZSBhbGlnbmVkKSBmb3IgNCBhcmd1bWVudHMuCisgICAgaml0LnN1YlB0cihKU0ludGVyZmFj ZUpJVDo6VHJ1c3RlZEltbTMyKDE2KSwgSlNJbnRlcmZhY2VKSVQ6OnN0YWNrUG9pbnRlclJlZ2lz dGVyKTsKKyNlbmRpZgorCiAgICAgLy8gQ2FsbGluZyBjb252ZW50aW9uIGlzIGYoYXJndW1lbnRH UFIwLCBhcmd1bWVudEdQUjEsIC4uLikuCiAgICAgLy8gSG9zdCBmdW5jdGlvbiBzaWduYXR1cmUg aXMgZihFeGVjU3RhdGUqKS4KICAgICBqaXQubW92ZShKU0ludGVyZmFjZUpJVDo6Y2FsbEZyYW1l UmVnaXN0ZXIsIEpTSW50ZXJmYWNlSklUOjphcmd1bWVudEdQUjApOwpAQCAtMzYxLDM1ICszNjYs MTAgQEAgc3RhdGljIE1hY3JvQXNzZW1ibGVyQ29kZVJlZiBuYXRpdmVGb3JHZQogICAgIGppdC5s b2FkUHRyKEpTSW50ZXJmYWNlSklUOjpBZGRyZXNzKEpTSW50ZXJmYWNlSklUOjphcmd1bWVudEdQ UjEsIEpTRnVuY3Rpb246Om9mZnNldE9mRXhlY3V0YWJsZSgpKSwgSlNJbnRlcmZhY2VKSVQ6OnJl Z1QyKTsKICAgICBqaXQuY2FsbChKU0ludGVyZmFjZUpJVDo6QWRkcmVzcyhKU0ludGVyZmFjZUpJ VDo6cmVnVDIsIGV4ZWN1dGFibGVPZmZzZXRUb0Z1bmN0aW9uKSk7CiAKLSAgICBqaXQucmVzdG9y ZVJldHVybkFkZHJlc3NCZWZvcmVSZXR1cm4oSlNJbnRlcmZhY2VKSVQ6OnJlZ1QzKTsKLSNlbGlm IENQVShNSVBTKQotICAgIC8vIExvYWQgY2FsbGVyIGZyYW1lJ3Mgc2NvcGUgY2hhaW4gaW50byB0 aGlzIGNhbGxmcmFtZSBzbyB0aGF0IHdoYXRldmVyIHdlIGNhbGwgY2FuCi0gICAgLy8gZ2V0IHRv IGl0cyBnbG9iYWwgZGF0YS4KLSAgICBqaXQuZW1pdEdldENhbGxlckZyYW1lRnJvbUNhbGxGcmFt ZUhlYWRlclB0cihKU0ludGVyZmFjZUpJVDo6cmVnVDApOwotICAgIGppdC5lbWl0R2V0RnJvbUNh bGxGcmFtZUhlYWRlclB0cihKU1N0YWNrOjpTY29wZUNoYWluLCBKU0ludGVyZmFjZUpJVDo6cmVn VDEsIEpTSW50ZXJmYWNlSklUOjpyZWdUMCk7Ci0gICAgaml0LmVtaXRQdXRDZWxsVG9DYWxsRnJh bWVIZWFkZXIoSlNJbnRlcmZhY2VKSVQ6OnJlZ1QxLCBKU1N0YWNrOjpTY29wZUNoYWluKTsKLQot ICAgIGppdC5wcmVzZXJ2ZVJldHVybkFkZHJlc3NBZnRlckNhbGwoSlNJbnRlcmZhY2VKSVQ6OnJl Z1QzKTsgLy8gQ2FsbGVlIHByZXNlcnZlZAotICAgIGppdC5lbWl0UHV0UmV0dXJuUENUb0NhbGxG cmFtZUhlYWRlcihKU0ludGVyZmFjZUpJVDo6cmVnVDMpOwotCi0gICAgLy8gQ2FsbGluZyBjb252 ZW50aW9uOiAgICAgIGYoYTAsIGExLCBhMiwgYTMpOwotICAgIC8vIEhvc3QgZnVuY3Rpb24gc2ln bmF0dXJlOiBmKEV4ZWNTdGF0ZSopOwotCi0gICAgLy8gQWxsb2NhdGUgc3RhY2sgc3BhY2UgZm9y IDE2IGJ5dGVzICg4LWJ5dGUgYWxpZ25lZCkKLSAgICAvLyAxNiBieXRlcyAodW51c2VkKSBmb3Ig NCBhcmd1bWVudHMKLSAgICBqaXQuc3ViUHRyKEpTSW50ZXJmYWNlSklUOjpUcnVzdGVkSW1tMzIo MTYpLCBKU0ludGVyZmFjZUpJVDo6c3RhY2tQb2ludGVyUmVnaXN0ZXIpOwotCi0gICAgLy8gU2V0 dXAgYXJnMAotICAgIGppdC5tb3ZlKEpTSW50ZXJmYWNlSklUOjpjYWxsRnJhbWVSZWdpc3Rlciwg TUlQU1JlZ2lzdGVyczo6YTApOwotCi0gICAgLy8gQ2FsbAotICAgIGppdC5lbWl0R2V0RnJvbUNh bGxGcmFtZUhlYWRlclB0cihKU1N0YWNrOjpDYWxsZWUsIE1JUFNSZWdpc3RlcnM6OmEyKTsKLSAg ICBqaXQubG9hZFB0cihKU0ludGVyZmFjZUpJVDo6QWRkcmVzcyhNSVBTUmVnaXN0ZXJzOjphMiwg SlNGdW5jdGlvbjo6b2Zmc2V0T2ZFeGVjdXRhYmxlKCkpLCBKU0ludGVyZmFjZUpJVDo6cmVnVDIp OwotICAgIGppdC5tb3ZlKEpTSW50ZXJmYWNlSklUOjpyZWdUMCwgSlNJbnRlcmZhY2VKSVQ6OmNh bGxGcmFtZVJlZ2lzdGVyKTsgLy8gRWFnZXJseSByZXN0b3JlIGNhbGxlciBmcmFtZSByZWdpc3Rl ciB0byBhdm9pZCBsb2FkaW5nIGZyb20gc3RhY2suCi0gICAgaml0LmNhbGwoSlNJbnRlcmZhY2VK SVQ6OkFkZHJlc3MoSlNJbnRlcmZhY2VKSVQ6OnJlZ1QyLCBleGVjdXRhYmxlT2Zmc2V0VG9GdW5j dGlvbikpOwotCisjaWYgQ1BVKE1JUFMpCiAgICAgLy8gUmVzdG9yZSBzdGFjayBzcGFjZQogICAg IGppdC5hZGRQdHIoSlNJbnRlcmZhY2VKSVQ6OlRydXN0ZWRJbW0zMigxNiksIEpTSW50ZXJmYWNl SklUOjpzdGFja1BvaW50ZXJSZWdpc3Rlcik7CisjZW5kaWYKIAogICAgIGppdC5yZXN0b3JlUmV0 dXJuQWRkcmVzc0JlZm9yZVJldHVybihKU0ludGVyZmFjZUpJVDo6cmVnVDMpOwogI2Vsc2UK