125063 2013-12-02 00:35:18 -0800 Guard JIT include. 2013-12-03 07:50:45 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 llango.u-szeged webkit-unassigned commit-queue fpizlo zherczeg oldest_to_newest 955267 0 llango.u-szeged 2013-12-02 00:35:18 -0800 JSInterfaceJIT.h is unused in LLIntThunks.cpp when webkit is built without JIT. 955269 1 218147 llango.u-szeged 2013-12-02 00:39:46 -0800 Created attachment 218147 Patch 955382 2 218147 msaboff 2013-12-02 08:27:50 -0800 Comment on attachment 218147 Patch The whole purpose of this file is to JIT generate small thunks to jump to LLInt entry points. 955399 3 fpizlo 2013-12-02 09:10:08 -0800 (In reply to comment #2) > (From update of attachment 218147 [details]) > The whole purpose of this file is to JIT generate small thunks to jump to LLInt entry points. Does that make Lashlo's change wrong? I think that this change is technically correct but just leads to code that is more complicated than it needs to be. I think that the problem here is that: - We have separate ENABLE(JIT) and ENABLE(LLINT_C_LOOP) defines, even though the two are exactly mutually exclusive if ENABLE(LLINT). - This entire file should basically either be guarded with either ENABLE(LLINT) && ENABLE(JIT) or ENABLE(LLINT) && !ENALBE(LLINT_C_LOOP). Lashlo's change sort of accomplishes this, but it does so piecemeal - the whole file is guarded by ENABLE(LLINT), then an include is guarded by ENABLE(JIT), and the rest of the file is guarded by !ENABLE(LLINT_C_LOOP). 955872 4 218287 llango.u-szeged 2013-12-03 05:07:20 -0800 Created attachment 218287 Patch 955893 5 218287 commit-queue 2013-12-03 07:50:43 -0800 Comment on attachment 218287 Patch Clearing flags on attachment: 218287 Committed r160003: <http://trac.webkit.org/changeset/160003> 955894 6 commit-queue 2013-12-03 07:50:45 -0800 All reviewed patches have been landed. Closing bug. 218147 2013-12-02 00:39:46 -0800 2013-12-03 05:07:13 -0800 Patch bug-125063-20131202003946.patch text/plain 1157 llango.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YTllZDRiMDg1Yjk2N2FiMzEyZGE0ZTRlZjYzOWExNDZkYWQyZmRiLi5iMWVmNzJhMTcyYzBlZDFl NTcyNjZhZjZiYmMzOGVkNTZmMzMwZTc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0xMi0wMiAgTMOhc3psw7MgTGFuZ8OzICA8bGFuZ29AaW5mLnUtc3pl Z2VkLmh1PgorCisgICAgICAgIEd1YXJkIEpJVCBpbmNsdWRlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MDYzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsbGludC9MTEludFRodW5rcy5jcHA6IEpT SW50ZXJmYWNlSklULmggaXMgdW51c2VkCisgICAgICAgIHdoZW4gd2Via2l0IGlzIGJ1aWx0IHdp dGhvdXQgSklULgorCiAyMDEzLTExLTI4ICBOYWRhdiBSb3RlbSAgPG5yb3RlbUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2ZXJ0IHRoZSBYODYgYXNzZW1ibGVyIHBlZXBob2xlIGNoYW5nZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludFRodW5rcy5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRUaHVua3MuY3BwCmluZGV4IGE3Mzg3ZDU0 YzVhZDVlZWRiZmZhMTQyYjk0Y2E4OTA3MzJiMTFjOWIuLmM3ODZmNzJmNWY3YzViMWM5NTI5NWQ1 YTA4NDA1N2I3NzhkMjliMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGlu dC9MTEludFRodW5rcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50 VGh1bmtzLmNwcApAQCAtMjgsNyArMjgsOSBAQAogCiAjaWYgRU5BQkxFKExMSU5UKQogCisjaWYg RU5BQkxFKEpJVCkKICNpbmNsdWRlICJKU0ludGVyZmFjZUpJVC5oIgorI2VuZGlmCiAjaW5jbHVk ZSAiSlNPYmplY3QuaCIKICNpbmNsdWRlICJMaW5rQnVmZmVyLmgiCiAjaW5jbHVkZSAiTG93TGV2 ZWxJbnRlcnByZXRlci5oIgo= 218287 2013-12-03 05:07:20 -0800 2013-12-03 07:50:43 -0800 Patch bug-125063-20131203050720.patch text/plain 1589 llango.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZTlmY2M2OGE0Mzg3ZDBiNTlmNWJiYzU5NTdmMDhiMmI4ZDlmZTAwLi44Y2Q1MmQxZmFkYTRiM2Zm ZGY3YmFhNTE0ZmRlYzk3YzQ3ZWM4NjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMy0xMi0wMyAgTMOhc3psw7MgTGFuZ8OzICA8bGFuZ29AaW5mLnUtc3pl Z2VkLmh1PgorCisgICAgICAgIEd1YXJkIEpJVCBpbmNsdWRlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MDYzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsbGludC9MTEludFRodW5rcy5jcHA6CisK IDIwMTMtMTEtMjkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBG aW5hbGx5IHJlbW92ZSB0aG9zZSBERkdfRU5BQkxFIHRoaW5ncwpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50VGh1bmtzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbGludC9MTEludFRodW5rcy5jcHAKaW5kZXggYTczODdkNTRjNWFkNWVlZGJmZmExNDJi OTRjYTg5MDczMmIxMWM5Yi4uY2Q0ZTdjMTA2YzIwMzM3YThmNDVlMTFkMjEyY2RlZWUwOWI0Mzhl MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50VGh1bmtzLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRUaHVua3MuY3BwCkBAIC0y Niw3ICsyNiw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTExJbnRUaHVua3Mu aCIKIAotI2lmIEVOQUJMRShMTElOVCkKKyNpZiBFTkFCTEUoTExJTlQpICYmIEVOQUJMRShKSVQp CiAKICNpbmNsdWRlICJKU0ludGVyZmFjZUpJVC5oIgogI2luY2x1ZGUgIkpTT2JqZWN0LmgiCkBA IC0zNiw4ICszNiw2IEBACiAKIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgTExJbnQgewogCi0j aWYgIUVOQUJMRShMTElOVF9DX0xPT1ApCi0KIHN0YXRpYyBNYWNyb0Fzc2VtYmxlckNvZGVSZWYg Z2VuZXJhdGVUaHVua1dpdGhKdW1wVG8oVk0qIHZtLCB2b2lkICgqdGFyZ2V0KSgpLCBjb25zdCBj aGFyICp0aHVua0tpbmQpCiB7CiAgICAgSlNJbnRlcmZhY2VKSVQgaml0KHZtKTsKQEAgLTgwLDgg Kzc4LDYgQEAgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmIHByb2dyYW1FbnRyeVRodW5rR2VuZXJhdG9y KFZNKiB2bSkKICAgICByZXR1cm4gZ2VuZXJhdGVUaHVua1dpdGhKdW1wVG8odm0sIGxsaW50X3By b2dyYW1fcHJvbG9ndWUsICJwcm9ncmFtIik7CiB9CiAKLSNlbmRpZiAvLyAhRU5BQkxFKExMSU5U X0NfTE9PUCkKLQogfSB9IC8vIG5hbWVzcGFjZSBKU0M6OkxMSW50CiAKLSNlbmRpZiAvLyBFTkFC TEUoTExJTlQpCisjZW5kaWYgLy8gRU5BQkxFKExMSU5UKSAmJiBFTkFCTEUoSklUKQo=