125061 2013-12-01 22:10:29 -0800 Web Inspector: Remove unused functions from InspectorAgent 2013-12-02 02:09:25 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 seokju seokju commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 955257 0 seokju 2013-12-01 22:10:29 -0800 Remove 'inspectedURLWithoutFragment()' from InspectorAgent as it's never called. 955258 1 218143 seokju 2013-12-01 22:13:01 -0800 Created attachment 218143 Patch 955268 2 seokju 2013-12-02 00:36:37 -0800 Remove 'inspectedURL()' as well. Patch is coming. 955270 3 218148 seokju 2013-12-02 00:39:56 -0800 Created attachment 218148 Patch 955273 4 218148 graouts 2013-12-02 00:54:18 -0800 Comment on attachment 218148 Patch I couldn't find any use of these methods either. r+ 955276 5 seokju 2013-12-02 00:56:08 -0800 (In reply to comment #4) > (From update of attachment 218148 [details]) > I couldn't find any use of these methods either. r+ Thanks, I will land the patch after making build-bots green. 955297 6 218148 commit-queue 2013-12-02 02:09:22 -0800 Comment on attachment 218148 Patch Clearing flags on attachment: 218148 Committed r159923: <http://trac.webkit.org/changeset/159923> 955298 7 commit-queue 2013-12-02 02:09:25 -0800 All reviewed patches have been landed. Closing bug. 218143 2013-12-01 22:13:01 -0800 2013-12-02 00:39:51 -0800 Patch bug-125061-20131202151300.patch text/plain 2059 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5OTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTVmZDY3M2MwNTk1ODEw YWUzOTI5Y2M2ZWMwNGQ2YmQ0MGU5MzMyMC4uODgyNmUxZjViMjBlMDBhZmI3MGVkZGU5NjI5NDhm Mjc5ZGE2ZjA0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEyLTAxICBTZW9r anUgS3dvbiAgPHNlb2tqdUB3ZWJraXQub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJl bW92ZSB1bnVzZWQgZnVuY3Rpb24gZnJvbSBJbnNwZWN0b3JBZ2VudAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MDYxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlICdpbnNwZWN0ZWRVUkxXaXRo b3V0RnJhZ21lbnQoKScgZnJvbSBJbnNwZWN0b3JBZ2VudCBhcyBpdCdzIG5ldmVyIGNhbGxlZC4K KworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvSW5zcGVjdG9yQWdlbnQuY3BwOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNw ZWN0b3JBZ2VudC5oOgorCiAyMDEzLTEyLTAxICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVA d2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTU5NzY0Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckFnZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JBZ2VudC5jcHAKaW5kZXggN2FjMzMw YWM0NTRmYjM2OWYxYzU0ZDEwYmVjMjYzYjQ3ZDgzMDk2ZS4uMGU1OTJiZDhhYWVkYjU3ZTUxNjlk MGJiYjRkZDQyMWY5Mjk0MjAyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yQWdlbnQuY3BwCkBAIC0xNjcsMTMgKzE2Nyw2IEBAIFVSTCBJbnNwZWN0b3JBZ2VudDo6aW5z cGVjdGVkVVJMKCkgY29uc3QKICAgICByZXR1cm4gbV9pbnNwZWN0ZWRQYWdlLT5tYWluRnJhbWUo KS5kb2N1bWVudCgpLT51cmwoKTsKIH0KIAotVVJMIEluc3BlY3RvckFnZW50OjppbnNwZWN0ZWRV UkxXaXRob3V0RnJhZ21lbnQoKSBjb25zdAotewotICAgIFVSTCB1cmwgPSBpbnNwZWN0ZWRVUkwo KTsKLSAgICB1cmwucmVtb3ZlRnJhZ21lbnRJZGVudGlmaWVyKCk7Ci0gICAgcmV0dXJuIHVybDsK LX0KLQogYm9vbCBJbnNwZWN0b3JBZ2VudDo6ZGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCgpIGNvbnN0 CiB7CiAgICAgaWYgKCFtX2luc3BlY3RlZFBhZ2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yQWdlbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JBZ2VudC5oCmluZGV4IDkxMTE4OWVjYjZjZTlmODA1NTFmZGQxZDRkZTUyMzAyM2Yz NTE4YzEuLjYwNjMyODUyOWJkN2ViY2EyYzA4YzBiNDU5ZjhlYTUxNGExZjk3NDUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JBZ2VudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JBZ2VudC5oCkBAIC02OCw3ICs2OCw2IEBAIHB1 YmxpYzoKICAgICB2b2lkIGRpc2FibGUoRXJyb3JTdHJpbmcqKTsKIAogICAgIFVSTCBpbnNwZWN0 ZWRVUkwoKSBjb25zdDsKLSAgICBVUkwgaW5zcGVjdGVkVVJMV2l0aG91dEZyYWdtZW50KCkgY29u c3Q7CiAKICAgICB2aXJ0dWFsIHZvaWQgZGlkQ3JlYXRlRnJvbnRlbmRBbmRCYWNrZW5kKEluc3Bl Y3RvckZyb250ZW5kQ2hhbm5lbCosIEluc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyKikgT1ZFUlJJ REU7CiAgICAgdmlydHVhbCB2b2lkIHdpbGxEZXN0cm95RnJvbnRlbmRBbmRCYWNrZW5kKCkgT1ZF UlJJREU7Cg== 218148 2013-12-02 00:39:56 -0800 2013-12-02 02:09:22 -0800 Patch bug-125061-20131202173955.patch text/plain 2685 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5OTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2FlY2E5YzIxZTgwNWQ4 Njk4YjJiZjY4MWU5MDNkMzFlZDI3OTMxYi4uMzg2Zjg0YjhhNmRjNGFiNTMxZjRlYzFiY2YyZTU1 NWJmMmFiZDgxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEyLTAyICBTZW9r anUgS3dvbiAgPHNlb2tqdUB3ZWJraXQub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJl bW92ZSB1bnVzZWQgZnVuY3Rpb25zIGZyb20gSW5zcGVjdG9yQWdlbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTA2MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdldCByaWQgb2YgdW51c2VkIGZ1bmN0 aW9ucywgcmVkdW5kYW50IGluY2x1c2lvbiBhbmQgZm9yd2FyZCBkZWNsYXJhdGlvbi4KKworICAg ICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvSW5zcGVjdG9yQWdlbnQuY3BwOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JB Z2VudC5oOgorCiAyMDEzLTEyLTAxICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4K IAogICAgICAgICBTVkc6IEludGVyc2VjdGlvbi9lbmNsb3N1cmUgY2hlY2tzIHNob3VsZCB1c2Ug UmVuZGVyRWxlbWVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQWdlbnQu Y3BwCmluZGV4IDdhYzMzMGFjNDU0ZmIzNjlmMWM1NGQxMGJlYzI2M2I0N2Q4MzA5NmUuLmVhN2I0 MjAxMzRlMjk1NzNmYTk1YmZkNjdlYWVjZDI1OGM2NGNiOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvckFnZW50LmNwcApAQCAtMTYyLDE4ICsxNjIsNiBAQCB2b2lkIElu c3BlY3RvckFnZW50OjppbnNwZWN0KFBhc3NSZWZQdHI8VHlwZUJ1aWxkZXI6OlJ1bnRpbWU6OlJl bW90ZU9iamVjdD4gb2JqZQogICAgIG1fcGVuZGluZ0luc3BlY3REYXRhLnNlY29uZCA9IGhpbnRz OwogfQogCi1VUkwgSW5zcGVjdG9yQWdlbnQ6Omluc3BlY3RlZFVSTCgpIGNvbnN0Ci17Ci0gICAg cmV0dXJuIG1faW5zcGVjdGVkUGFnZS0+bWFpbkZyYW1lKCkuZG9jdW1lbnQoKS0+dXJsKCk7Ci19 Ci0KLVVSTCBJbnNwZWN0b3JBZ2VudDo6aW5zcGVjdGVkVVJMV2l0aG91dEZyYWdtZW50KCkgY29u c3QKLXsKLSAgICBVUkwgdXJsID0gaW5zcGVjdGVkVVJMKCk7Ci0gICAgdXJsLnJlbW92ZUZyYWdt ZW50SWRlbnRpZmllcigpOwotICAgIHJldHVybiB1cmw7Ci19Ci0KIGJvb2wgSW5zcGVjdG9yQWdl bnQ6OmRldmVsb3BlckV4dHJhc0VuYWJsZWQoKSBjb25zdAogewogICAgIGlmICghbV9pbnNwZWN0 ZWRQYWdlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckFn ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQWdlbnQuaAppbmRleCA5 MTExODllY2I2Y2U5ZjgwNTUxZmRkMWQ0ZGU1MjMwMjNmMzUxOGMxLi5mYjRiZDI1NmZkOGUxNjJk YTMxMTI4OTcyYWRlMjA4Y2I4NzQ3Yzc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yQWdlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yQWdlbnQuaApAQCAtMzEsMTEgKzMxLDkgQEAKICNkZWZpbmUgSW5zcGVjdG9yQWdlbnRf aAogCiAjaW5jbHVkZSAiSW5zcGVjdG9yQmFzZUFnZW50LmgiCi0jaW5jbHVkZSA8d3RmL0Zvcndh cmQuaD4KICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRy Lmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgotI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmlu Zy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTQ2LDcgKzQ0LDYgQEAgY2xhc3MgSW5q ZWN0ZWRTY3JpcHRNYW5hZ2VyOwogY2xhc3MgSW5zcGVjdG9ySW5zcGVjdG9yRnJvbnRlbmREaXNw YXRjaGVyOwogY2xhc3MgSW5zcGVjdG9yT2JqZWN0OwogY2xhc3MgSW5zdHJ1bWVudGluZ0FnZW50 czsKLWNsYXNzIFVSTDsKIGNsYXNzIFBhZ2U7CiAKIHR5cGVkZWYgU3RyaW5nIEVycm9yU3RyaW5n OwpAQCAtNjcsOSArNjQsNiBAQCBwdWJsaWM6CiAgICAgdm9pZCBlbmFibGUoRXJyb3JTdHJpbmcq KTsKICAgICB2b2lkIGRpc2FibGUoRXJyb3JTdHJpbmcqKTsKIAotICAgIFVSTCBpbnNwZWN0ZWRV UkwoKSBjb25zdDsKLSAgICBVUkwgaW5zcGVjdGVkVVJMV2l0aG91dEZyYWdtZW50KCkgY29uc3Q7 Ci0KICAgICB2aXJ0dWFsIHZvaWQgZGlkQ3JlYXRlRnJvbnRlbmRBbmRCYWNrZW5kKEluc3BlY3Rv ckZyb250ZW5kQ2hhbm5lbCosIEluc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyKikgT1ZFUlJJREU7 CiAgICAgdmlydHVhbCB2b2lkIHdpbGxEZXN0cm95RnJvbnRlbmRBbmRCYWNrZW5kKCkgT1ZFUlJJ REU7CiAK