125051 2013-12-01 17:47:25 -0800 [Cocoa] The PageLoadState::Observer is not being set on iOS 2013-12-01 17:50:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 955197 0 sam 2013-12-01 17:47:25 -0800 [Cocoa] The PageLoadState::Observer is not being set on iOS 955198 1 218126 sam 2013-12-01 17:48:11 -0800 Created attachment 218126 Patch 955199 2 218126 mitz 2013-12-01 17:49:20 -0800 Comment on attachment 218126 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218126&action=review > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:43 > +#if WK_API_ENABLED Not sure we need these conditionals in iOS-only files. 955200 3 sam 2013-12-01 17:50:36 -0800 (In reply to comment #2) > (From update of attachment 218126 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218126&action=review > > > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:43 > > +#if WK_API_ENABLED > > Not sure we need these conditionals in iOS-only files. I'm going to keep it for consistency for now. 955201 4 sam 2013-12-01 17:50:51 -0800 Committed r159906: <http://trac.webkit.org/changeset/159906> 218126 2013-12-01 17:48:11 -0800 2013-12-01 17:49:20 -0800 Patch bug-125051-20131201174811.patch text/plain 1531 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTkwNSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEyLTAxICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NvY29hXSBUaGUgUGFnZUxvYWRTdGF0 ZTo6T2JzZXJ2ZXIgaXMgbm90IGJlaW5nIHNldCBvbiBpT1MKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTA1MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJ T1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cGxhdGZvcm1Jbml0aWFsaXpl KToKKyAgICAgICAgQWRkIG1pc3NpbmcgY2FsbCB0byBfZmluaXNoSW5pdGlhbGl6YXRpb24uCisK IDIwMTMtMTItMDEgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQgRUZMIEJ1aWxkIGZpeCBhdHRlbXB0IGFmdGVyIHIxNTk5MDMKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tCShy ZXZpc2lvbiAxNTk5MDQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dlYlBhZ2VQ cm94eUlPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjcsMTEgKzI3LDEyIEBACiAjaW1wb3J0ICJX ZWJQYWdlUHJveHkuaCIKIAogI2ltcG9ydCAiTmF0aXZlV2ViS2V5Ym9hcmRFdmVudC5oIgorI2lt cG9ydCAiUGFnZUNsaWVudC5oIgorI2ltcG9ydCAiV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVy SW50ZXJuYWwuaCIKICNpbXBvcnQgIldlYlBhZ2VNZXNzYWdlcy5oIgogI2ltcG9ydCAiV2ViUHJv Y2Vzc1Byb3h5LmgiCiAjaW1wb3J0IDxXZWJDb3JlL05vdEltcGxlbWVudGVkLmg+CiAjaW1wb3J0 IDxXZWJDb3JlL1NoYXJlZEJ1ZmZlci5oPgotI2ltcG9ydCAiUGFnZUNsaWVudEltcGxJT1MuaCIK IAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTM5LDcgKzQwLDkgQEAgbmFtZXNwYWNl IFdlYktpdCB7CiAKIHZvaWQgV2ViUGFnZVByb3h5OjpwbGF0Zm9ybUluaXRpYWxpemUoKQogewot ICAgIG5vdEltcGxlbWVudGVkKCk7CisjaWYgV0tfQVBJX0VOQUJMRUQKKyAgICBbV2ViS2l0Ojp3 cmFwcGVyKCp0aGlzKSBfZmluaXNoSW5pdGlhbGl6YXRpb25dOworI2VuZGlmCiB9CiAKIFN0cmlu ZyBXZWJQYWdlUHJveHk6OnN0YW5kYXJkVXNlckFnZW50KGNvbnN0IFN0cmluZyYpCg==