125034 2013-11-30 18:02:08 -0800 [EFL] Implement scrollbarThickness for opaque scrollbar 2013-11-30 23:03:06 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez commit-queue gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 955090 0 ryuan.choi 2013-11-30 18:02:08 -0800 WebKitEfl draws transparent scrollbar on the top of contents using edje. This patch give a chance to support opaque scrollbar by edje. 955091 1 218095 ryuan.choi 2013-11-30 18:12:13 -0800 Created attachment 218095 Patch 955095 2 218097 ryuan.choi 2013-11-30 18:44:34 -0800 Created attachment 218097 Patch 955113 3 218097 gyuyoung.kim 2013-11-30 21:28:04 -0800 Comment on attachment 218097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218097&action=review It looks this patch need to be verified if there is any layout test regression. > Source/WebCore/platform/efl/RenderThemeEfl.cpp:518 > + ScrollbarThemeEfl* scrollbarTheme = static_cast<ScrollbarThemeEfl*>(ScrollbarTheme::theme()); Don't we need to use local variable as below ? static_cast<ScrollbarThemeEfl*>(ScrollbarTheme::theme())->setScrollbarThickness(atoi(thickness)); > Source/WebCore/platform/efl/ScrollbarThemeEfl.h:39 > + virtual int scrollbarThickness(ScrollbarControlSize = RegularScrollbar) { return m_scrollbarThickness; } Missing OVERRIDE FINAL keyword. > Source/WebCore/platform/efl/ScrollbarThemeEfl.h:41 > + virtual void registerScrollbar(ScrollbarThemeClient*) { } ditto. > Source/WebCore/platform/efl/ScrollbarThemeEfl.h:42 > + virtual void unregisterScrollbar(ScrollbarThemeClient*) { } ditto. 955121 4 218103 ryuan.choi 2013-11-30 21:55:55 -0800 Created attachment 218103 Patch 955122 5 ryuan.choi 2013-11-30 21:57:20 -0800 (In reply to comment #3) > (From update of attachment 218097 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218097&action=review > > It looks this patch need to be verified if there is any layout test regression. > Because this does not change with default theme, it must be fine. > > Source/WebCore/platform/efl/RenderThemeEfl.cpp:518 > > + ScrollbarThemeEfl* scrollbarTheme = static_cast<ScrollbarThemeEfl*>(ScrollbarTheme::theme()); > > Don't we need to use local variable as below ? > static_cast<ScrollbarThemeEfl*>(ScrollbarTheme::theme())->setScrollbarThickness(atoi(thickness)); > Sure, fixed > > Source/WebCore/platform/efl/ScrollbarThemeEfl.h:39 > > + virtual int scrollbarThickness(ScrollbarControlSize = RegularScrollbar) { return m_scrollbarThickness; } > > Missing OVERRIDE FINAL keyword. > > > Source/WebCore/platform/efl/ScrollbarThemeEfl.h:41 > > + virtual void registerScrollbar(ScrollbarThemeClient*) { } > > ditto. > > > Source/WebCore/platform/efl/ScrollbarThemeEfl.h:42 > > + virtual void unregisterScrollbar(ScrollbarThemeClient*) { } > > ditto. Sure, I did. 955124 6 218103 gyuyoung.kim 2013-11-30 22:03:04 -0800 Comment on attachment 218103 Patch LGTM. 955134 7 218103 commit-queue 2013-11-30 23:03:03 -0800 Comment on attachment 218103 Patch Clearing flags on attachment: 218103 Committed r159897: <http://trac.webkit.org/changeset/159897> 955135 8 commit-queue 2013-11-30 23:03:06 -0800 All reviewed patches have been landed. Closing bug. 218095 2013-11-30 18:12:13 -0800 2013-11-30 18:44:29 -0800 Patch bug-125034-20131201111212.patch text/plain 4263 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDEyNjEwOGMwY2E4YWRh MTgzNGZhZDBmYzU3NmY0ZjNjMDUxMjg4MC4uODA4ZTI5YTJjOWFiYzZjNWY4OTA3NjFiYmQ3NmI4 OGI5NzIyMzllNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTExLTMwICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBJbXBsZW1l bnQgc2Nyb2xsYmFyVGhpY2tuZXNzIGZvciBvcGFxdWUgc2Nyb2xsYmFyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUwMzQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnRlZCBzY3JvbGxiYXJU aGlja25lc3MgdG8gc3VwcG9ydCBvcGFxdWUgc2Nyb2xsYmFyLgorICAgICAgICBOb3csIGVkaiBj YW4gZGVjaWRlIHdoZXRoZXIgdG8gc3VwcG9ydCBvcGFxdWUgc2Nyb2xsYmFyIGJ5IGFkZGluZyBz Y3JvbGxiYXIudGhpY2tuZXNzLgorICAgICAgICBJbiBhZGRpdGlvbiwgYWRkZWQgT1ZFUlJJREUv RklOQUwga2V5d29yZCB0byBTY3JvbGxiYXJUaGVtZUVmbCBhbmQgcmVtb3ZlZAorICAgICAgICB1 bm5lY2Vzc2FyeSBkZXN0cnVjdG9yLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1JlbmRlclRo ZW1lRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lRWZsOjpsb2FkVGhlbWUp OgorICAgICAgICBVcGRhdGUgdGhpY2tuZXNzIG9mIHNjcm9sbGJhciB3aGVuIHRoZW1lIHdhcyBs b2FkZWQuCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmNwcDoKKyAg ICAgICAgKiBwbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuaDoKKwogMjAxMy0xMS0yOSAg VGFtYXMgR2VyZ2VseSAgPHRnZXJnZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CiAK ICAgICAgICAgUmVtb3ZlIFN5bWJpYW4gc3BlY2lmaWMgY29kZS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCmluZGV4IDVhYWUyNTMxOTg5YzlmOGYz MzA5Y2ZkODNlMGFhOTFmZDFhNzRmZTMuLjExMDQwODkyNjc4NTNlMzc0ZjBkMzFiZjc4OTUwYWY5 MWNmZjI0YmEgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJU aGVtZUVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1l RWZsLmNwcApAQCAtNDIsOCArNDIsOCBAQAogI2luY2x1ZGUgIlJlbmRlck9iamVjdC5oIgogI2lu Y2x1ZGUgIlJlbmRlclByb2dyZXNzLmgiCiAjaW5jbHVkZSAiUmVuZGVyU2xpZGVyLmgiCisjaW5j bHVkZSAiU2Nyb2xsYmFyVGhlbWVFZmwuaCIKICNpbmNsdWRlICJVc2VyQWdlbnRTdHlsZVNoZWV0 cy5oIgotCiAjaW5jbHVkZSA8RWNvcmVfRXZhcy5oPgogI2luY2x1ZGUgPEVkamUuaD4KICNpbmNs dWRlIDxuZXc+CkBAIC01MTIsNiArNTEyLDEyIEBAIGJvb2wgUmVuZGVyVGhlbWVFZmw6OmxvYWRU aGVtZSgpCiAgICAgLy8gU2V0IG5ldyBsb2FkZWQgdGhlbWUsIGFuZCBhcHBseSBpdC4KICAgICBt X2VkamUgPSBvOwogCisgICAgY29uc3QgY2hhciogdGhpY2tuZXNzID0gZWRqZV9vYmplY3RfZGF0 YV9nZXQobV9lZGplLmdldCgpLCAic2Nyb2xsYmFyLnRoaWNrbmVzcyIpOworICAgIGlmICh0aGlj a25lc3MpIHsKKyAgICAgICAgU2Nyb2xsYmFyVGhlbWVFZmwqIHNjcm9sbGJhclRoZW1lID0gc3Rh dGljX2Nhc3Q8U2Nyb2xsYmFyVGhlbWVFZmwqPihTY3JvbGxiYXJUaGVtZTo6dGhlbWUoKSk7Cisg ICAgICAgIHNjcm9sbGJhclRoZW1lLT5zZXRTY3JvbGxiYXJUaGlja25lc3MoYXRvaSh0aGlja25l c3MpKTsKKyAgICB9CisKICAgICBlZGplX29iamVjdF9zaWduYWxfY2FsbGJhY2tfYWRkKGVkamUo KSwgImNvbG9yX2NsYXNzLHNldCIsICJ3ZWJraXQvc2VsZWN0aW9uL2ZvcmVncm91bmQiLCBhcHBs eUNvbG9yQ2FsbGJhY2ssIHRoaXMpOwogICAgIGVkamVfb2JqZWN0X3NpZ25hbF9jYWxsYmFja19h ZGQoZWRqZSgpLCAiY29sb3JfY2xhc3Msc2V0IiwgIndlYmtpdC9zZWxlY3Rpb24vYmFja2dyb3Vu ZCIsIGFwcGx5Q29sb3JDYWxsYmFjaywgdGhpcyk7CiAgICAgZWRqZV9vYmplY3Rfc2lnbmFsX2Nh bGxiYWNrX2FkZChlZGplKCksICJjb2xvcl9jbGFzcyxzZXQiLCAid2Via2l0L2ZvY3VzX3Jpbmci LCBhcHBseUNvbG9yQ2FsbGJhY2ssIHRoaXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2VmbC9TY3JvbGxiYXJUaGVtZUVmbC5jcHAKaW5kZXggYTExMWU2ZGUzZDBlZTJlMDI3ZmM1 ZTJiYWYxZjdiYzZiN2NmMDU2Yy4uZjNiZTU2NjljZTc3MmEyNzJiMjdiZTZjNzcxMGI1OTZmMTRl M2Y3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRo ZW1lRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhl bWVFZmwuY3BwCkBAIC0zNywyMiArMzcsNSBAQCBTY3JvbGxiYXJUaGVtZSogU2Nyb2xsYmFyVGhl bWU6Om5hdGl2ZVRoZW1lKCkKICAgICByZXR1cm4gJnRoZW1lOwogfQogCi1TY3JvbGxiYXJUaGVt ZUVmbDo6flNjcm9sbGJhclRoZW1lRWZsKCkKLXsKLX0KLQotaW50IFNjcm9sbGJhclRoZW1lRWZs OjpzY3JvbGxiYXJUaGlja25lc3MoU2Nyb2xsYmFyQ29udHJvbFNpemUpCi17Ci0gICAgcmV0dXJu IDA7IC8vIHdlIHBhaW50IG9uIHRvcAotfQotCi12b2lkIFNjcm9sbGJhclRoZW1lRWZsOjpyZWdp c3RlclNjcm9sbGJhcihTY3JvbGxiYXJUaGVtZUNsaWVudCopCi17Ci19Ci0KLXZvaWQgU2Nyb2xs YmFyVGhlbWVFZmw6OnVucmVnaXN0ZXJTY3JvbGxiYXIoU2Nyb2xsYmFyVGhlbWVDbGllbnQqKQot ewotfQotCiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3Jv bGxiYXJUaGVtZUVmbC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRo ZW1lRWZsLmgKaW5kZXggMjhjMTYzZWQzODg2MTA5M2FkNzg5NzUxMTJlNTYxYjE4ZjE2NzAwYy4u NTNkOWMxZTA5NDI5ODFkMTI1ZjUxNmRhNzQ1NmVjZDNiNWQzOTUyYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmgKQEAgLTMzLDE0ICszMywx NSBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIFNjcm9sbGJhclRoZW1lRWZsIDog cHVibGljIFNjcm9sbGJhclRoZW1lIHsKK2NsYXNzIFNjcm9sbGJhclRoZW1lRWZsIEZJTkFMIDog cHVibGljIFNjcm9sbGJhclRoZW1lIHsKIHB1YmxpYzoKLSAgICB2aXJ0dWFsIH5TY3JvbGxiYXJU aGVtZUVmbCgpOworICAgIHZvaWQgc2V0U2Nyb2xsYmFyVGhpY2tuZXNzKGludCB0aGlja25lc3Mp IHsgbV9zY3JvbGxiYXJUaGlja25lc3MgPSB0aGlja25lc3M7IH0KKyAgICB2aXJ0dWFsIGludCBz Y3JvbGxiYXJUaGlja25lc3MoU2Nyb2xsYmFyQ29udHJvbFNpemUgPSBSZWd1bGFyU2Nyb2xsYmFy KSBPVkVSUklERSB7IHJldHVybiBtX3Njcm9sbGJhclRoaWNrbmVzczsgfQogCi0gICAgdmlydHVh bCBpbnQgc2Nyb2xsYmFyVGhpY2tuZXNzKFNjcm9sbGJhckNvbnRyb2xTaXplID0gUmVndWxhclNj cm9sbGJhcik7Ci0KLSAgICB2aXJ0dWFsIHZvaWQgcmVnaXN0ZXJTY3JvbGxiYXIoU2Nyb2xsYmFy VGhlbWVDbGllbnQqKTsKLSAgICB2aXJ0dWFsIHZvaWQgdW5yZWdpc3RlclNjcm9sbGJhcihTY3Jv bGxiYXJUaGVtZUNsaWVudCopOworICAgIHZpcnR1YWwgdm9pZCByZWdpc3RlclNjcm9sbGJhcihT Y3JvbGxiYXJUaGVtZUNsaWVudCopIE9WRVJSSURFIHsgfQorICAgIHZpcnR1YWwgdm9pZCB1bnJl Z2lzdGVyU2Nyb2xsYmFyKFNjcm9sbGJhclRoZW1lQ2xpZW50KikgT1ZFUlJJREUgeyB9Citwcml2 YXRlOgorICAgIGludCBtX3Njcm9sbGJhclRoaWNrbmVzczsKIH07CiAKIH0K 218097 2013-11-30 18:44:34 -0800 2013-11-30 21:55:49 -0800 Patch bug-125034-20131201114433.patch text/plain 4413 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDEyNjEwOGMwY2E4YWRh MTgzNGZhZDBmYzU3NmY0ZjNjMDUxMjg4MC4uMzhmNjY0Nzk5ZWJmYzI5OTc2NDE4ZDA4NWNiOTUz MzRmOWE0ZTliYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTExLTMwICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBJbXBsZW1l bnQgc2Nyb2xsYmFyVGhpY2tuZXNzIGZvciBvcGFxdWUgc2Nyb2xsYmFyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUwMzQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnRlZCBzY3JvbGxiYXJU aGlja25lc3MgdG8gc3VwcG9ydCBvcGFxdWUgc2Nyb2xsYmFyLgorICAgICAgICBOb3csIGVkaiBj YW4gZGVjaWRlIHdoZXRoZXIgdG8gc3VwcG9ydCBvcGFxdWUgc2Nyb2xsYmFyIGJ5IGFkZGluZyBz Y3JvbGxiYXIudGhpY2tuZXNzLgorICAgICAgICBJbiBhZGRpdGlvbiwgcmVtb3ZlZCB1bm5lY2Vz c2FyeSBkZXN0cnVjdG9yLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZs LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lRWZsOjpsb2FkVGhlbWUpOgorICAg ICAgICBVcGRhdGUgdGhpY2tuZXNzIG9mIHNjcm9sbGJhciB3aGVuIHRoZW1lIHdhcyBsb2FkZWQu CisgICAgICAgICogcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmNwcDoKKyAgICAgICAg KiBwbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNj cm9sbGJhclRoZW1lRWZsOjpzZXRTY3JvbGxiYXJUaGlja25lc3MpOgorICAgICAgICAoV2ViQ29y ZTo6U2Nyb2xsYmFyVGhlbWVFZmw6OnNjcm9sbGJhclRoaWNrbmVzcyk6CisgICAgICAgIChXZWJD b3JlOjpTY3JvbGxiYXJUaGVtZUVmbDo6cmVnaXN0ZXJTY3JvbGxiYXIpOgorICAgICAgICAoV2Vi Q29yZTo6U2Nyb2xsYmFyVGhlbWVFZmw6OnVucmVnaXN0ZXJTY3JvbGxiYXIpOgorCiAyMDEzLTEx LTI5ICBUYW1hcyBHZXJnZWx5ICA8dGdlcmdlbHkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNv bT4KIAogICAgICAgICBSZW1vdmUgU3ltYmlhbiBzcGVjaWZpYyBjb2RlLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKaW5kZXggNWFhZTI1MzE5ODlj OWY4ZjMzMDljZmQ4M2UwYWE5MWZkMWE3NGZlMy4uMDNmNDc0Mzc4MmY5YWY2NjA0ZGJiYTMyODMz MzYzYWQ5MjdjNGFiNSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Jl bmRlclRoZW1lRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVy VGhlbWVFZmwuY3BwCkBAIC00Miw4ICs0Miw5IEBACiAjaW5jbHVkZSAiUmVuZGVyT2JqZWN0Lmgi CiAjaW5jbHVkZSAiUmVuZGVyUHJvZ3Jlc3MuaCIKICNpbmNsdWRlICJSZW5kZXJTbGlkZXIuaCIK KyNpbmNsdWRlICJTY3JvbGxiYXJUaGVtZUVmbC5oIgorI2luY2x1ZGUgIlNldHRpbmdzLmgiCiAj aW5jbHVkZSAiVXNlckFnZW50U3R5bGVTaGVldHMuaCIKLQogI2luY2x1ZGUgPEVjb3JlX0V2YXMu aD4KICNpbmNsdWRlIDxFZGplLmg+CiAjaW5jbHVkZSA8bmV3PgpAQCAtNTEyLDYgKzUxMywxMiBA QCBib29sIFJlbmRlclRoZW1lRWZsOjpsb2FkVGhlbWUoKQogICAgIC8vIFNldCBuZXcgbG9hZGVk IHRoZW1lLCBhbmQgYXBwbHkgaXQuCiAgICAgbV9lZGplID0gbzsKIAorICAgIGNvbnN0IGNoYXIq IHRoaWNrbmVzcyA9IGVkamVfb2JqZWN0X2RhdGFfZ2V0KG1fZWRqZS5nZXQoKSwgInNjcm9sbGJh ci50aGlja25lc3MiKTsKKyAgICBpZiAodGhpY2tuZXNzICYmICFTZXR0aW5nczo6bW9ja1Njcm9s bGJhcnNFbmFibGVkKCkpIHsKKyAgICAgICAgU2Nyb2xsYmFyVGhlbWVFZmwqIHNjcm9sbGJhclRo ZW1lID0gc3RhdGljX2Nhc3Q8U2Nyb2xsYmFyVGhlbWVFZmwqPihTY3JvbGxiYXJUaGVtZTo6dGhl bWUoKSk7CisgICAgICAgIHNjcm9sbGJhclRoZW1lLT5zZXRTY3JvbGxiYXJUaGlja25lc3MoYXRv aSh0aGlja25lc3MpKTsKKyAgICB9CisKICAgICBlZGplX29iamVjdF9zaWduYWxfY2FsbGJhY2tf YWRkKGVkamUoKSwgImNvbG9yX2NsYXNzLHNldCIsICJ3ZWJraXQvc2VsZWN0aW9uL2ZvcmVncm91 bmQiLCBhcHBseUNvbG9yQ2FsbGJhY2ssIHRoaXMpOwogICAgIGVkamVfb2JqZWN0X3NpZ25hbF9j YWxsYmFja19hZGQoZWRqZSgpLCAiY29sb3JfY2xhc3Msc2V0IiwgIndlYmtpdC9zZWxlY3Rpb24v YmFja2dyb3VuZCIsIGFwcGx5Q29sb3JDYWxsYmFjaywgdGhpcyk7CiAgICAgZWRqZV9vYmplY3Rf c2lnbmFsX2NhbGxiYWNrX2FkZChlZGplKCksICJjb2xvcl9jbGFzcyxzZXQiLCAid2Via2l0L2Zv Y3VzX3JpbmciLCBhcHBseUNvbG9yQ2FsbGJhY2ssIHRoaXMpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJUaGVtZUVmbC5jcHAKaW5kZXggYTExMWU2ZGUzZDBl ZTJlMDI3ZmM1ZTJiYWYxZjdiYzZiN2NmMDU2Yy4uZjNiZTU2NjljZTc3MmEyNzJiMjdiZTZjNzcx MGI1OTZmMTRlM2Y3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Nj cm9sbGJhclRoZW1lRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Ny b2xsYmFyVGhlbWVFZmwuY3BwCkBAIC0zNywyMiArMzcsNSBAQCBTY3JvbGxiYXJUaGVtZSogU2Ny b2xsYmFyVGhlbWU6Om5hdGl2ZVRoZW1lKCkKICAgICByZXR1cm4gJnRoZW1lOwogfQogCi1TY3Jv bGxiYXJUaGVtZUVmbDo6flNjcm9sbGJhclRoZW1lRWZsKCkKLXsKLX0KLQotaW50IFNjcm9sbGJh clRoZW1lRWZsOjpzY3JvbGxiYXJUaGlja25lc3MoU2Nyb2xsYmFyQ29udHJvbFNpemUpCi17Ci0g ICAgcmV0dXJuIDA7IC8vIHdlIHBhaW50IG9uIHRvcAotfQotCi12b2lkIFNjcm9sbGJhclRoZW1l RWZsOjpyZWdpc3RlclNjcm9sbGJhcihTY3JvbGxiYXJUaGVtZUNsaWVudCopCi17Ci19Ci0KLXZv aWQgU2Nyb2xsYmFyVGhlbWVFZmw6OnVucmVnaXN0ZXJTY3JvbGxiYXIoU2Nyb2xsYmFyVGhlbWVD bGllbnQqKQotewotfQotCiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VmbC9TY3JvbGxiYXJUaGVtZUVmbC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Nj cm9sbGJhclRoZW1lRWZsLmgKaW5kZXggMjhjMTYzZWQzODg2MTA5M2FkNzg5NzUxMTJlNTYxYjE4 ZjE2NzAwYy4uNjY1Yzg1MDY3YTI0NTZmNzFkODhjODA2NjllZTQ4NThiZTNkNjk2NSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmgKQEAgLTM1 LDEyICszNSwxMyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIFNjcm9sbGJhclRoZW1l RWZsIDogcHVibGljIFNjcm9sbGJhclRoZW1lIHsKIHB1YmxpYzoKLSAgICB2aXJ0dWFsIH5TY3Jv bGxiYXJUaGVtZUVmbCgpOworICAgIHZvaWQgc2V0U2Nyb2xsYmFyVGhpY2tuZXNzKGludCB0aGlj a25lc3MpIHsgbV9zY3JvbGxiYXJUaGlja25lc3MgPSB0aGlja25lc3M7IH0KKyAgICB2aXJ0dWFs IGludCBzY3JvbGxiYXJUaGlja25lc3MoU2Nyb2xsYmFyQ29udHJvbFNpemUgPSBSZWd1bGFyU2Ny b2xsYmFyKSB7IHJldHVybiBtX3Njcm9sbGJhclRoaWNrbmVzczsgfQogCi0gICAgdmlydHVhbCBp bnQgc2Nyb2xsYmFyVGhpY2tuZXNzKFNjcm9sbGJhckNvbnRyb2xTaXplID0gUmVndWxhclNjcm9s bGJhcik7Ci0KLSAgICB2aXJ0dWFsIHZvaWQgcmVnaXN0ZXJTY3JvbGxiYXIoU2Nyb2xsYmFyVGhl bWVDbGllbnQqKTsKLSAgICB2aXJ0dWFsIHZvaWQgdW5yZWdpc3RlclNjcm9sbGJhcihTY3JvbGxi YXJUaGVtZUNsaWVudCopOworICAgIHZpcnR1YWwgdm9pZCByZWdpc3RlclNjcm9sbGJhcihTY3Jv bGxiYXJUaGVtZUNsaWVudCopIHsgfQorICAgIHZpcnR1YWwgdm9pZCB1bnJlZ2lzdGVyU2Nyb2xs YmFyKFNjcm9sbGJhclRoZW1lQ2xpZW50KikgeyB9Citwcml2YXRlOgorICAgIGludCBtX3Njcm9s bGJhclRoaWNrbmVzczsKIH07CiAKIH0K 218103 2013-11-30 21:55:55 -0800 2013-11-30 23:03:00 -0800 Patch bug-125034-20131201145553.patch text/plain 4619 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDEyNjEwOGMwY2E4YWRh MTgzNGZhZDBmYzU3NmY0ZjNjMDUxMjg4MC4uMWIyZTg1ODE4YjViNzAxNzRhOGQ1NWYxNGNkYzY2 ZjYxMGM3NDc0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTExLTMwICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBJbXBsZW1l bnQgc2Nyb2xsYmFyVGhpY2tuZXNzIGZvciBvcGFxdWUgc2Nyb2xsYmFyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUwMzQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnRlZCBzY3JvbGxiYXJU aGlja25lc3MgdG8gc3VwcG9ydCBvcGFxdWUgc2Nyb2xsYmFyLgorICAgICAgICBOb3csIGVkaiBj YW4gZGVjaWRlIHdoZXRoZXIgdG8gc3VwcG9ydCBvcGFxdWUgc2Nyb2xsYmFyIGJ5IGFkZGluZyBz Y3JvbGxiYXIudGhpY2tuZXNzLgorICAgICAgICBJbiBhZGRpdGlvbiwgYWRkZWQgT1ZFUlJJREUv RklOQUwga2V5d29yZCBhbmQgcmVtb3ZlZCB1bm5lY2Vzc2FyeSBkZXN0cnVjdG9yCisgICAgICAg IGluIFNjcm9sbGJhclRoZW1lRWZsLmNwcC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJl aGF2aW9yIGNoYW5nZXMgd2l0aCBkZWZhdWx0IHRoZW1lLgorCisgICAgICAgICogcGxhdGZvcm0v ZWZsL1JlbmRlclRoZW1lRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lRWZs Ojpsb2FkVGhlbWUpOgorICAgICAgICBVcGRhdGUgdGhpY2tuZXNzIG9mIHNjcm9sbGJhciB3aGVu IHRoZW1lIHdhcyBsb2FkZWQuCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1l RWZsLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuaDoKKyAg ICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lRWZsOjpzZXRTY3JvbGxiYXJUaGlja25lc3Mp OgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVFZmw6OnNjcm9sbGJhclRoaWNrbmVz cyk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZUVmbDo6cmVnaXN0ZXJTY3JvbGxi YXIpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVFZmw6OnVucmVnaXN0ZXJTY3Jv bGxiYXIpOgorCiAyMDEzLTExLTI5ICBUYW1hcyBHZXJnZWx5ICA8dGdlcmdlbHkudS1zemVnZWRA cGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmUgU3ltYmlhbiBzcGVjaWZpYyBj b2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1l RWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAK aW5kZXggNWFhZTI1MzE5ODljOWY4ZjMzMDljZmQ4M2UwYWE5MWZkMWE3NGZlMy4uY2JjNWNhYjI0 MGMwNzZiNTU1ZTc5NmIxYjlmMTkyNjA1YWY2OTFlMyAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCkBAIC00Miw4ICs0Miw5IEBACiAjaW5jbHVk ZSAiUmVuZGVyT2JqZWN0LmgiCiAjaW5jbHVkZSAiUmVuZGVyUHJvZ3Jlc3MuaCIKICNpbmNsdWRl ICJSZW5kZXJTbGlkZXIuaCIKKyNpbmNsdWRlICJTY3JvbGxiYXJUaGVtZUVmbC5oIgorI2luY2x1 ZGUgIlNldHRpbmdzLmgiCiAjaW5jbHVkZSAiVXNlckFnZW50U3R5bGVTaGVldHMuaCIKLQogI2lu Y2x1ZGUgPEVjb3JlX0V2YXMuaD4KICNpbmNsdWRlIDxFZGplLmg+CiAjaW5jbHVkZSA8bmV3PgpA QCAtNTEyLDYgKzUxMywxMCBAQCBib29sIFJlbmRlclRoZW1lRWZsOjpsb2FkVGhlbWUoKQogICAg IC8vIFNldCBuZXcgbG9hZGVkIHRoZW1lLCBhbmQgYXBwbHkgaXQuCiAgICAgbV9lZGplID0gbzsK IAorICAgIGNvbnN0IGNoYXIqIHRoaWNrbmVzcyA9IGVkamVfb2JqZWN0X2RhdGFfZ2V0KG1fZWRq ZS5nZXQoKSwgInNjcm9sbGJhci50aGlja25lc3MiKTsKKyAgICBpZiAodGhpY2tuZXNzICYmICFT ZXR0aW5nczo6bW9ja1Njcm9sbGJhcnNFbmFibGVkKCkpCisgICAgICAgIHN0YXRpY19jYXN0PFNj cm9sbGJhclRoZW1lRWZsKj4oU2Nyb2xsYmFyVGhlbWU6OnRoZW1lKCkpLT5zZXRTY3JvbGxiYXJU aGlja25lc3MoYXRvaSh0aGlja25lc3MpKTsKKwogICAgIGVkamVfb2JqZWN0X3NpZ25hbF9jYWxs YmFja19hZGQoZWRqZSgpLCAiY29sb3JfY2xhc3Msc2V0IiwgIndlYmtpdC9zZWxlY3Rpb24vZm9y ZWdyb3VuZCIsIGFwcGx5Q29sb3JDYWxsYmFjaywgdGhpcyk7CiAgICAgZWRqZV9vYmplY3Rfc2ln bmFsX2NhbGxiYWNrX2FkZChlZGplKCksICJjb2xvcl9jbGFzcyxzZXQiLCAid2Via2l0L3NlbGVj dGlvbi9iYWNrZ3JvdW5kIiwgYXBwbHlDb2xvckNhbGxiYWNrLCB0aGlzKTsKICAgICBlZGplX29i amVjdF9zaWduYWxfY2FsbGJhY2tfYWRkKGVkamUoKSwgImNvbG9yX2NsYXNzLHNldCIsICJ3ZWJr aXQvZm9jdXNfcmluZyIsIGFwcGx5Q29sb3JDYWxsYmFjaywgdGhpcyk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmNwcAppbmRleCBhMTExZTZk ZTNkMGVlMmUwMjdmYzVlMmJhZjFmN2JjNmI3Y2YwNTZjLi5mM2JlNTY2OWNlNzcyYTI3MmIyN2Jl NmM3NzEwYjU5NmYxNGUzZjcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9l ZmwvU2Nyb2xsYmFyVGhlbWVFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9TY3JvbGxiYXJUaGVtZUVmbC5jcHAKQEAgLTM3LDIyICszNyw1IEBAIFNjcm9sbGJhclRoZW1l KiBTY3JvbGxiYXJUaGVtZTo6bmF0aXZlVGhlbWUoKQogICAgIHJldHVybiAmdGhlbWU7CiB9CiAK LVNjcm9sbGJhclRoZW1lRWZsOjp+U2Nyb2xsYmFyVGhlbWVFZmwoKQotewotfQotCi1pbnQgU2Ny b2xsYmFyVGhlbWVFZmw6OnNjcm9sbGJhclRoaWNrbmVzcyhTY3JvbGxiYXJDb250cm9sU2l6ZSkK LXsKLSAgICByZXR1cm4gMDsgLy8gd2UgcGFpbnQgb24gdG9wCi19Ci0KLXZvaWQgU2Nyb2xsYmFy VGhlbWVFZmw6OnJlZ2lzdGVyU2Nyb2xsYmFyKFNjcm9sbGJhclRoZW1lQ2xpZW50KikKLXsKLX0K LQotdm9pZCBTY3JvbGxiYXJUaGVtZUVmbDo6dW5yZWdpc3RlclNjcm9sbGJhcihTY3JvbGxiYXJU aGVtZUNsaWVudCopCi17Ci19Ci0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9l ZmwvU2Nyb2xsYmFyVGhlbWVFZmwuaAppbmRleCAyOGMxNjNlZDM4ODYxMDkzYWQ3ODk3NTExMmU1 NjFiMThmMTY3MDBjLi44NzU5MmE3MTVmNDQ5NDk0YzUwYTIzMWIzNGNlNmViNjI0MmNjNTdjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuaApA QCAtMzMsMTQgKzMzLDE2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3MgU2Nyb2xs YmFyVGhlbWVFZmwgOiBwdWJsaWMgU2Nyb2xsYmFyVGhlbWUgeworY2xhc3MgU2Nyb2xsYmFyVGhl bWVFZmwgRklOQUwgOiBwdWJsaWMgU2Nyb2xsYmFyVGhlbWUgewogcHVibGljOgotICAgIHZpcnR1 YWwgflNjcm9sbGJhclRoZW1lRWZsKCk7Ci0KLSAgICB2aXJ0dWFsIGludCBzY3JvbGxiYXJUaGlj a25lc3MoU2Nyb2xsYmFyQ29udHJvbFNpemUgPSBSZWd1bGFyU2Nyb2xsYmFyKTsKLQotICAgIHZp cnR1YWwgdm9pZCByZWdpc3RlclNjcm9sbGJhcihTY3JvbGxiYXJUaGVtZUNsaWVudCopOwotICAg IHZpcnR1YWwgdm9pZCB1bnJlZ2lzdGVyU2Nyb2xsYmFyKFNjcm9sbGJhclRoZW1lQ2xpZW50Kik7 CisgICAgU2Nyb2xsYmFyVGhlbWVFZmwoKSA6IG1fc2Nyb2xsYmFyVGhpY2tuZXNzKDApIHsgfQor ICAgIHZvaWQgc2V0U2Nyb2xsYmFyVGhpY2tuZXNzKGludCB0aGlja25lc3MpIHsgbV9zY3JvbGxi YXJUaGlja25lc3MgPSB0aGlja25lc3M7IH0KKyAgICB2aXJ0dWFsIGludCBzY3JvbGxiYXJUaGlj a25lc3MoU2Nyb2xsYmFyQ29udHJvbFNpemUgPSBSZWd1bGFyU2Nyb2xsYmFyKSBPVkVSUklERSB7 IHJldHVybiBtX3Njcm9sbGJhclRoaWNrbmVzczsgfQorCisgICAgdmlydHVhbCB2b2lkIHJlZ2lz dGVyU2Nyb2xsYmFyKFNjcm9sbGJhclRoZW1lQ2xpZW50KikgT1ZFUlJJREUgeyB9CisgICAgdmly dHVhbCB2b2lkIHVucmVnaXN0ZXJTY3JvbGxiYXIoU2Nyb2xsYmFyVGhlbWVDbGllbnQqKSBPVkVS UklERSB7IH0KK3ByaXZhdGU6CisgICAgaW50IG1fc2Nyb2xsYmFyVGhpY2tuZXNzOwogfTsKIAog fQo=