125033 2013-11-30 16:08:16 -0800 [EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded 2013-12-01 15:41:12 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez cmarcelo commit-queue gyuyoung.kim lucas.de.marchi luiz noam rakuco zeno oldest_to_newest 955087 0 ryuan.choi 2013-11-30 16:08:16 -0800 m_contentsSize should be cleared when new contents are loaded so that PageViewportController takes care of newly loaded contents having same size with previous one. It's because PageViewportController is cleared not to make wrong behaviour while loading when new contents are committed. 955088 1 218094 ryuan.choi 2013-11-30 16:11:15 -0800 Created attachment 218094 Patch 955140 2 218094 gyuyoung.kim 2013-12-01 01:06:03 -0800 Comment on attachment 218094 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218094&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:992 > + ewk_view_html_string_load(webView(), contentsSizeHTMLPortrait, 0, 0); Assuming that m_contentsSize needs to be initialized, this test looks make sense. > Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:374 > + m_contentsSize = IntSize(); Noam, could you take a look this ? 955141 3 218094 noam 2013-12-01 02:07:13 -0800 Comment on attachment 218094 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218094&action=review Some language nits, otherwise ok with me > Source/WebKit2/ChangeLog:9 > + takes care of newly loaded contents having same size with previous one. takes care -> would take care having -> with with -> as >> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:374 >> + m_contentsSize = IntSize(); > > Noam, could you take a look this ? I think this is fine. 955142 4 218094 noam 2013-12-01 02:07:14 -0800 Comment on attachment 218094 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218094&action=review Some language nits, otherwise ok with me > Source/WebKit2/ChangeLog:9 > + takes care of newly loaded contents having same size with previous one. takes care -> would take care having -> with with -> as >> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:374 >> + m_contentsSize = IntSize(); > > Noam, could you take a look this ? I think this is fine. 955143 5 218094 gyuyoung.kim 2013-12-01 05:09:12 -0800 Comment on attachment 218094 Patch Please land this patch after fixing things Noam points out. 955189 6 ryuan.choi 2013-12-01 15:40:24 -0800 Committed r159901: <http://trac.webkit.org/changeset/159901> 955190 7 ryuan.choi 2013-12-01 15:41:02 -0800 (In reply to comment #5) > (From update of attachment 218094 [details]) > Please land this patch after fixing things Noam points out. landed after fixed Noam's comment. Thanks. 218094 2013-11-30 16:11:15 -0800 2013-12-01 15:41:12 -0800 Patch bug-125033-20131201091114.patch text/plain 2780 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTQyMTRkYmIxOGZkOGM5 NTgyZjdiY2RmMDM4OTdmYmIyNjJjYzUwOS4uMTA5NmY3NGQzZWI2YTczZmQ0ZDFlN2VhYWQ1MDkx ZDc0MmZiYjIxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTExLTMwICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtDb29yZGlu YXRlZEdyYXBoaWNzXSBDbGVhciBtX2NvbnRlbnRzU2l6ZSB3aGVuIG5ldyBjb250ZW50cyBhcmUg bG9hZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjUwMzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBt X2NvbnRlbnRzU2l6ZSBzaG91bGQgYmUgY2xlYXJlZCB3aGVuIG5ldyBjb250ZW50cyBhcmUgbG9h ZGVkIHNvIHRoYXQgUGFnZVZpZXdwb3J0Q29udHJvbGxlcgorICAgICAgICB0YWtlcyBjYXJlIG9m IG5ld2x5IGxvYWRlZCBjb250ZW50cyBoYXZpbmcgc2FtZSBzaXplIHdpdGggcHJldmlvdXMgb25l LgorICAgICAgICBJdCdzIGJlY2F1c2UgUGFnZVZpZXdwb3J0Q29udHJvbGxlciBpcyBjbGVhcmVk IG5vdCB0byBtYWtlIHdyb25nIGJlaGF2aW91cgorICAgICAgICB3aGlsZSBsb2FkaW5nIHdoZW4g bmV3IGNvbnRlbnRzIGFyZSBjb21taXR0ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHA6CisgICAgICAgIChURVNUX0YpOgorICAgICAgICBJ bXByb3ZlIHRlc3RzIHRvIGNoZWNrIGNvbnRlbnRzLHNpemUsY2hhbmdlZCBzaWduYWwgd2hlbiBs b2FkZWQgY29udGVudHMgaGF2aW5nCisgICAgICAgIHNhbWUgc2l6ZSB3aXRoIHByZXZpb3VzIG9u ZS4KKyAgICAgICAgKiBVSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViVmlldzo6ZGlkQ29tbWl0TG9hZEZvck1haW5GcmFtZSk6IENs ZWFyZWQgbV9jb250ZW50c1NpemUuCisKIDIwMTMtMTEtMjggIFJ5dWFuIENob2kgIDxyeXVhbi5j aG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXIg ZG9lcyBub3QgbmVlZCB0byBiZSB1bmlxdWVfcHRyIGluc3RhbmNlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAK aW5kZXggYTU0MTJkNTkyY2Y2YTA3NGZhNzQyMWVkYjcwYWMxZTA4ZWIyYzdlMy4uZmNkNzM2ZTc1 NGEyNjMxNDVlMDA3NzM5ZjY0ZDRkZjA0NmY0NzQ2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcApAQCAt OTg2LDYgKzk4NiwxMyBAQCBURVNUX0YoRVdLMlZpZXdUZXN0LCBld2tfdmlld19jb250ZW50c19z aXplX2NoYW5nZWQpCiAgICAgc2l6ZUNoYW5nZWQgPSBmYWxzZTsKICAgICB3aGlsZSAoIXNpemVD aGFuZ2VkKQogICAgICAgICBlY29yZV9tYWluX2xvb3BfaXRlcmF0ZSgpOworCisgICAgLy8gTWFr ZSBzdXJlIHdlIGdldCBzaWduYWwgYWZ0ZXIgbG9hZGVkIHRoZSBjb250ZW50cyBoYXZpbmcgc2Ft ZSBzaXplIHdpdGggcHJldmlvdXMgb25lLgorICAgIHNpemVDaGFuZ2VkID0gZmFsc2U7CisgICAg ZXdrX3ZpZXdfaHRtbF9zdHJpbmdfbG9hZCh3ZWJWaWV3KCksIGNvbnRlbnRzU2l6ZUhUTUxQb3J0 cmFpdCwgMCwgMCk7CisgICAgd2hpbGUgKCFzaXplQ2hhbmdlZCkKKyAgICAgICAgZWNvcmVfbWFp bl9sb29wX2l0ZXJhdGUoKTsKKwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2RlbCh3 ZWJWaWV3KCksICJjb250ZW50cyxzaXplLGNoYW5nZWQiLCBvbkNvbnRlbnRzU2l6ZUNoYW5nZWRQ b3J0cmFpdCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29y ZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nv b3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKaW5kZXggNzg0MTJmY2U4OWI3ODExY2ExNjQz ZjUxZTI0ZjIzZjA2MDM4NjI0OS4uYzVmZDBlMGUzNjY0Mzk4NzQwOWRlNWVmNmIyMzA0MzhjNmI1 MTdiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvV2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5h dGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKQEAgLTM3MSw3ICszNzEsNyBAQCB2b2lkIFdlYlZpZXc6 OnRvb2xUaXBDaGFuZ2VkKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYgbmV3VG9vbFRpcCkK IAogdm9pZCBXZWJWaWV3OjpkaWRDb21taXRMb2FkRm9yTWFpbkZyYW1lKCkKIHsKLSAgICBub3RJ bXBsZW1lbnRlZCgpOworICAgIG1fY29udGVudHNTaXplID0gSW50U2l6ZSgpOwogfQogCiB2b2lk IFdlYlZpZXc6OnNldEN1cnNvcihjb25zdCBXZWJDb3JlOjpDdXJzb3ImKQo=