125021 2013-11-29 15:40:24 -0800 [MediaStream] Use iterator-based loops instead of index-based loops 2013-12-02 13:38:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rogerzanoni webkit-unassigned commit-queue eric.carlson glenn hta jer.noble nick.diego tommyw oldest_to_newest 955028 0 rogerzanoni 2013-11-29 15:40:24 -0800 Changing some index based loops to iterator loops and using auto keyword instead of default iterators 955029 1 218080 rogerzanoni 2013-11-29 15:41:40 -0800 Created attachment 218080 Patch 955032 2 218080 sam 2013-11-29 16:22:39 -0800 Comment on attachment 218080 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218080&action=review A few notes: - This bug does not have a descriptive enough title. - The patch is missing a changelog. > Source/WebCore/Modules/mediastream/MediaStream.cpp:140 > + for (auto iter = source.begin(); iter != source.end(); ++iter) The normal pattern we use is: for (auto it = source.begin(), end = source.end(); it != end; ++it) ... This avoids resolving .end() multiple times. > Source/WebCore/Modules/mediastream/MediaStream.cpp:-259 > + for (auto iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) > + if (!(*iter)->ended()) > return; > - > - for (size_t i = 0; i < m_videoTracks.size(); ++i) > - if (!m_videoTracks[i]->ended()) > + for (auto iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) > + if (!(*iter)->ended()) > return; > - The two loops should have braces. 955468 3 218193 rogerzanoni 2013-12-02 11:16:46 -0800 Created attachment 218193 Patch 955551 4 218193 commit-queue 2013-12-02 13:38:31 -0800 Comment on attachment 218193 Patch Clearing flags on attachment: 218193 Committed r159958: <http://trac.webkit.org/changeset/159958> 955552 5 commit-queue 2013-12-02 13:38:34 -0800 All reviewed patches have been landed. Closing bug. 218080 2013-11-29 15:41:40 -0800 2013-12-02 11:16:38 -0800 Patch bug-125021-20131129194020.patch text/plain 1917 rogerzanoni U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0uY3BwCmluZGV4IGZlYTE3ZmFkMTZiY2JjYWUzMDFi MjA2MzVhNDIwMTNlYTVmOWUxYjUuLmNlMThkOGEwZjFiMWNmYTBmYWRmM2YxMmVlMDVkMDhiNzZl NDcwMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVk aWFTdHJlYW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVk aWFTdHJlYW0uY3BwCkBAIC0xMzcsOCArMTM3LDggQEAgUGFzc1JlZlB0cjxNZWRpYVN0cmVhbT4g TWVkaWFTdHJlYW06OmNsb25lKCkKIAogdm9pZCBNZWRpYVN0cmVhbTo6Y2xvbmVNZWRpYVN0cmVh bVRyYWNrVmVjdG9yKFZlY3RvcjxSZWZQdHI8TWVkaWFTdHJlYW1UcmFjaz4+JiBkZXN0aW5hdGlv biwgY29uc3QgVmVjdG9yPFJlZlB0cjxNZWRpYVN0cmVhbVRyYWNrPj4mIHNvdXJjZSkKIHsKLSAg ICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc291cmNlLnNpemUoKTsgaSsrKQotICAgICAgICBk ZXN0aW5hdGlvbi5hcHBlbmQoc291cmNlW2ldLT5jbG9uZSgpKTsKKyAgICBmb3IgKGF1dG8gaXRl ciA9IHNvdXJjZS5iZWdpbigpOyBpdGVyICE9IHNvdXJjZS5lbmQoKTsgKytpdGVyKQorICAgICAg ICBkZXN0aW5hdGlvbi5hcHBlbmQoKCppdGVyKS0+Y2xvbmUoKSk7CiB9CiAKIHZvaWQgTWVkaWFT dHJlYW06OmFkZFRyYWNrKFBhc3NSZWZQdHI8TWVkaWFTdHJlYW1UcmFjaz4gcHJwVHJhY2ssIEV4 Y2VwdGlvbkNvZGUmIGVjKQpAQCAtMjQ5LDE0ICsyNDksMTMgQEAgTWVkaWFTdHJlYW1UcmFjayog TWVkaWFTdHJlYW06OmdldFRyYWNrQnlJZChTdHJpbmcgaWQpCiAKIHZvaWQgTWVkaWFTdHJlYW06 OnRyYWNrRGlkRW5kKCkKIHsKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fYXVkaW9UcmFj a3Muc2l6ZSgpOyArK2kpCi0gICAgICAgIGlmICghbV9hdWRpb1RyYWNrc1tpXS0+ZW5kZWQoKSkK KyAgICBmb3IgKGF1dG8gaXRlciA9IG1fYXVkaW9UcmFja3MuYmVnaW4oKTsgaXRlciAhPSBtX2F1 ZGlvVHJhY2tzLmVuZCgpOyArK2l0ZXIpCisgICAgICAgIGlmICghKCppdGVyKS0+ZW5kZWQoKSkK ICAgICAgICAgICAgIHJldHVybjsKLSAgICAKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1f dmlkZW9UcmFja3Muc2l6ZSgpOyArK2kpCi0gICAgICAgIGlmICghbV92aWRlb1RyYWNrc1tpXS0+ ZW5kZWQoKSkKKyAgICBmb3IgKGF1dG8gaXRlciA9IG1fdmlkZW9UcmFja3MuYmVnaW4oKTsgaXRl ciAhPSBtX3ZpZGVvVHJhY2tzLmVuZCgpOyArK2l0ZXIpCisgICAgICAgIGlmICghKCppdGVyKS0+ ZW5kZWQoKSkKICAgICAgICAgICAgIHJldHVybjsKLSAgICAKKwogICAgIHNldEVuZGVkKCk7CiB9 CiAKQEAgLTM1MSw5ICszNTAsOCBAQCB2b2lkIE1lZGlhU3RyZWFtOjpzY2hlZHVsZWRFdmVudFRp bWVyRmlyZWQoVGltZXI8TWVkaWFTdHJlYW0+KikKICAgICBWZWN0b3I8UmVmUHRyPEV2ZW50Pj4g ZXZlbnRzOwogICAgIGV2ZW50cy5zd2FwKG1fc2NoZWR1bGVkRXZlbnRzKTsKIAotICAgIFZlY3Rv cjxSZWZQdHI8RXZlbnQ+Pjo6aXRlcmF0b3IgaXQgPSBldmVudHMuYmVnaW4oKTsKLSAgICBmb3Ig KDsgaXQgIT0gZXZlbnRzLmVuZCgpOyArK2l0KQotICAgICAgICBkaXNwYXRjaEV2ZW50KCgqaXQp LnJlbGVhc2UoKSk7CisgICAgZm9yIChhdXRvIGl0ZXIgPSBldmVudHMuYmVnaW4oKTsgaXRlciAh PSBldmVudHMuZW5kKCk7ICsraXRlcikKKyAgICAgICAgZGlzcGF0Y2hFdmVudCgoKml0ZXIpLnJl bGVhc2UoKSk7CiAKICAgICBldmVudHMuY2xlYXIoKTsKIH0K 218193 2013-12-02 11:16:46 -0800 2013-12-02 13:38:31 -0800 Patch bug-125021-20131202151527.patch text/plain 4723 rogerzanoni U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5OTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThjYTRhZTJlMzI2MTQ1 OWUwMGE3MGNlNjczMGJkZDZlNjM3ODNkOS4uMmI0ZTc0ZmU5NTJkN2FiM2EwYWI4YzMzOGNmNzg4 NjY4MTdkZjVlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTEyLTAyICBSb2dl ciBaYW5vbmkgIDxyb2dlcnphbm9uaUBnbWFpbC5jb20+CisKKyAgICAgICAgW01lZGlhU3RyZWFt XSBVc2UgaXRlcmF0b3ItYmFzZWQgbG9vcHMgaW5zdGVhZCBvZiBpbmRleC1iYXNlZCBsb29wcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MDIxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxzbywgY2hh bmdpbmcgaXRlcmF0b3IgdmFyaWFibGUgbmFtZXMgZnJvbSBpdGVyIHRvIGl0IGFuZAorICAgICAg ICBpbml0aWFsaXppbmcgYW4gJ2VuZCcgdmFyaWFibGUgaW4gZWFjaCBsb29wIGluc3RlYWQgb2Yg ZXZhbHVhdGluZworICAgICAgICAnY29sbGVjdGlvbi5lbmQoKScgbXVsdGlwbGUgdGltZXMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5IGV4aXN0aW5nIG9uZXMuCisKKyAgICAg ICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhU3RyZWFtOjpjbG9uZU1lZGlhU3RyZWFtVHJhY2tWZWN0b3IpOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFTdHJlYW06OmhhdmVUcmFja1dpdGhTb3VyY2UpOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFTdHJlYW06OmdldFRyYWNrQnlJZCk6CisgICAgICAgIChXZWJDb3JlOjpNZWRp YVN0cmVhbTo6dHJhY2tEaWRFbmQpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTdHJlYW06OnNj aGVkdWxlZEV2ZW50VGltZXJGaXJlZCk6CisKIDIwMTMtMTItMDIgIEFuZHJlcyBHb21leiAgPGFn b21lekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEZhaWxzIHRvIGJ1aWxkIHdpdGggZnJl ZXR5cGUgMi41LjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vTWVkaWFTdHJlYW0uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9N ZWRpYVN0cmVhbS5jcHAKaW5kZXggZmVhMTdmYWQxNmJjYmNhZTMwMWIyMDYzNWE0MjAxM2VhNWY5 ZTFiNS4uNzhhZWNiNWRmZDMyNzlkMTgzMTE1MDZjYzFjNWIyMGNjYjYyY2E0YiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5jcHAKQEAg LTEzNyw4ICsxMzcsOCBAQCBQYXNzUmVmUHRyPE1lZGlhU3RyZWFtPiBNZWRpYVN0cmVhbTo6Y2xv bmUoKQogCiB2b2lkIE1lZGlhU3RyZWFtOjpjbG9uZU1lZGlhU3RyZWFtVHJhY2tWZWN0b3IoVmVj dG9yPFJlZlB0cjxNZWRpYVN0cmVhbVRyYWNrPj4mIGRlc3RpbmF0aW9uLCBjb25zdCBWZWN0b3I8 UmVmUHRyPE1lZGlhU3RyZWFtVHJhY2s+PiYgc291cmNlKQogewotICAgIGZvciAodW5zaWduZWQg aSA9IDA7IGkgPCBzb3VyY2Uuc2l6ZSgpOyBpKyspCi0gICAgICAgIGRlc3RpbmF0aW9uLmFwcGVu ZChzb3VyY2VbaV0tPmNsb25lKCkpOworICAgIGZvciAoYXV0byBpdCA9IHNvdXJjZS5iZWdpbigp LCBlbmQgPSBzb3VyY2UuZW5kKCk7IGl0ICE9IGVuZDsgKytpdCkKKyAgICAgICAgZGVzdGluYXRp b24uYXBwZW5kKCgqaXQpLT5jbG9uZSgpKTsKIH0KIAogdm9pZCBNZWRpYVN0cmVhbTo6YWRkVHJh Y2soUGFzc1JlZlB0cjxNZWRpYVN0cmVhbVRyYWNrPiBwcnBUcmFjaywgRXhjZXB0aW9uQ29kZSYg ZWMpCkBAIC0yMTcsMTUgKzIxNywxNSBAQCBib29sIE1lZGlhU3RyZWFtOjpyZW1vdmVUcmFjayhQ YXNzUmVmUHRyPE1lZGlhU3RyZWFtVHJhY2s+IHBycFRyYWNrKQogYm9vbCBNZWRpYVN0cmVhbTo6 aGF2ZVRyYWNrV2l0aFNvdXJjZShQYXNzUmVmUHRyPE1lZGlhU3RyZWFtU291cmNlPiBzb3VyY2Up CiB7CiAgICAgaWYgKHNvdXJjZS0+dHlwZSgpID09IE1lZGlhU3RyZWFtU291cmNlOjpBdWRpbykg ewotICAgICAgICBmb3IgKGF1dG8gaXRlciA9IG1fYXVkaW9UcmFja3MuYmVnaW4oKTsgaXRlciAh PSBtX2F1ZGlvVHJhY2tzLmVuZCgpOyArK2l0ZXIpIHsKLSAgICAgICAgICAgIGlmICgoKml0ZXIp LT5zb3VyY2UoKSA9PSBzb3VyY2UuZ2V0KCkpCisgICAgICAgIGZvciAoYXV0byBpdCA9IG1fYXVk aW9UcmFja3MuYmVnaW4oKSwgZW5kID0gbV9hdWRpb1RyYWNrcy5lbmQoKTsgaXQgIT0gZW5kOyAr K2l0KSB7CisgICAgICAgICAgICBpZiAoKCppdCktPnNvdXJjZSgpID09IHNvdXJjZS5nZXQoKSkK ICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQogICAgICAgICByZXR1cm4g ZmFsc2U7CiAgICAgfQogCi0gICAgZm9yIChhdXRvIGl0ZXIgPSBtX3ZpZGVvVHJhY2tzLmJlZ2lu KCk7IGl0ZXIgIT0gbV92aWRlb1RyYWNrcy5lbmQoKTsgKytpdGVyKSB7Ci0gICAgICAgIGlmICgo Kml0ZXIpLT5zb3VyY2UoKSA9PSBzb3VyY2UuZ2V0KCkpCisgICAgZm9yIChhdXRvIGl0ID0gbV92 aWRlb1RyYWNrcy5iZWdpbigpLCBlbmQgPSBtX3ZpZGVvVHJhY2tzLmVuZCgpOyBpdCAhPSBlbmQ7 ICsraXQpIHsKKyAgICAgICAgaWYgKCgqaXQpLT5zb3VyY2UoKSA9PSBzb3VyY2UuZ2V0KCkpCiAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKQEAgLTIzNCwxNCArMjM0LDE0IEBAIGJv b2wgTWVkaWFTdHJlYW06OmhhdmVUcmFja1dpdGhTb3VyY2UoUGFzc1JlZlB0cjxNZWRpYVN0cmVh bVNvdXJjZT4gc291cmNlKQogCiBNZWRpYVN0cmVhbVRyYWNrKiBNZWRpYVN0cmVhbTo6Z2V0VHJh Y2tCeUlkKFN0cmluZyBpZCkKIHsKLSAgICBmb3IgKGF1dG8gaXRlciA9IG1fYXVkaW9UcmFja3Mu YmVnaW4oKTsgaXRlciAhPSBtX2F1ZGlvVHJhY2tzLmVuZCgpOyArK2l0ZXIpIHsKLSAgICAgICAg aWYgKCgqaXRlciktPmlkKCkgPT0gaWQpCi0gICAgICAgICAgICByZXR1cm4gKCppdGVyKS5nZXQo KTsKKyAgICBmb3IgKGF1dG8gaXQgPSBtX2F1ZGlvVHJhY2tzLmJlZ2luKCksIGVuZCA9IG1fYXVk aW9UcmFja3MuZW5kKCk7IGl0ICE9IGVuZDsgKytpdCkgeworICAgICAgICBpZiAoKCppdCktPmlk KCkgPT0gaWQpCisgICAgICAgICAgICByZXR1cm4gKCppdCkuZ2V0KCk7CiAgICAgfQogCi0gICAg Zm9yIChhdXRvIGl0ZXIgPSBtX3ZpZGVvVHJhY2tzLmJlZ2luKCk7IGl0ZXIgIT0gbV92aWRlb1Ry YWNrcy5lbmQoKTsgKytpdGVyKSB7Ci0gICAgICAgIGlmICgoKml0ZXIpLT5pZCgpID09IGlkKQot ICAgICAgICAgICAgcmV0dXJuICgqaXRlcikuZ2V0KCk7CisgICAgZm9yIChhdXRvIGl0ID0gbV92 aWRlb1RyYWNrcy5iZWdpbigpLCBlbmQgPSBtX3ZpZGVvVHJhY2tzLmVuZCgpOyBpdCAhPSBlbmQ7 ICsraXQpIHsKKyAgICAgICAgaWYgKCgqaXQpLT5pZCgpID09IGlkKQorICAgICAgICAgICAgcmV0 dXJuICgqaXQpLmdldCgpOwogICAgIH0KIAogICAgIHJldHVybiBudWxscHRyOwpAQCAtMjQ5LDE0 ICsyNDksMTUgQEAgTWVkaWFTdHJlYW1UcmFjayogTWVkaWFTdHJlYW06OmdldFRyYWNrQnlJZChT dHJpbmcgaWQpCiAKIHZvaWQgTWVkaWFTdHJlYW06OnRyYWNrRGlkRW5kKCkKIHsKLSAgICBmb3Ig KHNpemVfdCBpID0gMDsgaSA8IG1fYXVkaW9UcmFja3Muc2l6ZSgpOyArK2kpCi0gICAgICAgIGlm ICghbV9hdWRpb1RyYWNrc1tpXS0+ZW5kZWQoKSkKKyAgICBmb3IgKGF1dG8gaXQgPSBtX2F1ZGlv VHJhY2tzLmJlZ2luKCksIGVuZCA9IG1fYXVkaW9UcmFja3MuZW5kKCk7IGl0ICE9IGVuZDsgKytp dCkgeworICAgICAgICBpZiAoISgqaXQpLT5lbmRlZCgpKQogICAgICAgICAgICAgcmV0dXJuOwot ICAgIAotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV92aWRlb1RyYWNrcy5zaXplKCk7ICsr aSkKLSAgICAgICAgaWYgKCFtX3ZpZGVvVHJhY2tzW2ldLT5lbmRlZCgpKQorICAgIH0KKyAgICBm b3IgKGF1dG8gaXQgPSBtX3ZpZGVvVHJhY2tzLmJlZ2luKCksIGVuZCA9IG1fdmlkZW9UcmFja3Mu ZW5kKCk7IGl0ICE9IGVuZDsgKytpdCkgeworICAgICAgICBpZiAoISgqaXQpLT5lbmRlZCgpKQog ICAgICAgICAgICAgcmV0dXJuOwotICAgIAorICAgIH0KKwogICAgIHNldEVuZGVkKCk7CiB9CiAK QEAgLTM1MSw4ICszNTIsNyBAQCB2b2lkIE1lZGlhU3RyZWFtOjpzY2hlZHVsZWRFdmVudFRpbWVy RmlyZWQoVGltZXI8TWVkaWFTdHJlYW0+KikKICAgICBWZWN0b3I8UmVmUHRyPEV2ZW50Pj4gZXZl bnRzOwogICAgIGV2ZW50cy5zd2FwKG1fc2NoZWR1bGVkRXZlbnRzKTsKIAotICAgIFZlY3RvcjxS ZWZQdHI8RXZlbnQ+Pjo6aXRlcmF0b3IgaXQgPSBldmVudHMuYmVnaW4oKTsKLSAgICBmb3IgKDsg aXQgIT0gZXZlbnRzLmVuZCgpOyArK2l0KQorICAgIGZvciAoYXV0byBpdCA9IGV2ZW50cy5iZWdp bigpLCBlbmQgPSBldmVudHMuZW5kKCk7IGl0ICE9IGVuZDsgKytpdCkKICAgICAgICAgZGlzcGF0 Y2hFdmVudCgoKml0KS5yZWxlYXNlKCkpOwogCiAgICAgZXZlbnRzLmNsZWFyKCk7Cg==