125010 2013-11-29 06:16:06 -0800 Fix build warning in EventHandler.cpp 2013-12-02 01:56:16 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mtiborinf webkit-unassigned benjamin commit-queue gyuyoung.kim hausmann kling ossy yong.li.webkit oldest_to_newest 954960 0 mtiborinf 2013-11-29 06:16:06 -0800 There is an unused parameter warning in EventHandler.cpp. 954967 1 218058 mtiborinf 2013-11-29 06:50:04 -0800 Created attachment 218058 Patch Patch for the unused parameter warning in Eventhandler.cpp. 954979 2 218058 ossy 2013-11-29 07:42:29 -0800 Comment on attachment 218058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218058&action=review > Source/WebCore/ChangeLog:9 > + There was a build warning in EventHandler.cpp > + Please remove this redundant comment. 954981 3 218066 mtiborinf 2013-11-29 07:51:36 -0800 Created attachment 218066 Patch v2 Removed the redundant comment. 955290 4 218066 commit-queue 2013-12-02 01:56:13 -0800 Comment on attachment 218066 Patch v2 Clearing flags on attachment: 218066 Committed r159921: <http://trac.webkit.org/changeset/159921> 955291 5 commit-queue 2013-12-02 01:56:16 -0800 All reviewed patches have been landed. Closing bug. 218058 2013-11-29 06:50:04 -0800 2013-11-29 07:51:36 -0800 Patch event.patch text/plain 1104 mtiborinf ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5YWI0MWI2Li5mNmEyOWJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMTEtMjkgIFRpYm9yIE1lc3phcm9zICA8bXRpYm9yQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBGaXggYnVpbGQgd2FybmluZyBpbiBFdmVudEhhbmRsZXIuY3BwCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUwMTAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSB3YXMgYSBidWls ZCB3YXJuaW5nIGluIEV2ZW50SGFuZGxlci5jcHAKKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5k bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6ZXZlbnRJbnZlcnRzVGFi c1RvTGlua3NDbGllbnRDYWxsUmVzdWx0KToKKwogMjAxMy0xMS0yNyAgTmljayBEaWVnbyBZYW1h bmUgIDxuaWNrLnlhbWFuZUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJlbW92ZSBRdC1zcGVj aWZpYyAucXJjIGZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFu ZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggOThi OTdhOS4uNGZkYWQxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRs ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMzM2 Niw2ICszMzY2LDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmV2ZW50SW52ZXJ0c1RhYnNUb0xpbmtz Q2xpZW50Q2FsbFJlc3VsdChLZXlib2FyZEV2ZW50KiBldmVudCkKICNpZiBQTEFURk9STShNQUMp IHx8IFBMQVRGT1JNKEVGTCkKICAgICByZXR1cm4gRXZlbnRIYW5kbGVyOjppc0tleWJvYXJkT3B0 aW9uVGFiKGV2ZW50KTsKICNlbHNlCisgICAgVU5VU0VEX1BBUkFNKGV2ZW50KTsKICAgICByZXR1 cm4gZmFsc2U7CiAjZW5kaWYKIH0K 218066 2013-11-29 07:51:36 -0800 2013-12-02 01:56:13 -0800 Patch v2 event.patch text/plain 1047 mtiborinf ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5YWI0MWI2Li4yMTZiZjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMTEtMjkgIFRpYm9yIE1lc3phcm9zICA8bXRpYm9yQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBGaXggYnVpbGQgd2FybmluZyBpbiBFdmVudEhhbmRsZXIuY3BwCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUwMTAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5k bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6ZXZlbnRJbnZlcnRzVGFi c1RvTGlua3NDbGllbnRDYWxsUmVzdWx0KToKKwogMjAxMy0xMS0yNyAgTmljayBEaWVnbyBZYW1h bmUgIDxuaWNrLnlhbWFuZUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJlbW92ZSBRdC1zcGVj aWZpYyAucXJjIGZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFu ZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggOThi OTdhOS4uNGZkYWQxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRs ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMzM2 Niw2ICszMzY2LDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmV2ZW50SW52ZXJ0c1RhYnNUb0xpbmtz Q2xpZW50Q2FsbFJlc3VsdChLZXlib2FyZEV2ZW50KiBldmVudCkKICNpZiBQTEFURk9STShNQUMp IHx8IFBMQVRGT1JNKEVGTCkKICAgICByZXR1cm4gRXZlbnRIYW5kbGVyOjppc0tleWJvYXJkT3B0 aW9uVGFiKGV2ZW50KTsKICNlbHNlCisgICAgVU5VU0VEX1BBUkFNKGV2ZW50KTsKICAgICByZXR1 cm4gZmFsc2U7CiAjZW5kaWYKIH0K