125007 2013-11-29 03:58:47 -0800 [EFL] Fix incorrectly position of the viewport 2013-12-25 19:05:34 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux CLOSED INVALID P2 Normal --- 124965 1 hs85.jeong webkit-unassigned cdumez cmarcelo commit-queue gyuyoung.kim lucas.de.marchi luiz noam rakuco ryuan.choi zeno oldest_to_newest 954938 0 hs85.jeong 2013-11-29 03:58:47 -0800 This bugs occurred by https://bugs.webkit.org/show_bug.cgi?id=124965. Added the missed part of previous patch. 954939 1 hs85.jeong 2013-11-29 04:00:43 -0800 Changed the titile name. 954940 2 hs85.jeong 2013-11-29 04:01:25 -0800 (In reply to comment #1) > Changed the titile name. titile -> title... 954943 3 218052 hs85.jeong 2013-11-29 04:35:22 -0800 Created attachment 218052 Patch 955089 4 218052 ryuan.choi 2013-11-30 17:20:18 -0800 Comment on attachment 218052 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218052&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] Fix incorrectly position of the viewport I think that title is really ambiguous. > Source/WebKit2/ChangeLog:8 > + The position of viewport is wrong by https://bugs.webkit.org/show_bug.cgi?id=124965. What is wrong? The previous commit is also to fix wrong viewport issue. We need more information whether to decide to revert previous one or fix new regression. 955101 5 hs85.jeong 2013-11-30 19:34:22 -0800 (In reply to comment #4) > (From update of attachment 218052 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218052&action=review > > > Source/WebKit2/ChangeLog:3 > > + [EFL] Fix incorrectly position of the viewport > > I think that title is really ambiguous. > > > Source/WebKit2/ChangeLog:8 > > + The position of viewport is wrong by https://bugs.webkit.org/show_bug.cgi?id=124965. > > What is wrong? The previous commit is also to fix wrong viewport issue. > > We need more information whether to decide to revert previous one or fix new regression. It Would be better to revert the previous patch. 955108 6 ryuan.choi 2013-11-30 19:59:51 -0800 I reverted r159865 so that this is not needed. You can upload a patch at Bug 124965 when you find a better solution not to make regression (that the position of events are wrong) 962941 7 218052 gyuyoung.kim 2013-12-25 18:57:15 -0800 Comment on attachment 218052 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218052&action=review >>> Source/WebKit2/ChangeLog:3 >>> + [EFL] Fix incorrectly position of the viewport >> >> I think that title is really ambiguous. > > It Would be better to revert the previous patch. incorrectly -> incorrect. And also, this patch touch coordinated graphics. So, it would be good to add [CoordinatedGraphics] as well. > Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:248 > +AffineTransform WebView::transformToUserViewport() const Could you explain why you use *UserViewport* in function name ? 962942 8 218052 gyuyoung.kim 2013-12-25 18:57:51 -0800 Comment on attachment 218052 Patch Oops. This patch was already closed. Clear r?. 962947 9 hs85.jeong 2013-12-25 19:05:34 -0800 Oops,,! I missed closing the issue. Sorry! 218052 2013-11-29 04:35:22 -0800 2013-12-25 18:57:51 -0800 Patch bug-125007-20131129213521.patch text/plain 4468 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODIzNWJlNGJlM2Q2ODBm YWJjYWZhZGIzMjJkMjBhOTRlZjJiNDA0My4uOGQ2ZTFkZTAzZTYxOTE0MzBhYWExODhmYzhhOWVi MjIyM2Q2NGRjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEzLTExLTI5ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KIAorICAgICAgICBbRUZMXSBGaXgg aW5jb3JyZWN0bHkgcG9zaXRpb24gb2YgdGhlIHZpZXdwb3J0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUwMDcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcG9zaXRpb24gb2Ygdmlld3BvcnQgaXMg d3JvbmcgYnkgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDk2NS4K KyAgICAgICAgQ2hhbmdlZCB0aGUgcG9zaXRpb24gb2Ygdmlld3BvcnQsIGJlY2F1c2UgcG9zaXRp b24gb2Ygdmlld3BvcnQgaXNuJ3Qgc3RhcnRlZCBmcm9tICgwLDApIHdoZW4gdGhlIHdlYnZpZXcg aXMgcGFpbnRlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwOgor ICAgICAgICAoRXdrVmlldzo6aGFuZGxlRXZhc09iamVjdENhbGN1bGF0ZSk6IEFkZGVkIHRoZSBX S1ZpZXdTZXRVc2VyVmlld3BvcnRUcmFuc2xhdGlvbi4KKyAgICAgICAgKiBVSVByb2Nlc3MvQ29v cmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlldzo6 cGFpbnRUb0N1cnJlbnRHTENvbnRleHQpOiBDaGFuZ2VkIHRoZSB0cmFuc2Zvcm1Ub1NjZW5lIHRv IHRyYW5zZm9ybVRvVXNlclZpZXdwb3J0LgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Ojp0cmFu c2Zvcm1Ub1VzZXJWaWV3cG9ydCk6IEFkZGVkIHRoZSB0cmFuc2Zvcm1Ub1VzZXJWaWV3cG9ydC4K KyAgICAgICAgKiBVSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3Lmg6IEFkZGVk IHRoZSB0cmFuc2Zvcm1Ub1VzZXJWaWV3cG9ydC4KKworMjAxMy0xMS0yOSAgSHVuc2VvcCBKZW9u ZyAgPGhzODUuamVvbmdAc2Ftc3VuZy5jb20+CisKICAgICAgICAgW0VGTF0gdmlld3BvcnQgbXVz dCBiZSBzYW1lIHdpdGggdGhlIHNpemUgb2Ygd2VidmlldwogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0OTY1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKaW5kZXggMDczNGE4MDBmYTBjNzVkNDRkY2NjN2Rk NGMwZGE4MGE0M2M4NzAyYi4uYjUwYTdlOGY1ZmE1NWZhYThlNjk1YTA5ZWU4NzhlMzdjOTk5ZTZm YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKQEAg LTExOTYsNiArMTE5Niw3IEBAIHZvaWQgRXdrVmlldzo6aGFuZGxlRXZhc09iamVjdENhbGN1bGF0 ZShFdmFzX09iamVjdCogZXZhc09iamVjdCkKICAgICAgICAgc21hcnREYXRhLT52aWV3LnggPSB4 OwogICAgICAgICBzbWFydERhdGEtPnZpZXcueSA9IHk7CiAgICAgICAgIGV2YXNfb2JqZWN0X21v dmUoc21hcnREYXRhLT5pbWFnZSwgeCwgeSk7CisgICAgICAgIFdLVmlld1NldFVzZXJWaWV3cG9y dFRyYW5zbGF0aW9uKHNlbGYtPndrVmlldygpLCB4LCB5KTsKICAgICB9CiAKICAgICBpZiAoc21h cnREYXRhLT5jaGFuZ2VkLnNpemUpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKaW5kZXggYThjZWQxMmFlYmE2 OTQzNWU4YmI4NWQ3MjFhZDUwMWJjMjY2YmMyYi4uN2UyOWM4NzFjYmQzYjY3MzI3NmI0NWYxNGZj ODg2NjZhYTMzNzU1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKQEAgLTE0OCw5ICsxNDgsOSBAQCB2b2lk IFdlYlZpZXc6OnBhaW50VG9DdXJyZW50R0xDb250ZXh0KCkKIAogICAgIC8vIEZJWE1FOiBXZSBu ZWVkIHRvIGNsZWFuIHVwIHRoaXMgY29kZSBhcyBpdCBpcyBzcGxpdCBvdmVyIENvb3JkR2Z4IGFu ZCBQYWdlLgogICAgIHNjZW5lLT5zZXREcmF3c0JhY2tncm91bmQobV9wYWdlLT5kcmF3c0JhY2tn cm91bmQoKSk7Ci0gICAgY29uc3QgRmxvYXRSZWN0JiB2aWV3cG9ydCA9IG1fdXNlclZpZXdwb3J0 VHJhbnNmb3JtLm1hcFJlY3QoSW50UmVjdChJbnRQb2ludCgpLCBtX3NpemUpKTsKKyAgICBjb25z dCBGbG9hdFJlY3QmIHZpZXdwb3J0ID0gRmxvYXRSZWN0KEZsb2F0UG9pbnQoKSwgc3RhdGljX2Nh c3Q8RmxvYXRTaXplPihtX3NpemUpKTsKIAotICAgIHNjZW5lLT5wYWludFRvQ3VycmVudEdMQ29u dGV4dCh0cmFuc2Zvcm1Ub1NjZW5lKCkudG9UcmFuc2Zvcm1hdGlvbk1hdHJpeCgpLCBtX29wYWNp dHksIHZpZXdwb3J0KTsKKyAgICBzY2VuZS0+cGFpbnRUb0N1cnJlbnRHTENvbnRleHQodHJhbnNm b3JtVG9Vc2VyVmlld3BvcnQoKS50b1RyYW5zZm9ybWF0aW9uTWF0cml4KCksIG1fb3BhY2l0eSwg dmlld3BvcnQpOwogfQogCiB2b2lkIFdlYlZpZXc6OnNldERyYXdzQmFja2dyb3VuZChib29sIGRy YXdzQmFja2dyb3VuZCkKQEAgLTI0NSw2ICsyNDUsMTkgQEAgQWZmaW5lVHJhbnNmb3JtIFdlYlZp ZXc6OnRyYW5zZm9ybVRvU2NlbmUoKSBjb25zdAogICAgIHJldHVybiB0cmFuc2Zvcm0udG9BZmZp bmVUcmFuc2Zvcm0oKTsKIH0KIAorQWZmaW5lVHJhbnNmb3JtIFdlYlZpZXc6OnRyYW5zZm9ybVRv VXNlclZpZXdwb3J0KCkgY29uc3QKK3sKKyAgICBGbG9hdFBvaW50IHBvc2l0aW9uID0gLW1fY29u dGVudFBvc2l0aW9uOworICAgIGZsb2F0IGVmZmVjdGl2ZVNjYWxlID0gbV9jb250ZW50U2NhbGVG YWN0b3IgKiBtX3BhZ2UtPmRldmljZVNjYWxlRmFjdG9yKCk7CisgICAgcG9zaXRpb24uc2NhbGUo ZWZmZWN0aXZlU2NhbGUsIGVmZmVjdGl2ZVNjYWxlKTsKKworICAgIFRyYW5zZm9ybWF0aW9uTWF0 cml4IHRyYW5zZm9ybTsKKyAgICB0cmFuc2Zvcm0udHJhbnNsYXRlKHBvc2l0aW9uLngoKSwgcG9z aXRpb24ueSgpKTsKKyAgICB0cmFuc2Zvcm0uc2NhbGUoZWZmZWN0aXZlU2NhbGUpOworCisgICAg cmV0dXJuIHRyYW5zZm9ybS50b0FmZmluZVRyYW5zZm9ybSgpOworfQorCiBDb29yZGluYXRlZEdy YXBoaWNzU2NlbmUqIFdlYlZpZXc6OmNvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZSgpCiB7CiAgICAg aWYgKENvb3JkaW5hdGVkRHJhd2luZ0FyZWFQcm94eSogZHJhd2luZ0FyZWEgPSBzdGF0aWNfY2Fz dDxDb29yZGluYXRlZERyYXdpbmdBcmVhUHJveHkqPihwYWdlKCktPmRyYXdpbmdBcmVhKCkpKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv V2ViVmlldy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv V2ViVmlldy5oCmluZGV4IDI0NTRkMTk2MGU5YTJjMTUzM2E0ZmZkNjlmMDczYjQ1MTA0MzI1NzMu LmU5NWVlYjM2M2U4NzdjMzY1Y2RkNjI0MmE3NDRmMzhhZjk0NjY5NzMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmgK QEAgLTExMSw2ICsxMTEsNyBAQCBwdWJsaWM6CiAgICAgLy8gRklYTUU6IFNob3VsZCBiZWNvbWUg cHJpdmF0ZSB3aGVuIFdlYiBFdmVudHMgY3JlYXRpb24gaXMgbW92ZWQgdG8gV2ViVmlldy4KICAg ICBXZWJDb3JlOjpBZmZpbmVUcmFuc2Zvcm0gdHJhbnNmb3JtRnJvbVNjZW5lKCkgY29uc3Q7CiAg ICAgV2ViQ29yZTo6QWZmaW5lVHJhbnNmb3JtIHRyYW5zZm9ybVRvU2NlbmUoKSBjb25zdDsKKyAg ICBXZWJDb3JlOjpBZmZpbmVUcmFuc2Zvcm0gdHJhbnNmb3JtVG9Vc2VyVmlld3BvcnQoKSBjb25z dDsKIAogICAgIHZvaWQgc2V0T3BhY2l0eShkb3VibGUgb3BhY2l0eSkgeyBtX29wYWNpdHkgPSBj bGFtcFRvKG9wYWNpdHksIDAuMCwgMS4wKTsgfQogICAgIGRvdWJsZSBvcGFjaXR5KCkgY29uc3Qg eyByZXR1cm4gbV9vcGFjaXR5OyB9Cg==