125001 2013-11-28 23:18:49 -0800 [WebGL] Unnecessary condition check in the while loop 2015-05-11 03:42:53 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 p.szymanski3 webkit-unassigned bfulgham commit-queue dino esprehn+autocc gyuyoung.kim kondapallykalyan ossy roger_fong oldest_to_newest 954888 0 p.szymanski3 2013-11-28 23:18:49 -0800 In this situation a while loop needs to make an unnecessary check at the begining. This loop is designed to make at least one iteration. In this case a better option is to use do-while. And it is also a good practice not to make such code. 954921 1 218047 p.szymanski3 2013-11-29 02:39:37 -0800 Created attachment 218047 patch 966179 2 bfulgham 2014-01-09 19:36:30 -0800 For the simple boolean test, I doubt this has much benefit. Did you do some profiling that showed this as a hotspot? I think your code is probably more correct, but I'm not sure it's worth changing at this point. 1093728 3 218047 commit-queue 2015-05-11 03:42:49 -0700 Comment on attachment 218047 patch Clearing flags on attachment: 218047 Committed r184073: <http://trac.webkit.org/changeset/184073> 1093729 4 commit-queue 2015-05-11 03:42:53 -0700 All reviewed patches have been landed. Closing bug. 218047 2013-11-29 02:39:37 -0800 2015-05-11 03:42:49 -0700 patch framebuffer_while.patch text/plain 1761 p.szymanski3 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMDMzNDIyLi5iNjZkYzBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMTEtMjkgIFByemVteXNsYXcgU3p5bWFuc2tpICA8cC5zenltYW5za2kzQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtXZWJHTF0gVW5uZWNlc3NhcnkgY29uZGl0aW9uIGNoZWNrIGlu IHRoZSB3aGlsZSBsb29wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjUwMDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGlsZSBsb29wIGluIHRoaXMgY2FzZSBuZWVkcyB0byBiZSBvcHRpbWl6ZWQgYSBs aXR0bGUuCisgICAgICAgIEZvciBub3cgYSBjb25kaXRpb25hbCBzdGF0ZW1lbnQgaW4gd2hpbGUg d2lsbCBleGVjdXRlIHR3bworICAgICAgICB0aW1lcyBhdCBiZWdpbi4gZG8td2hpbGUgbG9vcCBh dm9pZHMgdG8gY2hlY2sgZmlyc3Qgc3RhdGVtZW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g Tm8gYmVoYXZpb3VyIGNoYW5nZWQuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTEZyYW1l YnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMRnJhbWVidWZmZXI6OnJlbW92ZUF0 dGFjaG1lbnRGcm9tQm91bmRGcmFtZWJ1ZmZlcik6CisKIDIwMTMtMTEtMjggIEd5dXlvdW5nIEtp bSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW5hbWUgSW5saW5lSXRl cmF0b3I6Om1fb2JqIGFuZCBtYWtlIGl0IHByaXZhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvY2FudmFzL1dlYkdMRnJhbWVidWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9jYW52YXMvV2ViR0xGcmFtZWJ1ZmZlci5jcHAKaW5kZXggZjgwODQxNi4uOTEwZTdmZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xGcmFtZWJ1ZmZlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xGcmFtZWJ1ZmZlci5jcHAKQEAg LTM2OSw3ICszNjksNyBAQCB2b2lkIFdlYkdMRnJhbWVidWZmZXI6OnJlbW92ZUF0dGFjaG1lbnRG cm9tQm91bmRGcmFtZWJ1ZmZlcihXZWJHTFNoYXJlZE9iamVjdCogYQogICAgICAgICByZXR1cm47 CiAKICAgICBib29sIGNoZWNrTW9yZSA9IHRydWU7Ci0gICAgd2hpbGUgKGNoZWNrTW9yZSkgewor ICAgIGRvIHsKICAgICAgICAgY2hlY2tNb3JlID0gZmFsc2U7CiAgICAgICAgIGZvciAoQXR0YWNo bWVudE1hcDo6aXRlcmF0b3IgaXQgPSBtX2F0dGFjaG1lbnRzLmJlZ2luKCk7IGl0ICE9IG1fYXR0 YWNobWVudHMuZW5kKCk7ICsraXQpIHsKICAgICAgICAgICAgIFdlYkdMQXR0YWNobWVudCogYXR0 YWNobWVudE9iamVjdCA9IGl0LT52YWx1ZS5nZXQoKTsKQEAgLTM4MSw3ICszODEsNyBAQCB2b2lk IFdlYkdMRnJhbWVidWZmZXI6OnJlbW92ZUF0dGFjaG1lbnRGcm9tQm91bmRGcmFtZWJ1ZmZlcihX ZWJHTFNoYXJlZE9iamVjdCogYQogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAg fQogICAgICAgICB9Ci0gICAgfQorICAgIH0gd2hpbGUgKGNoZWNrTW9yZSk7CiB9CiAKIEdDM0Rz aXplaSBXZWJHTEZyYW1lYnVmZmVyOjpnZXRDb2xvckJ1ZmZlcldpZHRoKCkgY29uc3QK