124991 2013-11-28 16:05:53 -0800 [EFL] Build fix after r159859 2013-11-28 16:59:47 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song cmarcelo commit-queue lucas.de.marchi luiz noam zeno oldest_to_newest 954843 0 jinwoo7.song 2013-11-28 16:05:53 -0800 [ 94%] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp: In static member function ‘static WTF::PassRefPtr<WebKit::WebView> WebKit::WebView::create(WebKit::WebContext*, WebKit::WebPageGroup*)’: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp:54:54: error: cannot allocate an object of abstract type ‘WebKit::WebViewEfl’ In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp:27:0: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.h:39:7: note: because the following virtual functions are pure within ‘WebKit::WebViewEfl’: In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h:34:0, from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.h:29, from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp:27: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/PageClient.h:128:18: note: virtual void WebKit::PageClient::didCommitLoadForMainFrame() /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp:55:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/WebViewEfl.cpp.o] Error 1 954844 1 218026 jinwoo7.song 2013-11-28 16:10:48 -0800 Created attachment 218026 Patch 954849 2 218026 commit-queue 2013-11-28 16:59:45 -0800 Comment on attachment 218026 Patch Clearing flags on attachment: 218026 Committed r159861: <http://trac.webkit.org/changeset/159861> 954850 3 commit-queue 2013-11-28 16:59:47 -0800 All reviewed patches have been landed. Closing bug. 218026 2013-11-28 16:10:48 -0800 2013-11-28 16:59:44 -0800 Patch bug-124991-20131129091040.patch text/plain 2228 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjE1NzE1YWU2MGM5ODNl Y2I5ZmE4YWI5YmE3Yjc2MjIwY2U3YmFhYS4uMDlkMDYzNzMwNjRkOThlNWIwZjg3ZmMxMGIwNjQ2 YzU2YmViMGQ2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTExLTI4ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBCdWls ZCBmaXggYWZ0ZXIgcjE1OTg1OQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI0OTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVkZWZpbmVkIG5ld2x5IGFkZGVkIHB1cmUgdmlydHVhbCBmdW5jdGlvbiBp biBQYWdlQ2xpZW50IGNsYXNzIGFmdGVyIHIxNTk4NTkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv Q29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmll dzo6ZGlkQ29tbWl0TG9hZEZvck1haW5GcmFtZSk6CisgICAgICAgICogVUlQcm9jZXNzL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvV2ViVmlldy5oOgorCiAyMDEzLTExLTI3ICBTYW0gV2VpbmlnICA8c2Ft QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUGVyZm9ybSBzb21lIHNwcmluZyBjbGVhbmluZyB0byBX S0NvbnRlbnRWaWV3IGFuZCBXS1ZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKaW5kZXggNGQ4MWRhOTViMGRj ODY3Y2MyYzZlOTIwMWQ2YzRjZTI4MmVhZjk4ZC4uNzg0MTJmY2U4OWI3ODExY2ExNjQzZjUxZTI0 ZjIzZjA2MDM4NjI0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKQEAgLTM2OSw2ICszNjksMTEgQEAgdm9p ZCBXZWJWaWV3Ojp0b29sVGlwQ2hhbmdlZChjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmIG5l d1Rvb2xUaXApCiAgICAgbV9jbGllbnQuZGlkQ2hhbmdlVG9vbHRpcCh0aGlzLCBuZXdUb29sVGlw KTsKIH0KIAordm9pZCBXZWJWaWV3OjpkaWRDb21taXRMb2FkRm9yTWFpbkZyYW1lKCkKK3sKKyAg ICBub3RJbXBsZW1lbnRlZCgpOworfQorCiB2b2lkIFdlYlZpZXc6OnNldEN1cnNvcihjb25zdCBX ZWJDb3JlOjpDdXJzb3ImKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmggYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmgKaW5k ZXggYTg4NDk5MTkzYTZiMmU1ODlhNjk3MmRhZjZhZTA1MWIzOTFmYjcyOS4uMjQ1NGQxOTYwZTlh MmMxNTMzYTRmZmQ2OWYwNzNiNDUxMDQzMjU3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuaApAQCAtMTQ3LDYgKzE0 Nyw4IEBAIHByb3RlY3RlZDoKIAogICAgIHZpcnR1YWwgdm9pZCB0b29sVGlwQ2hhbmdlZChjb25z dCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmKSBPVkVSUklERTsKIAorICAgIHZpcnR1YWwgdm9pZCBk aWRDb21taXRMb2FkRm9yTWFpbkZyYW1lKCkgT1ZFUlJJREU7CisKICAgICB2aXJ0dWFsIHZvaWQg cGFnZURpZFJlcXVlc3RTY3JvbGwoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmKSBPVkVSUklERTsK ICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVuZGVyRnJhbWUoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYg Y29udGVudHNTaXplLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiBjb3ZlcmVkUmVjdCkgT1ZFUlJJ REU7CiAgICAgdmlydHVhbCB2b2lkIHBhZ2VUcmFuc2l0aW9uVmlld3BvcnRSZWFkeSgpIE9WRVJS SURFOwo=