<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>124975</bug_id>
          
          <creation_ts>2013-11-28 09:13:17 -0800</creation_ts>
          <short_desc>Fix a crash in the webaudio source provider when the audio track is going away.</short_desc>
          <delta_ts>2013-12-02 05:55:59 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BlinkMergeCandidate</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>121101</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Nick Diego Yamane (diegoyam)">nick.diego</reporter>
          <assigned_to name="Nick Diego Yamane (diegoyam)">nick.diego</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>glenn</cc>
    
    <cc>jer.noble</cc>
    
    <cc>pnormand</cc>
    
    <cc>rogerzanoni</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>954753</commentid>
    <comment_count>0</comment_count>
    <who name="Nick Diego Yamane (diegoyam)">nick.diego</who>
    <bug_when>2013-11-28 09:13:17 -0800</bug_when>
    <thetext>Consider merging:

https://chromium.googlesource.com/chromium/blink/+/b21838b32bf11b1a972dfc449ddde71115490c23

Before this, it was hitting a use-after-free crash on the renderer when the audio track in the media stream is going away and the webaudio MediaStreamSourceNode is still running.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955022</commentid>
    <comment_count>1</comment_count>
      <attachid>218078</attachid>
    <who name="Nick Diego Yamane (diegoyam)">nick.diego</who>
    <bug_when>2013-11-29 13:15:05 -0800</bug_when>
    <thetext>Created attachment 218078
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955060</commentid>
    <comment_count>2</comment_count>
      <attachid>218078</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-11-30 01:16:39 -0800</bug_when>
    <thetext>Comment on attachment 218078
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218078&amp;action=review

&gt; Source/WebCore/ChangeLog:8
&gt; +        Before this patch, it was hittinh a use-after-free crash  when the audio

Typo: hittinh. Also, I&apos;m not sure it&apos;s a common thing to do when merging Blink changes but I think it&apos;d be good to mention the blink commit and its author in the ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955081</commentid>
    <comment_count>3</comment_count>
      <attachid>218078</attachid>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2013-11-30 14:05:30 -0800</bug_when>
    <thetext>Comment on attachment 218078
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218078&amp;action=review

&gt;&gt; Source/WebCore/ChangeLog:8
&gt;&gt; +        Before this patch, it was hittinh a use-after-free crash  when the audio
&gt; 
&gt; Typo: hittinh. Also, I&apos;m not sure it&apos;s a common thing to do when merging Blink changes but I think it&apos;d be good to mention the blink commit and its author in the ChangeLog.

Yes, we typically include the Blink commit url and author in the ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955176</commentid>
    <comment_count>4</comment_count>
    <who name="Nick Diego Yamane (diegoyam)">nick.diego</who>
    <bug_when>2013-12-01 12:33:11 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 218078 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=218078&amp;action=review
&gt; 
&gt; &gt;&gt; Source/WebCore/ChangeLog:8
&gt; &gt;&gt; +        Before this patch, it was hittinh a use-after-free crash  when the audio
&gt; &gt; 
&gt; &gt; Typo: hittinh. Also, I&apos;m not sure it&apos;s a common thing to do when merging Blink changes but I think it&apos;d be good to mention the blink commit and its author in the ChangeLog.
&gt; 
&gt; Yes, we typically include the Blink commit url and author in the ChangeLog.

Yeah, you&apos;re right about that. I&apos;ll upload a patch with those i nformations in the changelog tomorrow.

Thanks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955328</commentid>
    <comment_count>5</comment_count>
      <attachid>218160</attachid>
    <who name="Nick Diego Yamane (diegoyam)">nick.diego</who>
    <bug_when>2013-12-02 03:59:01 -0800</bug_when>
    <thetext>Created attachment 218160
Improved ChangeLog

Updated as per comments from Eric and Philip.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955330</commentid>
    <comment_count>6</comment_count>
      <attachid>218160</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-12-02 04:09:28 -0800</bug_when>
    <thetext>Comment on attachment 218160
Improved ChangeLog

Hum sorry the author is missing in the ChangeLog</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955346</commentid>
    <comment_count>7</comment_count>
      <attachid>218160</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-12-02 05:29:30 -0800</bug_when>
    <thetext>Comment on attachment 218160
Improved ChangeLog

cq+ as other blink merges don&apos;t include author either. It can be found on the blink review link anyway.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955353</commentid>
    <comment_count>8</comment_count>
      <attachid>218160</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-12-02 05:55:57 -0800</bug_when>
    <thetext>Comment on attachment 218160
Improved ChangeLog

Clearing flags on attachment: 218160

Committed r159931: &lt;http://trac.webkit.org/changeset/159931&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955354</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-12-02 05:55:59 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>218078</attachid>
            <date>2013-11-29 13:15:05 -0800</date>
            <delta_ts>2013-12-02 03:58:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-124975-20131129172649.patch</filename>
            <type>text/plain</type>
            <size>6346</size>
            <attacher name="Nick Diego Yamane (diegoyam)">nick.diego</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDEyNjEwOGMwY2E4YWRh
MTgzNGZhZDBmYzU3NmY0ZjNjMDUxMjg4MC4uY2Y2OWNkMDM0ZGMxOWM3MTYwMTZhNWExYjM3ZDA5
MmUzZjhkMmY1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTExLTI5ICBOaWNr
IERpZWdvIFlhbWFuZSAgPG5pY2sueWFtYW5lQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgRml4
IGEgY3Jhc2ggaW4gdGhlIHdlYmF1ZGlvIHNvdXJjZSBwcm92aWRlciB3aGVuIHRoZSBhdWRpbyB0
cmFjayBpcyBnb2luZyBhd2F5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTI0OTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgQmVmb3JlIHRoaXMgcGF0Y2gsIGl0IHdhcyBoaXR0aW5oIGEgdXNlLWFmdGVy
LWZyZWUgY3Jhc2ggIHdoZW4gdGhlIGF1ZGlvCisgICAgICAgIHRyYWNrIGluIHRoZSBtZWRpYSBz
dHJlYW0gaXMgZ29pbmcgYXdheSBhbmQgdGhlIHdlYmF1ZGlvIG1lZGlhc3RyZWFtc291cmNlbm9k
ZQorICAgICAgICBpcyBzdGlsbCBydW5uaW5nLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRp
by9BdWRpb0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0OjpjcmVh
dGVNZWRpYVN0cmVhbVNvdXJjZSk6IFBhc3NpbmcgYXVkaW8gdHJhY2sKKyAgICAgICAgcG9pbnRl
ciB0byBNZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZSBjb25zdHJ1Y3Rvci4KKyAgICAgICAgKiBN
b2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6Ok1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlOjpjcmVhdGUpOgorICAgICAgICAo
V2ViQ29yZTo6TWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU6Ok1lZGlhU3RyZWFtQXVkaW9Tb3Vy
Y2VOb2RlKToKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3Vy
Y2VOb2RlLmg6IEFkZGVkCisgICAgICAgIE1lZGlhU3RyZWFtVHJhY2sgY2xhc3MgdmFyaWFibGUg
YW5kIGNoYW5nZSB0aGUgY29uc3RydWN0b3IgdG8gcmVjZWl2ZQorICAgICAgICBpdCBhcyBwYXJh
bWV0ZXIuCisKIDIwMTMtMTEtMjkgIFRhbWFzIEdlcmdlbHkgIDx0Z2VyZ2VseS51LXN6ZWdlZEBw
YXJ0bmVyLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFJlbW92ZSBTeW1iaWFuIHNwZWNpZmljIGNv
ZGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29u
dGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5j
cHAKaW5kZXggZThhY2Y2YjVmMGFlZDJhYzVmMGQxMDFlODY2NGRhMTg2OWM5MDdlMy4uMjA3M2Nk
N2NhNjcwNGY5OWRjNGU1YzcyOGM0YTgyZmJkZmY0Y2JhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJD
b3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcApAQCAtNDE3LDIwICs0MTcsMjEg
QEAgUGFzc1JlZlB0cjxNZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZT4gQXVkaW9Db250ZXh0Ojpj
cmVhdGVNZWRpYVN0cmVhbVNvdXJjZShNZWQKICAgICBBdWRpb1NvdXJjZVByb3ZpZGVyKiBwcm92
aWRlciA9IDA7CiAKICAgICBWZWN0b3I8UmVmUHRyPE1lZGlhU3RyZWFtVHJhY2s+PiBhdWRpb1Ry
YWNrcyA9IG1lZGlhU3RyZWFtLT5nZXRBdWRpb1RyYWNrcygpOworICAgIFJlZlB0cjxNZWRpYVN0
cmVhbVRyYWNrPiBhdWRpb1RyYWNrOworCiAgICAgLy8gRklYTUU6IGdldCBhIHByb3ZpZGVyIGZv
ciBub24tbG9jYWwgTWVkaWFTdHJlYW1zIChsaWtlIGZyb20gYSByZW1vdGUgcGVlcikuCiAgICAg
Zm9yIChzaXplX3QgaSA9IDA7IGkgPCBhdWRpb1RyYWNrcy5zaXplKCk7ICsraSkgewotICAgICAg
ICBSZWZQdHI8TWVkaWFTdHJlYW1UcmFjaz4gbG9jYWxBdWRpbyA9IGF1ZGlvVHJhY2tzW2ldOwot
ICAgICAgICBpZiAoIWxvY2FsQXVkaW8tPnNvdXJjZSgpLT5pc0F1ZGlvU3RyZWFtU291cmNlKCkp
Ci0gICAgICAgICAgICBjb250aW51ZTsKLQotICAgICAgICBNZWRpYVN0cmVhbUF1ZGlvU291cmNl
KiBzb3VyY2UgPSBzdGF0aWNfY2FzdDxNZWRpYVN0cmVhbUF1ZGlvU291cmNlKj4obG9jYWxBdWRp
by0+c291cmNlKCkpOwotICAgICAgICBBU1NFUlQoIXNvdXJjZS0+ZGV2aWNlSWQoKS5pc0VtcHR5
KCkpOwotICAgICAgICBkZXN0aW5hdGlvbigpLT5lbmFibGVJbnB1dChzb3VyY2UtPmRldmljZUlk
KCkpOwotICAgICAgICBwcm92aWRlciA9IGRlc3RpbmF0aW9uKCktPmxvY2FsQXVkaW9JbnB1dFBy
b3ZpZGVyKCk7Ci0gICAgICAgIGJyZWFrOworICAgICAgICBhdWRpb1RyYWNrID0gYXVkaW9UcmFj
a3NbaV07CisgICAgICAgIGlmIChhdWRpb1RyYWNrLT5zb3VyY2UoKS0+aXNBdWRpb1N0cmVhbVNv
dXJjZSgpKSB7CisgICAgICAgICAgICBhdXRvIHNvdXJjZSA9IHN0YXRpY19jYXN0PE1lZGlhU3Ry
ZWFtQXVkaW9Tb3VyY2UqPihhdWRpb1RyYWNrLT5zb3VyY2UoKSk7CisgICAgICAgICAgICBBU1NF
UlQoIXNvdXJjZS0+ZGV2aWNlSWQoKS5pc0VtcHR5KCkpOworICAgICAgICAgICAgZGVzdGluYXRp
b24oKS0+ZW5hYmxlSW5wdXQoc291cmNlLT5kZXZpY2VJZCgpKTsKKyAgICAgICAgICAgIHByb3Zp
ZGVyID0gZGVzdGluYXRpb24oKS0+bG9jYWxBdWRpb0lucHV0UHJvdmlkZXIoKTsKKyAgICAgICAg
ICAgIGJyZWFrOworICAgICAgICB9CiAgICAgfQogCi0gICAgUmVmUHRyPE1lZGlhU3RyZWFtQXVk
aW9Tb3VyY2VOb2RlPiBub2RlID0gTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU6OmNyZWF0ZSh0
aGlzLCBtZWRpYVN0cmVhbSwgcHJvdmlkZXIpOworICAgIFJlZlB0cjxNZWRpYVN0cmVhbUF1ZGlv
U291cmNlTm9kZT4gbm9kZSA9IE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlOjpjcmVhdGUodGhp
cywgbWVkaWFTdHJlYW0sIGF1ZGlvVHJhY2suZ2V0KCksIHByb3ZpZGVyKTsKIAogICAgIC8vIEZJ
WE1FOiBPbmx5IHN0ZXJlbyBzdHJlYW1zIGFyZSBzdXBwb3J0ZWQgcmlnaHQgbm93LiBXZSBzaG91
bGQgYmUgYWJsZSB0byBhY2NlcHQgbXVsdGktY2hhbm5lbCBzdHJlYW1zLgogICAgIG5vZGUtPnNl
dEZvcm1hdCgyLCBzYW1wbGVSYXRlKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k
dWxlcy93ZWJhdWRpby9NZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZS5jcHAgYi9Tb3VyY2UvV2Vi
Q29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmNwcAppbmRl
eCBhNjYwNTBhZjdmMTk0NWIwYWFmMjA1NjJmZDNkMjc3NGQwMmY0NjVlLi5hYTA0MTFiY2Q1NGY4
ZTEwY2Q4MGZjZGRkYmVhYTU5MTlhOTdkNzI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N
b2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmNwcAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmNw
cApAQCAtMzUsMTQgKzM1LDE1IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotUGFzc1JlZlB0
cjxNZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZT4gTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU6
OmNyZWF0ZShBdWRpb0NvbnRleHQqIGNvbnRleHQsIE1lZGlhU3RyZWFtKiBtZWRpYVN0cmVhbSwg
QXVkaW9Tb3VyY2VQcm92aWRlciogYXVkaW9Tb3VyY2VQcm92aWRlcikKK1Bhc3NSZWZQdHI8TWVk
aWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU+IE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlOjpjcmVh
dGUoQXVkaW9Db250ZXh0KiBjb250ZXh0LCBNZWRpYVN0cmVhbSogbWVkaWFTdHJlYW0sIE1lZGlh
U3RyZWFtVHJhY2sqIGF1ZGlvVHJhY2ssIEF1ZGlvU291cmNlUHJvdmlkZXIqIGF1ZGlvU291cmNl
UHJvdmlkZXIpCiB7Ci0gICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBNZWRpYVN0cmVhbUF1ZGlvU291
cmNlTm9kZShjb250ZXh0LCBtZWRpYVN0cmVhbSwgYXVkaW9Tb3VyY2VQcm92aWRlcikpOworICAg
IHJldHVybiBhZG9wdFJlZihuZXcgTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGUoY29udGV4dCwg
bWVkaWFTdHJlYW0sIGF1ZGlvVHJhY2ssIGF1ZGlvU291cmNlUHJvdmlkZXIpKTsKIH0KIAotTWVk
aWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU6Ok1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlKEF1ZGlv
Q29udGV4dCogY29udGV4dCwgTWVkaWFTdHJlYW0qIG1lZGlhU3RyZWFtLCBBdWRpb1NvdXJjZVBy
b3ZpZGVyKiBhdWRpb1NvdXJjZVByb3ZpZGVyKQorTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU6
Ok1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlKEF1ZGlvQ29udGV4dCogY29udGV4dCwgTWVkaWFT
dHJlYW0qIG1lZGlhU3RyZWFtLCBNZWRpYVN0cmVhbVRyYWNrKiBhdWRpb1RyYWNrLCBBdWRpb1Nv
dXJjZVByb3ZpZGVyKiBhdWRpb1NvdXJjZVByb3ZpZGVyKQogICAgIDogQXVkaW9Ob2RlKGNvbnRl
eHQsIGNvbnRleHQtPnNhbXBsZVJhdGUoKSkKICAgICAsIG1fbWVkaWFTdHJlYW0obWVkaWFTdHJl
YW0pCisgICAgLCBtX2F1ZGlvVHJhY2soYXVkaW9UcmFjaykKICAgICAsIG1fYXVkaW9Tb3VyY2VQ
cm92aWRlcihhdWRpb1NvdXJjZVByb3ZpZGVyKQogICAgICwgbV9zb3VyY2VOdW1iZXJPZkNoYW5u
ZWxzKDApCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01l
ZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1
ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmgKaW5kZXggNTYyNTZlOWRiYmU4YjdmMDA1
ZWE2NTY0Njk3YmQ0NzI0ODliN2I3Yy4uMWIyNGY2N2FmNDRmYTIxMTJhZGJmMjg3Zjg3ZDhkZTlm
M2EwNGMxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9NZWRp
YVN0cmVhbUF1ZGlvU291cmNlTm9kZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi
YXVkaW8vTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGUuaApAQCAtNDEsNyArNDEsNyBAQCBjbGFz
cyBBdWRpb0NvbnRleHQ7CiAKIGNsYXNzIE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlIDogcHVi
bGljIEF1ZGlvTm9kZSwgcHVibGljIEF1ZGlvU291cmNlUHJvdmlkZXJDbGllbnQgewogcHVibGlj
OgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlPiBjcmVh
dGUoQXVkaW9Db250ZXh0KiwgTWVkaWFTdHJlYW0qLCBBdWRpb1NvdXJjZVByb3ZpZGVyKik7Cisg
ICAgc3RhdGljIFBhc3NSZWZQdHI8TWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU+IGNyZWF0ZShB
dWRpb0NvbnRleHQqLCBNZWRpYVN0cmVhbSosIE1lZGlhU3RyZWFtVHJhY2sqLCBBdWRpb1NvdXJj
ZVByb3ZpZGVyKik7CiAKICAgICB2aXJ0dWFsIH5NZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZSgp
OwogCkBAIC01Nyw3ICs1Nyw3IEBAIHB1YmxpYzoKICAgICBBdWRpb1NvdXJjZVByb3ZpZGVyKiBh
dWRpb1NvdXJjZVByb3ZpZGVyKCkgY29uc3QgeyByZXR1cm4gbV9hdWRpb1NvdXJjZVByb3ZpZGVy
OyB9CiAKIHByaXZhdGU6Ci0gICAgTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGUoQXVkaW9Db250
ZXh0KiwgTWVkaWFTdHJlYW0qLCBBdWRpb1NvdXJjZVByb3ZpZGVyKik7CisgICAgTWVkaWFTdHJl
YW1BdWRpb1NvdXJjZU5vZGUoQXVkaW9Db250ZXh0KiwgTWVkaWFTdHJlYW0qLCBNZWRpYVN0cmVh
bVRyYWNrKiwgQXVkaW9Tb3VyY2VQcm92aWRlciopOwogCiAgICAgdmlydHVhbCBkb3VibGUgdGFp
bFRpbWUoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiAwOyB9CiAgICAgdmlydHVhbCBkb3VibGUg
bGF0ZW5jeVRpbWUoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiAwOyB9CkBAIC02Niw2ICs2Niw3
IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIHByb3BhZ2F0ZXNTaWxlbmNlKCkgY29uc3Qg
T1ZFUlJJREUgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIFJlZlB0cjxNZWRpYVN0cmVhbT4gbV9t
ZWRpYVN0cmVhbTsKKyAgICBSZWZQdHI8TWVkaWFTdHJlYW1UcmFjaz4gbV9hdWRpb1RyYWNrOwog
ICAgIEF1ZGlvU291cmNlUHJvdmlkZXIqIG1fYXVkaW9Tb3VyY2VQcm92aWRlcjsKIAogICAgIE11
dGV4IG1fcHJvY2Vzc0xvY2s7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>218160</attachid>
            <date>2013-12-02 03:59:01 -0800</date>
            <delta_ts>2013-12-02 05:55:57 -0800</delta_ts>
            <desc>Improved ChangeLog</desc>
            <filename>bug-124975-20131202081053.patch</filename>
            <type>text/plain</type>
            <size>6463</size>
            <attacher name="Nick Diego Yamane (diegoyam)">nick.diego</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWEwODhmMWUxNzUwZWQy
ODU4ODMxZDJlNGQ0ZWM2Zjg3MGQ1ZGMxMS4uNTI1OWU4MWYyMDU5M2UyZWRjNzAyM2NhZTg5OGM0
MDE4MWQ4OGJlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTEyLTAyICBOaWNr
IERpZWdvIFlhbWFuZSAgPG5pY2sueWFtYW5lQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgRml4
IGEgY3Jhc2ggaW4gdGhlIHdlYmF1ZGlvIHNvdXJjZSBwcm92aWRlciB3aGVuIHRoZSBhdWRpbyB0
cmFjayBpcyBnb2luZyBhd2F5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTI0OTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgTWVyZ2VkIGh0dHBzOi8vY2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9jaHJv
bWl1bS9ibGluay8rL2IyMTgzOGIzMmJmMTFiMWE5NzJkZmM0NDlkZGRlNzExMTU0OTBjMjMKKwor
ICAgICAgICBCZWZvcmUgdGhpcyBwYXRjaCwgaXQgd2FzIGhpdHRpbmcgYSB1c2UtYWZ0ZXItZnJl
ZSBjcmFzaCAgd2hlbiB0aGUgYXVkaW8KKyAgICAgICAgdHJhY2sgaW4gdGhlIG1lZGlhIHN0cmVh
bSBpcyBnb2luZyBhd2F5IGFuZCB0aGUgd2ViYXVkaW8gbWVkaWFzdHJlYW1zb3VyY2Vub2RlCisg
ICAgICAgIGlzIHN0aWxsIHJ1bm5pbmcuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0F1
ZGlvQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0NvbnRleHQ6OmNyZWF0ZU1l
ZGlhU3RyZWFtU291cmNlKTogUGFzc2luZyBhdWRpbyB0cmFjaworICAgICAgICBwb2ludGVyIHRv
IE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlIGNvbnN0cnVjdG9yLgorICAgICAgICAqIE1vZHVs
ZXMvd2ViYXVkaW8vTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGUuY3BwOgorICAgICAgICAoV2Vi
Q29yZTo6TWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU6OmNyZWF0ZSk6CisgICAgICAgIChXZWJD
b3JlOjpNZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZTo6TWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5v
ZGUpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5v
ZGUuaDogQWRkZWQKKyAgICAgICAgTWVkaWFTdHJlYW1UcmFjayBjbGFzcyB2YXJpYWJsZSBhbmQg
Y2hhbmdlIHRoZSBjb25zdHJ1Y3RvciB0byByZWNlaXZlCisgICAgICAgIGl0IGFzIHBhcmFtZXRl
ci4KKwogMjAxMy0xMi0wMiAgQW5kcnplaiBCYWRvd3NraSAgPGEuYmFkb3dza2lAc2Ftc3VuZy5j
b20+CiAKICAgICAgICAgW0FUS10gU3VwcG9ydCBhY3RpdmUgc3RhdGUgZm9yIGxpc3Rib3ggZWxl
bWVudHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlv
Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4
dC5jcHAKaW5kZXggZThhY2Y2YjVmMGFlZDJhYzVmMGQxMDFlODY2NGRhMTg2OWM5MDdlMy4uMjA3
M2NkN2NhNjcwNGY5OWRjNGU1YzcyOGM0YTgyZmJkZmY0Y2JhNSAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcApAQCAtNDE3LDIwICs0MTcs
MjEgQEAgUGFzc1JlZlB0cjxNZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZT4gQXVkaW9Db250ZXh0
OjpjcmVhdGVNZWRpYVN0cmVhbVNvdXJjZShNZWQKICAgICBBdWRpb1NvdXJjZVByb3ZpZGVyKiBw
cm92aWRlciA9IDA7CiAKICAgICBWZWN0b3I8UmVmUHRyPE1lZGlhU3RyZWFtVHJhY2s+PiBhdWRp
b1RyYWNrcyA9IG1lZGlhU3RyZWFtLT5nZXRBdWRpb1RyYWNrcygpOworICAgIFJlZlB0cjxNZWRp
YVN0cmVhbVRyYWNrPiBhdWRpb1RyYWNrOworCiAgICAgLy8gRklYTUU6IGdldCBhIHByb3ZpZGVy
IGZvciBub24tbG9jYWwgTWVkaWFTdHJlYW1zIChsaWtlIGZyb20gYSByZW1vdGUgcGVlcikuCiAg
ICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBhdWRpb1RyYWNrcy5zaXplKCk7ICsraSkgewotICAg
ICAgICBSZWZQdHI8TWVkaWFTdHJlYW1UcmFjaz4gbG9jYWxBdWRpbyA9IGF1ZGlvVHJhY2tzW2ld
OwotICAgICAgICBpZiAoIWxvY2FsQXVkaW8tPnNvdXJjZSgpLT5pc0F1ZGlvU3RyZWFtU291cmNl
KCkpCi0gICAgICAgICAgICBjb250aW51ZTsKLQotICAgICAgICBNZWRpYVN0cmVhbUF1ZGlvU291
cmNlKiBzb3VyY2UgPSBzdGF0aWNfY2FzdDxNZWRpYVN0cmVhbUF1ZGlvU291cmNlKj4obG9jYWxB
dWRpby0+c291cmNlKCkpOwotICAgICAgICBBU1NFUlQoIXNvdXJjZS0+ZGV2aWNlSWQoKS5pc0Vt
cHR5KCkpOwotICAgICAgICBkZXN0aW5hdGlvbigpLT5lbmFibGVJbnB1dChzb3VyY2UtPmRldmlj
ZUlkKCkpOwotICAgICAgICBwcm92aWRlciA9IGRlc3RpbmF0aW9uKCktPmxvY2FsQXVkaW9JbnB1
dFByb3ZpZGVyKCk7Ci0gICAgICAgIGJyZWFrOworICAgICAgICBhdWRpb1RyYWNrID0gYXVkaW9U
cmFja3NbaV07CisgICAgICAgIGlmIChhdWRpb1RyYWNrLT5zb3VyY2UoKS0+aXNBdWRpb1N0cmVh
bVNvdXJjZSgpKSB7CisgICAgICAgICAgICBhdXRvIHNvdXJjZSA9IHN0YXRpY19jYXN0PE1lZGlh
U3RyZWFtQXVkaW9Tb3VyY2UqPihhdWRpb1RyYWNrLT5zb3VyY2UoKSk7CisgICAgICAgICAgICBB
U1NFUlQoIXNvdXJjZS0+ZGV2aWNlSWQoKS5pc0VtcHR5KCkpOworICAgICAgICAgICAgZGVzdGlu
YXRpb24oKS0+ZW5hYmxlSW5wdXQoc291cmNlLT5kZXZpY2VJZCgpKTsKKyAgICAgICAgICAgIHBy
b3ZpZGVyID0gZGVzdGluYXRpb24oKS0+bG9jYWxBdWRpb0lucHV0UHJvdmlkZXIoKTsKKyAgICAg
ICAgICAgIGJyZWFrOworICAgICAgICB9CiAgICAgfQogCi0gICAgUmVmUHRyPE1lZGlhU3RyZWFt
QXVkaW9Tb3VyY2VOb2RlPiBub2RlID0gTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU6OmNyZWF0
ZSh0aGlzLCBtZWRpYVN0cmVhbSwgcHJvdmlkZXIpOworICAgIFJlZlB0cjxNZWRpYVN0cmVhbUF1
ZGlvU291cmNlTm9kZT4gbm9kZSA9IE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlOjpjcmVhdGUo
dGhpcywgbWVkaWFTdHJlYW0sIGF1ZGlvVHJhY2suZ2V0KCksIHByb3ZpZGVyKTsKIAogICAgIC8v
IEZJWE1FOiBPbmx5IHN0ZXJlbyBzdHJlYW1zIGFyZSBzdXBwb3J0ZWQgcmlnaHQgbm93LiBXZSBz
aG91bGQgYmUgYWJsZSB0byBhY2NlcHQgbXVsdGktY2hhbm5lbCBzdHJlYW1zLgogICAgIG5vZGUt
PnNldEZvcm1hdCgyLCBzYW1wbGVSYXRlKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv
TW9kdWxlcy93ZWJhdWRpby9NZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZS5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmNwcApp
bmRleCBhNjYwNTBhZjdmMTk0NWIwYWFmMjA1NjJmZDNkMjc3NGQwMmY0NjVlLi5hYTA0MTFiY2Q1
NGY4ZTEwY2Q4MGZjZGRkYmVhYTU5MTlhOTdkNzI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmNwcAorKysgYi9T
b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2Rl
LmNwcApAQCAtMzUsMTQgKzM1LDE1IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotUGFzc1Jl
ZlB0cjxNZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZT4gTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5v
ZGU6OmNyZWF0ZShBdWRpb0NvbnRleHQqIGNvbnRleHQsIE1lZGlhU3RyZWFtKiBtZWRpYVN0cmVh
bSwgQXVkaW9Tb3VyY2VQcm92aWRlciogYXVkaW9Tb3VyY2VQcm92aWRlcikKK1Bhc3NSZWZQdHI8
TWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU+IE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlOjpj
cmVhdGUoQXVkaW9Db250ZXh0KiBjb250ZXh0LCBNZWRpYVN0cmVhbSogbWVkaWFTdHJlYW0sIE1l
ZGlhU3RyZWFtVHJhY2sqIGF1ZGlvVHJhY2ssIEF1ZGlvU291cmNlUHJvdmlkZXIqIGF1ZGlvU291
cmNlUHJvdmlkZXIpCiB7Ci0gICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBNZWRpYVN0cmVhbUF1ZGlv
U291cmNlTm9kZShjb250ZXh0LCBtZWRpYVN0cmVhbSwgYXVkaW9Tb3VyY2VQcm92aWRlcikpOwor
ICAgIHJldHVybiBhZG9wdFJlZihuZXcgTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGUoY29udGV4
dCwgbWVkaWFTdHJlYW0sIGF1ZGlvVHJhY2ssIGF1ZGlvU291cmNlUHJvdmlkZXIpKTsKIH0KIAot
TWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU6Ok1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlKEF1
ZGlvQ29udGV4dCogY29udGV4dCwgTWVkaWFTdHJlYW0qIG1lZGlhU3RyZWFtLCBBdWRpb1NvdXJj
ZVByb3ZpZGVyKiBhdWRpb1NvdXJjZVByb3ZpZGVyKQorTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5v
ZGU6Ok1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlKEF1ZGlvQ29udGV4dCogY29udGV4dCwgTWVk
aWFTdHJlYW0qIG1lZGlhU3RyZWFtLCBNZWRpYVN0cmVhbVRyYWNrKiBhdWRpb1RyYWNrLCBBdWRp
b1NvdXJjZVByb3ZpZGVyKiBhdWRpb1NvdXJjZVByb3ZpZGVyKQogICAgIDogQXVkaW9Ob2RlKGNv
bnRleHQsIGNvbnRleHQtPnNhbXBsZVJhdGUoKSkKICAgICAsIG1fbWVkaWFTdHJlYW0obWVkaWFT
dHJlYW0pCisgICAgLCBtX2F1ZGlvVHJhY2soYXVkaW9UcmFjaykKICAgICAsIG1fYXVkaW9Tb3Vy
Y2VQcm92aWRlcihhdWRpb1NvdXJjZVByb3ZpZGVyKQogICAgICwgbV9zb3VyY2VOdW1iZXJPZkNo
YW5uZWxzKDApCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv
L01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl
YmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmgKaW5kZXggNTYyNTZlOWRiYmU4Yjdm
MDA1ZWE2NTY0Njk3YmQ0NzI0ODliN2I3Yy4uMWIyNGY2N2FmNDRmYTIxMTJhZGJmMjg3Zjg3ZDhk
ZTlmM2EwNGMxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9N
ZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv
d2ViYXVkaW8vTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGUuaApAQCAtNDEsNyArNDEsNyBAQCBj
bGFzcyBBdWRpb0NvbnRleHQ7CiAKIGNsYXNzIE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlIDog
cHVibGljIEF1ZGlvTm9kZSwgcHVibGljIEF1ZGlvU291cmNlUHJvdmlkZXJDbGllbnQgewogcHVi
bGljOgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlPiBj
cmVhdGUoQXVkaW9Db250ZXh0KiwgTWVkaWFTdHJlYW0qLCBBdWRpb1NvdXJjZVByb3ZpZGVyKik7
CisgICAgc3RhdGljIFBhc3NSZWZQdHI8TWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU+IGNyZWF0
ZShBdWRpb0NvbnRleHQqLCBNZWRpYVN0cmVhbSosIE1lZGlhU3RyZWFtVHJhY2sqLCBBdWRpb1Nv
dXJjZVByb3ZpZGVyKik7CiAKICAgICB2aXJ0dWFsIH5NZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9k
ZSgpOwogCkBAIC01Nyw3ICs1Nyw3IEBAIHB1YmxpYzoKICAgICBBdWRpb1NvdXJjZVByb3ZpZGVy
KiBhdWRpb1NvdXJjZVByb3ZpZGVyKCkgY29uc3QgeyByZXR1cm4gbV9hdWRpb1NvdXJjZVByb3Zp
ZGVyOyB9CiAKIHByaXZhdGU6Ci0gICAgTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGUoQXVkaW9D
b250ZXh0KiwgTWVkaWFTdHJlYW0qLCBBdWRpb1NvdXJjZVByb3ZpZGVyKik7CisgICAgTWVkaWFT
dHJlYW1BdWRpb1NvdXJjZU5vZGUoQXVkaW9Db250ZXh0KiwgTWVkaWFTdHJlYW0qLCBNZWRpYVN0
cmVhbVRyYWNrKiwgQXVkaW9Tb3VyY2VQcm92aWRlciopOwogCiAgICAgdmlydHVhbCBkb3VibGUg
dGFpbFRpbWUoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiAwOyB9CiAgICAgdmlydHVhbCBkb3Vi
bGUgbGF0ZW5jeVRpbWUoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiAwOyB9CkBAIC02Niw2ICs2
Niw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIHByb3BhZ2F0ZXNTaWxlbmNlKCkgY29u
c3QgT1ZFUlJJREUgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIFJlZlB0cjxNZWRpYVN0cmVhbT4g
bV9tZWRpYVN0cmVhbTsKKyAgICBSZWZQdHI8TWVkaWFTdHJlYW1UcmFjaz4gbV9hdWRpb1RyYWNr
OwogICAgIEF1ZGlvU291cmNlUHJvdmlkZXIqIG1fYXVkaW9Tb3VyY2VQcm92aWRlcjsKIAogICAg
IE11dGV4IG1fcHJvY2Vzc0xvY2s7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>