124965 2013-11-28 04:33:28 -0800 [EFL] viewport must be same with the size of webview 2017-03-11 10:52:40 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED WONTFIX P2 Normal --- 125007 125037 1 hs85.jeong webkit-unassigned cdumez commit-queue gyuyoung.kim gyuyoung.kim hw1008.kim lucas.de.marchi mcatanzaro rakuco oldest_to_newest 954690 0 hs85.jeong 2013-11-28 04:33:28 -0800 The Size of the glViewport is set up than the viewSize. 954692 1 217988 hs85.jeong 2013-11-28 04:39:09 -0800 Created attachment 217988 Patch 954840 2 217988 gyuyoung.kim 2013-11-28 15:36:28 -0800 Comment on attachment 217988 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217988&action=review > Source/WebKit2/ChangeLog:3 > + Fix the size of the glViewport() to draw the correct size. Different title from this bug. > Source/WebKit2/ChangeLog:8 > + The size of the glViewport() is set up than viewSize. I don't understand what do you want to say in this description. Please re-write description more clear. > Source/WebKit2/ChangeLog:9 > + Nevertheless, because the viewport is translated, it looks correctly. correctly -> correct ? 954852 3 218028 hs85.jeong 2013-11-28 17:15:21 -0800 Created attachment 218028 Patch 954866 4 218028 gyuyoung.kim 2013-11-28 19:55:46 -0800 Comment on attachment 218028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218028&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] glViewport() is set up than the viewSize. I really don't understand what does this title means now. Do you mean that glViewport size is bigger than viewSize ? Anyway, it seems to me that you want to change glViewport size with viewSize, right ? > Source/WebKit2/ChangeLog:9 > + Nevertheless, the viewport is translated when being painted, it looks correct. AFAIK, we should fix something when it is *correct*, not *looks correct*. 954872 5 hs85.jeong 2013-11-28 21:33:53 -0800 (In reply to comment #4) > (From update of attachment 218028 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218028&action=review > > > Source/WebKit2/ChangeLog:3 > > + [EFL] glViewport() is set up than the viewSize. > > I really don't understand what does this title means now. Do you mean that glViewport size is bigger than viewSize ? Anyway, it seems to me that you want to change glViewport size with viewSize, right ? > Yes, right. I mean that the glViewport size is bigger than viewSize. > > Source/WebKit2/ChangeLog:9 > > + Nevertheless, the viewport is translated when being painted, it looks correct. > > AFAIK, we should fix something when it is *correct*, not *looks correct*. Because the glViewport size bigger than viewSize, unnecessary work was occured. 954876 6 hs85.jeong 2013-11-28 22:31:29 -0800 I report the new one, changed the title name. 954877 7 gyuyoung.kim 2013-11-28 22:34:26 -0800 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 218028 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=218028&action=review > > > > > Source/WebKit2/ChangeLog:3 > > > + [EFL] glViewport() is set up than the viewSize. > > > > I really don't understand what does this title means now. Do you mean that glViewport size is bigger than viewSize ? Anyway, it seems to me that you want to change glViewport size with viewSize, right ? > > > Yes, right. I mean that the glViewport size is bigger than viewSize. > > > Source/WebKit2/ChangeLog:9 > > > + Nevertheless, the viewport is translated when being painted, it looks correct. > > > > AFAIK, we should fix something when it is *correct*, not *looks correct*. > Because the glViewport size bigger than viewSize, unnecessary work was occured. When we upload a patch, you should mention *why* this patch should be landed or why we need to land this patch. However, your patch description isn't clear for me. Please fix your changelog more clear. It would be good if you get a review from your co-worker before uploading new patch. FYI, "unnecessary work was occured." => "unnecessary work occurred" is correct, AFAIK. 954878 8 hs85.jeong 2013-11-28 22:44:11 -0800 Changed the title name Reopened, I don't know how to change the title name. Sorry. 954880 9 hs85.jeong 2013-11-28 22:46:13 -0800 *** Bug 124998 has been marked as a duplicate of this bug. *** 954881 10 218035 hs85.jeong 2013-11-28 22:59:59 -0800 Created attachment 218035 Patch 954883 11 hs85.jeong 2013-11-28 23:09:48 -0800 (In reply to comment #7) > (In reply to comment #5) > > (In reply to comment #4) > > > (From update of attachment 218028 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=218028&action=review > > > > > > > Source/WebKit2/ChangeLog:3 > > > > + [EFL] glViewport() is set up than the viewSize. > > > > > > I really don't understand what does this title means now. Do you mean that glViewport size is bigger than viewSize ? Anyway, it seems to me that you want to change glViewport size with viewSize, right ? > > > > > Yes, right. I mean that the glViewport size is bigger than viewSize. > > > > Source/WebKit2/ChangeLog:9 > > > > + Nevertheless, the viewport is translated when being painted, it looks correct. > > > > > > AFAIK, we should fix something when it is *correct*, not *looks correct*. > > Because the glViewport size bigger than viewSize, unnecessary work was occured. > > When we upload a patch, you should mention *why* this patch should be landed or why we need to land this patch. However, your patch description isn't clear for me. Please fix your changelog more clear. It would be good if you get a review from your co-worker before uploading new patch. > > FYI, "unnecessary work was occured." => "unnecessary work occurred" is correct, AFAIK. Sorry, Gyuyoung Kim. It is my first patch, Because I don't know how to upload patch and write description. I will reviewed by other co-worker when I reported next patch. 954885 12 218035 gyuyoung.kim 2013-11-28 23:13:57 -0800 Comment on attachment 218035 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218035&action=review Looks more reasonable than before. However, it looks there are unnecessary *the* in changelog. :( > Source/WebKit2/ChangeLog:8 > + Currently, the size of the viewport is set bigger than the size of the webview. How about using below ? "Currently, size of viewport is larger than size of webview. Changed the size of viewport with the size of webview because viewport is translated by wrong calculation," 954889 13 hs85.jeong 2013-11-28 23:24:24 -0800 (In reply to comment #12) > (From update of attachment 218035 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218035&action=review > > Looks more reasonable than before. However, it looks there are unnecessary *the* in changelog. :( > > > Source/WebKit2/ChangeLog:8 > > + Currently, the size of the viewport is set bigger than the size of the webview. > > How about using below ? > > "Currently, size of viewport is larger than size of webview. Changed the size of viewport with the size of webview because viewport is translated by wrong calculation," Thanks Gyuyoung Kim. I will change the changelog, and then upload the patch. 954890 14 218036 hs85.jeong 2013-11-28 23:26:00 -0800 Created attachment 218036 Patch 954895 15 218036 gyuyoung.kim 2013-11-28 23:52:33 -0800 Comment on attachment 218036 Patch It would be nicer if Ryuan or Hyowon take a final look before landing. 954898 16 218036 commit-queue 2013-11-29 00:34:50 -0800 Comment on attachment 218036 Patch Clearing flags on attachment: 218036 Committed r159865: <http://trac.webkit.org/changeset/159865> 954899 17 commit-queue 2013-11-29 00:34:53 -0800 All reviewed patches have been landed. Closing bug. 955103 18 commit-queue 2013-11-30 19:45:12 -0800 Re-opened since this is blocked by bug 125037 1286794 19 mcatanzaro 2017-03-11 10:52:40 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 217988 2013-11-28 04:39:09 -0800 2013-11-28 17:15:13 -0800 Patch bug-124965-20131128213907.patch text/plain 3081 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzQyYTJhYWFmY2NlOGFl YzRjMGI3N2NmODlmZDI0NDYwNmZiNGZiOS4uYTEyMWFjZGE2MGJiMzA1OTAzOTk0ZDMwOTlmNjlh NWNhOTI5NWNjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTExLTI4ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggdGhlIHNp emUgb2YgdGhlIGdsVmlld3BvcnQoKSB0byBkcmF3IHRoZSBjb3JyZWN0IHNpemUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ5NjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc2l6ZSBvZiB0aGUg Z2xWaWV3cG9ydCgpIGlzIHNldCB1cCB0aGFuIHZpZXdTaXplLgorICAgICAgICBOZXZlcnRoZWxl c3MsIGJlY2F1c2UgdGhlIHZpZXdwb3J0IGlzIHRyYW5zbGF0ZWQsIGl0IGxvb2tzIGNvcnJlY3Rs eS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwOgorICAgICAgICAo RXdrVmlldzo6ZGlzcGxheVRpbWVyRmlyZWQpOiBDaGFuZ2VkIHRvIHVzZSB0aGUgKDAsMCkuIAor ICAgICAgICAoRXdrVmlldzo6Y3JlYXRlR0xTdXJmYWNlKTogTW9kaWZpZWQgdG8gdXNlIHRoZSB2 aWV3U2l6ZSBpbnN0ZWFkIG9mIHRoZSBib3VuZHNFbmQuCisgICAgICAgIChFd2tWaWV3OjpoYW5k bGVFdmFzT2JqZWN0Q2FsY3VsYXRlKTogUmVtb3ZlIHRoZSBXS1ZpZXdTZXRVc2VyVmlld3BvcnRU cmFuc2xhdGlvbi4KKwogMjAxMy0xMS0yNyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgog CiAgICAgICAgIEdpdmUgdGhlIFBhZ2VDbGllbnQgYSBjaGFuY2UgdG8gaGFuZGxlIGdlb2xvY2F0 aW9uIHBlcm1pc3Npb24gcmVxdWVzdHMgaWYgdGhlIFVJQ2xpZW50IGRvZXNuJ3QgaGFuZGxlIGl0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNw cCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCmluZGV4IDYw Y2Y5MDRjMTZmYWQwNmM5NjIzNTliNGVhZjdhN2YxMmJiOWU0YTcuLjE3YzIyMTliMDIzNDdmY2I1 YjU5ZmI5MmZhZmZkYzUwZjUxMmEzMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL0V3a1ZpZXcuY3BwCkBAIC01ODAsNyArNTgwLDcgQEAgdm9pZCBFd2tWaWV3OjpkaXNw bGF5VGltZXJGaXJlZChUaW1lcjxFd2tWaWV3PiopCiAgICAgV0tWaWV3UGFpbnRUb0N1cnJlbnRH TENvbnRleHQod2tWaWV3KCkpOwogI2VuZGlmCiAgICAgLy8gc2QtPmltYWdlIGlzIHRpZWQgdG8g YSBuYXRpdmUgc3VyZmFjZSwgd2hpY2ggaXMgaW4gdGhlIHBhcmVudCdzIGNvb3JkaW5hdGVzLgot ICAgIGV2YXNfb2JqZWN0X2ltYWdlX2RhdGFfdXBkYXRlX2FkZChzZC0+aW1hZ2UsIHNkLT52aWV3 LngsIHNkLT52aWV3LnksIHNkLT52aWV3LncsIHNkLT52aWV3LmgpOworICAgIGV2YXNfb2JqZWN0 X2ltYWdlX2RhdGFfdXBkYXRlX2FkZChzZC0+aW1hZ2UsIDAsIDAsIHNkLT52aWV3LncsIHNkLT52 aWV3LmgpOwogfQogCiB2b2lkIEV3a1ZpZXc6OnNjaGVkdWxlVXBkYXRlRGlzcGxheSgpCkBAIC04 MjAsOCArODIwLDExIEBAIGJvb2wgRXdrVmlldzo6Y3JlYXRlR0xTdXJmYWNlKCkKICAgICAgICAg RVZBU19HTF9NVUxUSVNBTVBMRV9OT05FCiAgICAgfTsKIAorICAgIEV3a19WaWV3X1NtYXJ0X0Rh dGEqIHNkID0gc21hcnREYXRhKCk7CisgICAgSW50U2l6ZSB2aWV3U2l6ZShzZC0+dmlldy53LCBz ZC0+dmlldy5oKTsKKwogICAgIC8vIFJlY3JlYXRlIHRvIGN1cnJlbnQgc2l6ZTogUmVwbGFjZXMg aWYgbm9uLW51bGwsIGFuZCBmcmVlcyBleGlzdGluZyBzdXJmYWNlIGFmdGVyIChPd25QdHIpLgot ICAgIG1fZXZhc0dMU3VyZmFjZSA9IEV2YXNHTFN1cmZhY2U6OmNyZWF0ZShtX2V2YXNHTC5nZXQo KSwgJmV2YXNHTENvbmZpZywgZGV2aWNlU2l6ZSgpKTsKKyAgICBtX2V2YXNHTFN1cmZhY2UgPSBF dmFzR0xTdXJmYWNlOjpjcmVhdGUobV9ldmFzR0wuZ2V0KCksICZldmFzR0xDb25maWcsIHZpZXdT aXplKTsKICAgICBpZiAoIW1fZXZhc0dMU3VyZmFjZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CkBAIC04MzMsOCArODM2LDcgQEAgYm9vbCBFd2tWaWV3OjpjcmVhdGVHTFN1cmZhY2UoKQogCiAg ICAgRXZhc19HTF9BUEkqIGdsID0gZXZhc19nbF9hcGlfZ2V0KG1fZXZhc0dMLmdldCgpKTsKIAot ICAgIFdLUG9pbnQgYm91bmRzRW5kID0gV0tWaWV3VXNlclZpZXdwb3J0VG9TY2VuZSh3a1ZpZXco KSwgV0tQb2ludE1ha2UoZGV2aWNlU2l6ZSgpLndpZHRoKCksIGRldmljZVNpemUoKS5oZWlnaHQo KSkpOwotICAgIGdsLT5nbFZpZXdwb3J0KDAsIDAsIGJvdW5kc0VuZC54LCBib3VuZHNFbmQueSk7 CisgICAgZ2wtPmdsVmlld3BvcnQoMCwgMCwgdmlld1NpemUud2lkdGgoKSwgdmlld1NpemUuaGVp Z2h0KCkpOwogICAgIGdsLT5nbENsZWFyQ29sb3IoMS4wLCAxLjAsIDEuMCwgMCk7CiAgICAgZ2wt PmdsQ2xlYXIoR0xfQ09MT1JfQlVGRkVSX0JJVCk7CiAKQEAgLTExOTYsNyArMTE5OCw2IEBAIHZv aWQgRXdrVmlldzo6aGFuZGxlRXZhc09iamVjdENhbGN1bGF0ZShFdmFzX09iamVjdCogZXZhc09i amVjdCkKICAgICAgICAgc21hcnREYXRhLT52aWV3LnggPSB4OwogICAgICAgICBzbWFydERhdGEt PnZpZXcueSA9IHk7CiAgICAgICAgIGV2YXNfb2JqZWN0X21vdmUoc21hcnREYXRhLT5pbWFnZSwg eCwgeSk7Ci0gICAgICAgIFdLVmlld1NldFVzZXJWaWV3cG9ydFRyYW5zbGF0aW9uKHNlbGYtPndr VmlldygpLCB4LCB5KTsKICAgICB9CiAKICAgICBpZiAoc21hcnREYXRhLT5jaGFuZ2VkLnNpemUp IHsK 218028 2013-11-28 17:15:21 -0800 2013-11-28 22:59:50 -0800 Patch bug-124965-20131129101520.patch text/plain 3109 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzQyYTJhYWFmY2NlOGFl YzRjMGI3N2NmODlmZDI0NDYwNmZiNGZiOS4uNjkwM2Y0NTgxMTI2N2QyNDc1Mjc3YzYzNWY0ZTZj YWVlZjZiNjhhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTExLTI4ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBnbFZp ZXdwb3J0KCkgaXMgc2V0IHVwIHRoYW4gdGhlIHZpZXdTaXplLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0OTY1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgCisgICAgICAgIEJlY2F1c2UgdGhlIHVzZXJWaWV3 cG9ydCBpcyB0cmFuc2xhdGVkLCB0aGUgZ2xWaWV3cG9ydCBzZXR1cCBpcyBnb2luZyB3cm9uZy4K KyAgICAgICAgTmV2ZXJ0aGVsZXNzLCB0aGUgdmlld3BvcnQgaXMgdHJhbnNsYXRlZCB3aGVuIGJl aW5nIHBhaW50ZWQsIGl0IGxvb2tzIGNvcnJlY3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2VmbC9Fd2tWaWV3LmNwcDoKKyAgICAgICAgKEV3a1ZpZXc6OmRpc3BsYXlUaW1lckZpcmVkKTog Q2hhbmdlZCB0byB1c2UgdGhlICgwLDApLiAKKyAgICAgICAgKEV3a1ZpZXc6OmNyZWF0ZUdMU3Vy ZmFjZSk6IE1vZGlmaWVkIHRvIHVzZSB0aGUgdmlld1NpemUgaW5zdGVhZCBvZiB0aGUgYm91bmRz RW5kLgorICAgICAgICAoRXdrVmlldzo6aGFuZGxlRXZhc09iamVjdENhbGN1bGF0ZSk6IFJlbW92 ZSB0aGUgV0tWaWV3U2V0VXNlclZpZXdwb3J0VHJhbnNsYXRpb24uCisKIDIwMTMtMTEtMjcgIFNh bSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBHaXZlIHRoZSBQYWdlQ2xpZW50 IGEgY2hhbmNlIHRvIGhhbmRsZSBnZW9sb2NhdGlvbiBwZXJtaXNzaW9uIHJlcXVlc3RzIGlmIHRo ZSBVSUNsaWVudCBkb2Vzbid0IGhhbmRsZSBpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9Fd2tWaWV3LmNwcAppbmRleCA2MGNmOTA0YzE2ZmFkMDZjOTYyMzU5YjRlYWY3YTdm MTJiYjllNGE3Li4xN2MyMjE5YjAyMzQ3ZmNiNWI1OWZiOTJmYWZmZGM1MGY1MTJhMzIwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcApAQCAtNTgwLDcg KzU4MCw3IEBAIHZvaWQgRXdrVmlldzo6ZGlzcGxheVRpbWVyRmlyZWQoVGltZXI8RXdrVmlldz4q KQogICAgIFdLVmlld1BhaW50VG9DdXJyZW50R0xDb250ZXh0KHdrVmlldygpKTsKICNlbmRpZgog ICAgIC8vIHNkLT5pbWFnZSBpcyB0aWVkIHRvIGEgbmF0aXZlIHN1cmZhY2UsIHdoaWNoIGlzIGlu IHRoZSBwYXJlbnQncyBjb29yZGluYXRlcy4KLSAgICBldmFzX29iamVjdF9pbWFnZV9kYXRhX3Vw ZGF0ZV9hZGQoc2QtPmltYWdlLCBzZC0+dmlldy54LCBzZC0+dmlldy55LCBzZC0+dmlldy53LCBz ZC0+dmlldy5oKTsKKyAgICBldmFzX29iamVjdF9pbWFnZV9kYXRhX3VwZGF0ZV9hZGQoc2QtPmlt YWdlLCAwLCAwLCBzZC0+dmlldy53LCBzZC0+dmlldy5oKTsKIH0KIAogdm9pZCBFd2tWaWV3Ojpz Y2hlZHVsZVVwZGF0ZURpc3BsYXkoKQpAQCAtODIwLDggKzgyMCwxMSBAQCBib29sIEV3a1ZpZXc6 OmNyZWF0ZUdMU3VyZmFjZSgpCiAgICAgICAgIEVWQVNfR0xfTVVMVElTQU1QTEVfTk9ORQogICAg IH07CiAKKyAgICBFd2tfVmlld19TbWFydF9EYXRhKiBzZCA9IHNtYXJ0RGF0YSgpOworICAgIElu dFNpemUgdmlld1NpemUoc2QtPnZpZXcudywgc2QtPnZpZXcuaCk7CisKICAgICAvLyBSZWNyZWF0 ZSB0byBjdXJyZW50IHNpemU6IFJlcGxhY2VzIGlmIG5vbi1udWxsLCBhbmQgZnJlZXMgZXhpc3Rp bmcgc3VyZmFjZSBhZnRlciAoT3duUHRyKS4KLSAgICBtX2V2YXNHTFN1cmZhY2UgPSBFdmFzR0xT dXJmYWNlOjpjcmVhdGUobV9ldmFzR0wuZ2V0KCksICZldmFzR0xDb25maWcsIGRldmljZVNpemUo KSk7CisgICAgbV9ldmFzR0xTdXJmYWNlID0gRXZhc0dMU3VyZmFjZTo6Y3JlYXRlKG1fZXZhc0dM LmdldCgpLCAmZXZhc0dMQ29uZmlnLCB2aWV3U2l6ZSk7CiAgICAgaWYgKCFtX2V2YXNHTFN1cmZh Y2UpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIApAQCAtODMzLDggKzgzNiw3IEBAIGJvb2wgRXdr Vmlldzo6Y3JlYXRlR0xTdXJmYWNlKCkKIAogICAgIEV2YXNfR0xfQVBJKiBnbCA9IGV2YXNfZ2xf YXBpX2dldChtX2V2YXNHTC5nZXQoKSk7CiAKLSAgICBXS1BvaW50IGJvdW5kc0VuZCA9IFdLVmll d1VzZXJWaWV3cG9ydFRvU2NlbmUod2tWaWV3KCksIFdLUG9pbnRNYWtlKGRldmljZVNpemUoKS53 aWR0aCgpLCBkZXZpY2VTaXplKCkuaGVpZ2h0KCkpKTsKLSAgICBnbC0+Z2xWaWV3cG9ydCgwLCAw LCBib3VuZHNFbmQueCwgYm91bmRzRW5kLnkpOworICAgIGdsLT5nbFZpZXdwb3J0KDAsIDAsIHZp ZXdTaXplLndpZHRoKCksIHZpZXdTaXplLmhlaWdodCgpKTsKICAgICBnbC0+Z2xDbGVhckNvbG9y KDEuMCwgMS4wLCAxLjAsIDApOwogICAgIGdsLT5nbENsZWFyKEdMX0NPTE9SX0JVRkZFUl9CSVQp OwogCkBAIC0xMTk2LDcgKzExOTgsNiBAQCB2b2lkIEV3a1ZpZXc6OmhhbmRsZUV2YXNPYmplY3RD YWxjdWxhdGUoRXZhc19PYmplY3QqIGV2YXNPYmplY3QpCiAgICAgICAgIHNtYXJ0RGF0YS0+dmll dy54ID0geDsKICAgICAgICAgc21hcnREYXRhLT52aWV3LnkgPSB5OwogICAgICAgICBldmFzX29i amVjdF9tb3ZlKHNtYXJ0RGF0YS0+aW1hZ2UsIHgsIHkpOwotICAgICAgICBXS1ZpZXdTZXRVc2Vy Vmlld3BvcnRUcmFuc2xhdGlvbihzZWxmLT53a1ZpZXcoKSwgeCwgeSk7CiAgICAgfQogCiAgICAg aWYgKHNtYXJ0RGF0YS0+Y2hhbmdlZC5zaXplKSB7Cg== 218035 2013-11-28 22:59:59 -0800 2013-11-28 23:25:51 -0800 Patch bug-124965-20131129155958.patch text/plain 3153 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzQyYTJhYWFmY2NlOGFl YzRjMGI3N2NmODlmZDI0NDYwNmZiNGZiOS4uZDVlOGRmYjUwMTJkMDZkMjJiMTQ4NjVkOGY4NDUz Njk3NDM0NmZiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTExLTI4ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSB2aWV3 cG9ydCBtdXN0IGJlIHNhbWUgd2l0aCB0aGUgc2l6ZSBvZiB3ZWJ2aWV3CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ5NjUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHksIHRoZSBzaXplIG9m IHRoZSB2aWV3cG9ydCBpcyBzZXQgYmlnZ2VyIHRoYW4gdGhlIHNpemUgb2YgdGhlIHdlYnZpZXcu CisgICAgICAgIEJlY2F1c2Ugdmlld3BvcnQgaXMgdHJhbnNsYXRlZCBieSB3cm9uZyBjYWxjdWxh dGlvbiwgY2hhbmdlZCB0aGUgdGhlIHNpemUgb2YgdGhlIHZpZXdwb3J0IHdpdGggdGhlIHNpemUg b2YgdGhlIHdlYnZpZXcuIAorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5j cHA6CisgICAgICAgIChFd2tWaWV3OjpkaXNwbGF5VGltZXJGaXJlZCk6IENoYW5nZWQgdG8gdXNl IHRoZSAoMCwwKS4gCisgICAgICAgIChFd2tWaWV3OjpjcmVhdGVHTFN1cmZhY2UpOiBNb2RpZmll ZCB0byB1c2UgdGhlIHZpZXdTaXplIGluc3RlYWQgb2YgdGhlIGJvdW5kc0VuZC4KKyAgICAgICAg KEV3a1ZpZXc6OmhhbmRsZUV2YXNPYmplY3RDYWxjdWxhdGUpOiBSZW1vdmVkIHRoZSBXS1ZpZXdT ZXRVc2VyVmlld3BvcnRUcmFuc2xhdGlvbi4KKwogMjAxMy0xMS0yNyAgU2FtIFdlaW5pZyAgPHNh bUB3ZWJraXQub3JnPgogCiAgICAgICAgIEdpdmUgdGhlIFBhZ2VDbGllbnQgYSBjaGFuY2UgdG8g aGFuZGxlIGdlb2xvY2F0aW9uIHBlcm1pc3Npb24gcmVxdWVzdHMgaWYgdGhlIFVJQ2xpZW50IGRv ZXNuJ3QgaGFuZGxlIGl0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9Fd2tWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1Zp ZXcuY3BwCmluZGV4IDYwY2Y5MDRjMTZmYWQwNmM5NjIzNTliNGVhZjdhN2YxMmJiOWU0YTcuLjE3 YzIyMTliMDIzNDdmY2I1YjU5ZmI5MmZhZmZkYzUwZjUxMmEzMjAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCkBAIC01ODAsNyArNTgwLDcgQEAgdm9p ZCBFd2tWaWV3OjpkaXNwbGF5VGltZXJGaXJlZChUaW1lcjxFd2tWaWV3PiopCiAgICAgV0tWaWV3 UGFpbnRUb0N1cnJlbnRHTENvbnRleHQod2tWaWV3KCkpOwogI2VuZGlmCiAgICAgLy8gc2QtPmlt YWdlIGlzIHRpZWQgdG8gYSBuYXRpdmUgc3VyZmFjZSwgd2hpY2ggaXMgaW4gdGhlIHBhcmVudCdz IGNvb3JkaW5hdGVzLgotICAgIGV2YXNfb2JqZWN0X2ltYWdlX2RhdGFfdXBkYXRlX2FkZChzZC0+ aW1hZ2UsIHNkLT52aWV3LngsIHNkLT52aWV3LnksIHNkLT52aWV3LncsIHNkLT52aWV3LmgpOwor ICAgIGV2YXNfb2JqZWN0X2ltYWdlX2RhdGFfdXBkYXRlX2FkZChzZC0+aW1hZ2UsIDAsIDAsIHNk LT52aWV3LncsIHNkLT52aWV3LmgpOwogfQogCiB2b2lkIEV3a1ZpZXc6OnNjaGVkdWxlVXBkYXRl RGlzcGxheSgpCkBAIC04MjAsOCArODIwLDExIEBAIGJvb2wgRXdrVmlldzo6Y3JlYXRlR0xTdXJm YWNlKCkKICAgICAgICAgRVZBU19HTF9NVUxUSVNBTVBMRV9OT05FCiAgICAgfTsKIAorICAgIEV3 a19WaWV3X1NtYXJ0X0RhdGEqIHNkID0gc21hcnREYXRhKCk7CisgICAgSW50U2l6ZSB2aWV3U2l6 ZShzZC0+dmlldy53LCBzZC0+dmlldy5oKTsKKwogICAgIC8vIFJlY3JlYXRlIHRvIGN1cnJlbnQg c2l6ZTogUmVwbGFjZXMgaWYgbm9uLW51bGwsIGFuZCBmcmVlcyBleGlzdGluZyBzdXJmYWNlIGFm dGVyIChPd25QdHIpLgotICAgIG1fZXZhc0dMU3VyZmFjZSA9IEV2YXNHTFN1cmZhY2U6OmNyZWF0 ZShtX2V2YXNHTC5nZXQoKSwgJmV2YXNHTENvbmZpZywgZGV2aWNlU2l6ZSgpKTsKKyAgICBtX2V2 YXNHTFN1cmZhY2UgPSBFdmFzR0xTdXJmYWNlOjpjcmVhdGUobV9ldmFzR0wuZ2V0KCksICZldmFz R0xDb25maWcsIHZpZXdTaXplKTsKICAgICBpZiAoIW1fZXZhc0dMU3VyZmFjZSkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogCkBAIC04MzMsOCArODM2LDcgQEAgYm9vbCBFd2tWaWV3OjpjcmVhdGVH TFN1cmZhY2UoKQogCiAgICAgRXZhc19HTF9BUEkqIGdsID0gZXZhc19nbF9hcGlfZ2V0KG1fZXZh c0dMLmdldCgpKTsKIAotICAgIFdLUG9pbnQgYm91bmRzRW5kID0gV0tWaWV3VXNlclZpZXdwb3J0 VG9TY2VuZSh3a1ZpZXcoKSwgV0tQb2ludE1ha2UoZGV2aWNlU2l6ZSgpLndpZHRoKCksIGRldmlj ZVNpemUoKS5oZWlnaHQoKSkpOwotICAgIGdsLT5nbFZpZXdwb3J0KDAsIDAsIGJvdW5kc0VuZC54 LCBib3VuZHNFbmQueSk7CisgICAgZ2wtPmdsVmlld3BvcnQoMCwgMCwgdmlld1NpemUud2lkdGgo KSwgdmlld1NpemUuaGVpZ2h0KCkpOwogICAgIGdsLT5nbENsZWFyQ29sb3IoMS4wLCAxLjAsIDEu MCwgMCk7CiAgICAgZ2wtPmdsQ2xlYXIoR0xfQ09MT1JfQlVGRkVSX0JJVCk7CiAKQEAgLTExOTYs NyArMTE5OCw2IEBAIHZvaWQgRXdrVmlldzo6aGFuZGxlRXZhc09iamVjdENhbGN1bGF0ZShFdmFz X09iamVjdCogZXZhc09iamVjdCkKICAgICAgICAgc21hcnREYXRhLT52aWV3LnggPSB4OwogICAg ICAgICBzbWFydERhdGEtPnZpZXcueSA9IHk7CiAgICAgICAgIGV2YXNfb2JqZWN0X21vdmUoc21h cnREYXRhLT5pbWFnZSwgeCwgeSk7Ci0gICAgICAgIFdLVmlld1NldFVzZXJWaWV3cG9ydFRyYW5z bGF0aW9uKHNlbGYtPndrVmlldygpLCB4LCB5KTsKICAgICB9CiAKICAgICBpZiAoc21hcnREYXRh LT5jaGFuZ2VkLnNpemUpIHsK 218036 2013-11-28 23:26:00 -0800 2013-11-29 00:34:49 -0800 Patch bug-124965-20131129162558.patch text/plain 3120 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzQyYTJhYWFmY2NlOGFl YzRjMGI3N2NmODlmZDI0NDYwNmZiNGZiOS4uOGMzNjZmNzhmZDUwYzEzYzZiMzJmYmExZWE3NDk0 OThlZWIwNTU3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTExLTI4ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSB2aWV3 cG9ydCBtdXN0IGJlIHNhbWUgd2l0aCB0aGUgc2l6ZSBvZiB3ZWJ2aWV3CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ5NjUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHksIHNpemUgb2YgdGhl IHZpZXdwb3J0IGlzIGxhcmdlciB0aGFuIHNpemUgb2Ygd2Vidmlldy4KKyAgICAgICAgQ2hhbmdl ZCB0aGUgc2l6ZSBvZiB2aWV3cG9ydCB3aXRoIHNpemUgb2Ygd2VidmlldywgYmVjYXVzZSB2aWV3 cG9ydCBpcyB0cmFuc2xhdGVkIGJ5IHdyb25nIGNhbGN1bGF0aW9uLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHA6CisgICAgICAgIChFd2tWaWV3OjpkaXNwbGF5VGlt ZXJGaXJlZCk6IENoYW5nZWQgdG8gdXNlIHRoZSAoMCwwKS4gCisgICAgICAgIChFd2tWaWV3Ojpj cmVhdGVHTFN1cmZhY2UpOiBNb2RpZmllZCB0byB1c2UgdGhlIHZpZXdTaXplIGluc3RlYWQgb2Yg dGhlIGJvdW5kc0VuZC4KKyAgICAgICAgKEV3a1ZpZXc6OmhhbmRsZUV2YXNPYmplY3RDYWxjdWxh dGUpOiBSZW1vdmVkIHRoZSBXS1ZpZXdTZXRVc2VyVmlld3BvcnRUcmFuc2xhdGlvbi4KKwogMjAx My0xMS0yNyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEdpdmUgdGhl IFBhZ2VDbGllbnQgYSBjaGFuY2UgdG8gaGFuZGxlIGdlb2xvY2F0aW9uIHBlcm1pc3Npb24gcmVx dWVzdHMgaWYgdGhlIFVJQ2xpZW50IGRvZXNuJ3QgaGFuZGxlIGl0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCmluZGV4IDYwY2Y5MDRjMTZmYWQwNmM5NjIz NTliNGVhZjdhN2YxMmJiOWU0YTcuLjE3YzIyMTliMDIzNDdmY2I1YjU5ZmI5MmZhZmZkYzUwZjUx MmEzMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1Zp ZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3Bw CkBAIC01ODAsNyArNTgwLDcgQEAgdm9pZCBFd2tWaWV3OjpkaXNwbGF5VGltZXJGaXJlZChUaW1l cjxFd2tWaWV3PiopCiAgICAgV0tWaWV3UGFpbnRUb0N1cnJlbnRHTENvbnRleHQod2tWaWV3KCkp OwogI2VuZGlmCiAgICAgLy8gc2QtPmltYWdlIGlzIHRpZWQgdG8gYSBuYXRpdmUgc3VyZmFjZSwg d2hpY2ggaXMgaW4gdGhlIHBhcmVudCdzIGNvb3JkaW5hdGVzLgotICAgIGV2YXNfb2JqZWN0X2lt YWdlX2RhdGFfdXBkYXRlX2FkZChzZC0+aW1hZ2UsIHNkLT52aWV3LngsIHNkLT52aWV3LnksIHNk LT52aWV3LncsIHNkLT52aWV3LmgpOworICAgIGV2YXNfb2JqZWN0X2ltYWdlX2RhdGFfdXBkYXRl X2FkZChzZC0+aW1hZ2UsIDAsIDAsIHNkLT52aWV3LncsIHNkLT52aWV3LmgpOwogfQogCiB2b2lk IEV3a1ZpZXc6OnNjaGVkdWxlVXBkYXRlRGlzcGxheSgpCkBAIC04MjAsOCArODIwLDExIEBAIGJv b2wgRXdrVmlldzo6Y3JlYXRlR0xTdXJmYWNlKCkKICAgICAgICAgRVZBU19HTF9NVUxUSVNBTVBM RV9OT05FCiAgICAgfTsKIAorICAgIEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNkID0gc21hcnREYXRh KCk7CisgICAgSW50U2l6ZSB2aWV3U2l6ZShzZC0+dmlldy53LCBzZC0+dmlldy5oKTsKKwogICAg IC8vIFJlY3JlYXRlIHRvIGN1cnJlbnQgc2l6ZTogUmVwbGFjZXMgaWYgbm9uLW51bGwsIGFuZCBm cmVlcyBleGlzdGluZyBzdXJmYWNlIGFmdGVyIChPd25QdHIpLgotICAgIG1fZXZhc0dMU3VyZmFj ZSA9IEV2YXNHTFN1cmZhY2U6OmNyZWF0ZShtX2V2YXNHTC5nZXQoKSwgJmV2YXNHTENvbmZpZywg ZGV2aWNlU2l6ZSgpKTsKKyAgICBtX2V2YXNHTFN1cmZhY2UgPSBFdmFzR0xTdXJmYWNlOjpjcmVh dGUobV9ldmFzR0wuZ2V0KCksICZldmFzR0xDb25maWcsIHZpZXdTaXplKTsKICAgICBpZiAoIW1f ZXZhc0dMU3VyZmFjZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCkBAIC04MzMsOCArODM2LDcg QEAgYm9vbCBFd2tWaWV3OjpjcmVhdGVHTFN1cmZhY2UoKQogCiAgICAgRXZhc19HTF9BUEkqIGds ID0gZXZhc19nbF9hcGlfZ2V0KG1fZXZhc0dMLmdldCgpKTsKIAotICAgIFdLUG9pbnQgYm91bmRz RW5kID0gV0tWaWV3VXNlclZpZXdwb3J0VG9TY2VuZSh3a1ZpZXcoKSwgV0tQb2ludE1ha2UoZGV2 aWNlU2l6ZSgpLndpZHRoKCksIGRldmljZVNpemUoKS5oZWlnaHQoKSkpOwotICAgIGdsLT5nbFZp ZXdwb3J0KDAsIDAsIGJvdW5kc0VuZC54LCBib3VuZHNFbmQueSk7CisgICAgZ2wtPmdsVmlld3Bv cnQoMCwgMCwgdmlld1NpemUud2lkdGgoKSwgdmlld1NpemUuaGVpZ2h0KCkpOwogICAgIGdsLT5n bENsZWFyQ29sb3IoMS4wLCAxLjAsIDEuMCwgMCk7CiAgICAgZ2wtPmdsQ2xlYXIoR0xfQ09MT1Jf QlVGRkVSX0JJVCk7CiAKQEAgLTExOTYsNyArMTE5OCw2IEBAIHZvaWQgRXdrVmlldzo6aGFuZGxl RXZhc09iamVjdENhbGN1bGF0ZShFdmFzX09iamVjdCogZXZhc09iamVjdCkKICAgICAgICAgc21h cnREYXRhLT52aWV3LnggPSB4OwogICAgICAgICBzbWFydERhdGEtPnZpZXcueSA9IHk7CiAgICAg ICAgIGV2YXNfb2JqZWN0X21vdmUoc21hcnREYXRhLT5pbWFnZSwgeCwgeSk7Ci0gICAgICAgIFdL Vmlld1NldFVzZXJWaWV3cG9ydFRyYW5zbGF0aW9uKHNlbGYtPndrVmlldygpLCB4LCB5KTsKICAg ICB9CiAKICAgICBpZiAoc21hcnREYXRhLT5jaGFuZ2VkLnNpemUpIHsK