124963 2013-11-28 01:55:40 -0800 [CSS Regions] Fix Layout/RegionsSelection.html in Mac platform 2013-12-03 14:32:33 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124281 1 rego rego commit-queue jfernandez mihnea rniwa WebkitBugTracker oldest_to_newest 954681 0 rego 2013-11-28 01:55:40 -0800 The performance test Layout/RegionsSelection.html introduced in r159488 is not working properly in Mac platform. In Mac it takes just a few milliseconds to run the test, while in GTK+ and Blink (Linux) it takes more than 1 second (of course depending on the the machine). It seems that the test actually is not selecting anything due to mouse events being done out of the window dimensions. I think we should use setBaseAndExtent() to fix this test and in the future if we think it's needed we could add a new test that fits in the window size performing selection using mouse events. 954682 1 217987 rego 2013-11-28 01:57:28 -0800 Created attachment 217987 Patch 956069 2 217987 rniwa 2013-12-03 13:19:37 -0800 Comment on attachment 217987 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217987&action=review > PerformanceTests/Layout/resources/regions.js:95 > + window.getSelection().setBaseAndExtent(paragraphs[0], 0, paragraphs[i], 0); setBaseAndExtent is a non-standard API so perhaps we want to use collapse & extend? Also, we don't need "window.". 956077 3 218335 rego 2013-12-03 13:42:19 -0800 Created attachment 218335 Patch 956114 4 218335 commit-queue 2013-12-03 14:32:31 -0800 Comment on attachment 218335 Patch Clearing flags on attachment: 218335 Committed r160041: <http://trac.webkit.org/changeset/160041> 956115 5 commit-queue 2013-12-03 14:32:33 -0800 All reviewed patches have been landed. Closing bug. 217987 2013-11-28 01:57:28 -0800 2013-12-03 13:42:14 -0800 Patch bug-124963-20131128105930.patch text/plain 2276 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODA5CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDkxY2MyMTlmNzMz MWY4NjQyM2MyMzcxNzg3ZDJkOWZhYzExMDNiN2MuLjI4OWE4OGRjMTY0ZDQ2NTk1MTg1MjFjODkw YzRmNjRmYmIxNWIwMDcgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMTEt MjggIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CisKKyAgICAgICAg W0NTUyBSZWdpb25zXSBGaXggTGF5b3V0L1JlZ2lvbnNTZWxlY3Rpb24uaHRtbCBpbiBNYWMgcGxh dGZvcm0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NDk2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExh eW91dC9SZWdpb25zU2VsZWN0aW9uLmh0bWwgaW50cm9kdWNlZCBpbiByMTU5NDg4IHdhcyBub3Qg d29ya2luZyBpbgorICAgICAgICBNYWMgcGxhdGZvcm0gYmVjYXVzZSBvZiBpdCB3YXMgdHJ5aW5n IHRvIHVzZSBtb3VzZSBldmVudHMgb3V0IG9mIHRoZQorICAgICAgICB3aW5kb3cgZGltZW5zaW9u cy4gVXNlIHNlbGVjdGlvbi5zZXRCYXNlQW5kRXh0ZW50KCkgbWV0aG9kIGluc3RlYWQgdG8KKyAg ICAgICAgZml4IHRoZSBwcm9ibGVtLgorCisgICAgICAgICogTGF5b3V0L3Jlc291cmNlcy9yZWdp b25zLmpzOiBVc2Ugc2V0QmFzZUFuZEV4dGVudCgpIGluc3RlYWQgb2YgbW91c2UKKyAgICAgICAg ZXZlbnRzLgorCiAyMDEzLTExLTI2ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIFN1cHBvcnQgZ3JpZC1kZWZpbml0 aW9uLXtyb3dzfGNvbHVtbnN9IHJlcGVhdCgpIHN5bnRheApkaWZmIC0tZ2l0IGEvUGVyZm9ybWFu Y2VUZXN0cy9MYXlvdXQvcmVzb3VyY2VzL3JlZ2lvbnMuanMgYi9QZXJmb3JtYW5jZVRlc3RzL0xh eW91dC9yZXNvdXJjZXMvcmVnaW9ucy5qcwppbmRleCAwYTFmMjY0MDU2NDdkNjhjZjc4MjU4NjJi OGMwMmVkNzQwMDVhZWJmLi4zMjdmMjM0Zjk5ZWRkNzhlMDNjN2E3Nzc3NDdhNDdmYzA0ZDFhZGNk IDEwMDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL0xheW91dC9yZXNvdXJjZXMvcmVnaW9ucy5q cworKysgYi9QZXJmb3JtYW5jZVRlc3RzL0xheW91dC9yZXNvdXJjZXMvcmVnaW9ucy5qcwpAQCAt ODgsMjMgKzg4LDExIEBACiAgICAgICAgIH07CiAgICAgfQogCi0gICAgZnVuY3Rpb24gbW91c2VN b3ZlVG9SZWdpb25DZW50ZXIocmVnaW9uKSB7Ci0gICAgICAgIHZhciByZWN0ID0gcmVnaW9uLmdl dEJvdW5kaW5nQ2xpZW50UmVjdCgpOwotICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhy ZWN0LmxlZnQgKyAocmVjdC53aWR0aCAvIDIpLCByZWN0LnRvcCArIChyZWN0LmhlaWdodCAvIDIp KTsKLSAgICB9Ci0KLSAgICBmdW5jdGlvbiBwZXJmb3JtU2VsZWN0aW9uKHJlZ2lvbkNvdW50KSB7 Ci0gICAgICAgIHZhciByZWdpb25zID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgi cmVnaW9uIik7Ci0KLSAgICAgICAgaWYgKHdpbmRvdy5ldmVudFNlbmRlcikgewotICAgICAgICAg ICAgbW91c2VNb3ZlVG9SZWdpb25DZW50ZXIocmVnaW9uc1swXSk7Ci0gICAgICAgICAgICBldmVu dFNlbmRlci5tb3VzZURvd24oKTsKKyAgICBmdW5jdGlvbiBwZXJmb3JtU2VsZWN0aW9uKHBhcmFn cmFwaENvdW50KSB7CisgICAgICAgIHZhciBwYXJhZ3JhcGhzID0gZG9jdW1lbnQuZ2V0RWxlbWVu dHNCeUNsYXNzTmFtZSgiY29udGVudFBhcmFncmFwaCIpOwogCi0gICAgICAgICAgICBmb3IgKHZh ciBpID0gMTsgaSA8IHJlZ2lvbkNvdW50OyBpKyspCi0gICAgICAgICAgICAgICAgbW91c2VNb3Zl VG9SZWdpb25DZW50ZXIocmVnaW9uc1tpXSk7Ci0KLSAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1v dXNlVXAoKTsKLSAgICAgICAgfQorICAgICAgICBmb3IgKHZhciBpID0gMTsgaSA8IHBhcmFncmFw aENvdW50OyBpKyspCisgICAgICAgICAgICB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuc2V0QmFzZUFu ZEV4dGVudChwYXJhZ3JhcGhzWzBdLCAwLCBwYXJhZ3JhcGhzW2ldLCAwKTsKICAgICB9CiAKICAg ICBmdW5jdGlvbiBjcmVhdGVSZWdpb25zU2VsZWN0aW9uVGVzdChyZWdpb25Db3VudCkgewo= 218335 2013-12-03 13:42:19 -0800 2013-12-03 14:32:31 -0800 Patch bug-124963-20131203224217.patch text/plain 2339 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODA5CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDkxY2MyMTlmNzMz MWY4NjQyM2MyMzcxNzg3ZDJkOWZhYzExMDNiN2MuLjdmZmM3N2QwZjliYTc3ZmY5NjZkMzcxYWMz YTkzMWNjNTY1OGJlYTMgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMTEt MjggIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CisKKyAgICAgICAg W0NTUyBSZWdpb25zXSBGaXggTGF5b3V0L1JlZ2lvbnNTZWxlY3Rpb24uaHRtbCBpbiBNYWMgcGxh dGZvcm0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NDk2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExh eW91dC9SZWdpb25zU2VsZWN0aW9uLmh0bWwgaW50cm9kdWNlZCBpbiByMTU5NDg4IHdhcyBub3Qg d29ya2luZyBpbgorICAgICAgICBNYWMgcGxhdGZvcm0gYmVjYXVzZSBvZiBpdCB3YXMgdHJ5aW5n IHRvIHVzZSBtb3VzZSBldmVudHMgb3V0IG9mIHRoZQorICAgICAgICB3aW5kb3cgZGltZW5zaW9u cy4gVXNlIGNvbGxhcHNlKCkgYW5kIGV4dGVuZCgpIG1ldGhvZHMgZnJvbSBTZWxlY3Rpb24KKyAg ICAgICAgb2JqZWN0IHRvIHNvbHZlIHRoZSBpc3N1ZS4KKworICAgICAgICAqIExheW91dC9yZXNv dXJjZXMvcmVnaW9ucy5qczogVXNlIGNvbGxhcHNlKCkgYW5kIGV4dGVuZCgpIGluc3RlYWQgb2YK KyAgICAgICAgbW91c2UgZXZlbnRzLgorCiAyMDEzLTExLTI2ICBTZXJnaW8gVmlsbGFyIFNlbmlu ICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIFN1cHBv cnQgZ3JpZC1kZWZpbml0aW9uLXtyb3dzfGNvbHVtbnN9IHJlcGVhdCgpIHN5bnRheApkaWZmIC0t Z2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9MYXlvdXQvcmVzb3VyY2VzL3JlZ2lvbnMuanMgYi9QZXJm b3JtYW5jZVRlc3RzL0xheW91dC9yZXNvdXJjZXMvcmVnaW9ucy5qcwppbmRleCAwYTFmMjY0MDU2 NDdkNjhjZjc4MjU4NjJiOGMwMmVkNzQwMDVhZWJmLi4xNGZhYWE4M2M4YTA4MTdjMmQ2NTgzZTBl YzEwYjY4NDMyZDJjMzk3IDEwMDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL0xheW91dC9yZXNv dXJjZXMvcmVnaW9ucy5qcworKysgYi9QZXJmb3JtYW5jZVRlc3RzL0xheW91dC9yZXNvdXJjZXMv cmVnaW9ucy5qcwpAQCAtODgsMjMgKzg4LDE0IEBACiAgICAgICAgIH07CiAgICAgfQogCi0gICAg ZnVuY3Rpb24gbW91c2VNb3ZlVG9SZWdpb25DZW50ZXIocmVnaW9uKSB7Ci0gICAgICAgIHZhciBy ZWN0ID0gcmVnaW9uLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpOwotICAgICAgICBldmVudFNlbmRl ci5tb3VzZU1vdmVUbyhyZWN0LmxlZnQgKyAocmVjdC53aWR0aCAvIDIpLCByZWN0LnRvcCArIChy ZWN0LmhlaWdodCAvIDIpKTsKLSAgICB9Ci0KLSAgICBmdW5jdGlvbiBwZXJmb3JtU2VsZWN0aW9u KHJlZ2lvbkNvdW50KSB7Ci0gICAgICAgIHZhciByZWdpb25zID0gZG9jdW1lbnQuZ2V0RWxlbWVu dHNCeUNsYXNzTmFtZSgicmVnaW9uIik7CisgICAgZnVuY3Rpb24gcGVyZm9ybVNlbGVjdGlvbihw YXJhZ3JhcGhDb3VudCkgeworICAgICAgICB2YXIgcGFyYWdyYXBocyA9IGRvY3VtZW50LmdldEVs ZW1lbnRzQnlDbGFzc05hbWUoImNvbnRlbnRQYXJhZ3JhcGgiKTsKKyAgICAgICAgdmFyIHNlbGVj dGlvbiA9IGdldFNlbGVjdGlvbigpOwogCi0gICAgICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIp IHsKLSAgICAgICAgICAgIG1vdXNlTW92ZVRvUmVnaW9uQ2VudGVyKHJlZ2lvbnNbMF0pOwotICAg ICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgICAgIHNlbGVjdGlvbi5jb2xs YXBzZShwYXJhZ3JhcGhzWzBdLCAwKTsKIAotICAgICAgICAgICAgZm9yICh2YXIgaSA9IDE7IGkg PCByZWdpb25Db3VudDsgaSsrKQotICAgICAgICAgICAgICAgIG1vdXNlTW92ZVRvUmVnaW9uQ2Vu dGVyKHJlZ2lvbnNbaV0pOwotCi0gICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7Ci0g ICAgICAgIH0KKyAgICAgICAgZm9yICh2YXIgaSA9IDE7IGkgPCBwYXJhZ3JhcGhDb3VudDsgaSsr KQorICAgICAgICAgICAgc2VsZWN0aW9uLmV4dGVuZChwYXJhZ3JhcGhzW2ldLCAwKTsKICAgICB9 CiAKICAgICBmdW5jdGlvbiBjcmVhdGVSZWdpb25zU2VsZWN0aW9uVGVzdChyZWdpb25Db3VudCkg ewo=