124962 2013-11-28 01:38:38 -0800 Remove get_test() and reference test names directly instead. 2013-12-03 04:37:45 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbatyai.u-szeged webkit-unassigned commit-queue glenn rniwa oldest_to_newest 954678 0 dbatyai.u-szeged 2013-11-28 01:38:38 -0800 Remove get_test() and instead reference test names directly in text_expectations_unittest.py 954679 1 217985 dbatyai.u-szeged 2013-11-28 01:39:19 -0800 Created attachment 217985 Proposed patch 955826 2 dbatyai.u-szeged 2013-12-03 02:10:52 -0800 Can you take a look at this as well, please? 955853 3 217985 ossy 2013-12-03 04:12:42 -0800 Comment on attachment 217985 Proposed patch r=me 955859 4 217985 commit-queue 2013-12-03 04:37:44 -0800 Comment on attachment 217985 Proposed patch Clearing flags on attachment: 217985 Committed r159998: <http://trac.webkit.org/changeset/159998> 955860 5 commit-queue 2013-12-03 04:37:45 -0800 All reviewed patches have been landed. Closing bug. 217985 2013-11-28 01:39:19 -0800 2013-12-03 04:37:44 -0800 Proposed patch proposedpatch.patch text/plain 5834 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlNmE5 NzM1Li4yOTVjMjE3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTMtMTEtMjggIETDoW5pZWwgQsOhdHlhaSAgPEJh dHlhaS5EYW5pZWxAc3R1ZC51LXN6ZWdlZC5odT4KKworICAgICAgICBSZW1vdmUgZ2V0X3Rlc3Qo KSBhbmQgcmVmZXJlbmNlIHRlc3QgbmFtZXMgZGlyZWN0bHkgaW5zdGVhZC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDk2MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0ZXN0LnB5OgorICAgICAg ICAoQmFzZS5fX2luaXRfXyk6CisgICAgICAgIChCYXNlLmdldF9iYXNpY190ZXN0cyk6CisgICAg ICAgIChhc3NlcnRfZXhwKToKKyAgICAgICAgKE1pc2NUZXN0cy50ZXN0X211bHRpcGxlX3Jlc3Vs dHMpOgorICAgICAgICAoTWlzY1Rlc3RzLnRlc3RfY2F0ZWdvcnlfZXhwZWN0YXRpb25zKToKKyAg ICAgICAgKE1pc2NUZXN0cy50ZXN0X2dldF9tb2RpZmllcnMpOgorICAgICAgICAoTWlzY1Rlc3Rz LnRlc3RfZ2V0X2V4cGVjdGF0aW9uc19zdHJpbmcpOgorICAgICAgICAoTWlzY1Rlc3RzLnRlc3Rf Z2V0X3Rlc3Rfc2V0KToKKyAgICAgICAgKE1pc2NUZXN0cy50ZXN0X3BhcnNlX3dhcm5pbmcpOgor ICAgICAgICAoTWlzY1Rlc3RzLnRlc3RfcGl4ZWxfdGVzdHNfZmxhZy5tYXRjaCk6CisKIDIwMTMt MTEtMjYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBEbyBieXRl Y29kZSB2YWxpZGF0aW9uIGFzIHBhcnQgb2YgdGVzdGluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0 ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3Rf ZXhwZWN0YXRpb25zX3VuaXR0ZXN0LnB5CmluZGV4IDI3YmIzYmMuLjgyMWFhMGYgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVj dGF0aW9uc191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnNfdW5pdHRlc3QucHkKQEAgLTUzLDE3ICs1Mywx MyBAQCBjbGFzcyBCYXNlKHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5fZXhwID0g Tm9uZQogICAgICAgICB1bml0dGVzdC5UZXN0Q2FzZS5fX2luaXRfXyhzZWxmLCB0ZXN0RnVuYykK IAotICAgIGRlZiBnZXRfdGVzdChzZWxmLCB0ZXN0X25hbWUpOgotICAgICAgICAjIEZJWE1FOiBS ZW1vdmUgdGhpcyByb3V0aW5lIGFuZCBqdXN0IHJlZmVyZW5jZSB0ZXN0IG5hbWVzIGRpcmVjdGx5 LgotICAgICAgICByZXR1cm4gdGVzdF9uYW1lCi0KICAgICBkZWYgZ2V0X2Jhc2ljX3Rlc3RzKHNl bGYpOgotICAgICAgICByZXR1cm4gW3NlbGYuZ2V0X3Rlc3QoJ2ZhaWx1cmVzL2V4cGVjdGVkL3Rl eHQuaHRtbCcpLAotICAgICAgICAgICAgICAgIHNlbGYuZ2V0X3Rlc3QoJ2ZhaWx1cmVzL2V4cGVj dGVkL2ltYWdlX2NoZWNrc3VtLmh0bWwnKSwKLSAgICAgICAgICAgICAgICBzZWxmLmdldF90ZXN0 KCdmYWlsdXJlcy9leHBlY3RlZC9jcmFzaC5odG1sJyksCi0gICAgICAgICAgICAgICAgc2VsZi5n ZXRfdGVzdCgnZmFpbHVyZXMvZXhwZWN0ZWQvbWlzc2luZ190ZXh0Lmh0bWwnKSwKLSAgICAgICAg ICAgICAgICBzZWxmLmdldF90ZXN0KCdmYWlsdXJlcy9leHBlY3RlZC9pbWFnZS5odG1sJyksCi0g ICAgICAgICAgICAgICAgc2VsZi5nZXRfdGVzdCgncGFzc2VzL3RleHQuaHRtbCcpXQorICAgICAg ICByZXR1cm4gWydmYWlsdXJlcy9leHBlY3RlZC90ZXh0Lmh0bWwnLAorICAgICAgICAgICAgICAg ICdmYWlsdXJlcy9leHBlY3RlZC9pbWFnZV9jaGVja3N1bS5odG1sJywKKyAgICAgICAgICAgICAg ICAnZmFpbHVyZXMvZXhwZWN0ZWQvY3Jhc2guaHRtbCcsCisgICAgICAgICAgICAgICAgJ2ZhaWx1 cmVzL2V4cGVjdGVkL21pc3NpbmdfdGV4dC5odG1sJywKKyAgICAgICAgICAgICAgICAnZmFpbHVy ZXMvZXhwZWN0ZWQvaW1hZ2UuaHRtbCcsCisgICAgICAgICAgICAgICAgJ3Bhc3Nlcy90ZXh0Lmh0 bWwnXQogCiAgICAgZGVmIGdldF9iYXNpY19leHBlY3RhdGlvbnMoc2VsZik6CiAgICAgICAgIHJl dHVybiAiIiIKQEAgLTg0LDcgKzgwLDcgQEAgQnVnKHRlc3QpIGZhaWx1cmVzL2V4cGVjdGVkL2lt YWdlLmh0bWwgWyBXb250Rml4IE1hYyBdCiAgICAgICAgIHNlbGYuX2V4cCA9IFRlc3RFeHBlY3Rh dGlvbnMoc2VsZi5fcG9ydCwgc2VsZi5nZXRfYmFzaWNfdGVzdHMoKSwgZXhwZWN0YXRpb25zX3Rv X2xpbnQ9ZXhwZWN0YXRpb25zX3RvX2xpbnQpCiAKICAgICBkZWYgYXNzZXJ0X2V4cChzZWxmLCB0 ZXN0LCByZXN1bHQpOgotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYuX2V4cC5nZXRfZXhw ZWN0YXRpb25zKHNlbGYuZ2V0X3Rlc3QodGVzdCkpLAorICAgICAgICBzZWxmLmFzc2VydEVxdWFs KHNlbGYuX2V4cC5nZXRfZXhwZWN0YXRpb25zKHRlc3QpLAogICAgICAgICAgICAgICAgICAgICAg ICAgICBzZXQoW3Jlc3VsdF0pKQogCiAgICAgZGVmIGFzc2VydF9iYWRfZXhwZWN0YXRpb25zKHNl bGYsIGV4cGVjdGF0aW9ucywgb3ZlcnJpZGVzPU5vbmUpOgpAQCAtMTA0LDcgKzEwMCw3IEBAIGNs YXNzIE1pc2NUZXN0cyhCYXNlKToKICAgICBkZWYgdGVzdF9tdWx0aXBsZV9yZXN1bHRzKHNlbGYp OgogICAgICAgICBzZWxmLnBhcnNlX2V4cCgnQnVnKHgpIGZhaWx1cmVzL2V4cGVjdGVkL3RleHQu aHRtbCBbIENyYXNoIEZhaWx1cmUgXScpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5f ZXhwLmdldF9leHBlY3RhdGlvbnMoCi0gICAgICAgICAgICBzZWxmLmdldF90ZXN0KCdmYWlsdXJl cy9leHBlY3RlZC90ZXh0Lmh0bWwnKSksCisgICAgICAgICAgICAnZmFpbHVyZXMvZXhwZWN0ZWQv dGV4dC5odG1sJyksCiAgICAgICAgICAgICBzZXQoW0ZBSUwsIENSQVNIXSkpCiAKICAgICBkZWYg dGVzdF9yZXN1bHRfd2FzX2V4cGVjdGVkKHNlbGYpOgpAQCAtMTQwLDIxICsxMzYsMTggQEAgY2xh c3MgTWlzY1Rlc3RzKEJhc2UpOgogICAgICAgICBleHBfc3RyID0gJ0J1Zyh4KSBmYWlsdXJlcy9l eHBlY3RlZCBbIFdvbnRGaXggXScKICAgICAgICAgc2VsZi5wYXJzZV9leHAoZXhwX3N0cikKICAg ICAgICAgdGVzdF9uYW1lID0gJ2ZhaWx1cmVzL2V4cGVjdGVkL3Vua25vd24tdGVzdC5odG1sJwot ICAgICAgICB1bmtub3duX3Rlc3QgPSBzZWxmLmdldF90ZXN0KHRlc3RfbmFtZSkKKyAgICAgICAg dW5rbm93bl90ZXN0ID0gdGVzdF9uYW1lCiAgICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKEtleUVy cm9yLCBzZWxmLl9leHAuZ2V0X2V4cGVjdGF0aW9ucywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgdW5rbm93bl90ZXN0KQogICAgICAgICBzZWxmLmFzc2VydF9leHAoJ2ZhaWx1cmVzL2V4cGVj dGVkL2NyYXNoLmh0bWwnLCBQQVNTKQogCiAgICAgZGVmIHRlc3RfZ2V0X21vZGlmaWVycyhzZWxm KToKICAgICAgICAgc2VsZi5wYXJzZV9leHAoc2VsZi5nZXRfYmFzaWNfZXhwZWN0YXRpb25zKCkp Ci0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5fZXhwLmdldF9tb2RpZmllcnMoCi0gICAg ICAgICAgICAgICAgICAgICAgICAgc2VsZi5nZXRfdGVzdCgncGFzc2VzL3RleHQuaHRtbCcpKSwg W10pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5fZXhwLmdldF9tb2RpZmllcnMoJ3Bh c3Nlcy90ZXh0Lmh0bWwnKSwgW10pCiAKICAgICBkZWYgdGVzdF9nZXRfZXhwZWN0YXRpb25zX3N0 cmluZyhzZWxmKToKICAgICAgICAgc2VsZi5wYXJzZV9leHAoc2VsZi5nZXRfYmFzaWNfZXhwZWN0 YXRpb25zKCkpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5fZXhwLmdldF9leHBlY3Rh dGlvbnNfc3RyaW5nKAotICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLmdldF90ZXN0KCdm YWlsdXJlcy9leHBlY3RlZC90ZXh0Lmh0bWwnKSksCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICdGQUlMJykKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZWxmLl9leHAuZ2V0X2V4cGVjdGF0 aW9uc19zdHJpbmcoJ2ZhaWx1cmVzL2V4cGVjdGVkL3RleHQuaHRtbCcpLCAnRkFJTCcpCiAKICAg ICBkZWYgdGVzdF9leHBlY3RhdGlvbl90b19zdHJpbmcoc2VsZik6CiAgICAgICAgICMgTm9ybWFs IGNhc2VzIGFyZSBoYW5kbGVkIGJ5IG90aGVyIHRlc3RzLgpAQCAtMTY3LDE0ICsxNjAsMTMgQEAg Y2xhc3MgTWlzY1Rlc3RzKEJhc2UpOgogICAgICAgICBzZWxmLnBhcnNlX2V4cChzZWxmLmdldF9i YXNpY19leHBlY3RhdGlvbnMoKSkKICAgICAgICAgcyA9IHNlbGYuX2V4cC5nZXRfdGVzdF9zZXQo V09OVEZJWCkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzLAotICAgICAgICAgICAgc2V0KFtz ZWxmLmdldF90ZXN0KCdmYWlsdXJlcy9leHBlY3RlZC9jcmFzaC5odG1sJyksCi0gICAgICAgICAg ICAgICAgIHNlbGYuZ2V0X3Rlc3QoJ2ZhaWx1cmVzL2V4cGVjdGVkL2ltYWdlX2NoZWNrc3VtLmh0 bWwnKV0pKQorICAgICAgICAgICAgc2V0KFsnZmFpbHVyZXMvZXhwZWN0ZWQvY3Jhc2guaHRtbCcs CisgICAgICAgICAgICAgICAgICdmYWlsdXJlcy9leHBlY3RlZC9pbWFnZV9jaGVja3N1bS5odG1s J10pKQogCiAgICAgZGVmIHRlc3RfcGFyc2Vfd2FybmluZyhzZWxmKToKICAgICAgICAgdHJ5Ogog ICAgICAgICAgICAgZmlsZXN5c3RlbSA9IHNlbGYuX3BvcnQuaG9zdC5maWxlc3lzdGVtCiAgICAg ICAgICAgICBmaWxlc3lzdGVtLndyaXRlX3RleHRfZmlsZShmaWxlc3lzdGVtLmpvaW4oc2VsZi5f cG9ydC5sYXlvdXRfdGVzdHNfZGlyKCksICdkaXNhYmxlZC10ZXN0Lmh0bWwtZGlzYWJsZWQnKSwg J2NvbnRlbnQnKQotICAgICAgICAgICAgc2VsZi5nZXRfdGVzdCgnZGlzYWJsZWQtdGVzdC5odG1s LWRpc2FibGVkJyksCiAgICAgICAgICAgICBzZWxmLnBhcnNlX2V4cCgiWyBGT08gXSBmYWlsdXJl cy9leHBlY3RlZC90ZXh0Lmh0bWwgWyBGYWlsdXJlIF1cbiIKICAgICAgICAgICAgICAgICAiQnVn KHJuaXdhKSBub24tZXhpc3RlbnQtdGVzdC5odG1sIFsgRmFpbHVyZSBdXG4iCiAgICAgICAgICAg ICAgICAgIkJ1Zyhybml3YSkgZGlzYWJsZWQtdGVzdC5odG1sLWRpc2FibGVkIFsgSW1hZ2VPbmx5 RmFpbHVyZSBdIiwgaXNfbGludF9tb2RlPVRydWUpCkBAIC0yMjQsNyArMjE2LDcgQEAgY2xhc3Mg TWlzY1Rlc3RzKEJhc2UpOgogICAgIGRlZiB0ZXN0X3BpeGVsX3Rlc3RzX2ZsYWcoc2VsZik6CiAg ICAgICAgIGRlZiBtYXRjaCh0ZXN0LCByZXN1bHQsIHBpeGVsX3Rlc3RzX2VuYWJsZWQpOgogICAg ICAgICAgICAgcmV0dXJuIHNlbGYuX2V4cC5tYXRjaGVzX2FuX2V4cGVjdGVkX3Jlc3VsdCgKLSAg ICAgICAgICAgICAgICBzZWxmLmdldF90ZXN0KHRlc3QpLCByZXN1bHQsIHBpeGVsX3Rlc3RzX2Vu YWJsZWQpCisgICAgICAgICAgICAgICAgdGVzdCwgcmVzdWx0LCBwaXhlbF90ZXN0c19lbmFibGVk KQogCiAgICAgICAgIHNlbGYucGFyc2VfZXhwKHNlbGYuZ2V0X2Jhc2ljX2V4cGVjdGF0aW9ucygp KQogICAgICAgICBzZWxmLmFzc2VydFRydWUobWF0Y2goJ2ZhaWx1cmVzL2V4cGVjdGVkL3RleHQu aHRtbCcsIEZBSUwsIFRydWUpKQo=