124954 2013-11-27 18:34:14 -0800 REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false 2013-11-28 08:00:18 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 david gustavo cgarcia gustavo zan oldest_to_newest 954637 0 david 2013-11-27 18:34:14 -0800 this is webkit 2.2.1. The following code correctly toggled viewing the source with previous webkit versions. int toggle() { gboolean mode; mode = webkit_web_view_get_view_source_mode(t->wv); mode = !mode; webkit_web_view_set_view_source_mode(t->wv, mode); return (0); } However, the first call correctly views the source code, but the next call does not toggle back due to mode = webkit_web_view_get_view_source_mode(t->wv); always returning FALSE. webkit is compiled with --disable-webkit2. 954694 1 gustavo 2013-11-28 05:06:12 -0800 Heh: @@ -5181,8 +5166,7 @@ gboolean webkit_web_view_get_view_source_mode (WebKitWebView* webView) { g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), FALSE); - if (Frame* mainFrame = core(webView)->mainFrame()) - return mainFrame->inViewSourceMode(); + core(webView)->mainFrame().inViewSourceMode(); return FALSE; } From 095b544b7. 954711 2 217995 gustavo 2013-11-28 06:19:42 -0800 Created attachment 217995 Patch 954737 3 gustavo 2013-11-28 08:00:18 -0800 Committed r159843: <http://trac.webkit.org/changeset/159843> 217995 2013-11-28 06:19:42 -0800 2013-11-28 06:46:04 -0800 Patch bug-124954-20131128121941.patch text/plain 3142 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMjM3NzExZDUw ZTBiMDAxMTA1NGViODdiNTdkMDk1MTA5YTQwZmM3Ny4uYmU2ZTkzN2ZmOWI1OWFmZGRlZWFmNzk0 MDc5YzgxZDdiMjRlYzZkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEz LTExLTI4ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3Jh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNTQ2NTgpOiB3ZWJraXRfd2ViX3ZpZXdfZ2V0 X3ZpZXdfc291cmNlX21vZGUgYWx3YXlzIHJldHVybnMgZmFsc2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDk1NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvdGVzdHdlYnZpZXcuYzogbmV3 IHRlc3QgdG8gZW5zdXJlIHNldHRpbmcgYW5kIGdldHRpbmcgc291cmNlIG1vZGUgd29yayBhcyBp bnRlbmRlZC4KKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3 ZWJraXRfd2ViX3ZpZXdfZ2V0X3ZpZXdfc291cmNlX21vZGUpOiBhY3R1YWxseSByZXR1cm4gdGhl IHZhbHVlIHdlIHF1ZXJ5IGZyb20gV2ViQ29yZS4KKwogMjAxMy0xMS0xOCAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBk YXRlIE5FV1MgYW5kIFZlcnNpb25zLm00IGZvciAyLjMuMiByZWxlYXNlLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdHdlYnZpZXcuYyBiL1NvdXJjZS9XZWJLaXQvZ3Rr L3Rlc3RzL3Rlc3R3ZWJ2aWV3LmMKaW5kZXggOTBlNmNjMzZhN2Y0MTgyOTEwMzU2NTBjMWVjODU1 ZWRmZGY5YWE2ZS4uMjIxMzA2MWNhOWM3OTg1YTUzMzIzYWViM2IzYWUzYmIyODVhYjAxNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdHdlYnZpZXcuYworKysgYi9Tb3Vy Y2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vidmlldy5jCkBAIC02ODcsNiArNjg3LDI3IEBAIHN0 YXRpYyB2b2lkIHRlc3Rfd2Via2l0X3dlYl92aWV3X2ZpbGVfY2hvb3NlcigpCiAgICAgZ3RrX3dp ZGdldF9kZXN0cm95KHdpbmRvdyk7CiB9CiAKK3N0YXRpYyB2b2lkIHRlc3Rfd2Via2l0X3dlYl92 aWV3X3NvdXJjZV9tb2RlKCkKK3sKKyAgICBHdGtXaWRnZXQqIHdlYl92aWV3OworCisgICAgd2Vi X3ZpZXcgPSB3ZWJraXRfd2ViX3ZpZXdfbmV3KCk7CisKKyAgICB3ZWJraXRfd2ViX3ZpZXdfbG9h ZF9zdHJpbmcoV0VCS0lUX1dFQl9WSUVXKHdlYl92aWV3KSwgIjxodG1sPjxib2R5PjwvYm9keT48 L2h0bWw+IiwgTlVMTCwgTlVMTCwgTlVMTCk7CisKKyAgICBnX2Fzc2VydCghd2Via2l0X3dlYl92 aWV3X2dldF92aWV3X3NvdXJjZV9tb2RlKFdFQktJVF9XRUJfVklFVyh3ZWJfdmlldykpKTsKKwor ICAgIHdlYmtpdF93ZWJfdmlld19zZXRfdmlld19zb3VyY2VfbW9kZShXRUJLSVRfV0VCX1ZJRVco d2ViX3ZpZXcpLCBUUlVFKTsKKworICAgIGdfYXNzZXJ0KHdlYmtpdF93ZWJfdmlld19nZXRfdmll d19zb3VyY2VfbW9kZShXRUJLSVRfV0VCX1ZJRVcod2ViX3ZpZXcpKSk7CisKKyAgICB3ZWJraXRf d2ViX3ZpZXdfc2V0X3ZpZXdfc291cmNlX21vZGUoV0VCS0lUX1dFQl9WSUVXKHdlYl92aWV3KSwg RkFMU0UpOworCisgICAgZ19hc3NlcnQoIXdlYmtpdF93ZWJfdmlld19nZXRfdmlld19zb3VyY2Vf bW9kZShXRUJLSVRfV0VCX1ZJRVcod2ViX3ZpZXcpKSk7CisKKyAgICBndGtfd2lkZ2V0X2Rlc3Ry b3kod2ViX3ZpZXcpOworfQorCiBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiB7CiAg ICAgU291cFNlcnZlciogc2VydmVyOwpAQCAtNzE5LDYgKzc0MCw3IEBAIGludCBtYWluKGludCBh cmdjLCBjaGFyKiogYXJndikKICAgICBnX3Rlc3RfYWRkX2RhdGFfZnVuYygiL3dlYmtpdC93ZWJ2 aWV3L2Z1bGxzY3JlZW4iLCBHSU5UX1RPX1BPSU5URVIoRkFMU0UpLCB0ZXN0X3dlYmtpdF93ZWJf dmlld19mdWxsc2NyZWVuKTsKICAgICBnX3Rlc3RfYWRkX2RhdGFfZnVuYygiL3dlYmtpdC93ZWJ2 aWV3L2Z1bGxzY3JlZW4tYmxvY2tlZCIsIEdJTlRfVE9fUE9JTlRFUihUUlVFKSwgdGVzdF93ZWJr aXRfd2ViX3ZpZXdfZnVsbHNjcmVlbik7CiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L3dl YnZpZXcvZmlsZS1jaG9vc2VyIiwgdGVzdF93ZWJraXRfd2ViX3ZpZXdfZmlsZV9jaG9vc2VyKTsK KyAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvd2Vidmlldy9zb3VyY2UtbW9kZSIsIHRlc3Rf d2Via2l0X3dlYl92aWV3X3NvdXJjZV9tb2RlKTsKIAogICAgIHJldHVybiBnX3Rlc3RfcnVuICgp OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcu Y3BwIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IGUw MDM1MmZmNWFlY2ZkMDdkMzgxOTY5YTNjZmQ1OWYzOGY1ZDA1NTAuLmQ3OTM3MjkxZmRhZjQwOWEw NGQ4NDNlMmU4ZWUwNzU3YjhlMzdhMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0d2Vidmlldy5jcHAKQEAgLTUxOTEsOSArNTE5MSw3IEBAIGdib29sZWFuIHdlYmtpdF93ZWJf dmlld19nZXRfdmlld19zb3VyY2VfbW9kZSAoV2ViS2l0V2ViVmlldyogd2ViVmlldykKIHsKICAg ICBnX3JldHVybl92YWxfaWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVcod2ViVmlldyksIEZBTFNF KTsKIAotICAgIGNvcmUod2ViVmlldyktPm1haW5GcmFtZSgpLmluVmlld1NvdXJjZU1vZGUoKTsK LQotICAgIHJldHVybiBGQUxTRTsKKyAgICByZXR1cm4gY29yZSh3ZWJWaWV3KS0+bWFpbkZyYW1l KCkuaW5WaWV3U291cmNlTW9kZSgpOwogfQogCiAvLyBJbnRlcm5hbCBzdWJyZXNvdXJjZSBtYW5h Z2VtZW50Cg==