124953 2013-11-27 18:12:04 -0800 Add accessors for the WKProcessGroup and WKBrowsingContextGroup on the WKBrowsingContextController 2013-11-27 18:23:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 954633 0 sam 2013-11-27 18:12:04 -0800 Add accessors for the WKProcessGroup and WKBrowsingContextGroup on the WKBrowsingContextController 954634 1 217973 sam 2013-11-27 18:13:04 -0800 Created attachment 217973 Patch 954635 2 217973 mitz 2013-11-27 18:18:16 -0800 Comment on attachment 217973 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217973&action=review > Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h:34 > +@class WKBrowsingContextGroup; > +@class WKProcessGroup; Can we just import the headers for these instead of forward-declaring them? I think it’s best to do that in API headers (the reason WKBackForwardList* are forward-declared is that they’re temporarily in PrivateHeaders). 954636 3 sam 2013-11-27 18:23:06 -0800 Committed r159830: <http://trac.webkit.org/changeset/159830> 217973 2013-11-27 18:13:04 -0800 2013-11-27 18:18:16 -0800 Patch bug-124953-20131127181303.patch text/plain 2989 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTgyOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTExLTI3ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIGFjY2Vzc29ycyBmb3IgdGhlIFdL UHJvY2Vzc0dyb3VwIGFuZCBXS0Jyb3dzaW5nQ29udGV4dEdyb3VwIG9uIHRoZSBXS0Jyb3dzaW5n Q29udGV4dENvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNDk1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVy Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRDb250cm9s bGVyLm1tOgorICAgICAgICAoLVtXS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIgcHJvY2Vzc0dy b3VwXSk6CisgICAgICAgICgtW1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlciBicm93c2luZ0Nv bnRleHRHcm91cF0pOgorICAgICAgICBBZGQgYWNjZXNzb3JzLgorCiAyMDEzLTExLTI3ICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFrZSBXS1Byb2Nlc3NHcm91cCB3 b3JrIHdpdGggV0tPYmplY3Qgd3JhcHBpbmcKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlci5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxl ci5oCShyZXZpc2lvbiAxNTk4MjMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21h Yy9XS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzAsNiAr MzAsOCBAQAogCiBAY2xhc3MgV0tCYWNrRm9yd2FyZExpc3Q7CiBAY2xhc3MgV0tCYWNrRm9yd2Fy ZExpc3RJdGVtOworQGNsYXNzIFdLQnJvd3NpbmdDb250ZXh0R3JvdXA7CitAY2xhc3MgV0tQcm9j ZXNzR3JvdXA7CiBAcHJvdG9jb2wgV0tCcm93c2luZ0NvbnRleHRIaXN0b3J5RGVsZWdhdGU7CiBA cHJvdG9jb2wgV0tCcm93c2luZ0NvbnRleHRMb2FkRGVsZWdhdGU7CiBAcHJvdG9jb2wgV0tCcm93 c2luZ0NvbnRleHRQb2xpY3lEZWxlZ2F0ZTsKQEAgLTM3LDEwICszOSwxMiBAQAogV0tfQVBJX0NM QVNTCiBAaW50ZXJmYWNlIFdLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlciA6IE5TT2JqZWN0CiAK K0Bwcm9wZXJ0eSAocmVhZG9ubHkpIFdLUHJvY2Vzc0dyb3VwICpwcm9jZXNzR3JvdXA7CitAcHJv cGVydHkgKHJlYWRvbmx5KSBXS0Jyb3dzaW5nQ29udGV4dEdyb3VwICpicm93c2luZ0NvbnRleHRH cm91cDsKKwogI3ByYWdtYSBtYXJrIERlbGVnYXRlcwogCiBAcHJvcGVydHkgKGFzc2lnbikgaWQg PFdLQnJvd3NpbmdDb250ZXh0TG9hZERlbGVnYXRlPiBsb2FkRGVsZWdhdGU7Ci0KIEBwcm9wZXJ0 eSAoYXNzaWduKSBpZCA8V0tCcm93c2luZ0NvbnRleHRQb2xpY3lEZWxlZ2F0ZT4gcG9saWN5RGVs ZWdhdGU7CiBAcHJvcGVydHkgKGFzc2lnbikgaWQgPFdLQnJvd3NpbmdDb250ZXh0SGlzdG9yeURl bGVnYXRlPiBoaXN0b3J5RGVsZWdhdGU7CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xs ZXIubW0JKHJldmlzaW9uIDE1OTgyMykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv bWFjL1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtNTAs OSArNTAsMTEgQEAKICNpbXBvcnQgPHd0Zi9PYmpjUnVudGltZUV4dHJhcy5oPgogI2ltcG9ydCA8 d3RmL1JldGFpblB0ci5oPgogCisjaW1wb3J0ICJXS0Jyb3dzaW5nQ29udGV4dEdyb3VwSW50ZXJu YWwuaCIKICNpbXBvcnQgIldLQnJvd3NpbmdDb250ZXh0SGFuZGxlSW50ZXJuYWwuaCIKICNpbXBv cnQgIldLQnJvd3NpbmdDb250ZXh0TG9hZERlbGVnYXRlLmgiCiAjaW1wb3J0ICJXS0Jyb3dzaW5n Q29udGV4dFBvbGljeURlbGVnYXRlLmgiCisjaW1wb3J0ICJXS1Byb2Nlc3NHcm91cEludGVybmFs LmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKQEAgLTExMyw2ICsxMTUsMjIgQEAgLSAo dm9pZClkZWFsbG9jCiAgICAgW3N1cGVyIGRlYWxsb2NdOwogfQogCistIChXS1Byb2Nlc3NHcm91 cCAqKXByb2Nlc3NHcm91cAoreworICAgIFdlYkNvbnRleHQqIGNvbnRleHQgPSB0b0ltcGwoX3Bh Z2VSZWYuZ2V0KCkpLT5wcm9jZXNzKCktPmNvbnRleHQoKTsKKyAgICBpZiAoIWNvbnRleHQpCisg ICAgICAgIHJldHVybiBuaWw7CisgICAgcmV0dXJuIHdyYXBwZXIoKmNvbnRleHQpOworfQorCist IChXS0Jyb3dzaW5nQ29udGV4dEdyb3VwICopYnJvd3NpbmdDb250ZXh0R3JvdXAKK3sKKyAgICBX ZWJQYWdlR3JvdXAqIHBhZ2VHcm91cCA9IHRvSW1wbChfcGFnZVJlZi5nZXQoKSktPnBhZ2VHcm91 cCgpOworICAgIGlmICghcGFnZUdyb3VwKQorICAgICAgICByZXR1cm4gbmlsOworICAgIHJldHVy biB3cmFwcGVyKCpwYWdlR3JvdXApOworfQorCiAtIChXS1BhZ2VSZWYpX3BhZ2VSZWYKIHsKICAg ICByZXR1cm4gX3BhZ2VSZWYuZ2V0KCk7Cg==