124946 2013-11-27 12:17:13 -0800 [Win] Some JavaScript date tests are failing in non-California Timezones 2023-01-15 12:36:32 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=250553 InRadar P2 Normal --- 124450 1 peavo bfulgham benjamin bfulgham cmarcelo commit-queue dbates eflews.bot ggaren gyuyoung.kim msaboff webkit-bug-importer oldest_to_newest 954592 0 peavo 2013-11-27 12:17:13 -0800 When I run the javascript tests on Windows, I get the errors listed below. I have traced this down to the method calculateDSTOffset in wtf/DateMath.cpp. On Windows, I think it makes sense to use the native functions for this, instead of using the function getLocalTime, which uses the localtime_s function in the C runtime library. ** The following Mozilla test failures have been introduced: ecma/Date/15.9.5.10-1.js ecma/Date/15.9.5.10-10.js ecma/Date/15.9.5.10-11.js ecma/Date/15.9.5.10-12.js ecma/Date/15.9.5.10-13.js ecma/Date/15.9.5.10-2.js ecma/Date/15.9.5.10-3.js ecma/Date/15.9.5.10-4.js ecma/Date/15.9.5.10-5.js ecma/Date/15.9.5.10-6.js ecma/Date/15.9.5.10-7.js ecma/Date/15.9.5.10-8.js ecma/Date/15.9.5.10-9.js ecma/Date/15.9.5.12-1.js ecma/Date/15.9.5.12-2.js ecma/Date/15.9.5.12-3.js ecma/Date/15.9.5.12-4.js ecma/Date/15.9.5.12-5.js ecma/Date/15.9.5.12-6.js ecma/Date/15.9.5.12-7.js ecma/Date/15.9.5.28-1.js ecma/Date/15.9.5.29-1.js ecma/Date/15.9.5.35-1.js ecma/Date/15.9.5.8.js ecma/String/15.5.4.6-2.js Results for Mozilla tests: 25 regressions found. 0 tests fixed. 954595 1 217963 peavo 2013-11-27 12:24:22 -0800 Created attachment 217963 Patch 954596 2 peavo 2013-11-27 12:25:38 -0800 These are the results with the patch included: Results for Mozilla tests: 0 regressions found. 0 tests fixed. OK. 954597 3 peavo 2013-11-27 12:27:34 -0800 Also see bug 25160. 954600 4 217963 eflews.bot 2013-11-27 12:58:34 -0800 Comment on attachment 217963 Patch Attachment 217963 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/38598062 954604 5 peavo 2013-11-27 13:22:06 -0800 The efl-wk2 build seems to fail with an internal compiler error in a different file, so I don't think that is related to this patch. 954757 6 bfulgham 2013-11-28 09:22:44 -0800 Do these same failures happen under Apple's Windows port? It looks like there are 11 jscore errors, but I can't see what those errors arson the buildbots. Still, they can' t be the same just based on counts. Should we only use this code path for the WinCairo port? 955059 7 peavo 2013-11-30 00:52:42 -0800 (In reply to comment #6) > Do these same failures happen under Apple's Windows port? It looks like there are 11 jscore errors, but I can't see what those errors arson the buildbots. Still, they can' t be the same just based on counts. > > Should we only use this code path for the WinCairo port? Thanks for looking into this :) Yes, I get the exact same errors when running WinApple. The strange thing is that, when I change the timezone to e.g. California-time (UTC - 8.00, I think), there are no errors, both with, and without the patch. It seems the results depends on which timezone you are in, which might explain why we are seeing different results. With the patch, I get no errors in both timezones. To be on the safe side, I can make this patch WinCairo-only. Your call :) 955098 8 217963 bfulgham 2013-11-30 19:04:26 -0800 Comment on attachment 217963 Patch R=me 955099 9 217963 commit-queue 2013-11-30 19:30:57 -0800 Comment on attachment 217963 Patch Clearing flags on attachment: 217963 Committed r159892: <http://trac.webkit.org/changeset/159892> 955100 10 commit-queue 2013-11-30 19:30:59 -0800 All reviewed patches have been landed. Closing bug. 955133 11 bfulgham 2013-11-30 22:52:05 -0800 (In reply to comment #7) > (In reply to comment #6) > > Do these same failures happen under Apple's Windows port? It looks like there are 11 jscore errors, but I can't see what those errors arson the buildbots. Still, they can' t be the same just based on counts. > > > Thanks for looking into this :) > > Yes, I get the exact same errors when running WinApple. > > The strange thing is that, when I change the timezone to e.g. California-time (UTC - 8.00, I think), there are no errors, both with, and without the patch. > It seems the results depends on which timezone you are in, which might explain why we are seeing different results. > > With the patch, I get no errors in both timezones. > Very interesting. I wonder if this indicates a general weakness in our test coverage. All of our test bots live in California, and use that time zone. Thanks for catching this! 971190 12 dbates 2014-01-23 09:44:49 -0800 (In reply to comment #9) > (From update of attachment 217963 [details]) > Clearing flags on attachment: 217963 > > Committed r159892: <http://trac.webkit.org/changeset/159892> Using the data on the Flakiness Dashboard (*) as a starting point (**) and comparing the Windows {Debug, Release} expected results diffs, this commit regressed test LayoutTests/js/dom/date-big-constructor.html (*) <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fdate-big-constructor.html> (**) The Flakiness Dashboard only has data that shows the test passed in r159891 and failed since r159894. Looking at the commits in [r159891, r159894], <http://trac.webkit.org/changeset/159892> seemed relevant given that it's the only patch that touched code related to date logic. Moreover, the description of this bug is with regards to JavaScript date tests. 971191 13 webkit-bug-importer 2014-01-23 09:45:36 -0800 <rdar://problem/15892592> 971193 14 bfulgham 2014-01-23 09:47:07 -0800 Interesting! So we fixed ecma problems, but somehow broke a layout test? What is the layout test failure? Could it be that we had bad expectations checked in? 971200 15 dbates 2014-01-23 09:49:02 -0800 (In reply to comment #12) > (In reply to comment #9) > > (From update of attachment 217963 [details] [details]) > > Clearing flags on attachment: 217963 > > > > Committed r159892: <http://trac.webkit.org/changeset/159892> > > Using the data on the Flakiness Dashboard (*) as a starting point (**) and comparing the Windows {Debug, Release} expected results diffs, this commit regressed test LayoutTests/js/dom/date-big-constructor.html > > [...] Filed bug #127492 for the regression. 971203 16 dbates 2014-01-23 09:51:10 -0800 (In reply to comment #14) > Interesting! So we fixed ecma problems, but somehow broke a layout test? > Yes, according to the Flakiness Dashboard. > What is the layout test failure? Could it be that we had bad expectations checked in? Windows disagrees with the cross-platform expected results for the test. Windows Debug bot diff: <http://build.webkit.org/results/Apple%20Win%207%20Debug%20(Tests)/r162609%20(57442)/js/dom/date-big-constructor-pretty-diff.html> Window Release Bot diff (identical to the Windows Debug bot diff): <http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r162610%20(41968)/js/dom/date-big-constructor-pretty-diff.html> 217963 2013-11-27 12:24:22 -0800 2013-11-30 19:30:56 -0800 Patch bug-124946-20131127212408.patch text/plain 2483 peavo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTk4MjIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTExLTI3ICBwZWF2b0BvdXRsb29rLmNvbSAg PHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dIFNvbWUgSmF2YVNjcmlwdCBkYXRl IHRlc3RzIGFyZSBmYWlsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI0OTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXNlIG5hdGl2ZSBXaW4zMiBhcGkgZnVuY3Rpb25zIHRvIGNvbXB1dGUgRGF5 bGlnaHQgc2F2aW5nIHRpbWUgb2Zmc2V0LgorCisgICAgICAgICogd3RmL0RhdGVNYXRoLmNwcDoK KyAgICAgICAgKFdURjo6VW5peFRpbWVUb0ZpbGVUaW1lKTogQWRkZWQgbWV0aG9kIHRvIGNhbGN1 bGF0ZSBXaW4zMiBzcGVjaWZpYyBzdHJ1Y3QgRklMRVRJTUUgZnJvbSB0aW1lX3QgdmFsdWUuCisg ICAgICAgIChXVEY6OmNhbGN1bGF0ZURTVE9mZnNldCk6IFVzZSBuYXRpdmUgV2luMzIgYXBpIGZ1 bmN0aW9ucyB0byBjb21wdXRlIERheWxpZ2h0IHNhdmluZyB0aW1lIG9mZnNldC4KKwogMjAxMy0x MS0yNyAgVGFtYXMgR2VyZ2VseSAgPHRnZXJnZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5j b20+CiAKICAgICAgICAgUmVtb3ZlIFNwYXJjIHNwZWNpZmljIGNvZGUuCkluZGV4OiBTb3VyY2Uv V1RGL3d0Zi9EYXRlTWF0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvRGF0ZU1h dGguY3BwCShyZXZpc2lvbiAxNTk4MjApCisrKyBTb3VyY2UvV1RGL3d0Zi9EYXRlTWF0aC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQxMSw2ICs0MTEsMTkgQEAgc3RhdGljIGludDMyX3QgY2FsY3Vs YXRlVVRDT2Zmc2V0KCkKICNlbmRpZgogfQogCisjaWYgT1MoV0lORE9XUykKKy8vIENvZGUgdGFr ZW4gZnJvbSBodHRwOi8vc3VwcG9ydC5taWNyb3NvZnQuY29tL2tiLzE2NzI5Ngorc3RhdGljIHZv aWQgVW5peFRpbWVUb0ZpbGVUaW1lKHRpbWVfdCB0LCBMUEZJTEVUSU1FIHBmdCkKK3sKKyAgICAv LyBOb3RlIHRoYXQgTE9OR0xPTkcgaXMgYSA2NC1iaXQgdmFsdWUKKyAgICBMT05HTE9ORyBsbDsK KworICAgIGxsID0gSW50MzJ4MzJUbzY0KHQsIDEwMDAwMDAwKSArIDExNjQ0NDczNjAwMDAwMDAw MDsKKyAgICBwZnQtPmR3TG93RGF0ZVRpbWUgPSAoRFdPUkQpbGw7CisgICAgcGZ0LT5kd0hpZ2hE YXRlVGltZSA9IGxsID4+IDMyOworfQorI2VuZGlmCisKIC8qCiAgKiBHZXQgdGhlIERTVCBvZmZz ZXQgZm9yIHRoZSB0aW1lIHBhc3NlZCBpbi4KICAqLwpAQCAtNDIwLDYgKzQzMywyMiBAQCBzdGF0 aWMgZG91YmxlIGNhbGN1bGF0ZURTVE9mZnNldCh0aW1lX3QKICAgICBVTlVTRURfUEFSQU0obG9j YWxUaW1lKTsKICAgICBVTlVTRURfUEFSQU0odXRjT2Zmc2V0KTsKICAgICByZXR1cm4gMDsKKyNl bGlmIE9TKFdJTkRPV1MpCisgICAgRklMRVRJTUUgdXRjRmlsZVRpbWU7CisgICAgVW5peFRpbWVU b0ZpbGVUaW1lKGxvY2FsVGltZSwgJnV0Y0ZpbGVUaW1lKTsKKyAgICBTWVNURU1USU1FIHV0Y1N5 c3RlbVRpbWUsIGxvY2FsU3lzdGVtVGltZTsKKyAgICBGaWxlVGltZVRvU3lzdGVtVGltZSgmdXRj RmlsZVRpbWUsICZ1dGNTeXN0ZW1UaW1lKTsKKyAgICBTeXN0ZW1UaW1lVG9UelNwZWNpZmljTG9j YWxUaW1lKDAsICZ1dGNTeXN0ZW1UaW1lLCAmbG9jYWxTeXN0ZW1UaW1lKTsKKworICAgIGRvdWJs ZSBvZmZzZXRUaW1lID0gKGxvY2FsVGltZSAqIG1zUGVyU2Vjb25kKSArIHV0Y09mZnNldDsKKwor ICAgIC8vIE9mZnNldCBmcm9tIFVUQyBidXQgZG9lc24ndCBpbmNsdWRlIERTVCBvYnZpb3VzbHkK KyAgICBpbnQgb2Zmc2V0SG91ciA9ICBtc1RvSG91cnMob2Zmc2V0VGltZSk7CisgICAgaW50IG9m ZnNldE1pbnV0ZSA9ICBtc1RvTWludXRlcyhvZmZzZXRUaW1lKTsKKworICAgIGRvdWJsZSBkaWZm ID0gKChsb2NhbFN5c3RlbVRpbWUud0hvdXIgLSBvZmZzZXRIb3VyKSAqIHNlY29uZHNQZXJIb3Vy KSArICgobG9jYWxTeXN0ZW1UaW1lLndNaW51dGUgLSBvZmZzZXRNaW51dGUpICogNjApOworCisg ICAgcmV0dXJuIGRpZmYgKiBtc1BlclNlY29uZDsKICNlbHNlCiAgICAgLy9pbnB1dCBpcyBVVEMg c28gd2UgaGF2ZSB0byBzaGlmdCBiYWNrIHRvIGxvY2FsIHRpbWUgdG8gZGV0ZXJtaW5lIERTVCB0 aHVzIHRoZSArIGdldFVUQ09mZnNldCgpCiAgICAgZG91YmxlIG9mZnNldFRpbWUgPSAobG9jYWxU aW1lICogbXNQZXJTZWNvbmQpICsgdXRjT2Zmc2V0Owo=