124943 2013-11-27 08:35:27 -0800 Checkout should own the scm object in Host 2013-11-28 05:43:49 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbatyai.u-szeged webkit-unassigned commit-queue glenn rniwa oldest_to_newest 954559 0 dbatyai.u-szeged 2013-11-27 08:35:27 -0800 Checkout should own the scm object in common/host.py 954560 1 217955 dbatyai.u-szeged 2013-11-27 08:36:10 -0800 Created attachment 217955 Proposed patch 954684 2 217955 rniwa 2013-11-28 02:36:02 -0800 Comment on attachment 217955 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=217955&action=review > Tools/Scripts/webkitpy/common/host.py:82 > + scm = detector.default_scm(patch_directories) > + self._checkout = Checkout(scm) It seems like Checkout's constructor could simply take patch_directories. If not, we could do all of this in one line. 954693 3 217989 dbatyai.u-szeged 2013-11-28 05:05:17 -0800 Created attachment 217989 Proposed patch 954705 4 217989 commit-queue 2013-11-28 05:43:48 -0800 Comment on attachment 217989 Proposed patch Clearing flags on attachment: 217989 Committed r159838: <http://trac.webkit.org/changeset/159838> 954706 5 commit-queue 2013-11-28 05:43:49 -0800 All reviewed patches have been landed. Closing bug. 217955 2013-11-27 08:36:10 -0800 2013-11-28 05:04:41 -0800 Proposed patch proposedpatch.patch text/plain 1644 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNDc3 ZjFjLi40YWZhZWQ2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTEtMjcgIETDoW5pZWwgQsOhdHlhaSAgPEJh dHlhaS5EYW5pZWxAc3R1ZC51LXN6ZWdlZC5odT4KKworICAgICAgICBDaGVja291dCBzaG91bGQg b3duIHRoZSBzY20gb2JqZWN0IGluIEhvc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNDk0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weToKKyAg ICAgICAgKEhvc3QuX19pbml0X18pOgorICAgICAgICAoSG9zdC5pbml0aWFsaXplX3NjbSk6Cisg ICAgICAgIChIb3N0LnNjbSk6CisKIDIwMTMtMTEtMjYgIETDoW5pZWwgQsOhdHlhaSAgPEJhdHlh aS5EYW5pZWxAc3R1ZC51LXN6ZWdlZC5odT4KIAogICAgICAgICBNb3ZlZCBtZXRob2RzIHdoaWNo IGJlbG9uZyB0byBDaGVja291dCBpbnRvIGNoZWNrb3V0LnB5CmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vaG9zdC5weQppbmRleCAwMjJjMTNiLi5mMDI2OGU2IDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2hvc3QucHkKQEAgLTQ4LDggKzQ4LDYgQEAgY2xhc3MgSG9zdChTeXN0ZW1Ib3N0 KToKICAgICAgICAgU3lzdGVtSG9zdC5fX2luaXRfXyhzZWxmKQogICAgICAgICBzZWxmLndlYiA9 IHdlYi5XZWIoKQogCi0gICAgICAgICMgRklYTUU6IENoZWNrb3V0IHNob3VsZCBvd24gdGhlIHNj bSBvYmplY3QuCi0gICAgICAgIHNlbGYuX3NjbSA9IE5vbmUKICAgICAgICAgc2VsZi5fY2hlY2tv dXQgPSBOb25lCiAKICAgICAgICAgIyBFdmVyeXRoaW5nIGJlbG93IHRoaXMgbGluZSBpcyBXZWJL aXQtc3BlY2lmaWMgYW5kIGJlbG9uZ3Mgb24gYSBoaWdoZXItbGV2ZWwgb2JqZWN0LgpAQCAtODAs MTEgKzc4LDExIEBAIGNsYXNzIEhvc3QoU3lzdGVtSG9zdCk6CiAKICAgICBkZWYgaW5pdGlhbGl6 ZV9zY20oc2VsZiwgcGF0Y2hfZGlyZWN0b3JpZXM9Tm9uZSk6CiAgICAgICAgIGRldGVjdG9yID0g U0NNRGV0ZWN0b3Ioc2VsZi5maWxlc3lzdGVtLCBzZWxmLmV4ZWN1dGl2ZSkKLSAgICAgICAgc2Vs Zi5fc2NtID0gZGV0ZWN0b3IuZGVmYXVsdF9zY20ocGF0Y2hfZGlyZWN0b3JpZXMpCi0gICAgICAg IHNlbGYuX2NoZWNrb3V0ID0gQ2hlY2tvdXQoc2VsZi5zY20oKSkKKyAgICAgICAgc2NtID0gZGV0 ZWN0b3IuZGVmYXVsdF9zY20ocGF0Y2hfZGlyZWN0b3JpZXMpCisgICAgICAgIHNlbGYuX2NoZWNr b3V0ID0gQ2hlY2tvdXQoc2NtKQogCiAgICAgZGVmIHNjbShzZWxmKToKLSAgICAgICAgcmV0dXJu IHNlbGYuX3NjbQorICAgICAgICByZXR1cm4gc2VsZi5fY2hlY2tvdXQuX3NjbQogCiAgICAgZGVm IGNoZWNrb3V0KHNlbGYpOgogICAgICAgICByZXR1cm4gc2VsZi5fY2hlY2tvdXQK 217989 2013-11-28 05:05:17 -0800 2013-11-28 05:43:48 -0800 Proposed patch proposedpatch.patch text/plain 1593 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlNmE5 NzM1Li5hZTllNjUxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTEtMjggIETDoW5pZWwgQsOhdHlhaSAgPEJh dHlhaS5EYW5pZWxAc3R1ZC51LXN6ZWdlZC5odT4KKworICAgICAgICBDaGVja291dCBzaG91bGQg b3duIHRoZSBzY20gb2JqZWN0IGluIEhvc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNDk0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weToKKyAg ICAgICAgKEhvc3QuX19pbml0X18pOgorICAgICAgICAoSG9zdC5pbml0aWFsaXplX3NjbSk6Cisg ICAgICAgIChIb3N0LnNjbSk6CisKIDIwMTMtMTEtMjYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFw cGxlLmNvbT4KIAogICAgICAgICBEbyBieXRlY29kZSB2YWxpZGF0aW9uIGFzIHBhcnQgb2YgdGVz dGluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2hvc3QucHkKaW5kZXggMDIyYzEzYi4uOGNk MDM4YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5CkBAIC00OCw4ICs0OCw2 IEBAIGNsYXNzIEhvc3QoU3lzdGVtSG9zdCk6CiAgICAgICAgIFN5c3RlbUhvc3QuX19pbml0X18o c2VsZikKICAgICAgICAgc2VsZi53ZWIgPSB3ZWIuV2ViKCkKIAotICAgICAgICAjIEZJWE1FOiBD aGVja291dCBzaG91bGQgb3duIHRoZSBzY20gb2JqZWN0LgotICAgICAgICBzZWxmLl9zY20gPSBO b25lCiAgICAgICAgIHNlbGYuX2NoZWNrb3V0ID0gTm9uZQogCiAgICAgICAgICMgRXZlcnl0aGlu ZyBiZWxvdyB0aGlzIGxpbmUgaXMgV2ViS2l0LXNwZWNpZmljIGFuZCBiZWxvbmdzIG9uIGEgaGln aGVyLWxldmVsIG9iamVjdC4KQEAgLTgwLDExICs3OCwxMCBAQCBjbGFzcyBIb3N0KFN5c3RlbUhv c3QpOgogCiAgICAgZGVmIGluaXRpYWxpemVfc2NtKHNlbGYsIHBhdGNoX2RpcmVjdG9yaWVzPU5v bmUpOgogICAgICAgICBkZXRlY3RvciA9IFNDTURldGVjdG9yKHNlbGYuZmlsZXN5c3RlbSwgc2Vs Zi5leGVjdXRpdmUpCi0gICAgICAgIHNlbGYuX3NjbSA9IGRldGVjdG9yLmRlZmF1bHRfc2NtKHBh dGNoX2RpcmVjdG9yaWVzKQotICAgICAgICBzZWxmLl9jaGVja291dCA9IENoZWNrb3V0KHNlbGYu c2NtKCkpCisgICAgICAgIHNlbGYuX2NoZWNrb3V0ID0gQ2hlY2tvdXQoZGV0ZWN0b3IuZGVmYXVs dF9zY20ocGF0Y2hfZGlyZWN0b3JpZXMpKQogCiAgICAgZGVmIHNjbShzZWxmKToKLSAgICAgICAg cmV0dXJuIHNlbGYuX3NjbQorICAgICAgICByZXR1cm4gc2VsZi5fY2hlY2tvdXQuX3NjbQogCiAg ICAgZGVmIGNoZWNrb3V0KHNlbGYpOgogICAgICAgICByZXR1cm4gc2VsZi5fY2hlY2tvdXQK