124936 2013-11-27 06:11:36 -0800 moveDoubleToInts should be used in SpecializedThunkJIT::returnDouble 2013-11-29 09:23:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fpizlo ggaren mark.lam msaboff oliver zherczeg oldest_to_newest 954524 0 jbriance 2013-11-27 06:11:36 -0800 In current SpecializedThunkJIT::returnDouble of JSVALUE32_64 ports, moveDoubleToInts function from macro assembler is likely to be more efficient than the current generic implementation using the stack. 954526 1 217946 jbriance 2013-11-27 06:13:08 -0800 Created attachment 217946 Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for JSVALUE32_64 ports. 954964 2 zherczeg 2013-11-29 06:34:15 -0800 I suspect the point of the original code to avoid changing of src, which is returned by returnDouble(...). We might need to keep the original code path on x86. 954965 3 jbriance 2013-11-29 06:38:59 -0800 (In reply to comment #2) > I suspect the point of the original code to avoid changing of src, which is returned by returnDouble(...). We might need to keep the original code path on x86. You're right, I didn't see that, thanks. I'm going to check all 32-bit architectures moveDoubleToInts then submit a new patch with #if CPU(xx) condition. 954987 4 218068 jbriance 2013-11-29 08:24:44 -0800 Created attachment 218068 Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports. 954992 5 218068 zherczeg 2013-11-29 08:56:24 -0800 Comment on attachment 218068 Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports. nice patch. r=me 954997 6 218068 commit-queue 2013-11-29 09:23:18 -0800 Comment on attachment 218068 Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports. Clearing flags on attachment: 218068 Committed r159873: <http://trac.webkit.org/changeset/159873> 954998 7 commit-queue 2013-11-29 09:23:21 -0800 All reviewed patches have been landed. Closing bug. 217946 2013-11-27 06:13:08 -0800 2013-11-29 06:39:13 -0800 Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for JSVALUE32_64 ports. bug-124936.patch text/plain 1806 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5ODExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTExLTI3ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFVzZSBtb3ZlRG91YmxlVG9JbnRzIGluIFNwZWNpYWxpemVkVGh1bmtKSVQ6OnJldHVy bkRvdWJsZSBmb3IgSlNWQUxVRTMyXzY0IHBvcnRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0OTM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG1vdmVEb3VibGVUb0ludHMgZnVuY3Rpb24gZnJv bSBtYWNybyBhc3NlbWJsZXIgaXMgbGlrZWx5IHRvIGJlIG1vcmUgZWZmaWNpZW50CisgICAgICAg IHRoYW4gdGhlIGN1cnJlbnQgZ2VuZXJpYyBpbXBsZW1lbnRhdGlvbiB1c2luZyB0aGUgc3RhY2su CisKKyAgICAgICAgKiBqaXQvU3BlY2lhbGl6ZWRUaHVua0pJVC5oOgorICAgICAgICAoSlNDOjpT cGVjaWFsaXplZFRodW5rSklUOjpyZXR1cm5Eb3VibGUpOgorCiAyMDEzLTExLTI2ICBGaWxpcCBQ aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVzdHJ1Y3R1cmUgZ2xvYmFsIHZh cmlhYmxlIGNvbnN0YW50IGluZmVyZW5jZSBzbyB0aGF0IGl0IGNvdWxkIHdvcmsgZm9yIGFueSBr aW5kIG9mIHN5bWJvbCB0YWJsZSB2YXJpYWJsZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9TcGVjaWFsaXplZFRodW5rSklULmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9TcGVjaWFsaXplZFRodW5rSklULmgJKHJldmlzaW9uIDE1OTgwNykKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvU3BlY2lhbGl6ZWRUaHVua0pJVC5oCSh3b3JraW5nIGNv cHkpCkBAIC0xMjEsOSArMTIxLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAgICBtb3Zl KHRhZ1R5cGVOdW1iZXJSZWdpc3RlciwgcmVnVDApOwogICAgICAgICAgICAgZG9uZS5saW5rKHRo aXMpOwogI2Vsc2UKLSAgICAgICAgICAgIHN0b3JlRG91YmxlKHNyYywgQWRkcmVzcyhzdGFja1Bv aW50ZXJSZWdpc3RlciwgLShpbnQpc2l6ZW9mKGRvdWJsZSkpKTsKLSAgICAgICAgICAgIGxvYWRQ dHIoQWRkcmVzcyhzdGFja1BvaW50ZXJSZWdpc3RlciwgT0JKRUNUX09GRlNFVE9GKEpTVmFsdWUs IHUuYXNCaXRzLnRhZykgLSBzaXplb2YoZG91YmxlKSksIHJlZ1QxKTsKLSAgICAgICAgICAgIGxv YWRQdHIoQWRkcmVzcyhzdGFja1BvaW50ZXJSZWdpc3RlciwgT0JKRUNUX09GRlNFVE9GKEpTVmFs dWUsIHUuYXNCaXRzLnBheWxvYWQpIC0gc2l6ZW9mKGRvdWJsZSkpLCByZWdUMCk7CisgICAgICAg ICAgICBtb3ZlRG91YmxlVG9JbnRzKHNyYywgcmVnVDAsIHJlZ1QxKTsKICAgICAgICAgICAgIEp1 bXAgbG93Tm9uWmVybyA9IGJyYW5jaFRlc3RQdHIoTm9uWmVybywgcmVnVDEpOwogICAgICAgICAg ICAgSnVtcCBoaWdoTm9uWmVybyA9IGJyYW5jaFRlc3RQdHIoTm9uWmVybywgcmVnVDApOwogICAg ICAgICAgICAgbW92ZShUcnVzdGVkSW1tMzIoMCksIHJlZ1QwKTsK 218068 2013-11-29 08:24:44 -0800 2013-11-29 09:23:18 -0800 Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports. bug-124936_2.patch text/plain 2030 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5ODcyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEzLTExLTI5ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFVzZSBtb3ZlRG91YmxlVG9JbnRzIGluIFNwZWNpYWxpemVkVGh1bmtKSVQ6OnJldHVy bkRvdWJsZSBmb3Igbm9uLVg4NiBKU1ZBTFVFMzJfNjQgcG9ydHMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ5MzYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbW92ZURvdWJsZVRvSW50cyBpbXBs ZW1lbnRhdGlvbnMgaW4gQVJNLCBNSVBTIGFuZCBTSDQgbWFjcm8gYXNzZW1ibGVycyBkbyBub3Qg Y2xvYmJlcgorICAgICAgICBzcmMgRlBSZWdpc3RlciBhbmQgYXJlIGxpa2VseSB0byBiZSBtb3Jl IGVmZmljaWVudCB0aGFuIHRoZSBjdXJyZW50IGdlbmVyaWMgaW1wbGVtZW50YXRpb24KKyAgICAg ICAgdXNpbmcgdGhlIHN0YWNrLgorCisgICAgICAgICogaml0L1NwZWNpYWxpemVkVGh1bmtKSVQu aDoKKyAgICAgICAgKEpTQzo6U3BlY2lhbGl6ZWRUaHVua0pJVDo6cmV0dXJuRG91YmxlKToKKwog MjAxMy0xMS0yOSAgSnVsaWVuIEJyaWFuY2VhdSAgPGpicmlhbmNlQGNpc2NvLmNvbT4KIAogICAg ICAgICBNZXJnZSBhcm0gYW5kIHNoNCBwYXRocyBpbiBuYXRpdmVGb3JHZW5lcmF0b3IgYW5kIHBy aXZhdGVDb21waWxlQ1RJTmF0aXZlQ2FsbCBmdW5jdGlvbnMuCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L1NwZWNpYWxpemVkVGh1bmtKSVQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L1NwZWNpYWxpemVkVGh1bmtKSVQuaAkocmV2aXNpb24gMTU5ODcx KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9TcGVjaWFsaXplZFRodW5rSklULmgJKHdv cmtpbmcgY29weSkKQEAgLTEyMSw5ICsxMjEsMTQgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAg ICAgICBtb3ZlKHRhZ1R5cGVOdW1iZXJSZWdpc3RlciwgcmVnVDApOwogICAgICAgICAgICAgZG9u ZS5saW5rKHRoaXMpOwogI2Vsc2UKKyNpZiAhQ1BVKFg4NikKKyAgICAgICAgICAgIC8vIFRoZSBz cmMgcmVnaXN0ZXIgaXMgbm90IGNsb2JiZXJlZCBieSBtb3ZlRG91YmxlVG9JbnRzIHdpdGggQVJN LCBNSVBTIGFuZCBTSDQgbWFjcm8gYXNzZW1ibGVycywgc28gbGV0J3MgdXNlIGl0LgorICAgICAg ICAgICAgbW92ZURvdWJsZVRvSW50cyhzcmMsIHJlZ1QwLCByZWdUMSk7CisjZWxzZQogICAgICAg ICAgICAgc3RvcmVEb3VibGUoc3JjLCBBZGRyZXNzKHN0YWNrUG9pbnRlclJlZ2lzdGVyLCAtKGlu dClzaXplb2YoZG91YmxlKSkpOwogICAgICAgICAgICAgbG9hZFB0cihBZGRyZXNzKHN0YWNrUG9p bnRlclJlZ2lzdGVyLCBPQkpFQ1RfT0ZGU0VUT0YoSlNWYWx1ZSwgdS5hc0JpdHMudGFnKSAtIHNp emVvZihkb3VibGUpKSwgcmVnVDEpOwogICAgICAgICAgICAgbG9hZFB0cihBZGRyZXNzKHN0YWNr UG9pbnRlclJlZ2lzdGVyLCBPQkpFQ1RfT0ZGU0VUT0YoSlNWYWx1ZSwgdS5hc0JpdHMucGF5bG9h ZCkgLSBzaXplb2YoZG91YmxlKSksIHJlZ1QwKTsKKyNlbmRpZgogICAgICAgICAgICAgSnVtcCBs b3dOb25aZXJvID0gYnJhbmNoVGVzdFB0cihOb25aZXJvLCByZWdUMSk7CiAgICAgICAgICAgICBK dW1wIGhpZ2hOb25aZXJvID0gYnJhbmNoVGVzdFB0cihOb25aZXJvLCByZWdUMCk7CiAgICAgICAg ICAgICBtb3ZlKFRydXN0ZWRJbW0zMigwKSwgcmVnVDApOwo=