124918 2013-11-27 02:00:13 -0800 Style checker requires alphabetical ordering in cmake lists even it contains variable. 2013-12-04 05:46:50 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gbalogh.u-szeged webkit-unassigned commit-queue glenn oldest_to_newest 954478 0 gbalogh.u-szeged 2013-11-27 02:00:13 -0800 For example: ${foo} ${bar} is bad ${bar} ${foo} is ok 954482 1 217931 gbalogh.u-szeged 2013-11-27 02:11:31 -0800 Created attachment 217931 patch 954670 2 217984 gbalogh.u-szeged 2013-11-27 23:49:40 -0800 Created attachment 217984 patch 955854 3 217984 ossy 2013-12-03 04:17:34 -0800 Comment on attachment 217984 patch This patch looks good to me, but could you add a unittest for this change? 956352 4 218398 gbalogh.u-szeged 2013-12-04 04:15:51 -0800 Created attachment 218398 patch unittest updated 956353 5 218399 gbalogh.u-szeged 2013-12-04 04:23:56 -0800 Created attachment 218399 patch 956363 6 218399 ossy 2013-12-04 05:19:24 -0800 Comment on attachment 218399 patch r=me 956368 7 218399 commit-queue 2013-12-04 05:46:48 -0800 Comment on attachment 218399 patch Clearing flags on attachment: 218399 Committed r160090: <http://trac.webkit.org/changeset/160090> 956369 8 commit-queue 2013-12-04 05:46:50 -0800 All reviewed patches have been landed. Closing bug. 217931 2013-11-27 02:11:31 -0800 2013-11-27 23:49:40 -0800 patch f2604.diff text/plain 1599 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL0NNYWtlTGlzdHMudHh0IGIvQ01ha2VMaXN0cy50eHQKaW5kZXggYmEzZjUw OC4uMTBmODUwNSAxMDA2NDQKLS0tIGEvQ01ha2VMaXN0cy50eHQKKysrIGIvQ01ha2VMaXN0cy50 eHQKQEAgLTEsMTIgKzEsNiBAQAogY21ha2VfbWluaW11bV9yZXF1aXJlZChWRVJTSU9OIDIuOC4z KQogcHJvamVjdChXZWJLaXQpCiAKLSMtLS0tLS0tY2hlY2tzdHlsZSBkZWJ1Zwotc2V0KEZPTwot ICAgICR7emFhen0KLSAgICAke3JhYXJ9KQotCi0KICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMg RGVmYXVsdCBsaWJyYXJ5IHR5cGUKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1OWIwZWRhLi45YjBlMmI0 IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTMtMTEtMjcgIEdlcmdvIEJhbG9naCAgPGdlcnl4eXpAaW5mLnUtc3pl Z2VkLmh1PgorCisgICAgICAgIFN0eWxlIGNoZWNrZXIgcmVxdWlyZXMgYWxwaGFiZXRpY2FsIG9y ZGVyaW5nIGluIGNtYWtlIGxpc3RzIGV2ZW4gaXQgY29udGFpbnMgdmFyaWFibGUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ5MTgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY21ha2UucHk6CisgICAgICAgIChDTWFrZUNoZWNrZXIuX2NoZWNr X2xpc3Rfb3JkZXIpOgorICAgICAgICBUaGlzIHdpbGwgaWdub3JlIGxpbmVzIHdpdGggdmFyaWFi bGUgc3Vic3RpdHV0aW9uLgorCiAyMDEzLTExLTIxICBQZXRlciBNb2xuYXIgIDxwbW9sbmFyLnUt c3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmVtb3ZlIEVOQUJMRV9XT1JL RVJTCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nt YWtlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jbWFrZS5weQpp bmRleCA1NTU2ZjBlLi5lNDEyMzZiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NtYWtlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY21ha2UucHkKQEAgLTE1Myw2ICsxNTMsOSBAQCBjbGFzcyBDTWFrZUNoZWNr ZXIob2JqZWN0KToKIAogICAgICAgICBsaW5lX251bWJlciA9IDAKICAgICAgICAgZm9yIGxpbmUg aW4gbGluZXM6CisgICAgICAgICAgICBtYXRjaGVkID0gc2VhcmNoKCdcJFx7LipcfScsIGxpbmUp CisgICAgICAgICAgICBpZiBtYXRjaGVkOgorICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAg ICAgICAgICBsaW5lX251bWJlciArPSAxCiAgICAgICAgICAgICBsaW5lID0gbGluZS5zdHJpcCgp CiAK 217984 2013-11-27 23:49:40 -0800 2013-12-04 04:15:51 -0800 patch f2604.diff text/plain 1155 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1OWIw ZWRhLi45YjBlMmI0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMTEtMjcgIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFN0eWxlIGNoZWNrZXIgcmVxdWlyZXMgYWxw aGFiZXRpY2FsIG9yZGVyaW5nIGluIGNtYWtlIGxpc3RzIGV2ZW4gaXQgY29udGFpbnMgdmFyaWFi bGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ5 MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2UucHk6CisgICAgICAgIChDTWFrZUNo ZWNrZXIuX2NoZWNrX2xpc3Rfb3JkZXIpOgorICAgICAgICBUaGlzIHdpbGwgaWdub3JlIGxpbmVz IHdpdGggdmFyaWFibGUgc3Vic3RpdHV0aW9uLgorCiAyMDEzLTExLTIxICBQZXRlciBNb2xuYXIg IDxwbW9sbmFyLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmVtb3Zl IEVOQUJMRV9XT1JLRVJTCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NtYWtlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jbWFrZS5weQppbmRleCA1NTU2ZjBlLi5lNDEyMzZiIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NtYWtlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2UucHkKQEAgLTE1Myw2ICsxNTMsOSBAQCBjbGFz cyBDTWFrZUNoZWNrZXIob2JqZWN0KToKIAogICAgICAgICBsaW5lX251bWJlciA9IDAKICAgICAg ICAgZm9yIGxpbmUgaW4gbGluZXM6CisgICAgICAgICAgICBtYXRjaGVkID0gc2VhcmNoKCdcJFx7 LipcfScsIGxpbmUpCisgICAgICAgICAgICBpZiBtYXRjaGVkOgorICAgICAgICAgICAgICAgIGNv bnRpbnVlCiAgICAgICAgICAgICBsaW5lX251bWJlciArPSAxCiAgICAgICAgICAgICBsaW5lID0g bGluZS5zdHJpcCgpCiAK 218398 2013-12-04 04:15:51 -0800 2013-12-04 04:23:56 -0800 patch f2604.test.diff text/plain 1851 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxODU0 ZDI5Li42MDM0MzdmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTMtMTItMDQgIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFN0eWxlIGNoZWNrZXIgcmVxdWlyZXMgYWxw aGFiZXRpY2FsIG9yZGVyaW5nIGluIGNtYWtlIGxpc3RzIGV2ZW4gaXQgY29udGFpbnMgdmFyaWFi bGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ5 MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2VfdW5pdHRlc3QucHk6CisgICAgICAg IChDTWFrZUNoZWNrZXJUZXN0LnRlc3RfY2hlY2spOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY21ha2UucHk6CisgICAgICAgIChDTWFrZUNoZWNrZXIuX2NoZWNr X2xpc3Rfb3JkZXIpOgorICAgICAgICBUaGlzIHdpbGwgaWdub3JlIGxpbmVzIHdpdGggdmFyaWFi bGUgc3Vic3RpdHV0aW9uLgorCiAyMDEzLTEyLTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgcnVuLWpzYy1zdHJlc3MtdGVzdHMgc2hvdWxkIGFsbG93IGZvciB0 ZXN0cyB0aGF0IGhhdmUgYSBkaXJlY3RvcnkgY29udGFpbmluZyAuanMgZmlsZXMgbmVzdGVkIHdp dGhpbiBhIGRpcmVjdG9yeSBjb250YWluaW5nIHRoZSBkYXRhCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NtYWtlLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jbWFrZS5weQppbmRleCA1NTU2ZjBlLi5lNDEyMzZiIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NtYWtlLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2UucHkKQEAg LTE1Myw2ICsxNTMsOSBAQCBjbGFzcyBDTWFrZUNoZWNrZXIob2JqZWN0KToKIAogICAgICAgICBs aW5lX251bWJlciA9IDAKICAgICAgICAgZm9yIGxpbmUgaW4gbGluZXM6CisgICAgICAgICAgICBt YXRjaGVkID0gc2VhcmNoKCdcJFx7LipcfScsIGxpbmUpCisgICAgICAgICAgICBpZiBtYXRjaGVk OgorICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgICAgICBsaW5lX251bWJlciArPSAx CiAgICAgICAgICAgICBsaW5lID0gbGluZS5zdHJpcCgpCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2VfdW5pdHRlc3QucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NtYWtlX3VuaXR0ZXN0LnB5CmluZGV4IDkw Y2I3N2IuLmMwMzRmOGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY21ha2VfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jbWFrZV91bml0dGVzdC5weQpAQCAtOTAsNiArOTAsNyBAQCBjbGFzcyBD TWFrZUNoZWNrZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgICdjL2EuYVxu JywKICAgICAgICAgICAgICdcbicsCiAgICAgICAgICAgICAnYy9iL2EuYVxuJywKKyAgICAgICAg ICAgICcke2FWYXJpYWJsZX1cbicsCiAgICAgICAgICAgICAnXG4nLAogICAgICAgICAgICAgJ2Mv Yy5jXG4nLAogICAgICAgICAgICAgJ1xuJywK 218399 2013-12-04 04:23:56 -0800 2013-12-04 05:46:48 -0800 patch f2604.test.diff text/plain 1851 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxODU0 ZDI5Li4wN2E3ZWM2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTItMDQgIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFN0eWxlIGNoZWNrZXIgcmVxdWlyZXMgYWxw aGFiZXRpY2FsIG9yZGVyaW5nIGluIGNtYWtlIGxpc3RzIGV2ZW4gaXQgY29udGFpbnMgdmFyaWFi bGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ5 MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2VfdW5pdHRlc3QucHk6CisgICAgICAg IChDTWFrZUNoZWNrZXJUZXN0LnRlc3RfY2hlY2spOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY21ha2UucHk6CisgICAgICAgIChDTWFrZUNoZWNrZXIuX2NoZWNr X2xpc3Rfb3JkZXIpOgorICAgICAgICBUaGlzIHdpbGwgaWdub3JlIGxpbmVzIHdpdGggdmFyaWFi bGUgc3Vic3RpdHV0aW9uLgorCiAyMDEzLTEyLTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgcnVuLWpzYy1zdHJlc3MtdGVzdHMgc2hvdWxkIGFsbG93IGZvciB0 ZXN0cyB0aGF0IGhhdmUgYSBkaXJlY3RvcnkgY29udGFpbmluZyAuanMgZmlsZXMgbmVzdGVkIHdp dGhpbiBhIGRpcmVjdG9yeSBjb250YWluaW5nIHRoZSBkYXRhCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NtYWtlLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jbWFrZS5weQppbmRleCA1NTU2ZjBlLi5lNDEyMzZiIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NtYWtlLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2UucHkKQEAg LTE1Myw2ICsxNTMsOSBAQCBjbGFzcyBDTWFrZUNoZWNrZXIob2JqZWN0KToKIAogICAgICAgICBs aW5lX251bWJlciA9IDAKICAgICAgICAgZm9yIGxpbmUgaW4gbGluZXM6CisgICAgICAgICAgICBt YXRjaGVkID0gc2VhcmNoKCdcJFx7LipcfScsIGxpbmUpCisgICAgICAgICAgICBpZiBtYXRjaGVk OgorICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgICAgICBsaW5lX251bWJlciArPSAx CiAgICAgICAgICAgICBsaW5lID0gbGluZS5zdHJpcCgpCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2VfdW5pdHRlc3QucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NtYWtlX3VuaXR0ZXN0LnB5CmluZGV4IDkw Y2I3N2IuLmMwMzRmOGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY21ha2VfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jbWFrZV91bml0dGVzdC5weQpAQCAtOTAsNiArOTAsNyBAQCBjbGFzcyBD TWFrZUNoZWNrZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgICdjL2EuYVxu JywKICAgICAgICAgICAgICdcbicsCiAgICAgICAgICAgICAnYy9iL2EuYVxuJywKKyAgICAgICAg ICAgICcke2FWYXJpYWJsZX1cbicsCiAgICAgICAgICAgICAnXG4nLAogICAgICAgICAgICAgJ2Mv Yy5jXG4nLAogICAgICAgICAgICAgJ1xuJywK