124899 2013-11-26 13:20:20 -0800 [cmake] Fix cmake warning: Argument not separated from preceding token by whitespace 2013-11-29 02:49:11 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lvidacs.u-szeged webkit-unassigned commit-queue galpeter gyuyoung.kim lvidacs.u-szeged rakuco oldest_to_newest 954332 0 lvidacs.u-szeged 2013-11-26 13:20:20 -0800 Fix cmake (v2.8.11+) warnings like: CMake Warning (dev) at Source/cmake/OptionsEfl.cmake:172 (find_package): Syntax Warning in cmake code at /home/elecro/work/webkit/WebKit/Source/cmake/FindGStreamer.cmake:97:45 Argument not separated from preceding token by whitespace. Call Stack (most recent call first): CMakeLists.txt:137 (include) This warning is for project developers. Use -Wno-dev to suppress it. 954341 1 217900 lvidacs.u-szeged 2013-11-26 14:12:09 -0800 Created attachment 217900 Patch 954672 2 galpeter 2013-11-28 00:18:56 -0800 LGTM (sadly I'm not a reviewer :( ) 954673 3 217900 ryuan.choi 2013-11-28 00:23:28 -0800 Comment on attachment 217900 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217900&action=review > Source/cmake/FindGStreamer.cmake:97 > - message(FATAL_ERROR "Required version ("${GStreamer_FIND_VERSION}") is higher than found version ("${GSTREAMER_VERSION}")") > + message(FATAL_ERROR "Required version (" ${GStreamer_FIND_VERSION} ") is higher than found version (" ${GSTREAMER_VERSION} ")") Just removing " is also fine. 954923 4 217900 commit-queue 2013-11-29 02:49:09 -0800 Comment on attachment 217900 Patch Clearing flags on attachment: 217900 Committed r159866: <http://trac.webkit.org/changeset/159866> 954924 5 commit-queue 2013-11-29 02:49:11 -0800 All reviewed patches have been landed. Closing bug. 217900 2013-11-26 14:12:09 -0800 2013-11-29 02:49:09 -0800 Patch bug-124899-20131126231206.patch text/plain 1988 lvidacs.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZENhaXJvLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRDYWlyby5jbWFrZQppbmRleCBjMjg5YjNi ZjhiNDI4ZjFiMTU4ZGFiOWQwZjc3MzM3MTAxNzQwNTVkLi4wYTJkYmQ2YWNjYjZjNTExNmNkOWZl ZmE5NDhhNmFmYzFjYWMwMGFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZENhaXJvLmNt YWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kQ2Fpcm8uY21ha2UKQEAgLTYyLDcgKzYyLDcgQEAg aWYgKENBSVJPX0lOQ0xVREVfRElSUykKIGVuZGlmICgpCiAKIGlmICgiJHtDYWlyb19GSU5EX1ZF UlNJT059IiBWRVJTSU9OX0dSRUFURVIgIiR7Q0FJUk9fVkVSU0lPTn0iKQotICAgIG1lc3NhZ2Uo RkFUQUxfRVJST1IgIlJlcXVpcmVkIHZlcnNpb24gKCIke0NhaXJvX0ZJTkRfVkVSU0lPTn0iKSBp cyBoaWdoZXIgdGhhbiBmb3VuZCB2ZXJzaW9uICgiJHtDQUlST19WRVJTSU9OfSIpIikKKyAgICBt ZXNzYWdlKEZBVEFMX0VSUk9SICJSZXF1aXJlZCB2ZXJzaW9uICgiICR7Q2Fpcm9fRklORF9WRVJT SU9OfSAiKSBpcyBoaWdoZXIgdGhhbiBmb3VuZCB2ZXJzaW9uICgiICR7Q0FJUk9fVkVSU0lPTn0g IikiKQogZW5kaWYgKCkKIAogaW5jbHVkZShGaW5kUGFja2FnZUhhbmRsZVN0YW5kYXJkQXJncykK ZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLmNtYWtlIGIvU291cmNlL2Nt YWtlL0ZpbmRHU3RyZWFtZXIuY21ha2UKaW5kZXggMmE3ODAwNWI0Nzk2ZDZkNjA4NWFkMTYwZGVj MjBkNDg0YWNhYWY5NS4uYjlkZDBiYmRjMDNiOWZlYzQxZjM3MTEzNGFmY2UyYzdmNWM3NTcxNCAx MDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXIuY21ha2UKKysrIGIvU291cmNl L2NtYWtlL0ZpbmRHU3RyZWFtZXIuY21ha2UKQEAgLTk0LDcgKzk0LDcgQEAgaWYgKEdTVFJFQU1F Ul9JTkNMVURFX0RJUlMpCiBlbmRpZiAoKQogCiBpZiAoIiR7R1N0cmVhbWVyX0ZJTkRfVkVSU0lP Tn0iIFZFUlNJT05fR1JFQVRFUiAiJHtHU1RSRUFNRVJfVkVSU0lPTn0iKQotICAgIG1lc3NhZ2Uo RkFUQUxfRVJST1IgIlJlcXVpcmVkIHZlcnNpb24gKCIke0dTdHJlYW1lcl9GSU5EX1ZFUlNJT059 IikgaXMgaGlnaGVyIHRoYW4gZm91bmQgdmVyc2lvbiAoIiR7R1NUUkVBTUVSX1ZFUlNJT059Iiki KQorICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgIlJlcXVpcmVkIHZlcnNpb24gKCIgJHtHU3RyZWFt ZXJfRklORF9WRVJTSU9OfSAiKSBpcyBoaWdoZXIgdGhhbiBmb3VuZCB2ZXJzaW9uICgiICR7R1NU UkVBTUVSX1ZFUlNJT059ICIpIikKIGVuZGlmICgpCiAKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDM4N2U4ZmU3YWM3 M2QzZWNiNTRlMmY1MjgxYTY2YTE1NzA1Zjk0MzkuLjIzODY5ZTgxYjI1MGU0NmNhY2MxMTQ5ZWNi MjkwNDk1NTI4MDA5NDUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMy0xMS0yNiAgTGFzemxvIFZpZGFjcyAgPGxhY0BpbmYudS1zemVn ZWQuaHU+CisKKyAgICAgICAgW2NtYWtlXSBGaXggY21ha2Ugd2FybmluZzogQXJndW1lbnQgbm90 IHNlcGFyYXRlZCBmcm9tIHByZWNlZGluZyB0b2tlbiBieSB3aGl0ZXNwYWNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ4OTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5k Q2Fpcm8uY21ha2U6CisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRHU3RyZWFtZXIuY21ha2U6 CisKIDIwMTMtMTEtMjMgIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlh LmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBSZW1vdmUgMC4xMCBjb2RlcGF0aAo=