124888 2013-11-26 06:52:02 -0800 [GTK] Enable web audio by default 2013-12-06 03:05:23 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned cgarcia gustavo mrobinson pnormand oldest_to_newest 954251 0 berto 2013-11-26 06:52:02 -0800 When building with ./configure, enable_web_audio defaults to "no". However the basic functionality has been working for months so it's safe to enable it now. 954252 1 217877 berto 2013-11-26 06:53:14 -0800 Created attachment 217877 Patch 954253 2 mrobinson 2013-11-26 06:53:32 -0800 How is test coverage? 954254 3 mrobinson 2013-11-26 06:54:07 -0800 We should probably get some rough consensus to ship this feature. How is test coverage? 954257 4 pnormand 2013-11-26 07:00:00 -0800 Most webaudio tests pass. Currently flagged: webkit.org/b/79203 webaudio/mediastreamaudiodestinationnode.html [ Skip ] webkit.org/b/79203 webaudio/mediastreamaudiosourcenode.html [ Skip ] webkit.org/b/105296 webaudio/delaynode-max-nondefault-delay.html [ Failure ] webkit.org/b/105296 webaudio/delaynode-maxdelay.html [ Failure ] webkit.org/b/105296 webaudio/delaynode-scheduling.html [ Failure ] webkit.org/b/105299 webaudio/javascriptaudionode.html [ Failure ] 954258 5 pnormand 2013-11-26 07:12:26 -0800 I think it's safe to ship it... Moreover the enable-webaudio setting is off by default, so in the end it's up to the application developer to enable it or not. 954891 6 pnormand 2013-11-28 23:27:14 -0800 Adding Carlos and Gustavo. What do you think about enabling WebAudio by default? 954894 7 cgarcia 2013-11-28 23:50:26 -0800 (In reply to comment #6) > Adding Carlos and Gustavo. > > What do you think about enabling WebAudio by default? I don't see why not 954996 8 gustavo 2013-11-29 09:15:11 -0800 +1 from me 957196 9 berto 2013-12-06 03:05:23 -0800 Committed r160215: <http://trac.webkit.org/changeset/160215> 217877 2013-11-26 06:53:14 -0800 2013-12-06 02:25:45 -0800 Patch 124888.diff text/plain 1381 berto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzODdlOGZlLi5mZDFkNGIy IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTMtMTEtMjYgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBFbmFibGUgd2ViIGF1ZGlvIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDg4OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gYnVpbGRpbmcgd2l0aCAuL2NvbmZpZ3Vy ZSwgZW5hYmxlX3dlYl9hdWRpbyBkZWZhdWx0cyB0bworICAgICAgICAibm8iLiBIb3dldmVyIHRo ZSBiYXNpYyBmdW5jdGlvbmFsaXR5IGhhcyBiZWVuIHdvcmtpbmcgZm9yIG1vbnRocworICAgICAg ICBzbyBpdCdzIHNhZmUgdG8gZW5hYmxlIGl0IG5vdy4KKworICAgICAgICAqIFNvdXJjZS9hdXRv dG9vbHMvUmVhZENvbW1hbmRMaW5lQXJndW1lbnRzLm00OgorCiAyMDEzLTExLTIzICBYYWJpZXIg Um9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJl YW1lcl0gUmVtb3ZlIDAuMTAgY29kZXBhdGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9hdXRvdG9vbHMv UmVhZENvbW1hbmRMaW5lQXJndW1lbnRzLm00IGIvU291cmNlL2F1dG90b29scy9SZWFkQ29tbWFu ZExpbmVBcmd1bWVudHMubTQKaW5kZXggY2U4ZDJhZi4uMWRlMjVkNCAxMDA2NDQKLS0tIGEvU291 cmNlL2F1dG90b29scy9SZWFkQ29tbWFuZExpbmVBcmd1bWVudHMubTQKKysrIGIvU291cmNlL2F1 dG90b29scy9SZWFkQ29tbWFuZExpbmVBcmd1bWVudHMubTQKQEAgLTE0Nyw5ICsxNDcsOSBAQCBB Q19NU0dfUkVTVUxUKFskZW5hYmxlX3N2Z19mb250c10pCiAKIEFDX01TR19DSEVDS0lORyhbd2hl dGhlciB0byBlbmFibGUgV2ViIEF1ZGlvIHN1cHBvcnRdKQogQUNfQVJHX0VOQUJMRSh3ZWJfYXVk aW8sIAotICAgIEFDX0hFTFBfU1RSSU5HKFstLWVuYWJsZS13ZWItYXVkaW9dLCBbZW5hYmxlIHN1 cHBvcnQgZm9yIFdlYiBBdWRpbyBbZGVmYXVsdD1ub11dKSwKKyAgICBBQ19IRUxQX1NUUklORyhb LS1lbmFibGUtd2ViLWF1ZGlvXSwgW2VuYWJsZSBzdXBwb3J0IGZvciBXZWIgQXVkaW8gW2RlZmF1 bHQ9eWVzXV0pLAogICAgIFtdLAotICAgIFtlbmFibGVfd2ViX2F1ZGlvPSJubyJdKQorICAgIFtl bmFibGVfd2ViX2F1ZGlvPSJ5ZXMiXSkKIEFDX01TR19SRVNVTFQoWyRlbmFibGVfd2ViX2F1ZGlv XSkKIAogQUNfTVNHX0NIRUNLSU5HKFt3aGV0aGVyIHRvIGVuYWJsZSBCYXR0ZXJ5IFN0YXR1cyBB UEkgc3VwcG9ydF0pCg==