124872 2013-11-25 17:12:51 -0800 Remote Layer Tree: Hook up setLayerTreeStateIsFrozen 2013-12-02 12:55:38 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca sam simon.fraser webkit-bug-importer oldest_to_newest 954170 0 thorton 2013-11-25 17:12:51 -0800 To make printing not kill the main page. We can just keep deferring the flush until we get unfrozen; all of the property changes will just keep accumulating. 954171 1 217849 thorton 2013-11-25 17:14:58 -0800 Created attachment 217849 patch 954422 2 217849 bfulgham 2013-11-26 19:18:45 -0800 Comment on attachment 217849 patch View in context: https://bugs.webkit.org/attachment.cgi?id=217849&action=review r=me. But please consider whether the "optimization" or "flush avoidance" I suggested makes any sense. > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:145 > + if (!m_isFlushingSuspended && m_hasDeferredFlush) { Should we bother checking if our original state was already "!m_isFlushingSuspended" and only schedule the layer flush for the case where state is changing? I.e.: if (m_isFlushingSuspended == isFrozen) return; ... before doing the rest of your code? 955530 3 thorton 2013-12-02 12:55:38 -0800 http://trac.webkit.org/changeset/159956 217849 2013-11-25 17:14:58 -0800 2013-11-26 19:18:44 -0800 patch freeze.diff text/plain 4870 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhYzJkMjllLi5jNjNhMmNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTMtMTEtMjUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3RlIExheWVyIFRyZWU6IEhvb2sgdXAgc2V0TGF5ZXJUcmVlU3RhdGVJc0Zy b3plbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0 ODcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc2V0 TGF5ZXJUcmVlU3RhdGVJc0Zyb3plbiBpcyB0aGUgbWVjaGFuaXNtIHVzZWQgdG8gZW5zdXJlIHRo YXQKKyAgICAgICAgbGF5ZXIgcHJvcGVydHkgY2hhbmdlcyAoaW5jbHVkaW5nIG5ldyBiYWNraW5n IHN0b3JlKSBhcmVuJ3QgY29tbWl0dGVkCisgICAgICAgIHdoaWxlIGUuZy4gdGhlIHBhZ2UgaXMg cmVjb25maWd1cmVkIGZvciBwcmludGluZy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvUmVtb3RlTGF5ZXJUcmVlQ29udGV4dC5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlQ29udGV4dC5tbToKKyAgICAgICAgKFdlYktpdDo6UmVt b3RlTGF5ZXJUcmVlQ29udGV4dDo6UmVtb3RlTGF5ZXJUcmVlQ29udGV4dCk6CisgICAgICAgIChX ZWJLaXQ6OlJlbW90ZUxheWVyVHJlZUNvbnRleHQ6OmZsdXNoTGF5ZXJzKToKKyAgICAgICAgKFdl YktpdDo6UmVtb3RlTGF5ZXJUcmVlQ29udGV4dDo6c2V0SXNGbHVzaGluZ1N1c3BlbmRlZCk6Cisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJl YS5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJh d2luZ0FyZWEubW06CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVh OjpzZXRMYXllclRyZWVTdGF0ZUlzRnJvemVuKToKKwogMjAxMy0xMS0yNSAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gVXNlIGNsYXNzIGV4dGVuc2lv bnMgZm9yIElQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L21hYy9SZW1vdGVMYXllclRyZWVDb250ZXh0LmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZUNvbnRleHQuaAppbmRleCBhM2VhMjlhLi5jY2I0 ZTVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1Jl bW90ZUxheWVyVHJlZUNvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZUNvbnRleHQuaApAQCAtNTYsNiArNTYsOCBAQCBwdWJs aWM6CiAKICAgICBMYXllckhvc3RpbmdNb2RlIGxheWVySG9zdGluZ01vZGUoKSBjb25zdCB7IHJl dHVybiBtX3dlYlBhZ2UtPmxheWVySG9zdGluZ01vZGUoKTsgfQogCisgICAgdm9pZCBzZXRJc0Zs dXNoaW5nU3VzcGVuZGVkKGJvb2wpOworCiBwcml2YXRlOgogICAgIC8vIFdlYkNvcmU6OkdyYXBo aWNzTGF5ZXJGYWN0b3J5CiAgICAgdmlydHVhbCBzdGQ6OnVuaXF1ZV9wdHI8V2ViQ29yZTo6R3Jh cGhpY3NMYXllcj4gY3JlYXRlR3JhcGhpY3NMYXllcihXZWJDb3JlOjpHcmFwaGljc0xheWVyQ2xp ZW50KikgT1ZFUlJJREU7CkBAIC03MSw2ICs3Myw5IEBAIHByaXZhdGU6CiAKICAgICBWZWN0b3I8 UmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246OkxheWVyQ3JlYXRpb25Qcm9wZXJ0aWVzPiBtX2Ny ZWF0ZWRMYXllcnM7CiAgICAgVmVjdG9yPFJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uOjpMYXll cklEPiBtX2Rlc3Ryb3llZExheWVyczsKKworICAgIGJvb2wgbV9pc0ZsdXNoaW5nU3VzcGVuZGVk OworICAgIGJvb2wgbV9oYXNEZWZlcnJlZEZsdXNoOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2Vi S2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1Jl bW90ZUxheWVyVHJlZUNvbnRleHQubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1JlbW90ZUxheWVyVHJlZUNvbnRleHQubW0KaW5kZXggNDFjZmJkZi4uOGM2OTA0YyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVM YXllclRyZWVDb250ZXh0Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvUmVtb3RlTGF5ZXJUcmVlQ29udGV4dC5tbQpAQCAtNDMsNiArNDMsOCBAQCBuYW1lc3Bh Y2UgV2ViS2l0IHsKIFJlbW90ZUxheWVyVHJlZUNvbnRleHQ6OlJlbW90ZUxheWVyVHJlZUNvbnRl eHQoV2ViUGFnZSogd2ViUGFnZSkKICAgICA6IG1fd2ViUGFnZSh3ZWJQYWdlKQogICAgICwgbV9s YXllckZsdXNoVGltZXIodGhpcywgJlJlbW90ZUxheWVyVHJlZUNvbnRleHQ6OmxheWVyRmx1c2hU aW1lckZpcmVkKQorICAgICwgbV9pc0ZsdXNoaW5nU3VzcGVuZGVkKGZhbHNlKQorICAgICwgbV9o YXNEZWZlcnJlZEZsdXNoKGZhbHNlKQogewogfQogCkBAIC0xMTQsNiArMTE2LDExIEBAIHZvaWQg UmVtb3RlTGF5ZXJUcmVlQ29udGV4dDo6Zmx1c2hMYXllcnMoKQogICAgIGlmICghbV9yb290TGF5 ZXIpCiAgICAgICAgIHJldHVybjsKIAorICAgIGlmIChtX2lzRmx1c2hpbmdTdXNwZW5kZWQpIHsK KyAgICAgICAgbV9oYXNEZWZlcnJlZEZsdXNoID0gdHJ1ZTsKKyAgICAgICAgcmV0dXJuOworICAg IH0KKwogICAgIFJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uIHRyYW5zYWN0aW9uOwogCiAgICAg dHJhbnNhY3Rpb24uc2V0Um9vdExheWVySUQobV9yb290TGF5ZXItPmxheWVySUQoKSk7CkBAIC0x MzEsNCArMTM4LDE0IEBAIHZvaWQgUmVtb3RlTGF5ZXJUcmVlQ29udGV4dDo6Zmx1c2hMYXllcnMo KQogICAgIG1fd2ViUGFnZS0+c2VuZChNZXNzYWdlczo6UmVtb3RlTGF5ZXJUcmVlSG9zdDo6Q29t bWl0KHRyYW5zYWN0aW9uKSk7CiB9CiAKK3ZvaWQgUmVtb3RlTGF5ZXJUcmVlQ29udGV4dDo6c2V0 SXNGbHVzaGluZ1N1c3BlbmRlZChib29sIGlzRnJvemVuKQoreworICAgIG1faXNGbHVzaGluZ1N1 c3BlbmRlZCA9IGlzRnJvemVuOworCisgICAgaWYgKCFtX2lzRmx1c2hpbmdTdXNwZW5kZWQgJiYg bV9oYXNEZWZlcnJlZEZsdXNoKSB7CisgICAgICAgIG1faGFzRGVmZXJyZWRGbHVzaCA9IGZhbHNl OworICAgICAgICBzY2hlZHVsZUxheWVyRmx1c2goKTsKKyAgICB9Cit9CisKIH0gLy8gbmFtZXNw YWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5oCmluZGV4IDA2ZmM2 ZGYuLmIwMTY5ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhLmgKQEAgLTY0 LDYgKzY0LDggQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgc2V0UGFnZU92ZXJsYXlOZWVk c0Rpc3BsYXkoUGFnZU92ZXJsYXkqLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JikgT1ZFUlJJREU7 CiAgICAgdmlydHVhbCB2b2lkIHNldFBhZ2VPdmVybGF5T3BhY2l0eShQYWdlT3ZlcmxheSosIGZs b2F0KSBPVkVSUklERTsKIAorICAgIHZpcnR1YWwgdm9pZCBzZXRMYXllclRyZWVTdGF0ZUlzRnJv emVuKGJvb2wpIE9WRVJSSURFOworCiAgICAgLy8gV2ViQ29yZTo6R3JhcGhpY3NMYXllckNsaWVu dAogICAgIHZpcnR1YWwgdm9pZCBub3RpZnlBbmltYXRpb25TdGFydGVkKGNvbnN0IFdlYkNvcmU6 OkdyYXBoaWNzTGF5ZXIqLCBkb3VibGUgdGltZSkgT1ZFUlJJREUgeyB9CiAgICAgdmlydHVhbCB2 b2lkIG5vdGlmeUZsdXNoUmVxdWlyZWQoY29uc3QgV2ViQ29yZTo6R3JhcGhpY3NMYXllciopIE9W RVJSSURFIHsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEubW0KaW5kZXggMGI4 ZTU3ZS4uM2JkNWI3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhLm1tCkBA IC0xODcsNCArMTg3LDkgQEAgZmxvYXQgUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWE6OmRldmlj ZVNjYWxlRmFjdG9yKCkgY29uc3QKICAgICByZXR1cm4gbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5k ZXZpY2VTY2FsZUZhY3RvcigpOwogfQogCit2b2lkIFJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVh OjpzZXRMYXllclRyZWVTdGF0ZUlzRnJvemVuKGJvb2wgaXNGcm96ZW4pCit7CisgICAgbV9yZW1v dGVMYXllclRyZWVDb250ZXh0LT5zZXRJc0ZsdXNoaW5nU3VzcGVuZGVkKGlzRnJvemVuKTsKK30K KwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==