124869 2013-11-25 16:17:38 -0800 Optimize away OR with zero - a common ASM.js pattern. 2013-11-26 15:40:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nrotem nrotem commit-queue fpizlo ggaren oldest_to_newest 954150 0 nrotem 2013-11-25 16:17:38 -0800 Optimize away OR with zero - a common ASM.js pattern. 954151 1 217843 nrotem 2013-11-25 16:17:55 -0800 Created attachment 217843 Patch 954154 2 217844 nrotem 2013-11-25 16:20:03 -0800 Created attachment 217844 Patch 954166 3 217844 fpizlo 2013-11-25 16:56:01 -0800 Comment on attachment 217844 Patch This feels somewhat suboptimal - ideally we would allow for copy-propagation of y = (x|0), which this doesn't do. I recommend doing this in the FixupPhase instead. The way that you would do it is replace BitOr(x, 0) with Identity(x) ; Phantom(0). The Phantom(0) is relevant because want to know that the constant zero was live up to that point. 954204 4 nrotem 2013-11-25 20:17:53 -0800 I also thought that it would be a good idea to peephole it earlier. Should we also keep this one? 954207 5 fpizlo 2013-11-25 20:36:19 -0800 (In reply to comment #4) > I also thought that it would be a good idea to peephole it earlier. Should we also keep this one? Nah - in fact what I would do is have: - An earlier peephole in FixupPhase. - A "later" peephole in MacroAssemblerBlah.h, where Blah = x86_64 | ARMv7 | ARM64. This would help the other JITs - including our regex JIT. ;-) 954219 6 217864 nrotem 2013-11-25 22:58:33 -0800 Created attachment 217864 Patch 954277 7 217864 commit-queue 2013-11-26 09:07:26 -0800 Comment on attachment 217864 Patch Clearing flags on attachment: 217864 Committed r159783: <http://trac.webkit.org/changeset/159783> 954278 8 commit-queue 2013-11-26 09:07:28 -0800 All reviewed patches have been landed. Closing bug. 954365 9 nrotem 2013-11-26 15:40:44 -0800 Filip, can we do this: void add32(TrustedImm32 imm, RegisterID dest) { if (imm.m_value) <---------- this add32(imm, dest, dest); } someone may be calling add32 just to use the flags. When is it safe to optimize code in the emitter ? 217843 2013-11-25 16:17:55 -0800 2013-11-25 16:20:02 -0800 Patch bug-124869-20131125161755.patch text/plain 1402 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZWYxZDRkMDEwMTgzYjVjNDYzYWQ0MDZkOTkwZjA0NGM2YmRlZWVlLi4xODkxYzIzMjg3ZjFkOTJj ODhmZTQxYzJiNzY1MmVjMTk4YmFlNTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0xMS0yNSAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIE9wdGltaXplIGF3YXkgT1Igd2l0aCB6ZXJvIC0gYSBjb21tb24gQVNNLmpzIHBh dHRlcm4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjQ4NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZl SklUOjpiaXRPcCk6CisKIDIwMTMtMTEtMjIgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJn QGFwcGxlLmNvbT4KIAogICAgICAgICBKU0MgT2JqLUMgQVBJIHNob3VsZCBoYXZlIHJlYWwgZG9j dW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VC5oCmluZGV4IGJlZDQzMmQxZTZhOGMyZjZiOWJmY2YzYzUxMDJhMTdkOTM5ZDRjNGMuLjFlMTQz ZThlYTU3N2JhZjIwNTFmZTBjMWNlNGNhZjJkZmRlMzQwMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgKQEAgLTYyMiw3ICs2MjIsMTAgQEAgcHVi bGljOgogICAgICAgICAgICAgbV9qaXQuYW5kMzIoSW1tMzIoaW1tKSwgb3AxLCByZXN1bHQpOwog ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQml0T3I6Ci0gICAgICAgICAgICBtX2pp dC5vcjMyKEltbTMyKGltbSksIG9wMSwgcmVzdWx0KTsKKyAgICAgICAgICAgIGlmIChpbW0pCisg ICAgICAgICAgICAgICAgbV9qaXQub3IzMihJbW0zMihpbW0pLCBvcDEsIHJlc3VsdCk7CisgICAg ICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgbV9qaXQubW92ZShvcDEsIHJlc3VsdCk7CiAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBCaXRYb3I6CiAgICAgICAgICAgICBtX2pp dC54b3IzMihJbW0zMihpbW0pLCBvcDEsIHJlc3VsdCk7Cg== 217844 2013-11-25 16:20:03 -0800 2013-11-25 22:58:32 -0800 Patch bug-124869-20131125162003.patch text/plain 1402 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZWYxZDRkMDEwMTgzYjVjNDYzYWQ0MDZkOTkwZjA0NGM2YmRlZWVlLi4xODkxYzIzMjg3ZjFkOTJj ODhmZTQxYzJiNzY1MmVjMTk4YmFlNTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0xMS0yNSAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIE9wdGltaXplIGF3YXkgT1Igd2l0aCB6ZXJvIC0gYSBjb21tb24gQVNNLmpzIHBh dHRlcm4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjQ4NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZl SklUOjpiaXRPcCk6CisKIDIwMTMtMTEtMjIgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJn QGFwcGxlLmNvbT4KIAogICAgICAgICBKU0MgT2JqLUMgQVBJIHNob3VsZCBoYXZlIHJlYWwgZG9j dW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VC5oCmluZGV4IGJlZDQzMmQxZTZhOGMyZjZiOWJmY2YzYzUxMDJhMTdkOTM5ZDRjNGMuLjFlMTQz ZThlYTU3N2JhZjIwNTFmZTBjMWNlNGNhZjJkZmRlMzQwMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgKQEAgLTYyMiw3ICs2MjIsMTAgQEAgcHVi bGljOgogICAgICAgICAgICAgbV9qaXQuYW5kMzIoSW1tMzIoaW1tKSwgb3AxLCByZXN1bHQpOwog ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQml0T3I6Ci0gICAgICAgICAgICBtX2pp dC5vcjMyKEltbTMyKGltbSksIG9wMSwgcmVzdWx0KTsKKyAgICAgICAgICAgIGlmIChpbW0pCisg ICAgICAgICAgICAgICAgbV9qaXQub3IzMihJbW0zMihpbW0pLCBvcDEsIHJlc3VsdCk7CisgICAg ICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgbV9qaXQubW92ZShvcDEsIHJlc3VsdCk7CiAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBCaXRYb3I6CiAgICAgICAgICAgICBtX2pp dC54b3IzMihJbW0zMihpbW0pLCBvcDEsIHJlc3VsdCk7Cg== 217864 2013-11-25 22:58:33 -0800 2013-11-26 09:07:25 -0800 Patch bug-124869-20131125225833.patch text/plain 1886 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5Nzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ODA0N2Y3NDAwNWMwMDg0NmQ3ODViNWZkNDY3NTAzOGZmOTljMTcyLi43Zjg5Yzk3MTczMWIzOWVh ODE3NmM0YmQ3MDZlMzIyMTZmMzJlNDZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0xMS0yNSAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIE9wdGltaXplIGF3YXkgT1Igd2l0aCB6ZXJvIC0gYSBjb21tb24gQVNNLmpzIHBh dHRlcm4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjQ4NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGRmZy9ERkdGaXh1cFBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpGaXh1cFBoYXNlOjpm aXh1cE5vZGUpOgorCiAyMDEzLTExLTI1ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lz Y28uY29tPgogCiAgICAgICAgIFthcm1dW21pcHNdIEZpeCBjcmFzaCBpbiBkZmctYXJyYXlpZnkt ZWxpbWluYXRpb24gbGF5b3V0IGpzYyB0ZXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHRml4dXBQaGFzZS5jcHAKaW5kZXggMjYxZDZlMWJmMzUwNzdmMDA1YTNiMTVhYjM4NDRhY2Rj YTU3NWNhYS4uMTM4ZTdiODRiYTM5MGRiNTBkMjM0Y2MzNDhiMjAzNjZmZTE2NmJkMSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCkBAIC05OCw4ICs5OCwy MyBAQCBwcml2YXRlOgogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgICAgICAg ICAKKyAgICAgICAgY2FzZSBCaXRPcjogeworICAgICAgICAgICAgLy8gT3B0aW1pemUgWHwwIC0+ IFguCisgICAgICAgICAgICBpZiAobm9kZS0+Y2hpbGQyKCktPmlzQ29uc3RhbnQoKSkgeworICAg ICAgICAgICAgICAgIEpTVmFsdWUgQzIgPSBtX2dyYXBoLnZhbHVlT2ZKU0NvbnN0YW50KG5vZGUt PmNoaWxkMigpLm5vZGUoKSk7CisgICAgICAgICAgICAgICAgaWYgKEMyLmlzSW50MzIoKSAmJiAh QzIuYXNJbnQzMigpKSB7CisgICAgICAgICAgICAgICAgICAgIG1faW5zZXJ0aW9uU2V0Lmluc2Vy dE5vZGUobV9pbmRleEluQmxvY2ssIFNwZWNOb25lLCBQaGFudG9tLCBub2RlLT5jb2RlT3JpZ2lu LAorICAgICAgICAgICAgICAgICAgICAgICAgRWRnZShub2RlLT5jaGlsZDIoKS5ub2RlKCksIEtu b3duSW50MzJVc2UpKTsKKyAgICAgICAgICAgICAgICAgICAgbm9kZS0+Y2hpbGRyZW4ucmVtb3Zl RWRnZSgxKTsKKyAgICAgICAgICAgICAgICAgICAgbm9kZS0+Y29udmVydFRvSWRlbnRpdHkoKTsK KyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAg ICAgfQorICAgICAgICAgICAgZml4SW50RWRnZShub2RlLT5jaGlsZDEoKSk7CisgICAgICAgICAg ICBmaXhJbnRFZGdlKG5vZGUtPmNoaWxkMigpKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAg ICB9CiAgICAgICAgIGNhc2UgQml0QW5kOgotICAgICAgICBjYXNlIEJpdE9yOgogICAgICAgICBj YXNlIEJpdFhvcjoKICAgICAgICAgY2FzZSBCaXRSU2hpZnQ6CiAgICAgICAgIGNhc2UgQml0TFNo aWZ0Ogo=