124867 2013-11-25 15:14:58 -0800 More prep work for GStreamer on Windows 2013-12-17 08:52:29 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Minor --- 1 alex.christensen webkit-unassigned bfulgham commit-queue pnormand oldest_to_newest 954127 0 alex.christensen 2013-11-25 15:14:58 -0800 I have some compile fixes, and g_main_context_iteration needs to be called in the main loop for GStreamer to work. 954131 1 alex.christensen 2013-11-25 15:20:39 -0800 The WinLauncher change is based on http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=commitdiff;h=895ab852892ec2e6393e41cc8576d4bbcfe636ea 954132 2 217839 alex.christensen 2013-11-25 15:21:49 -0800 Created attachment 217839 Patch 954221 3 217839 pnormand 2013-11-25 23:17:34 -0800 Comment on attachment 217839 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217839&action=review > Tools/WinLauncher/WinLauncher.cpp:45 > +#if USE(GSTREAMER) IIRC there is an ENABLE(GLIB_SUPPORT). Perhaps it would make more sense to enable that macro in WinCairo and use it here. > Tools/WinLauncher/WinLauncher.cpp:623 > +#if USE(GSTREAMER) Ditto 960406 4 alex.christensen 2013-12-16 22:11:41 -0800 https://bugs.webkit.org/show_bug.cgi?id=104266 changed that to USE(GLIB), which would be a better fit there. 960408 5 219398 alex.christensen 2013-12-16 22:14:42 -0800 Created attachment 219398 Patch 960519 6 219398 commit-queue 2013-12-17 08:52:27 -0800 Comment on attachment 219398 Patch Clearing flags on attachment: 219398 Committed r160707: <http://trac.webkit.org/changeset/160707> 960520 7 commit-queue 2013-12-17 08:52:29 -0800 All reviewed patches have been landed. Closing bug. 217839 2013-11-25 15:21:49 -0800 2013-12-16 22:14:37 -0800 Patch bug-124867-20131125162148.patch text/plain 2849 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTc2OCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTExLTI1 ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAg W1dpbkNhaXJvXSBDb21waWxlIGZpeGVzIGZvciBHU3RyZWFtZXIgb24gV2luZG93cy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDg2NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy5jcHA6 CisgICAgICAgIChXZWJWaWV3OjplbnRlckZ1bGxzY3JlZW5Gb3JOb2RlKToKKyAgICAgICAgKFdl YlZpZXc6OmV4aXRGdWxsc2NyZWVuKToKKyAgICAgICAgR1N0cmVhbWVyIGluIFdlYktpdCBkb2Vz IG5vdCBzdXBwb3J0IGZ1bGxzY3JlZW4sIHNvCisgICAgICAgIEkgYWRkZWQgI2lmICFVU0UoR1NU UkVBTUVSKSB0byB0aGUgZnVsbHNjcmVlbiBjb2RlIHRvIGdldCBpdCB0byBjb21waWxlLgorCiAy MDEzLTExLTI1ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgogCiAgICAg ICAgIFtXaW5dIFdlYktpdCB2ZXJzaW9uIGluIHVzZXIgYWdlbnQgc3RyaW5nIGlzIGluY29ycmVj dC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiAxNTk3NjYpCisrKyBTb3VyY2Uv V2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjI5MCw3ICs2MjkwLDcg QEAgSFJFU1VMVCBXZWJWaWV3OjpzZXRDYW5TdGFydFBsdWdpbnMoQk9PTAogCiB2b2lkIFdlYlZp ZXc6OmVudGVyRnVsbHNjcmVlbkZvck5vZGUoTm9kZSogbm9kZSkKIHsKLSNpZiBFTkFCTEUoVklE RU8pCisjaWYgRU5BQkxFKFZJREVPKSAmJiAhVVNFKEdTVFJFQU1FUikKICAgICBpZiAoIWlzSFRN TFZpZGVvRWxlbWVudChub2RlKSB8fCAhbm9kZS0+aXNFbGVtZW50Tm9kZSgpKQogICAgICAgICBy ZXR1cm47CiAKQEAgLTYzMjEsNyArNjMyMSw3IEBAIHZvaWQgV2ViVmlldzo6ZW50ZXJGdWxsc2Ny ZWVuRm9yTm9kZShOb2QKIAogdm9pZCBXZWJWaWV3OjpleGl0RnVsbHNjcmVlbigpCiB7Ci0jaWYg RU5BQkxFKFZJREVPKQorI2lmIEVOQUJMRShWSURFTykgJiYgIVVTRShHU1RSRUFNRVIpCiAgICAg aWYgKCFtX2Z1bGxTY3JlZW5WaWRlb0NvbnRyb2xsZXIpCiAgICAgICAgIHJldHVybjsKICAgICAK SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1OTc2OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEzLTExLTI1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgW1dpbkNhaXJvXSBBZGRpbmcgc3VwcG9ydCBmb3IgR1N0cmVh bWVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0 ODY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX aW5MYXVuY2hlci9XaW5MYXVuY2hlci5jcHA6CisgICAgICAgICh3V2luTWFpbik6CisgICAgICAg IEFkZGVkIGdfbWFpbl9jb250ZXh0X2l0ZXJhdGlvbiBpbiBtYWluIGV2ZW50IGxvb3AuCisKIDIw MTMtMTEtMjUgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29j b2FdIFB1dCBtb3N0IG9mIHRoZSBDb2NvYSBBUEkgYmVoaW5kIFdLX0FQSV9FTkFCTEVEIGd1YXJk cwpJbmRleDogVG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLmNwcAkocmV2aXNpb24gMTU5NzY2KQorKysg VG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2 ICs0MiwxMCBAQAogI2luY2x1ZGUgPENvcmVGb3VuZGF0aW9uL0NGUnVuTG9vcC5oPgogI2VuZGlm CiAKKyNpZiBVU0UoR1NUUkVBTUVSKQorI2luY2x1ZGUgPGdsaWIuaD4KKyNlbmRpZgorCiAjaW5j bHVkZSA8YWxnb3JpdGhtPgogI2luY2x1ZGUgPGFzc2VydC5oPgogI2luY2x1ZGUgPGNvbWlwLmg+ CkBAIC02MTYsNiArNjIwLDkgQEAgaW50IFdJTkFQSSB3V2luTWFpbihISU5TVEFOQ0UsIEhJTlNU QU5DRQogICAgICAgICAgICAgICAgIFRyYW5zbGF0ZU1lc3NhZ2UoJm1zZyk7CiAgICAgICAgICAg ICAgICAgRGlzcGF0Y2hNZXNzYWdlKCZtc2cpOwogICAgICAgICAgICAgfQorI2lmIFVTRShHU1RS RUFNRVIpCisgICAgICAgICAgICBnX21haW5fY29udGV4dF9pdGVyYXRpb24oMCwgZmFsc2UpOwor I2VuZGlmCiAgICAgICAgIH0KICAgICB9IF9fZXhjZXB0KGNyZWF0ZUNyYXNoUmVwb3J0KEdldEV4 Y2VwdGlvbkluZm9ybWF0aW9uKCkpLCBFWENFUFRJT05fRVhFQ1VURV9IQU5ETEVSKSB7IH0KIAo= 219398 2013-12-16 22:14:42 -0800 2013-12-17 08:52:27 -0800 Patch bug-124867-20131216231442.patch text/plain 2836 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDY5MykKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEyLTE2 ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAg W1dpbkNhaXJvXSBDb21waWxlIGZpeGVzIGZvciBHU3RyZWFtZXIgb24gV2luZG93cy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDg2NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy5jcHA6 CisgICAgICAgIChXZWJWaWV3OjplbnRlckZ1bGxzY3JlZW5Gb3JOb2RlKToKKyAgICAgICAgKFdl YlZpZXc6OmV4aXRGdWxsc2NyZWVuKToKKyAgICAgICAgR1N0cmVhbWVyIGluIFdlYktpdCBkb2Vz IG5vdCBzdXBwb3J0IGZ1bGxzY3JlZW4sIHNvCisgICAgICAgIEkgYWRkZWQgI2lmICFVU0UoR1NU UkVBTUVSKSB0byB0aGUgZnVsbHNjcmVlbiBjb2RlIHRvIGdldCBpdCB0byBjb21waWxlLgorCiAy MDEzLTEyLTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogUHVzaCBNb3JlIEluc3BlY3RvciBSZXF1aXJlZCBDbGFzc2VzIERv d24gaW50byBKYXZhU2NyaXB0Q29yZQpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9u IDE2MDY5MykKKysrIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02MjkyLDcgKzYyOTIsNyBAQCBIUkVTVUxUIFdlYlZpZXc6OnNldENhblN0YXJ0UGx1Z2lu cyhCT09MCiAKIHZvaWQgV2ViVmlldzo6ZW50ZXJGdWxsc2NyZWVuRm9yTm9kZShOb2RlKiBub2Rl KQogewotI2lmIEVOQUJMRShWSURFTykKKyNpZiBFTkFCTEUoVklERU8pICYmICFVU0UoR1NUUkVB TUVSKQogICAgIGlmICghaXNIVE1MVmlkZW9FbGVtZW50KG5vZGUpIHx8ICFub2RlLT5pc0VsZW1l bnROb2RlKCkpCiAgICAgICAgIHJldHVybjsKIApAQCAtNjMyMyw3ICs2MzIzLDcgQEAgdm9pZCBX ZWJWaWV3OjplbnRlckZ1bGxzY3JlZW5Gb3JOb2RlKE5vZAogCiB2b2lkIFdlYlZpZXc6OmV4aXRG dWxsc2NyZWVuKCkKIHsKLSNpZiBFTkFCTEUoVklERU8pCisjaWYgRU5BQkxFKFZJREVPKSAmJiAh VVNFKEdTVFJFQU1FUikKICAgICBpZiAoIW1fZnVsbFNjcmVlblZpZGVvQ29udHJvbGxlcikKICAg ICAgICAgcmV0dXJuOwogICAgIApJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwNjkzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMTItMTYgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBbV2luQ2Fpcm9dIEFkZGlu ZyBzdXBwb3J0IGZvciBHU3RyZWFtZXIgYW5kIEdMaWIuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ4NjcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLmNwcDoK KyAgICAgICAgKHdXaW5NYWluKToKKyAgICAgICAgQWRkZWQgZ19tYWluX2NvbnRleHRfaXRlcmF0 aW9uIGluIG1haW4gZXZlbnQgbG9vcC4KKwogMjAxMy0xMi0xNiAgUm9iIEJ1aXMgIDxyb2IuYnVp c0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBBZGQgbXkgU2Ftc3VuZyBlbWFpbCBhZGRyZXNzLgpJ bmRleDogVG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLmNwcAkocmV2aXNpb24gMTYwNjkzKQorKysgVG9v bHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0 MiwxMCBAQAogI2luY2x1ZGUgPENvcmVGb3VuZGF0aW9uL0NGUnVuTG9vcC5oPgogI2VuZGlmCiAK KyNpZiBVU0UoR0xJQikKKyNpbmNsdWRlIDxnbGliLmg+CisjZW5kaWYKKwogI2luY2x1ZGUgPGFs Z29yaXRobT4KICNpbmNsdWRlIDxhc3NlcnQuaD4KICNpbmNsdWRlIDxjb21pcC5oPgpAQCAtNjE2 LDYgKzYyMCw5IEBAIGludCBXSU5BUEkgd1dpbk1haW4oSElOU1RBTkNFLCBISU5TVEFOQ0UKICAg ICAgICAgICAgICAgICBUcmFuc2xhdGVNZXNzYWdlKCZtc2cpOwogICAgICAgICAgICAgICAgIERp c3BhdGNoTWVzc2FnZSgmbXNnKTsKICAgICAgICAgICAgIH0KKyNpZiBVU0UoR0xJQikKKyAgICAg ICAgICAgIGdfbWFpbl9jb250ZXh0X2l0ZXJhdGlvbigwLCBmYWxzZSk7CisjZW5kaWYKICAgICAg ICAgfQogICAgIH0gX19leGNlcHQoY3JlYXRlQ3Jhc2hSZXBvcnQoR2V0RXhjZXB0aW9uSW5mb3Jt YXRpb24oKSksIEVYQ0VQVElPTl9FWEVDVVRFX0hBTkRMRVIpIHsgfQogCg==