124861 2013-11-25 14:44:15 -0800 freeOwnedGPtr(GError*) needs to be exported 2013-12-17 10:42:42 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Windows 8 RESOLVED FIXED P2 Trivial --- 1 alex.christensen webkit-unassigned benjamin cmarcelo commit-queue mrobinson pnormand oldest_to_newest 954108 0 alex.christensen 2013-11-25 14:44:15 -0800 WebKit doesn't link on Windows without exporting freeOwnedGPtr(GError*). Specifically MediaPlayerPrivateGStreamer.obj and GStreamerUtilities.obj have 1 unresolved external symbol when linking. 954112 1 217835 alex.christensen 2013-11-25 14:55:14 -0800 Created attachment 217835 Patch 954419 2 217835 bfulgham 2013-11-26 19:08:42 -0800 Comment on attachment 217835 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217835&action=review > Source/WTF/wtf/gobject/GOwnPtr.cpp:30 > +WTF_EXPORT_PRIVATE void freeOwnedGPtr(GError* ptr) It seem strange that this is not a template on Windows. Why is that? 954721 3 pnormand 2013-11-28 06:47:47 -0800 The folks trying to build the MediaPlayerPrivate on OSX have the same issue, it seems. 955115 4 alex.christensen 2013-11-30 21:35:58 -0800 It does seem strange, but it doesn't export the correct linker symbol as a template. Maybe this should be changed where it is used instead of where it's defined. I'll look into this more next week. 960383 5 219392 alex.christensen 2013-12-16 20:50:36 -0800 Created attachment 219392 Patch 960384 6 alex.christensen 2013-12-16 20:53:28 -0800 It said I had different linkage because I forgot to add it to the declaration. Adding it to the declaration and definition solves the problem the right way. 960570 7 219392 commit-queue 2013-12-17 10:42:40 -0800 Comment on attachment 219392 Patch Clearing flags on attachment: 219392 Committed r160716: <http://trac.webkit.org/changeset/160716> 960571 8 commit-queue 2013-12-17 10:42:42 -0800 All reviewed patches have been landed. Closing bug. 217835 2013-11-25 14:55:14 -0800 2013-12-16 20:50:32 -0800 Patch bug-124861-20131125155513.patch text/plain 1074 alex.christensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTk3NjYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTExLTI1ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dpbl0gRml4ZWQgbGlua2VyIGVy cm9yIHdpdGggR1N0cmVhbWVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI0ODYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvZ29iamVjdC9HT3duUHRyLmNwcDoKKyAgICAgICAgKFdURjo6ZnJl ZU93bmVkR1B0cik6CisgICAgICAgIEFkZGVkIG5vbi10ZW1wbGF0ZSBkZWNsYXJhdGlvbiBmb3Ig V2luZG93cy4KKwogMjAxMy0xMS0yNCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KIAogICAgICAgICBVcHN0cmVhbSBVU0UoSU9TVVJGQUNFKSBmcm9tIHRoZSBpT1MgcG9y dApJbmRleDogU291cmNlL1dURi93dGYvZ29iamVjdC9HT3duUHRyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dPd25QdHIuY3BwCShyZXZpc2lvbiAxNTk3NjYpCisr KyBTb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dPd25QdHIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y Niw3ICsyNiwxMSBAQAogCiBuYW1lc3BhY2UgV1RGIHsKIAorI2lmIFBMQVRGT1JNKFdJTikKK1dU Rl9FWFBPUlRfUFJJVkFURSB2b2lkIGZyZWVPd25lZEdQdHIoR0Vycm9yKiBwdHIpCisjZWxzZQog dGVtcGxhdGUgPD4gdm9pZCBmcmVlT3duZWRHUHRyPEdFcnJvcj4oR0Vycm9yKiBwdHIpCisjZW5k aWYKIHsKICAgICBpZiAocHRyKQogICAgICAgICBnX2Vycm9yX2ZyZWUocHRyKTsK 219392 2013-12-16 20:50:36 -0800 2013-12-17 10:42:40 -0800 Patch bug-124861-20131216215035.patch text/plain 1720 alex.christensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNjA2OTMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTE2ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dpbl0gRml4ZWQgbGlua2VyIGVy cm9yIHdpdGggR1N0cmVhbWVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI0ODYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvZ29iamVjdC9HT3duUHRyLmNwcDoKKyAgICAgICAgKFdURjo6R0Vy cm9yKToKKyAgICAgICAgKiB3dGYvZ29iamVjdC9HT3duUHRyLmg6CisgICAgICAgIEFkZGVkIFdU Rl9FWFBPUlRfUFJJVkFURSB0byBmcmVlT3duZWRHUHRyPEdFcnJvcj4gZGVjbGFyYXRpb24gYW5k IGRlZmluaXRpb24uCisKIDIwMTMtMTItMTYgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRW51bUNsYXNzLmggZnJvbSBXVEYKSW5kZXg6IFNv dXJjZS9XVEYvd3RmL2dvYmplY3QvR093blB0ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dU Ri93dGYvZ29iamVjdC9HT3duUHRyLmNwcAkocmV2aXNpb24gMTYwNjkwKQorKysgU291cmNlL1dU Ri93dGYvZ29iamVjdC9HT3duUHRyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjYsNyArMjYsNyBA QAogCiBuYW1lc3BhY2UgV1RGIHsKIAotdGVtcGxhdGUgPD4gdm9pZCBmcmVlT3duZWRHUHRyPEdF cnJvcj4oR0Vycm9yKiBwdHIpCit0ZW1wbGF0ZSA8PiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBm cmVlT3duZWRHUHRyPEdFcnJvcj4oR0Vycm9yKiBwdHIpCiB7CiAgICAgaWYgKHB0cikKICAgICAg ICAgZ19lcnJvcl9mcmVlKHB0cik7CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dPd25Q dHIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dPd25QdHIuaAkocmV2 aXNpb24gMTYwNjkwKQorKysgU291cmNlL1dURi93dGYvZ29iamVjdC9HT3duUHRyLmgJKHdvcmtp bmcgY29weSkKQEAgLTMzLDcgKzMzLDcgQEAgZXh0ZXJuICJDIiB2b2lkIGdfZnJlZSh2b2lkKik7 CiBuYW1lc3BhY2UgV1RGIHsKIAogdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IGlubGluZSB2b2lkIGZy ZWVPd25lZEdQdHIoVCogcHRyKTsKLXRlbXBsYXRlPD4gdm9pZCBmcmVlT3duZWRHUHRyPEdFcnJv cj4oR0Vycm9yKik7Cit0ZW1wbGF0ZTw+IFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIGZyZWVPd25l ZEdQdHI8R0Vycm9yPihHRXJyb3IqKTsKIHRlbXBsYXRlPD4gdm9pZCBmcmVlT3duZWRHUHRyPEdM aXN0PihHTGlzdCopOwogdGVtcGxhdGU8PiB2b2lkIGZyZWVPd25lZEdQdHI8R1NMaXN0PihHU0xp c3QqKTsKIHRlbXBsYXRlPD4gdm9pZCBmcmVlT3duZWRHUHRyPEdQYXR0ZXJuU3BlYz4oR1BhdHRl cm5TcGVjKik7Cg==