<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>124855</bug_id>
          
          <creation_ts>2013-11-25 12:52:31 -0800</creation_ts>
          <short_desc>Deduplicate shortish Text node strings during tree construction.</short_desc>
          <delta_ts>2019-02-06 09:03:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>REOPENED</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>125055</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andreas Kling">kling</reporter>
          <assigned_to name="Andreas Kling">kling</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kling</cc>
    
    <cc>koivisto</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>954066</commentid>
    <comment_count>0</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-11-25 12:52:31 -0800</bug_when>
    <thetext>There are a lot of repeating strings in the DOM trees on the web. We should do something clever to cut down on the number of duplicates we keep in RAM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>954068</commentid>
    <comment_count>1</comment_count>
      <attachid>217824</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-11-25 12:57:55 -0800</bug_when>
    <thetext>Created attachment 217824
Patch idea</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>954088</commentid>
    <comment_count>2</comment_count>
      <attachid>217824</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-11-25 13:51:00 -0800</bug_when>
    <thetext>Comment on attachment 217824
Patch idea

Clearing flags on attachment: 217824

Committed r159764: &lt;http://trac.webkit.org/changeset/159764&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>954089</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-11-25 13:51:01 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955216</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-12-01 19:31:29 -0800</bug_when>
    <thetext>Re-opened since this is blocked by bug 125055</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1503035</commentid>
    <comment_count>5</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2019-02-06 09:03:46 -0800</bug_when>
    <thetext>Mass moving XML DOM bugs to the &quot;DOM&quot; Component.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>217824</attachid>
            <date>2013-11-25 12:57:55 -0800</date>
            <delta_ts>2013-11-25 13:51:00 -0800</delta_ts>
            <desc>Patch idea</desc>
            <filename>bug-124855.diff</filename>
            <type>text/plain</type>
            <size>3736</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBhMWM3MzNmLi5mZTRjOWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg
QEAKKzIwMTMtMTEtMjUgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg
ICAgIERlZHVwbGljYXRlIHNob3J0aXNoIFRleHQgbm9kZSBzdHJpbmdzIGR1cmluZyB0cmVlIGNv
bnN0cnVjdGlvbi4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNDg1NT4KKworICAg
ICAgICBMZXQgSFRNTENvbnN0cnVjdGlvblNpdGUga2VlcCBhIGhhc2ggc2V0IG9mIGFscmVhZHkg
c2VlbiBzdHJpbmdzIG92ZXIKKyAgICAgICAgaXRzIGxpZmV0aW1lLiBVc2UgdGhpcyB0byBkZWR1
cGxpY2F0ZSB0aGUgc3RyaW5ncyBpbnNpZGUgVGV4dCBub2RlcworICAgICAgICBmb3IgYW55IHN0
cmluZyB1cCB0byA2NCBjaGFyYWN0ZXJzIG9mIGxlbmd0aC4KKworICAgICAgICBUaGlzIG9wdGlt
aXphdGlvbiBhbHJlYWR5IHNvcnQtb2YgZXhpc3RlZCBmb3Igd2hpdGVzcGFjZS1vbmx5IFRleHRz
LAorICAgICAgICBidXQgdGhvc2UgYXJlIGxhdW5kZXJlZCBpbiB0aGUgQXRvbWljU3RyaW5nIHRh
YmxlIHdoaWNoIHdlIGRlZmluaXRlbHkKKyAgICAgICAgZG9uJ3Qgd2FudCB0byBwb2xsdXRlIHdp
dGggZXZlcnkgc2luZ2xlIFRleHQuIEl0IG1pZ2h0IGJlIGEgZ29vZCBpZGVhCisgICAgICAgIHRv
IHN0b3AgdXNpbmcgdGhlIEF0b21pY1N0cmluZyB0YWJsZSBmb3IgYWxsLXdoaXRlc3BhY2UgVGV4
dCB0b28uCisKKyAgICAgICAgMy44MiBNQiBwcm9ncmVzc2lvbiBvbiBIVE1MNS04MjY2IGxvY2Fs
bHkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKIDIwMTMtMTEtMjUg
IExhc3psbyBWaWRhY3MgIDxsYWNAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFZlcnRpY2Fs
IGJvcmRlciBzcGFjaW5nIGlzIGRvdWJsZWQgYmV0d2VlbiB0YWJsZSByb3cgZ3JvdXBzCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5j
cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAK
aW5kZXggMTk2M2IyOS4uZjM5ZGRhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9w
YXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv
cGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcApAQCAtNTA1LDExICs1MDUsMTEgQEAgdm9p
ZCBIVE1MQ29uc3RydWN0aW9uU2l0ZTo6aW5zZXJ0VGV4dE5vZGUoY29uc3QgU3RyaW5nJiBjaGFy
YWN0ZXJzLCBXaGl0ZXNwYWNlTW8KICAgICB9CiAKICAgICB3aGlsZSAoY3VycmVudFBvc2l0aW9u
IDwgY2hhcmFjdGVycy5sZW5ndGgoKSkgewotICAgICAgICBSZWZQdHI8VGV4dD4gdGV4dE5vZGUg
PSBUZXh0OjpjcmVhdGVXaXRoTGVuZ3RoTGltaXQodGFzay5wYXJlbnQtPmRvY3VtZW50KCksIHNo
b3VsZFVzZUF0b21pY1N0cmluZyA/IEF0b21pY1N0cmluZyhjaGFyYWN0ZXJzKS5zdHJpbmcoKSA6
IGNoYXJhY3RlcnMsIGN1cnJlbnRQb3NpdGlvbiwgbGVuZ3RoTGltaXQpOworICAgICAgICBSZWZQ
dHI8VGV4dD4gdGV4dE5vZGUgPSBUZXh0OjpjcmVhdGVXaXRoTGVuZ3RoTGltaXQodGFzay5wYXJl
bnQtPmRvY3VtZW50KCksIHN0cmluZ0ZvclRleHROb2RlKGNoYXJhY3RlcnMsIHNob3VsZFVzZUF0
b21pY1N0cmluZyksIGN1cnJlbnRQb3NpdGlvbiwgbGVuZ3RoTGltaXQpOwogICAgICAgICAvLyBJ
ZiB3ZSBoYXZlIGEgd2hvbGUgc3RyaW5nIG9mIHVuYnJlYWthYmxlIGNoYXJhY3RlcnMgdGhlIGFi
b3ZlIGNvdWxkIGxlYWQgdG8gYW4gaW5maW5pdGUgbG9vcC4gRXhjZWVkaW5nIHRoZSBsZW5ndGgg
bGltaXQgaXMgdGhlIGxlc3NlciBldmlsLgogICAgICAgICBpZiAoIXRleHROb2RlLT5sZW5ndGgo
KSkgewogICAgICAgICAgICAgU3RyaW5nIHN1YnN0cmluZyA9IGNoYXJhY3RlcnMuc3Vic3RyaW5n
KGN1cnJlbnRQb3NpdGlvbik7Ci0gICAgICAgICAgICB0ZXh0Tm9kZSA9IFRleHQ6OmNyZWF0ZSh0
YXNrLnBhcmVudC0+ZG9jdW1lbnQoKSwgc2hvdWxkVXNlQXRvbWljU3RyaW5nID8gQXRvbWljU3Ry
aW5nKHN1YnN0cmluZykuc3RyaW5nKCkgOiBzdWJzdHJpbmcpOworICAgICAgICAgICAgdGV4dE5v
ZGUgPSBUZXh0OjpjcmVhdGUodGFzay5wYXJlbnQtPmRvY3VtZW50KCksIHN0cmluZ0ZvclRleHRO
b2RlKHN1YnN0cmluZywgc2hvdWxkVXNlQXRvbWljU3RyaW5nKSk7CiAgICAgICAgIH0KIAogICAg
ICAgICBjdXJyZW50UG9zaXRpb24gKz0gdGV4dE5vZGUtPmxlbmd0aCgpOwpAQCAtNjY2LDQgKzY2
NiwxNCBAQCB2b2lkIEhUTUxDb25zdHJ1Y3Rpb25TaXRlOjpmb3N0ZXJQYXJlbnQoUGFzc1JlZlB0
cjxOb2RlPiBub2RlKQogICAgIG1fYXR0YWNobWVudFF1ZXVlLmFwcGVuZCh0YXNrKTsKIH0KIAor
U3RyaW5nIEhUTUxDb25zdHJ1Y3Rpb25TaXRlOjpzdHJpbmdGb3JUZXh0Tm9kZShjb25zdCBTdHJp
bmcmIHN0cmluZywgYm9vbCBzaG91bGRVc2VBdG9taWNTdHJpbmcpCit7CisgICAgc3RhdGljIGNv
bnN0IHVuc2lnbmVkIG1heGltdW1MZW5ndGhGb3JEZWR1cGxpY2F0aW9uID0gNjQ7CisgICAgaWYg
KHNob3VsZFVzZUF0b21pY1N0cmluZykKKyAgICAgICAgcmV0dXJuIEF0b21pY1N0cmluZyhzdHJp
bmcpLnN0cmluZygpOworICAgIGlmIChzdHJpbmcubGVuZ3RoKCkgPiBtYXhpbXVtTGVuZ3RoRm9y
RGVkdXBsaWNhdGlvbikKKyAgICAgICAgcmV0dXJuIHN0cmluZzsKKyAgICByZXR1cm4gKm1fc3Ry
aW5nc0ZvckRlZHVwbGljYXRpb24uYWRkKHN0cmluZykuaXRlcmF0b3I7Cit9CisKIH0KZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmgg
Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5oCmluZGV4
IGQ0YzAzMTMuLmZmZGNkNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2Vy
L0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIv
SFRNTENvbnN0cnVjdGlvblNpdGUuaApAQCAtMTcwLDYgKzE3MCw4IEBAIHByaXZhdGU6CiAgICAg
dm9pZCBtZXJnZUF0dHJpYnV0ZXNGcm9tVG9rZW5JbnRvRWxlbWVudChBdG9taWNIVE1MVG9rZW4q
LCBFbGVtZW50Kik7CiAgICAgdm9pZCBkaXNwYXRjaERvY3VtZW50RWxlbWVudEF2YWlsYWJsZUlm
TmVlZGVkKCk7CiAKKyAgICBTdHJpbmcgc3RyaW5nRm9yVGV4dE5vZGUoY29uc3QgU3RyaW5nJiwg
Ym9vbCBzaG91bGRVc2VBdG9taWNTdHJpbmcpOworCiAgICAgRG9jdW1lbnQqIG1fZG9jdW1lbnQ7
CiAgICAgCiAgICAgLy8gVGhpcyBpcyB0aGUgcm9vdCBDb250YWluZXJOb2RlIHRvIHdoaWNoIHRo
ZSBwYXJzZXIgYXR0YWNoZXMgYWxsIG5ld2x5CkBAIC0xOTYsNiArMTk4LDggQEAgcHJpdmF0ZToK
ICAgICB1bnNpZ25lZCBtX21heGltdW1ET01UcmVlRGVwdGg7CiAKICAgICBib29sIG1faW5RdWly
a3NNb2RlOworCisgICAgSGFzaFNldDxTdHJpbmc+IG1fc3RyaW5nc0ZvckRlZHVwbGljYXRpb247
CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>