124834 2013-11-25 02:43:42 -0800 REGRESSION(r159575): fast/block/float/clear-negative-margin-top.html reftest is failing 2017-10-04 10:15:49 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure, Regression P2 Normal --- 125406 125409 1 zan zan bugs-noreply cgarcia mrobinson oldest_to_newest 953936 0 zan 2013-11-25 02:43:42 -0800 After r159575, the fast/block/float/clear-negative-margin-top.html reftest is failing with a minimal difference between the reftest and the reference file. http://trac.webkit.org/changeset/159575 http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fblock%2Ffloat%2Fclear-negative-margin-top.html Specific to the GTK port, and probably an issue in font rendering. 954019 1 217811 zan 2013-11-25 09:12:26 -0800 Created attachment 217811 Simplified test case -- test file A simplified test file. 954020 2 217812 zan 2013-11-25 09:12:52 -0800 Created attachment 217812 Simplified test case -- reference file 954027 3 zan 2013-11-25 09:30:47 -0800 The test file draws the 'ggggggg' text over the #visible <div>. The reference file produces a render tree in which the #visible <div> (which is now positioned relatively) is located in its own layer, and is drawn after the text, and is subsequently drawn over it. The bottoms of the first five letters 'g' are therefor painted over when viewing the reference file. This boils down to the text being rendered in boxes of which the height is 17px, while the font itself measures 18px in height. As a proof, adding 'margin-top: 1px' to the #visible rule simply pushes the colored <div> 1 pixel down, and the text is rendered correctly in both cases, with the <div> not being drawn over it when it is positioned relatively. This problem is evident in basically all render tree baselines for tests that contain text -- the text is rendered 17px high, instead of 18px. 954497 4 217939 zan 2013-11-27 04:02:13 -0800 Created attachment 217939 Patch 954548 5 217939 mrobinson 2013-11-27 08:00:55 -0800 Comment on attachment 217939 Patch Wow...annoying. 1356481 6 cgarcia 2017-10-04 10:15:49 -0700 This started to pass after the freetype upgrade in r221670 217811 2013-11-25 09:12:26 -0800 2013-11-25 09:12:26 -0800 Simplified test case -- test file simple.html text/html 136 zan PHN0eWxlPgogICAgI3Zpc2libGUgeyBoZWlnaHQ6IDIwcHg7IHdpZHRoOjQwcHg7IGZsb2F0Omxl ZnQ7IGJhY2tncm91bmQtY29sb3I6IGJsdWU7IH0KPC9zdHlsZT4KZ2dnZ2dnZzxicj4KPGRpdiBp ZD0idmlzaWJsZSI+PC9kaXY+CQkJCg== 217812 2013-11-25 09:12:52 -0800 2013-11-25 09:12:52 -0800 Simplified test case -- reference file simple-expected.html text/html 160 zan PHN0eWxlPgogICAgI3Zpc2libGUgeyBoZWlnaHQ6IDIwcHg7IHdpZHRoOjQwcHg7IGZsb2F0Omxl ZnQ7IGJhY2tncm91bmQtY29sb3I6IGJsdWU7IH0KPC9zdHlsZT4KZ2dnZ2dnZzxicj4KPGRpdiBz dHlsZT0icG9zaXRpb246cmVsYXRpdmU7IiBpZD0idmlzaWJsZSI+PC9kaXY+Cg== 217939 2013-11-27 04:02:13 -0800 2013-11-27 08:00:54 -0800 Patch bug-124834-20131127040211.patch text/plain 4052 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5Nzc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODY5YWU2N2YxYjVkMzhlNDFlZWNmNzJhNWFjNzQ3ZGRj NDFhNDViYS4uZTU3YzEzODNlMzZjYmE1MjI0N2Y0MTg3Y2M1OTZjMWJjMjUyYzdjNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEzLTExLTI3ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwor ICAgICAgICBSRUdSRVNTSU9OKHIxNTk1NzUpOiBmYXN0L2Jsb2NrL2Zsb2F0L2NsZWFyLW5lZ2F0 aXZlLW1hcmdpbi10b3AuaHRtbCByZWZ0ZXN0IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDgzNAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3AgYXBwbHlpbmcgdGhlIGFkZGl0aW9u YWwgcGF0Y2ggdG8gdGhlIEZyZWVUeXBlIHNvdXJjZSB0cmVlIHRoYXQgd2FzIHRoZW4gYnVpbHQg YW5kIGluc3RhbGxlZAorICAgICAgICBpbnRvIHRoZSBKaGJ1aWxkIGVudmlyb25tZW50LiBUaGUg cGF0Y2ggY2hhbmdlZCB0aGUgcm91bmRpbmcgb2YgZm9udCBoZWlnaHQsIHJlc3VsdGluZyBpbiBu bworICAgICAgICBsaW5lIGdhcC4gRm9yIGEgZm9udCB0aGF0J3MgMTZweCBoaWdoLCB0aGlzIG1l YW50IHRoYXQgdGhlIFJlbmRlclRleHQgb2JqZWN0IGtlcHQgdGhlIGhlaWdodCBvZiAxN3B4Cisg ICAgICAgIHdoaWxlIHRoZSBlbmNsb3NpbmcgcmVuZGVyIG9iamVjdCBhbHNvIG1lYXN1cmVkIDE3 cHggaW4gaGVpZ2h0LCBpbnN0ZWFkIG9mIHRoZSBleHBlY3RlZCAxOHB4IGR1ZSB0bworICAgICAg ICB0aGUgbGluZSBnYXAuCisKKyAgICAgICAgVGhlIHBhdGNoIGRpZCBsYW5kIGluIEZyZWVUeXBl LCBidXQgd2FzIHJldmVydGVkIGp1c3QgYSBjb3VwbGUgb2YgZGF5cyBsYXRlci4KKworICAgICAg ICBBIGxhcmdlIGFtb3VudCBvZiByZWJhc2VsaW5pbmcgd2lsbCBmb2xsb3cgYWZ0ZXIgdGhlc2Ug Y2hhbmdlcyBsYW5kLgorCisgICAgICAgICogZ3RrL2poYnVpbGQubW9kdWxlczoKKyAgICAgICAg KiBndGsvcGF0Y2hlcy9mcmVldHlwZTYtMi40LjExLXRydWV0eXBlLWZvbnQtaGVpZ2h0LWZpeC5w YXRjaDogUmVtb3ZlZC4KKwogMjAxMy0xMS0yNSAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gVXNlIENvbmZpZyBtb2RlIG9mIGZpbmRfcGFja2Fn ZSBmb3IgRUZMIDEuOApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcyBiL1Rv b2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggNzE2NjFhYWUxMDdjMDM2YmEwYWExZDNjYjc2 ZTJmY2I1ZWIxMDNiZi4uYWRmOGUyYjNhNzA2NGI2ZWNkZDk4ZTZjYWVkYzMzNDZlMzgzMjdmZCAx MDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9ndGsvamhi dWlsZC5tb2R1bGVzCkBAIC0xMDAsNyArMTAwLDYgQEAKICAgICAgICAgICAgIHJlcG89InNhdmFu bmFoLmdudS5vcmciCiAgICAgICAgICAgICBoYXNoPSJzaGEyNTY6ZWY5ZDBiY2I2NDY0N2Q5ZTUx MjVkYzc1MzRkN2NhMzcxYzk4MzEwZmVjODc2NzdjNDEwZjM5N2Y3MWZmYmUzZiIKICAgICAgICAg ICAgIG1kNXN1bT0iYjkzNDM1NDg4OTQyNDg2YzhkMGNhMjJlOGY3NjgwMzQiPgotICAgICAgPHBh dGNoIGZpbGU9ImZyZWV0eXBlNi0yLjQuMTEtdHJ1ZXR5cGUtZm9udC1oZWlnaHQtZml4LnBhdGNo IiBzdHJpcD0iMSIvPgogICAgIDwvYnJhbmNoPgogICA8L2F1dG90b29scz4KIApkaWZmIC0tZ2l0 IGEvVG9vbHMvZ3RrL3BhdGNoZXMvZnJlZXR5cGU2LTIuNC4xMS10cnVldHlwZS1mb250LWhlaWdo dC1maXgucGF0Y2ggYi9Ub29scy9ndGsvcGF0Y2hlcy9mcmVldHlwZTYtMi40LjExLXRydWV0eXBl LWZvbnQtaGVpZ2h0LWZpeC5wYXRjaApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMGZm ZTc2YjRlZjAyMThjNzFlMTY3MzBjOGQ0MDZjYjUzZGU3YTAxYS4uMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Ub29scy9ndGsvcGF0Y2hlcy9mcmVldHlwZTYt Mi40LjExLXRydWV0eXBlLWZvbnQtaGVpZ2h0LWZpeC5wYXRjaAorKysgL2Rldi9udWxsCkBAIC0x LDM5ICswLDAgQEAKLUZyb20gZTA0NjkzNzJiZTM4NzBhNWFkNjBiMmM0NTg2ZTljMjgxMzU3YmQy OCBNb24gU2VwIDE3IDAwOjAwOjAwIDIwMDEKLUZyb206IFdlcm5lciBMZW1iZXJnIDx3bEBnbnUu b3JnPgotRGF0ZTogVHVlLCAyMiBKYW4gMjAxMyAxMDowNzowNyArMDAwMAotU3ViamVjdDogW3Ry dWV0eXBlXSBGaXggZm9udCBoZWlnaHQuCi0KLSogc3JjL3RydWV0eXBlL3R0b2Jqcy5jICh0dF9z aXplX3Jlc2V0KTogVGhlIFdpbmRvd3MgcmVuZGVyaW5nCi1lbmdpbmUgdXNlcyByb3VuZGVkIHZh bHVlcyBvZiB0aGUgYXNjZW5kZXIgYW5kIGRlc2NlbmRlciB0byBjb21wdXRlCi10aGUgVHJ1ZVR5 cGUgZm9udCBoZWlnaHQuCi0tLS0KLWRpZmYgLS1naXQgYS9zcmMvdHJ1ZXR5cGUvdHRvYmpzLmMg Yi9zcmMvdHJ1ZXR5cGUvdHRvYmpzLmMKLWluZGV4IGM2MWIyMTguLjU5MGI2NmMgMTAwNjQ0Ci0t LS0gYS9zcmMvdHJ1ZXR5cGUvdHRvYmpzLmMKLSsrKyBiL3NyYy90cnVldHlwZS90dG9ianMuYwot QEAgLTQsNyArNCw3IEBACi0gLyogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKi8KLSAvKiAgICBPYmplY3RzIG1h bmFnZXIgKGJvZHkpLiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAqLwotIC8qICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICovCi0tLyogIENvcHlyaWdodCAxOTk2LTIwMTIgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKi8KLSsvKiAg Q29weXJpZ2h0IDE5OTYtMjAxMyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAqLwotIC8qICBEYXZpZCBUdXJuZXIsIFJvYmVydCBXaWxoZWxtLCBhbmQg V2VybmVyIExlbWJlcmcuICAgICAgICAgICAgICAgICAgICAgICovCi0gLyogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKi8KLSAvKiAgVGhpcyBmaWxlIGlzIHBhcnQgb2YgdGhlIEZyZWVUeXBlIHByb2plY3QsIGFu ZCBtYXkgb25seSBiZSB1c2VkLCAgICAgICAqLwotQEAgLTExNzcsMTEgKzExNzcsMTIgQEAKLSAg ICAgICAgIEZUX1BJWF9ST1VORCggRlRfTXVsRml4KCBmYWNlLT5yb290LmFzY2VuZGVyLCBtZXRy aWNzLT55X3NjYWxlICkgKTsKLSAgICAgICBtZXRyaWNzLT5kZXNjZW5kZXIgPQotICAgICAgICAg RlRfUElYX1JPVU5EKCBGVF9NdWxGaXgoIGZhY2UtPnJvb3QuZGVzY2VuZGVyLCBtZXRyaWNzLT55 X3NjYWxlICkgKTsKLS0gICAgICBtZXRyaWNzLT5oZWlnaHQgPQotLSAgICAgICAgRlRfUElYX1JP VU5EKCBGVF9NdWxGaXgoIGZhY2UtPnJvb3QuaGVpZ2h0LCBtZXRyaWNzLT55X3NjYWxlICkgKTsK LSAgICAgICBtZXRyaWNzLT5tYXhfYWR2YW5jZSA9Ci0gICAgICAgICBGVF9QSVhfUk9VTkQoIEZU X011bEZpeCggZmFjZS0+cm9vdC5tYXhfYWR2YW5jZV93aWR0aCwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBtZXRyaWNzLT54X3NjYWxlICkgKTsKLSsKLSsgICAgICAvKiB0aGUg aGVpZ2h0IGlzIGRlcml2ZWQgZnJvbSByb3VuZGVkIHZhbHVlcyAqLwotKyAgICAgIG1ldHJpY3Mt PmhlaWdodCA9IG1ldHJpY3MtPmFzY2VuZGVyIC0gbWV0cmljcy0+ZGVzY2VuZGVyOwotICAgICB9 Ci0gCi0gICAgIC8qIGNvbXB1dGUgbmV3IHRyYW5zZm9ybWF0aW9uICovCi0tLQotY2dpdCB2MC45 LjAuMgo=