124832 2013-11-25 01:47:05 -0800 [EFL] Ensure EGLOffScreenContext::initialize calls platformMakeCurrent on the surface 2014-05-21 02:11:57 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 spena spena bunhere cmarcelo commit-queue gyuyoung.kim hw1008.kim kenneth kkristof lucas.de.marchi luiz noam ossy sergio szledan zeno zherczeg oldest_to_newest 953923 0 spena 2013-11-25 01:47:05 -0800 Currently EGLOffScreenContext::initialize only calls platformMakeCurrent when the GL_EXT_robustness extension is available. platformMakeCurrent should be call regardless of the availability of the extension. Patch following now. 953926 1 217778 spena 2013-11-25 01:52:55 -0800 Created attachment 217778 Patch 960878 2 spena 2013-12-18 03:08:19 -0800 This bug also affects NIX port. 1007263 3 gyuyoung.kim 2014-05-07 02:56:30 -0700 Ryuan and Hyowon, does EFL port need to use this patch ? 1010417 4 hw1008.kim 2014-05-20 00:17:29 -0700 I think we need to call eglDestroyContext if platformMakeCurrent is failed on the line 104. 1010428 5 spena 2014-05-20 01:23:04 -0700 (In reply to comment #4) > I think we need to call eglDestroyContext if platformMakeCurrent is failed on the line 104. Ah, like we do on line 96? I will update the patch, thanks. 1010465 6 231762 spena 2014-05-20 05:46:08 -0700 Created attachment 231762 Patch 1010474 7 231762 tonikitoo 2014-05-20 06:24:27 -0700 Comment on attachment 231762 Patch You could say what problem this patch fixes, maybe? 1010494 8 231768 spena 2014-05-20 08:05:17 -0700 Created attachment 231768 Patch 1010495 9 spena 2014-05-20 08:10:26 -0700 (In reply to comment #7) > (From update of attachment 231762 [details]) > You could say what problem this patch fixes, maybe? Hopefully this version is a bit more clear in the changelog =) 1010501 10 231768 tonikitoo 2014-05-20 08:37:41 -0700 Comment on attachment 231768 Patch r=me 1010506 11 spena 2014-05-20 09:11:13 -0700 (In reply to comment #10) > (From update of attachment 231768 [details]) > r=me Thanks for the review! I will land it tomorrow. 1010726 12 231768 commit-queue 2014-05-21 02:11:47 -0700 Comment on attachment 231768 Patch Clearing flags on attachment: 231768 Committed r169153: <http://trac.webkit.org/changeset/169153> 1010727 13 commit-queue 2014-05-21 02:11:57 -0700 All reviewed patches have been landed. Closing bug. 217778 2013-11-25 01:52:55 -0800 2014-05-20 05:45:59 -0700 Patch bug-124832-20131125095234.patch text/plain 1947 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmUyZjVmNzI2MmRkZTZh NzRjMmMzMGJkN2FhYzUzYTM2ZjRlYjlmMS4uZWVmODA5MjllODUxZGIyZjI3ZDZmYjc3MzQ1YWYx ZmYzNTg4YzUxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTExLTI1ICBTaW1v biBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBFbnN1cmUg RUdMT2ZmU2NyZWVuQ29udGV4dDo6aW5pdGlhbGl6ZSBjYWxscyBwbGF0Zm9ybU1ha2VDdXJyZW50 IG9uIHRoZSBzdXJmYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjQ4MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBFbnN1cmUgcGxhdGZvcm1NYWtlQ3VycmVudCBpcyBjYWxsZWQgb24KKyAgICAgICAg RUdMT2ZmU2NyZWVuQ29udGV4dDo6aW5pdGlhbGl6ZSwgZXZlbiB3aGVuIHRoZSBHTF9FWFRfcm9i dXN0bmVzcworICAgICAgICBleHRlbnNpb24gaXMgbm90IGF2YWlsYWJsZS4gQ3VycmVudGx5LCB3 aGVuIHRoZSBleHRlbnNpb24gaXMgbm90CisgICAgICAgIHN1cHBvcnRlZCwgYSBjb250ZXh0IGlz IGNyZWF0ZWQgd2l0aG91dCB0aGUgZXh0ZW5zaW9uIGF0dHJpYnV0ZXMsCisgICAgICAgIGJ1dCB0 aGF0IGNvZGUgcGF0aCB3YXMgbWlzc2luZyB0aGUgcGxhdGZvcm1NYWtlQ3VycmVudCBjYWxsLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZWdsL0VHTENvbnRleHQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RUdMT2ZmU2NyZWVuQ29udGV4dDo6aW5pdGlhbGl6ZSk6CisK IDIwMTMtMTEtMTggIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0NTUyBHcmlkIExheW91dF0gQ2FjaGUgc2V2ZXJhbCB2ZWN0b3JzIHRvIGF2b2lk IG1hbGxvYy9mcmVlIGNodXJuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29udGV4dC5jcHAKaW5kZXggYzIwOGRjYzM3 NTA4MTRiODdmY2ViYjI5MDc4ODVlOGUwMzhjY2ZjNC4uNGE5Y2MwMjcwOGE1MmYzZWU4ZjIwNjFi NTVkZjJhY2JkZWY3MDU1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvc3VyZmFjZXMvZWdsL0VHTENvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2VnbC9FR0xDb250ZXh0LmNwcApAQCAtOTksOCArOTks MTAgQEAgYm9vbCBFR0xPZmZTY3JlZW5Db250ZXh0Ojppbml0aWFsaXplKEdMUGxhdGZvcm1TdXJm YWNlKiBzdXJmYWNlLCBQbGF0Zm9ybUNvbnRleHQKICAgICAgICAgICAgIGVnbERlc3Ryb3lDb250 ZXh0KG1fZGlzcGxheSwgbV9jb250ZXh0SGFuZGxlKTsKICAgICB9CiAKLSAgICBpZiAobV9jb250 ZXh0SGFuZGxlID09IEVHTF9OT19DT05URVhUKQorICAgIGlmIChtX2NvbnRleHRIYW5kbGUgPT0g RUdMX05PX0NPTlRFWFQpIHsKICAgICAgICAgbV9jb250ZXh0SGFuZGxlID0gZWdsQ3JlYXRlQ29u dGV4dChtX2Rpc3BsYXksIGNvbmZpZywgc2hhcmVkQ29udGV4dCwgY29udGV4dEF0dHJpYnV0ZXMp OworICAgICAgICByZXR1cm4gcGxhdGZvcm1NYWtlQ3VycmVudChzdXJmYWNlKTsKKyAgICB9CiAK ICAgICBpZiAobV9jb250ZXh0SGFuZGxlICE9IEVHTF9OT19DT05URVhUKQogICAgICAgICByZXR1 cm4gdHJ1ZTsK 231762 2014-05-20 05:46:08 -0700 2014-05-20 08:05:05 -0700 Patch bug-124832-20140520134532.patch text/plain 2017 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZhNTViNjIxZDRiOWI0 NjkzNzM4ZjRlZjg3OTUxNGM0ODZkYWQ3MC4uZTZkYWI5ZDNmODM5YmY3NTA3YzAzYzM4ZGZkNDVm M2YzMDIxYzgwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA1LTIwICBTaW1v biBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBFbnN1cmUg RUdMT2ZmU2NyZWVuQ29udGV4dDo6aW5pdGlhbGl6ZSBjYWxscyBwbGF0Zm9ybU1ha2VDdXJyZW50 IG9uIHRoZSBzdXJmYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjQ4MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBFbnN1cmUgcGxhdGZvcm1NYWtlQ3VycmVudCBpcyBjYWxsZWQgb24KKyAgICAgICAg RUdMT2ZmU2NyZWVuQ29udGV4dDo6aW5pdGlhbGl6ZSwgZXZlbiB3aGVuIHRoZSBHTF9FWFRfcm9i dXN0bmVzcworICAgICAgICBleHRlbnNpb24gaXMgbm90IGF2YWlsYWJsZS4gQ3VycmVudGx5LCB3 aGVuIHRoZSBleHRlbnNpb24gaXMgbm90CisgICAgICAgIHN1cHBvcnRlZCwgYSBjb250ZXh0IGlz IGNyZWF0ZWQgd2l0aG91dCB0aGUgZXh0ZW5zaW9uIGF0dHJpYnV0ZXMsCisgICAgICAgIGJ1dCB0 aGF0IGNvZGUgcGF0aCB3YXMgbWlzc2luZyB0aGUgcGxhdGZvcm1NYWtlQ3VycmVudCBjYWxsLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZWdsL0VHTENvbnRleHQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RUdMT2ZmU2NyZWVuQ29udGV4dDo6aW5pdGlhbGl6ZSk6CisK IDIwMTQtMDUtMTkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAg ICAgICAgU2Nyb2xsaW5nIHBhZ2VzIHdpdGggbGFyZ2UgVGlsZWRCYWNraW5nIGNvbnRlbnQgbGF5 ZXJzIGNyZWF0ZXMgd2F5IHRvbyBtYW55IHRpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29udGV4dC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29udGV4dC5jcHAKaW5k ZXggYzIwOGRjYzM3NTA4MTRiODdmY2ViYjI5MDc4ODVlOGUwMzhjY2ZjNC4uNjJhZjQ0MzA5NGZi ODFlOWRjMTBkODQ0YmJlMDE2Mzc2MzVlNmY5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZWdsL0VHTENvbnRleHQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2VnbC9FR0xDb250ZXh0LmNwcApA QCAtOTksOCArOTksMTEgQEAgYm9vbCBFR0xPZmZTY3JlZW5Db250ZXh0Ojppbml0aWFsaXplKEdM UGxhdGZvcm1TdXJmYWNlKiBzdXJmYWNlLCBQbGF0Zm9ybUNvbnRleHQKICAgICAgICAgICAgIGVn bERlc3Ryb3lDb250ZXh0KG1fZGlzcGxheSwgbV9jb250ZXh0SGFuZGxlKTsKICAgICB9CiAKLSAg ICBpZiAobV9jb250ZXh0SGFuZGxlID09IEVHTF9OT19DT05URVhUKQorICAgIGlmIChtX2NvbnRl eHRIYW5kbGUgPT0gRUdMX05PX0NPTlRFWFQpIHsKICAgICAgICAgbV9jb250ZXh0SGFuZGxlID0g ZWdsQ3JlYXRlQ29udGV4dChtX2Rpc3BsYXksIGNvbmZpZywgc2hhcmVkQ29udGV4dCwgY29udGV4 dEF0dHJpYnV0ZXMpOworICAgICAgICBpZiAoIXBsYXRmb3JtTWFrZUN1cnJlbnQoc3VyZmFjZSkp CisgICAgICAgICAgICBlZ2xEZXN0cm95Q29udGV4dChtX2Rpc3BsYXksIG1fY29udGV4dEhhbmRs ZSk7CisgICAgfQogCiAgICAgaWYgKG1fY29udGV4dEhhbmRsZSAhPSBFR0xfTk9fQ09OVEVYVCkK ICAgICAgICAgcmV0dXJuIHRydWU7Cg== 231768 2014-05-20 08:05:17 -0700 2014-05-21 02:11:46 -0700 Patch bug-124832-20140520160441.patch text/plain 2159 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZhNTViNjIxZDRiOWI0 NjkzNzM4ZjRlZjg3OTUxNGM0ODZkYWQ3MC4uNmQ3MzA0OGVkZmI5MmEyY2FkODg3ZjU1ZmU1MDlk NTZhZjBmZGJjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA1LTIwICBTaW1v biBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBFbnN1cmUg RUdMT2ZmU2NyZWVuQ29udGV4dDo6aW5pdGlhbGl6ZSBjYWxscyBwbGF0Zm9ybU1ha2VDdXJyZW50 IG9uIHRoZSBzdXJmYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjQ4MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgb3JpZ2luYWwgY29kZSB3YXMgb25seSBjYWxsaW5nIHBsYXRmb3JtTWFrZUN1 cnJlbnQgd2hlbiB0aGUKKyAgICAgICAgR0xfRVhUX3JvYnVzdG5lc3MgZXh0ZW5zaW9uIGlzIHN1 cHBvcnRlZDogdGhlIGFsdGVybmF0ZSBjb2RlIHBhdGgKKyAgICAgICAgd291bGQgb25seSBjcmVh dGUgYSBjb250ZXh0LCBidXQgaXQgd291bGRuJ3QgbWFrZSB0aGF0IGNvbnRleHQKKyAgICAgICAg Y3VycmVudC4gVGhpcyBwYXRjaCBlbnN1cmVzIHBsYXRmb3JtTWFrZUN1cnJlbnQgaXMgYWxzbyBj YWxsZWQgZm9yCisgICAgICAgIHRoZSBhbHRlcm5hdGUgY29kZSBwYXRoLCBhbmQsIGlmIGl0IGZh aWxzIHRvIG1ha2UgdGhlIGNvbnRleHQKKyAgICAgICAgY3VycmVudCwgd2lsbCBkZXN0cm95IHRo ZSBjb250ZXh0LiBFZmZlY3RpdmVseSwgdGhpcyBtYWtlcyBib3RoCisgICAgICAgIGNvZGUgcGF0 aHMgYmVoYXZlIGluIHRoZSBzYW1lIHdheS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L3N1cmZhY2VzL2VnbC9FR0xDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVHTE9mZlNj cmVlbkNvbnRleHQ6OmluaXRpYWxpemUpOgorCiAyMDE0LTA1LTE5ICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNjcm9sbGluZyBwYWdlcyB3aXRoIGxh cmdlIFRpbGVkQmFja2luZyBjb250ZW50IGxheWVycyBjcmVhdGVzIHdheSB0b28gbWFueSB0aWxl cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMv ZWdsL0VHTENvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3Vy ZmFjZXMvZWdsL0VHTENvbnRleHQuY3BwCmluZGV4IGMyMDhkY2MzNzUwODE0Yjg3ZmNlYmIyOTA3 ODg1ZThlMDM4Y2NmYzQuLjYyYWY0NDMwOTRmYjgxZTlkYzEwZDg0NGJiZTAxNjM3NjM1ZTZmOTIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2Vn bC9FR0xDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z dXJmYWNlcy9lZ2wvRUdMQ29udGV4dC5jcHAKQEAgLTk5LDggKzk5LDExIEBAIGJvb2wgRUdMT2Zm U2NyZWVuQ29udGV4dDo6aW5pdGlhbGl6ZShHTFBsYXRmb3JtU3VyZmFjZSogc3VyZmFjZSwgUGxh dGZvcm1Db250ZXh0CiAgICAgICAgICAgICBlZ2xEZXN0cm95Q29udGV4dChtX2Rpc3BsYXksIG1f Y29udGV4dEhhbmRsZSk7CiAgICAgfQogCi0gICAgaWYgKG1fY29udGV4dEhhbmRsZSA9PSBFR0xf Tk9fQ09OVEVYVCkKKyAgICBpZiAobV9jb250ZXh0SGFuZGxlID09IEVHTF9OT19DT05URVhUKSB7 CiAgICAgICAgIG1fY29udGV4dEhhbmRsZSA9IGVnbENyZWF0ZUNvbnRleHQobV9kaXNwbGF5LCBj b25maWcsIHNoYXJlZENvbnRleHQsIGNvbnRleHRBdHRyaWJ1dGVzKTsKKyAgICAgICAgaWYgKCFw bGF0Zm9ybU1ha2VDdXJyZW50KHN1cmZhY2UpKQorICAgICAgICAgICAgZWdsRGVzdHJveUNvbnRl eHQobV9kaXNwbGF5LCBtX2NvbnRleHRIYW5kbGUpOworICAgIH0KIAogICAgIGlmIChtX2NvbnRl eHRIYW5kbGUgIT0gRUdMX05PX0NPTlRFWFQpCiAgICAgICAgIHJldHVybiB0cnVlOwo=