124821 2013-11-24 18:04:48 -0800 check-webkit-style should check for extraneous newline between config.h and primary header 2013-11-29 06:30:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.webkit.org/coding/coding-style.html#include-config-h P2 Normal --- 1 burg webkit-unassigned commit-queue darin glenn llango.u-szeged ossy oldest_to_newest 953880 0 burg 2013-11-24 18:04:48 -0800 The solution should be added in the vicinity of Source/Tools/Scripts/webkitpy/style/checkers/cpp.py, in function check_include_line. 954521 1 llango.u-szeged 2013-11-27 06:04:11 -0800 (In reply to comment #0) > The solution should be added in the vicinity of Source/Tools/Scripts/webkitpy/style/checkers/cpp.py, in function check_include_line. Why do you want an extra blank line between the config.h and primary header? On the given URL there is no such rule. 954575 2 burg 2013-11-27 10:39:29 -0800 extraneous, meaning that it is not necessary. So the following is good: #include "config.h" #include "Foo.h" the following is discouraged: #include "config.h" #include "Foo.h" 954900 3 218038 gbalogh.u-szeged 2013-11-29 00:58:07 -0800 Created attachment 218038 patch 954927 4 218038 ossy 2013-11-29 03:02:48 -0800 Comment on attachment 218038 patch View in context: https://bugs.webkit.org/attachment.cgi?id=218038&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:2821 > # Check to make sure we have a blank line after primary header. Please fix this comment before landing. 954951 5 218055 gbalogh.u-szeged 2013-11-29 05:42:00 -0800 Created attachment 218055 patch fix 954962 6 218055 commit-queue 2013-11-29 06:30:13 -0800 Comment on attachment 218055 patch fix Clearing flags on attachment: 218055 Committed r159872: <http://trac.webkit.org/changeset/159872> 954963 7 commit-queue 2013-11-29 06:30:15 -0800 All reviewed patches have been landed. Closing bug. 218038 2013-11-29 00:58:07 -0800 2013-11-29 05:42:00 -0800 patch f2592.diff text/plain 3616 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1OWIw ZWRhLi5mYTc3Y2M5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMTEtMjggIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBzaG91bGQg Y2hlY2sgZm9yIGV4dHJhbmVvdXMgbmV3bGluZSBiZXR3ZWVuIGNvbmZpZy5oIGFuZCBwcmltYXJ5 IGhlYWRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNDgyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVj a19pbmNsdWRlX2xpbmUpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoT3JkZXJPZkluY2x1ZGVzVGVzdC50ZXN0X2No ZWNrX2xpbmVfYnJlYWtfYWZ0ZXJfb3duX2hlYWRlcik6CisgICAgICAgIChPcmRlck9mSW5jbHVk ZXNUZXN0KToKKyAgICAgICAgKE9yZGVyT2ZJbmNsdWRlc1Rlc3QudGVzdF9jaGVja19saW5lX2Jy ZWFrX2JlZm9yZV9vd25faGVhZGVyKToKKwogMjAxMy0xMS0yMSAgUGV0ZXIgTW9sbmFyICA8cG1v bG5hci51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFJlbW92ZSBFTkFC TEVfV09SS0VSUwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5w eQppbmRleCAyZDU1OWJkLi5jOGZiZWYwIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMjgyMCwxMCArMjgyMCwxNCBAQCBkZWYgY2hlY2tfaW5j bHVkZV9saW5lKGZpbGVuYW1lLCBmaWxlX2V4dGVuc2lvbiwgY2xlYW5fbGluZXMsIGxpbmVfbnVt YmVyLCBpbmNsdQogCiAgICAgIyBDaGVjayB0byBtYWtlIHN1cmUgd2UgaGF2ZSBhIGJsYW5rIGxp bmUgYWZ0ZXIgcHJpbWFyeSBoZWFkZXIuCiAgICAgaWYgbm90IGVycm9yX21lc3NhZ2UgYW5kIGhl YWRlcl90eXBlID09IF9QUklNQVJZX0hFQURFUjoKLSAgICAgICAgIG5leHRfbGluZSA9IGNsZWFu X2xpbmVzLnJhd19saW5lc1tsaW5lX251bWJlciArIDFdCi0gICAgICAgICBpZiBub3QgaXNfYmxh bmtfbGluZShuZXh0X2xpbmUpOgorICAgICAgICBuZXh0X2xpbmUgPSBjbGVhbl9saW5lcy5yYXdf bGluZXNbbGluZV9udW1iZXIgKyAxXQorICAgICAgICBwcmV2aW91c19saW5lID0gY2xlYW5fbGlu ZXMucmF3X2xpbmVzW2xpbmVfbnVtYmVyIC0gMV0KKyAgICAgICAgaWYgbm90IGlzX2JsYW5rX2xp bmUobmV4dF9saW5lKToKICAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnYnVpbGQvaW5j bHVkZV9vcmRlcicsIDQsCi0gICAgICAgICAgICAgICAgICAnWW91IHNob3VsZCBhZGQgYSBibGFu ayBsaW5lIGFmdGVyIGltcGxlbWVudGF0aW9uIGZpbGVcJ3Mgb3duIGhlYWRlci4nKQorICAgICAg ICAgICAgICAgICdZb3Ugc2hvdWxkIGFkZCBhIGJsYW5rIGxpbmUgYWZ0ZXIgaW1wbGVtZW50YXRp b24gZmlsZVwncyBvd24gaGVhZGVyLicpCisgICAgICAgIGlmIGlzX2JsYW5rX2xpbmUocHJldmlv dXNfbGluZSk6CisgICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ2J1aWxkL2luY2x1ZGVf b3JkZXInLCA0LAorICAgICAgICAgICAgICAgICdZb3Ugc2hvdWxkIG5vdCBhZGQgYSBibGFuayBs aW5lIGJlZm9yZSBpbXBsZW1lbnRhdGlvbiBmaWxlXCdzIG93biBoZWFkZXIuJykKIAogICAgICMg Q2hlY2sgdG8gbWFrZSBzdXJlIGFsbCBoZWFkZXJzIGJlc2lkZXMgY29uZmlnLmggYW5kIHRoZSBw cmltYXJ5IGhlYWRlciBhcmUKICAgICAjIGFscGhhYmV0aWNhbGx5IHNvcnRlZC4KZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkK aW5kZXggZTE0MzViYi4uMzU1YWNlMSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTI2NDQsNiArMjY0NCwyMiBA QCBjbGFzcyBPcmRlck9mSW5jbHVkZXNUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImJhci5oIlxuJywKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJycpCiAKKyAgICBkZWYgdGVz dF9jaGVja19saW5lX2JyZWFrX2JlZm9yZV9vd25faGVhZGVyKHNlbGYpOgorICAgICAgICBzZWxm LmFzc2VydF9sYW5ndWFnZV9ydWxlc19jaGVjaygnZm9vLmNwcCcsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAiY29uZmlnLmgiXG4nCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdcbicKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJmb28uaCJcbicKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ1xuJworICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImJhci5oIlxuJywKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJ1lvdSBzaG91bGQgbm90IGFkZCBhIGJsYW5rIGxp bmUgYmVmb3JlIGltcGxlbWVudGF0aW9uIGZpbGVcJ3Mgb3duIGhlYWRlci4gIFtidWlsZC9pbmNs dWRlX29yZGVyXSBbNF0nKQorCisgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1bGVzX2No ZWNrKCdmb28uY3BwJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JyNpbmNsdWRlICJjb25maWcuaCJcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJyNpbmNsdWRlICJmb28uaCJcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJ1xuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAnI2luY2x1ZGUgImJhci5oIlxuJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJycpCisKICAgICBkZWYgdGVzdF9jaGVja19wcmVwcm9jZXNzb3JfaW5faW5j bHVkZV9zZWN0aW9uKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydF9sYW5ndWFnZV9ydWxlc19j aGVjaygnZm9vLmNwcCcsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICcjaW5jbHVkZSAiY29uZmlnLmgiXG4nCg== 218055 2013-11-29 05:42:00 -0800 2013-11-29 06:30:13 -0800 patch fix f2592.diff text/plain 3865 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZWYw MDMyLi4xYWExNzRjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMTEtMjggIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBzaG91bGQg Y2hlY2sgZm9yIGV4dHJhbmVvdXMgbmV3bGluZSBiZXR3ZWVuIGNvbmZpZy5oIGFuZCBwcmltYXJ5 IGhlYWRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNDgyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVj a19pbmNsdWRlX2xpbmUpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoT3JkZXJPZkluY2x1ZGVzVGVzdC50ZXN0X2No ZWNrX2xpbmVfYnJlYWtfYWZ0ZXJfb3duX2hlYWRlcik6CisgICAgICAgIChPcmRlck9mSW5jbHVk ZXNUZXN0KToKKyAgICAgICAgKE9yZGVyT2ZJbmNsdWRlc1Rlc3QudGVzdF9jaGVja19saW5lX2Jy ZWFrX2JlZm9yZV9vd25faGVhZGVyKToKKwogMjAxMy0xMS0yOCAgQ29tbWl0IFF1ZXVlICA8Y29t bWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjE1OTgzOS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkK aW5kZXggMmQ1NTliZC4uYWI0M2Y4MyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHAucHkKQEAgLTI4MTgsMTIgKzI4MTgsMTYgQEAgZGVmIGNoZWNrX2luY2x1 ZGVfbGluZShmaWxlbmFtZSwgZmlsZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5lX251bWJl ciwgaW5jbHUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZmlsZV9leHRlbnNpb24gPT0gImgiLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcmltYXJ5X2hlYWRlcl9leGlz dHMpCiAKLSAgICAjIENoZWNrIHRvIG1ha2Ugc3VyZSB3ZSBoYXZlIGEgYmxhbmsgbGluZSBhZnRl ciBwcmltYXJ5IGhlYWRlci4KKyAgICAjIENoZWNrIHRvIG1ha2Ugc3VyZSB3ZSBoYXZlIGEgYmxh bmsgbGluZSBhZnRlciBhbmQgbm9uZSBiZWZvcmUgcHJpbWFyeSBoZWFkZXIuCiAgICAgaWYgbm90 IGVycm9yX21lc3NhZ2UgYW5kIGhlYWRlcl90eXBlID09IF9QUklNQVJZX0hFQURFUjoKLSAgICAg ICAgIG5leHRfbGluZSA9IGNsZWFuX2xpbmVzLnJhd19saW5lc1tsaW5lX251bWJlciArIDFdCi0g ICAgICAgICBpZiBub3QgaXNfYmxhbmtfbGluZShuZXh0X2xpbmUpOgorICAgICAgICBuZXh0X2xp bmUgPSBjbGVhbl9saW5lcy5yYXdfbGluZXNbbGluZV9udW1iZXIgKyAxXQorICAgICAgICBwcmV2 aW91c19saW5lID0gY2xlYW5fbGluZXMucmF3X2xpbmVzW2xpbmVfbnVtYmVyIC0gMV0KKyAgICAg ICAgaWYgbm90IGlzX2JsYW5rX2xpbmUobmV4dF9saW5lKToKICAgICAgICAgICAgIGVycm9yKGxp bmVfbnVtYmVyLCAnYnVpbGQvaW5jbHVkZV9vcmRlcicsIDQsCi0gICAgICAgICAgICAgICAgICAn WW91IHNob3VsZCBhZGQgYSBibGFuayBsaW5lIGFmdGVyIGltcGxlbWVudGF0aW9uIGZpbGVcJ3Mg b3duIGhlYWRlci4nKQorICAgICAgICAgICAgICAgICdZb3Ugc2hvdWxkIGFkZCBhIGJsYW5rIGxp bmUgYWZ0ZXIgaW1wbGVtZW50YXRpb24gZmlsZVwncyBvd24gaGVhZGVyLicpCisgICAgICAgIGlm IGlzX2JsYW5rX2xpbmUocHJldmlvdXNfbGluZSk6CisgICAgICAgICAgICBlcnJvcihsaW5lX251 bWJlciwgJ2J1aWxkL2luY2x1ZGVfb3JkZXInLCA0LAorICAgICAgICAgICAgICAgICdZb3Ugc2hv dWxkIG5vdCBhZGQgYSBibGFuayBsaW5lIGJlZm9yZSBpbXBsZW1lbnRhdGlvbiBmaWxlXCdzIG93 biBoZWFkZXIuJykKIAogICAgICMgQ2hlY2sgdG8gbWFrZSBzdXJlIGFsbCBoZWFkZXJzIGJlc2lk ZXMgY29uZmlnLmggYW5kIHRoZSBwcmltYXJ5IGhlYWRlciBhcmUKICAgICAjIGFscGhhYmV0aWNh bGx5IHNvcnRlZC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggZTE0MzViYi4uMzU1YWNlMSAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkK QEAgLTI2NDQsNiArMjY0NCwyMiBAQCBjbGFzcyBPcmRlck9mSW5jbHVkZXNUZXN0KENwcFN0eWxl VGVzdEJhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2lu Y2x1ZGUgImJhci5oIlxuJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJycpCiAKKyAgICBkZWYgdGVzdF9jaGVja19saW5lX2JyZWFrX2JlZm9yZV9vd25faGVhZGVy KHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydF9sYW5ndWFnZV9ydWxlc19jaGVjaygnZm9vLmNw cCcsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAi Y29uZmlnLmgiXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdc bicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJm b28uaCJcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ1xuJwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImJhci5o IlxuJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ1lvdSBzaG91 bGQgbm90IGFkZCBhIGJsYW5rIGxpbmUgYmVmb3JlIGltcGxlbWVudGF0aW9uIGZpbGVcJ3Mgb3du IGhlYWRlci4gIFtidWlsZC9pbmNsdWRlX29yZGVyXSBbNF0nKQorCisgICAgICAgIHNlbGYuYXNz ZXJ0X2xhbmd1YWdlX3J1bGVzX2NoZWNrKCdmb28uY3BwJywKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJjb25maWcuaCJcbicKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJmb28uaCJcbicKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ1xuJworICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImJhci5oIlxuJywKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJycpCisKICAgICBkZWYgdGVzdF9jaGVj a19wcmVwcm9jZXNzb3JfaW5faW5jbHVkZV9zZWN0aW9uKHNlbGYpOgogICAgICAgICBzZWxmLmFz c2VydF9sYW5ndWFnZV9ydWxlc19jaGVjaygnZm9vLmNwcCcsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAiY29uZmlnLmgiXG4nCg==