12482 2007-01-30 10:51:24 -0800 Add small-caps to list of traits to ignore as it can be synthesized 2024-04-19 12:24:38 -0700 1 1 1 Unclassified WebKit Text 420+ Mac OS X 10.4 NEW P2 Normal --- 1 nickshanks webkit-unassigned ahmad.saleem792 mitz vitor.roriz oldest_to_newest 30124 0 nickshanks 2007-01-30 10:51:24 -0800 The fix for bug #6146 forgot to handle small-caps, which is also synthesized. Although currently the small-caps trait is not requested (since it is always synthesized), I plan on fixing that. This code ought to be ready to handle requests that include the small-caps trait. 30104 1 12800 nickshanks 2007-01-30 10:52:18 -0800 Created attachment 12800 patch 30098 2 12800 darin 2007-01-30 10:53:29 -0800 Comment on attachment 12800 patch Need a test case and a ChangeLog entry. 30062 3 nickshanks 2007-01-30 18:52:33 -0800 What sort of test case do you suggest? Since font-variant: small-caps doesn't request a font with the NSFontSmallCapsMask trait presently, I don't think it can be tested. 2029919 4 ahmad.saleem792 2024-04-19 12:24:38 -0700 This patch was modifying 'WebFontCache.mm', which was deleted by this commit: https://github.com/WebKit/WebKit/commit/cf78b9f051b13cd4ddcfb8bfc570174a6e2faafd We don't have test case to understand to confirm whether the bug exist or not. @Vitor - is this applicable any more? 12800 2007-01-30 10:52:18 -0800 2010-06-10 14:27:40 -0700 patch synthCaps.diff text/plain 1782 nickshanks SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkZvbnRDYWNoZS5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJGb250Q2FjaGUubW0JKHJldmlzaW9uIDE5MjU1KQor KysgV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViRm9udENhY2hlLm1tCSh3b3JraW5nIGNvcHkpCkBA IC0zMSw3ICszMSw3IEBACiAKICNpbXBvcnQgPG1hdGguaD4KIAotI2RlZmluZSBTWU5USEVTSVpF RF9GT05UX1RSQUlUUyAoTlNCb2xkRm9udE1hc2sgfCBOU0l0YWxpY0ZvbnRNYXNrKQorI2RlZmlu ZSBTWU5USEVTSVpFRF9GT05UX1RSQUlUUyAoTlNCb2xkRm9udE1hc2sgfCBOU0l0YWxpY0ZvbnRN YXNrIHwgTlNTbWFsbENhcHNGb250TWFzaykKIAogI2RlZmluZSBJTVBPUlRBTlRfRk9OVF9UUkFJ VFMgKDAgXAogICAgIHwgTlNCb2xkRm9udE1hc2sgXApAQCAtMTkxLDExICsxOTksMTIgQEAKICAg ICAgICAgcmV0dXJuIG5pbDsKIAogICAgIE5TRm9udFRyYWl0TWFzayBhY3R1YWxUcmFpdHMgPSAw OwotICAgIGlmIChkZXNpcmVkVHJhaXRzICYgKE5TSXRhbGljRm9udE1hc2sgfCBOU0JvbGRGb250 TWFzaykpCisgICAgaWYgKGRlc2lyZWRUcmFpdHMgJiBTWU5USEVTSVpFRF9GT05UX1RSQUlUUykK ICAgICAgICAgYWN0dWFsVHJhaXRzID0gW1tOU0ZvbnRNYW5hZ2VyIHNoYXJlZEZvbnRNYW5hZ2Vy XSB0cmFpdHNPZkZvbnQ6Zm9udF07CiAKICAgICBib29sIHN5bnRoZXRpY0JvbGQgPSAoZGVzaXJl ZFRyYWl0cyAmIE5TQm9sZEZvbnRNYXNrKSAmJiAhKGFjdHVhbFRyYWl0cyAmIE5TQm9sZEZvbnRN YXNrKTsKICAgICBib29sIHN5bnRoZXRpY09ibGlxdWUgPSAoZGVzaXJlZFRyYWl0cyAmIE5TSXRh bGljRm9udE1hc2spICYmICEoYWN0dWFsVHJhaXRzICYgTlNJdGFsaWNGb250TWFzayk7CisgICAg Ym9vbCBzeW50aGV0aWNTbWFsbENhcHMgPSAoZGVzaXJlZFRyYWl0cyAmIE5TU21hbGxDYXBzRm9u dE1hc2spICYmICEoYWN0dWFsVHJhaXRzICYgTlNTbWFsbENhcHNGb250TWFzayk7CiAKICAgICAv LyBUaGVyZSBhcmUgc29tZSBtYWxmb3JtZWQgZm9udHMgdGhhdCB3aWxsIGJlIGNvcnJlY3RseSBy ZXR1cm5lZCBieSAtZm9udFdpdGhGYW1pbHk6dHJhaXRzOndlaWdodDpzaXplOiBhcyBhIG1hdGNo IGZvciBhIHBhcnRpY3VsYXIgdHJhaXQsCiAgICAgLy8gdGhvdWdoIC1bTlNGb250TWFuYWdlciB0 cmFpdHNPZkZvbnQ6XSBpbmNvcnJlY3RseSBjbGFpbXMgdGhlIGZvbnQgZG9lcyBub3QgaGF2ZSB0 aGUgc3BlY2lmaWVkIHRyYWl0LiBUaGlzIGNvdWxkIHJlc3VsdCBpbiBhcHBseWluZyAKQEAgLTIx MCw2ICsyMTksOSBAQAogICAgIGlmIChzeW50aGV0aWNPYmxpcXVlKQogICAgICAgICBub25TeW50 aGV0aWNUcmFpdHMgJj0gfk5TSXRhbGljRm9udE1hc2s7CiAKKyAgICBpZiAoc3ludGhldGljU21h bGxDYXBzKQorICAgICAgICBub25TeW50aGV0aWNUcmFpdHMgJj0gfk5TU21hbGxDYXBzRm9udE1h c2s7CisKICAgICBpZiAobm9uU3ludGhldGljVHJhaXRzICE9IGRlc2lyZWRUcmFpdHMpIHsKICAg ICAgICAgTlNGb250ICpmb250V2l0aG91dFN5bnRoZXRpY1RyYWl0cyA9IFtmb250TWFuYWdlciBm b250V2l0aEZhbWlseTphdmFpbGFibGVGYW1pbHkgdHJhaXRzOm5vblN5bnRoZXRpY1RyYWl0cyB3 ZWlnaHQ6Y2hvc2VuV2VpZ2h0IHNpemU6c2l6ZV07CiAgICAgICAgIGlmIChmb250V2l0aG91dFN5 bnRoZXRpY1RyYWl0cykK