124796 2013-11-22 15:26:24 -0800 REGRESSION (r156291): TileController tiles don't always repaint when they resize 2013-11-24 00:32:15 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton dino mitz simon.fraser oldest_to_newest 953697 0 thorton 2013-11-22 15:26:24 -0800 http://trac.webkit.org/changeset/156291 dropped the setNeedsDisplay that was previously moved under platformCALayerDidCreateTiles without moving it back into TileController. This means that when tiles resize, we don't repaint. <rdar://problem/15537608> 953700 1 217722 thorton 2013-11-22 15:29:48 -0800 Created attachment 217722 patch I'm going to try to make a test now. 953733 2 217722 simon.fraser 2013-11-22 16:41:24 -0800 Comment on attachment 217722 patch View in context: https://bugs.webkit.org/attachment.cgi?id=217722&action=review > Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + * platform/graphics/ca/mac/TileController.mm: High level summary please. Why did r156291 break it? 953835 3 thorton 2013-11-24 00:32:15 -0800 http://trac.webkit.org/changeset/159732 217722 2013-11-22 15:29:48 -0800 2013-11-22 16:41:23 -0800 patch stretch.diff text/plain 3010 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNjUxZDlmLi5mODM5MTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMTEtMjIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjE1NjI5MSk6IFRpbGVDb250cm9sbGVyIHRpbGVzIGRvbid0 IGFsd2F5cyByZXBhaW50IHdoZW4gdGhleSByZXNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDc5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVD b250cm9sbGVyLm1tOgorICAgICAgICAoV2ViQ29yZTo6VGlsZUNvbnRyb2xsZXI6OnNldE5lZWRz RGlzcGxheSk6CisgICAgICAgIFVzZSBoYXNTdGFsZUNvbnRlbnQgd2hlbiBpbnZhbGlkYXRpbmcg YSB3aG9sZSB0aWxlLCBqdXN0CisgICAgICAgIGxpa2Ugd2UgZG8gZm9yIHBhcnRpYWwgdGlsZSBy ZXBhaW50cy4KKworICAgICAgICAoV2ViQ29yZTo6VGlsZUNvbnRyb2xsZXI6OnNldFRpbGVOZWVk c0Rpc3BsYXlJblJlY3QpOgorICAgICAgICBNYXJrIGhhc1N0YWxlQ29udGVudCBmb3IgYW55IHVu cGFyZW50ZWQgbGF5ZXJzLCBzbyB0aGV5J2xsIGJlIHBhaW50ZWQKKyAgICAgICAgd2hlbiB0aGV5 IGFyZSByZXBhcmVudGVkLgorCisgICAgICAgIChXZWJDb3JlOjpUaWxlQ29udHJvbGxlcjo6ZW5z dXJlVGlsZXNGb3JSZWN0KToKKyAgICAgICAgSW52YWxpZGF0ZSB0aGUgd2hvbGUgdGlsZSB3aGVu IGl0IGNoYW5nZXMgc2l6ZS4KKwogMjAxMy0xMS0yMiAgSGFucyBNdWxsZXIgIDxobXVsbGVyQGFk b2JlLmNvbT4KIAogICAgICAgICBbQ1NTIFNoYXBlc10gV2hlbiB0aGUgPGJveD4gdmFsdWUgaXMg c2V0LCBkZXJpdmUgcmFkaWkgZnJvbSBib3JkZXItcmFkaXVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIubW0gYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIubW0KaW5k ZXggN2FmNjNhMi4uZjExZmY1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2EvbWFjL1RpbGVDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxlQ29udHJvbGxlci5tbQpAQCAtOTgsOSArOTgsMTQg QEAgdm9pZCBUaWxlQ29udHJvbGxlcjo6dGlsZUNhY2hlTGF5ZXJCb3VuZHNDaGFuZ2VkKCkKIAog dm9pZCBUaWxlQ29udHJvbGxlcjo6c2V0TmVlZHNEaXNwbGF5KCkKIHsKLSAgICBmb3IgKFRpbGVN YXA6OmNvbnN0X2l0ZXJhdG9yIGl0ID0gbV90aWxlcy5iZWdpbigpLCBlbmQgPSBtX3RpbGVzLmVu ZCgpOyBpdCAhPSBlbmQ7ICsraXQpIHsKLSAgICAgICAgY29uc3QgVGlsZUluZm8mIHRpbGVJbmZv ID0gaXQtPnZhbHVlOwotICAgICAgICB0aWxlSW5mby5sYXllci0+c2V0TmVlZHNEaXNwbGF5KCk7 CisgICAgZm9yIChUaWxlTWFwOjppdGVyYXRvciBpdCA9IG1fdGlsZXMuYmVnaW4oKSwgZW5kID0g bV90aWxlcy5lbmQoKTsgaXQgIT0gZW5kOyArK2l0KSB7CisgICAgICAgIFRpbGVJbmZvJiB0aWxl SW5mbyA9IGl0LT52YWx1ZTsKKyAgICAgICAgSW50UmVjdCB0aWxlUmVjdCA9IHJlY3RGb3JUaWxl SW5kZXgoaXQtPmtleSk7CisKKyAgICAgICAgaWYgKHRpbGVSZWN0LmludGVyc2VjdHMobV9wcmlt YXJ5VGlsZUNvdmVyYWdlUmVjdCkgJiYgdGlsZUluZm8ubGF5ZXItPnN1cGVybGF5ZXIoKSkKKyAg ICAgICAgICAgIHRpbGVJbmZvLmxheWVyLT5zZXROZWVkc0Rpc3BsYXkoKTsKKyAgICAgICAgZWxz ZQorICAgICAgICAgICAgdGlsZUluZm8uaGFzU3RhbGVDb250ZW50ID0gdHJ1ZTsKICAgICB9CiB9 CiAKQEAgLTE0OSw3ICsxNTQsNyBAQCB2b2lkIFRpbGVDb250cm9sbGVyOjpzZXRUaWxlTmVlZHNE aXNwbGF5SW5SZWN0KGNvbnN0IFRpbGVJbmRleCYgdGlsZUluZGV4LCBUaWxlSQogICAgIAogICAg IC8vIFdlIGNvdWxkIHRlc3QgZm9yIGludGVyc2VjdGlvbiB3aXRoIHRoZSB2aXNpYmxlIHJlY3Qu IFRoaXMgd291bGQgcmVkdWNlIHBhaW50aW5nIHlldCBtb3JlLAogICAgIC8vIGJ1dCBtYXkgbWFr ZSBzY3JvbGxpbmcgc3RhbGUgdGlsZXMgaW50byB2aWV3IG1vcmUgZnJlcXVlbnQuCi0gICAgaWYg KHRpbGVSZWN0LmludGVyc2VjdHMoY292ZXJhZ2VSZWN0SW5UaWxlQ29vcmRzKSkgeworICAgIGlm ICh0aWxlUmVjdC5pbnRlcnNlY3RzKGNvdmVyYWdlUmVjdEluVGlsZUNvb3JkcykgJiYgdGlsZUxh eWVyLT5zdXBlcmxheWVyKCkpIHsKICAgICAgICAgdGlsZUxheWVyLT5zZXROZWVkc0Rpc3BsYXko JnRpbGVSZXBhaW50UmVjdCk7CiAKICAgICAgICAgaWYgKG93bmluZ0dyYXBoaWNzTGF5ZXIoKS0+ cGxhdGZvcm1DQUxheWVyU2hvd1JlcGFpbnRDb3VudGVyKDApKSB7CkBAIC04NjksNiArODc0LDcg QEAgSW50UmVjdCBUaWxlQ29udHJvbGxlcjo6ZW5zdXJlVGlsZXNGb3JSZWN0KGNvbnN0IEZsb2F0 UmVjdCYgcmVjdCwgQ292ZXJhZ2VUeXBlIG4KICAgICAgICAgICAgICAgICBpZiAoc2hvdWxkQ2hh bmdlVGlsZUxheWVyRnJhbWUpIHsKICAgICAgICAgICAgICAgICAgICAgdGlsZUluZm8ubGF5ZXIt PnNldEJvdW5kcyhGbG9hdFJlY3QoRmxvYXRQb2ludCgpLCB0aWxlUmVjdC5zaXplKCkpKTsKICAg ICAgICAgICAgICAgICAgICAgdGlsZUluZm8ubGF5ZXItPnNldFBvc2l0aW9uKHRpbGVSZWN0Lmxv Y2F0aW9uKCkpOworICAgICAgICAgICAgICAgICAgICB0aWxlSW5mby5sYXllci0+c2V0TmVlZHNE aXNwbGF5KCk7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogCg==