124794 2013-11-22 15:19:05 -0800 [WK2] Fix the build of the NetworkProcess on iOS 2013-11-22 15:45:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 953692 0 benjamin 2013-11-22 15:19:05 -0800 [WK2] Fix the build of the NetworkProcess on iOS 953693 1 217718 benjamin 2013-11-22 15:19:30 -0800 Created attachment 217718 Patch 953703 2 217718 ap 2013-11-22 15:37:59 -0800 Comment on attachment 217718 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217718&action=review > Source/WebKit2/NetworkProcess/AsynchronousNetworkLoaderClient.cpp:71 > -#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 > +#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090) I wonder if we should be using a USE style macro here, not a PLATFORM one. 953706 3 217718 benjamin 2013-11-22 15:45:17 -0800 Comment on attachment 217718 Patch Clearing flags on attachment: 217718 Committed r159718: <http://trac.webkit.org/changeset/159718> 953707 4 benjamin 2013-11-22 15:45:18 -0800 All reviewed patches have been landed. Closing bug. 217718 2013-11-22 15:19:30 -0800 2013-11-22 15:45:16 -0800 Patch bug-124794-20131122151929.patch text/plain 3442 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjAzNGFmNGRmZGRjMjRi NzFkZGI1MDc3M2I1NThlNzFkOWY1OWI2Zi4uNjJjYzUyNmRjZWY5NjY2OGQ5ZmRlYmE5NjI2Yjc3 ZjMyODgwZDRiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTExLTIyICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIEZpeCB0 aGUgYnVpbGQgb2YgdGhlIE5ldHdvcmtQcm9jZXNzIG9uIGlPUworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0Nzk0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9Bc3luY2hyb25v dXNOZXR3b3JrTG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6QXN5bmNocm9ub3Vz TmV0d29ya0xvYWRlckNsaWVudDo6ZGlkUmVjZWl2ZUJ1ZmZlcik6CisgICAgICAgICogTmV0d29y a1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmg6CisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvU3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 U3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50Ojp3aWxsU2VuZFJlcXVlc3QpOgorCiAyMDEz LTExLTIyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAg TW92ZSBXS1BhZ2VMb2FkZXJDbGllbnQgb3V0IGludG8gYSBzZXBhcmF0ZSBoZWFkZXIKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL0FzeW5jaHJvbm91c05ldHdvcmtM b2FkZXJDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvQXN5bmNocm9u b3VzTmV0d29ya0xvYWRlckNsaWVudC5jcHAKaW5kZXggODY1YjRjMDkwNzQ5MTgxNGI3ZjcwYjVm MzQ1ZmI2NDAxYWE4NzY4Mi4uYzU0M2EzZWUwZWYzNDZjNmUwOTVmYzYwNWY1YzEwOTJjMWEzNTZj NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvQXN5bmNocm9ub3Vz TmV0d29ya0xvYWRlckNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvQXN5bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudC5jcHAKQEAgLTY4LDcgKzY4LDcgQEAg dm9pZCBBc3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50OjpkaWRSZWNlaXZlUmVzcG9uc2Uo TmV0d29ya1Jlc291cmNlTG9hZGVyKgogCiB2b2lkIEFzeW5jaHJvbm91c05ldHdvcmtMb2FkZXJD bGllbnQ6OmRpZFJlY2VpdmVCdWZmZXIoTmV0d29ya1Jlc291cmNlTG9hZGVyKiBsb2FkZXIsIFNo YXJlZEJ1ZmZlciogYnVmZmVyLCBpbnQgZW5jb2RlZERhdGFMZW5ndGgpCiB7Ci0jaWYgUExBVEZP Uk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwOTAKKyNpZiBQ TEFURk9STShJT1MpIHx8IChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPj0gMTA5MCkKICAgICBTaGFyZWFibGVSZXNvdXJjZTo6SGFuZGxlIHNoYXJlYWJs ZVJlc291cmNlSGFuZGxlOwogICAgIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6dHJ5R2V0U2hhcmVh YmxlSGFuZGxlRnJvbVNoYXJlZEJ1ZmZlcihzaGFyZWFibGVSZXNvdXJjZUhhbmRsZSwgYnVmZmVy KTsKICAgICBpZiAoIXNoYXJlYWJsZVJlc291cmNlSGFuZGxlLmlzTnVsbCgpKSB7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIu aCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5o CmluZGV4IDMyN2FlMzRjYzdiNGQyYTU0YmExZTFhNTczYjRiYTU0YjBiYmYxOGMuLjRmYWZjMDIz ODM4MDA0NGEwZDZhYTBkMjYzMGRlYzM2NTgyZTQzNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5oCisrKyBiL1NvdXJjZS9X ZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5oCkBAIC0xMTIsNyAr MTEyLDcgQEAgcHVibGljOgogICAgIC8vIE1lc3NhZ2UgaGFuZGxlcnMuCiAgICAgdm9pZCBkaWRS ZWNlaXZlTmV0d29ya1Jlc291cmNlTG9hZGVyTWVzc2FnZShDb3JlSVBDOjpDb25uZWN0aW9uKiwg Q29yZUlQQzo6TWVzc2FnZURlY29kZXImKTsKIAotI2lmIFBMQVRGT1JNKE1BQykgJiYgX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDkwCisjaWYgUExBVEZPUk0oSU9TKSB8fCAo UExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwOTAp CiAgICAgc3RhdGljIHZvaWQgdHJ5R2V0U2hhcmVhYmxlSGFuZGxlRnJvbUNGVVJMQ2FjaGVkUmVz cG9uc2UoU2hhcmVhYmxlUmVzb3VyY2U6OkhhbmRsZSYsIENGQ2FjaGVkVVJMUmVzcG9uc2VSZWYp OwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL1N5 bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9TeW5jaHJvbm91c05ldHdvcmtMb2FkZXJDbGllbnQuY3BwCmluZGV4IGMwN2YxNDEy ODc3NGY2NjYwMjgyNTY5N2Q0ZDlhMzVlNTRmYmRhNWEuLjA3YjE0OGNmYzBmZTgwY2NmMGY2MDk2 ZTA5MTQ4YWExYzEwYjYxYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL1N5bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvU3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50LmNwcApAQCAt NTksNyArNTksNyBAQCB2b2lkIFN5bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudDo6d2lsbFNl bmRSZXF1ZXN0KE5ldHdvcmtSZXNvdXJjZUxvYWRlciogbG9hZAogICAgIGlmICghcHJvdG9jb2xI b3N0QW5kUG9ydEFyZUVxdWFsKG1fb3JpZ2luYWxSZXF1ZXN0LnVybCgpLCBwcm9wb3NlZFJlcXVl c3QudXJsKCkpKSB7CiAgICAgICAgIEFTU0VSVChtX2Vycm9yLmlzTnVsbCgpKTsKICAgICAgICAg bV9lcnJvciA9IFN5bmNocm9ub3VzTG9hZGVyQ2xpZW50OjpwbGF0Zm9ybUJhZFJlc3BvbnNlRXJy b3IoKTsKLSAgICAgICAgcHJvcG9zZWRSZXF1ZXN0ID0gMDsKKyAgICAgICAgcHJvcG9zZWRSZXF1 ZXN0ID0gUmVzb3VyY2VSZXF1ZXN0KCk7CiAgICAgfQogICAgIAogICAgIG1fY3VycmVudFJlcXVl c3QgPSBwcm9wb3NlZFJlcXVlc3Q7Cg==