124786 2013-11-22 12:30:09 -0800 MiniBrowser should use the blocks-based NSOpenPanel API 2013-11-22 12:36:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 953642 0 andersca 2013-11-22 12:30:09 -0800 MiniBrowser should use the blocks-based NSOpenPanel API 953645 1 217707 andersca 2013-11-22 12:32:55 -0800 Created attachment 217707 Patch 953648 2 andersca 2013-11-22 12:36:31 -0800 Committed r159707: <http://trac.webkit.org/changeset/159707> 217707 2013-11-22 12:32:55 -0800 2013-11-22 12:33:43 -0800 Patch bug-124786-20131122123254.patch text/plain 3996 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmM3ZDA4NDU0MTVkM2UwMTVkNzcyYzMyZGI1NDFhM2Qy MTQ4MjAxMC4uY2RmMjc1Mjg1OTkwMTI4MzJjYTA5YWUxZWIzZDkyYWU2Zjk5YTMwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTExLTIyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisK KyAgICAgICAgTWluaUJyb3dzZXIgc2hvdWxkIHVzZSB0aGUgYmxvY2tzLWJhc2VkIE5TT3BlblBh bmVsIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI0Nzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBNaW5pQnJvd3Nlci9tYWMvQXBwRGVsZWdhdGUubToKKyAgICAgICAgKC1bQnJvd3NlckFwcERl bGVnYXRlIGZyb250bW9zdEJyb3dzZXJXaW5kb3dDb250cm9sbGVyXSk6CisgICAgICAgIEFjY291 bnQgZm9yIHdpbmRvd3MgdGhhdCBkb24ndCBoYXZlIGEgQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIu CisKKyAgICAgICAgKC1bQnJvd3NlckFwcERlbGVnYXRlIG9wZW5Eb2N1bWVudDpdKToKKwogMjAx My0xMS0yMiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE1OTY5MC4KZGlmZiAtLWdpdCBhL1Rvb2xzL01p bmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5tIGIvVG9vbHMvTWluaUJyb3dzZXIvbWFjL0FwcERl bGVnYXRlLm0KaW5kZXggM2JkZTNkMWY1Mjc4M2E1NTVlZDhjNWE4MWMzMWNiZmFjZDNjYWM1Mi4u MWY3ODg5MGQzMTNlZDA3NDJkNzkxY2I3ODAzYzgxMTVhZDAwYjE0MSAxMDA2NDQKLS0tIGEvVG9v bHMvTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm0KKysrIGIvVG9vbHMvTWluaUJyb3dzZXIv bWFjL0FwcERlbGVnYXRlLm0KQEAgLTE5OSwxMCArMTk5LDEyIEBAIC0gKHZvaWQpYXBwbGljYXRp b25XaWxsVGVybWluYXRlOihOU05vdGlmaWNhdGlvbiAqKW5vdGlmaWNhdGlvbgogCiAtIChCcm93 c2VyV2luZG93Q29udHJvbGxlciAqKWZyb250bW9zdEJyb3dzZXJXaW5kb3dDb250cm9sbGVyCiB7 Ci0gICAgTlNBcnJheSogd2luZG93cyA9IFtOU0FwcCB3aW5kb3dzXTsKLSAgICBmb3IgKE5TV2lu ZG93KiB3aW5kb3cgaW4gd2luZG93cykgeworICAgIGZvciAoTlNXaW5kb3cqIHdpbmRvdyBpbiBb TlNBcHAgd2luZG93c10pIHsKICAgICAgICAgaWQgZGVsZWdhdGUgPSBbd2luZG93IGRlbGVnYXRl XTsKLSAgICAgICAgYXNzZXJ0KFtkZWxlZ2F0ZSBpc0tpbmRPZkNsYXNzOltCcm93c2VyV2luZG93 Q29udHJvbGxlciBjbGFzc11dKTsKKworICAgICAgICBpZiAoIVtkZWxlZ2F0ZSBpc0tpbmRPZkNs YXNzOltCcm93c2VyV2luZG93Q29udHJvbGxlciBjbGFzc11dKQorICAgICAgICAgICAgY29udGlu dWU7CisKICAgICAgICAgQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIgKmNvbnRyb2xsZXIgPSAoQnJv d3NlcldpbmRvd0NvbnRyb2xsZXIgKilkZWxlZ2F0ZTsKICAgICAgICAgYXNzZXJ0KFtfYnJvd3Nl cldpbmRvd3MgY29udGFpbnNPYmplY3Q6W2NvbnRyb2xsZXIgd2luZG93XV0pOwogICAgICAgICBy ZXR1cm4gY29udHJvbGxlcjsKQEAgLTIxMywzMCArMjE1LDMyIEBAIC0gKEJyb3dzZXJXaW5kb3dD b250cm9sbGVyICopZnJvbnRtb3N0QnJvd3NlcldpbmRvd0NvbnRyb2xsZXIKIAogLSAoSUJBY3Rp b24pb3BlbkRvY3VtZW50OihpZClzZW5kZXIKIHsKLSAgICBOU09wZW5QYW5lbCAqb3BlblBhbmVs ID0gW1tOU09wZW5QYW5lbCBvcGVuUGFuZWxdIHJldGFpbl07Ci0gICAgW29wZW5QYW5lbCBiZWdp bkZvckRpcmVjdG9yeTpuaWwKLSAgICAgICAgZmlsZTpuaWwKLSAgICAgICAgdHlwZXM6bmlsCi0g ICAgICAgIG1vZGVsZXNzRGVsZWdhdGU6c2VsZgotICAgICAgICBkaWRFbmRTZWxlY3RvcjpAc2Vs ZWN0b3Iob3BlblBhbmVsRGlkRW5kOnJldHVybkNvZGU6Y29udGV4dEluZm86KQotICAgICAgICBj b250ZXh0SW5mbzowXTsKLX0KKyAgICBCcm93c2VyV2luZG93Q29udHJvbGxlciAqYnJvd3Nlcldp bmRvd0NvbnRyb2xsZXIgPSBbc2VsZiBmcm9udG1vc3RCcm93c2VyV2luZG93Q29udHJvbGxlcl07 CiAKLS0gKHZvaWQpb3BlblBhbmVsRGlkRW5kOihOU09wZW5QYW5lbCAqKXNoZWV0IHJldHVybkNv ZGU6KGludClyZXR1cm5Db2RlIGNvbnRleHRJbmZvOih2b2lkICopY29udGV4dEluZm8KLXsKLSAg ICBbc2hlZXQgYXV0b3JlbGVhc2VdOwotICAgIGlmIChyZXR1cm5Db2RlICE9IE5TT0tCdXR0b24g fHwgIVtbc2hlZXQgZmlsZW5hbWVzXSBjb3VudF0pCi0gICAgICAgIHJldHVybjsKLSAgICAKLSAg ICBOU1N0cmluZyogZmlsZVBhdGggPSBbW3NoZWV0IGZpbGVuYW1lc10gb2JqZWN0QXRJbmRleDow XTsKKyAgICBpZiAoYnJvd3NlcldpbmRvd0NvbnRyb2xsZXIpIHsKKyAgICAgICAgTlNPcGVuUGFu ZWwgKm9wZW5QYW5lbCA9IFtbTlNPcGVuUGFuZWwgb3BlblBhbmVsXSByZXRhaW5dOworICAgICAg ICBbb3BlblBhbmVsIGJlZ2luU2hlZXRNb2RhbEZvcldpbmRvdzpicm93c2VyV2luZG93Q29udHJv bGxlci53aW5kb3cgY29tcGxldGlvbkhhbmRsZXI6XihOU0ludGVnZXIgcmVzdWx0KSB7CisgICAg ICAgICAgICBpZiAocmVzdWx0ICE9IE5TTW9kYWxSZXNwb25zZU9LKQorICAgICAgICAgICAgICAg IHJldHVybjsKIAotICAgIEJyb3dzZXJXaW5kb3dDb250cm9sbGVyICpjb250cm9sbGVyID0gW3Nl bGYgZnJvbnRtb3N0QnJvd3NlcldpbmRvd0NvbnRyb2xsZXJdOwotICAgIGlmICghY29udHJvbGxl cikgewotICAgICAgICBjb250cm9sbGVyID0gW1tXSzJCcm93c2VyV2luZG93Q29udHJvbGxlciBh bGxvY10gaW5pdFdpdGhDb250ZXh0Ol9wcm9jZXNzQ29udGV4dCBwYWdlR3JvdXA6X3BhZ2VHcm91 cF07IC8vIEZJWE1FOiBhZGQgYSB3YXkgdG8gb3BlbiBpbiBXSzEgYWxzby4KLSAgICAgICAgW1tj b250cm9sbGVyIHdpbmRvd10gbWFrZUtleUFuZE9yZGVyRnJvbnQ6c2VsZl07CisgICAgICAgICAg ICBOU1VSTCAqdXJsID0gb3BlblBhbmVsLlVSTHMuZmlyc3RPYmplY3Q7CisgICAgICAgICAgICBb YnJvd3NlcldpbmRvd0NvbnRyb2xsZXIgbG9hZFVSTFN0cmluZzpbdXJsIGFic29sdXRlU3RyaW5n XV07CisgICAgICAgIH1dOworICAgICAgICByZXR1cm47CiAgICAgfQotICAgIAotICAgIFtjb250 cm9sbGVyIGxvYWRVUkxTdHJpbmc6W1tOU1VSTCBmaWxlVVJMV2l0aFBhdGg6ZmlsZVBhdGhdIGFi c29sdXRlU3RyaW5nXV07CisKKyAgICBOU09wZW5QYW5lbCAqb3BlblBhbmVsID0gW05TT3BlblBh bmVsIG9wZW5QYW5lbF07CisgICAgW29wZW5QYW5lbCBiZWdpbldpdGhDb21wbGV0aW9uSGFuZGxl cjpeKE5TSW50ZWdlciByZXN1bHQpIHsKKyAgICAgICAgaWYgKHJlc3VsdCAhPSBOU01vZGFsUmVz cG9uc2VPSykKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgCisgICAgICAgIC8vIEZJWE1F OiBhZGQgYSB3YXkgdG8gb3BlbiBpbiBXSzEgYWxzby4KKyAgICAgICAgQnJvd3NlcldpbmRvd0Nv bnRyb2xsZXIgKm5ld0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyID0gW1tXSzJCcm93c2VyV2luZG93 Q29udHJvbGxlciBhbGxvY10gaW5pdFdpdGhDb250ZXh0Ol9wcm9jZXNzQ29udGV4dCBwYWdlR3Jv dXA6X3BhZ2VHcm91cF07CisgICAgICAgIFtuZXdCcm93c2VyV2luZG93Q29udHJvbGxlci53aW5k b3cgbWFrZUtleUFuZE9yZGVyRnJvbnQ6c2VsZl07CisKKyAgICAgICAgTlNVUkwgKnVybCA9IG9w ZW5QYW5lbC5VUkxzLmZpcnN0T2JqZWN0OworICAgICAgICBbbmV3QnJvd3NlcldpbmRvd0NvbnRy b2xsZXIgbG9hZFVSTFN0cmluZzpbdXJsIGFic29sdXRlU3RyaW5nXV07CisgICAgfV07CiB9CiAK IEBlbmQK