124774 2013-11-22 07:29:39 -0800 WebView assumes accelerated compositing 2013-11-22 11:03:35 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows 8 RESOLVED DUPLICATE 124773 P2 Trivial --- 1 alex.christensen webkit-unassigned bdakin simon.fraser oldest_to_newest 953528 0 alex.christensen 2013-11-22 07:29:39 -0800 Some of our less accelerated friends are failing to compile WebView.cpp because of a lack of USE(ACCELERATED_COMPOSITING) macros. http://build.webkit.org/builders/WinCairo%20Release/builds/33849/steps/compile-webkit/logs/stdio I'm working on using accelerated compositing with TextureMapper, but let's fix this for the WinCairo bot. 953546 1 217685 alex.christensen 2013-11-22 08:01:21 -0800 Created attachment 217685 Patch 953548 2 alex.christensen 2013-11-22 08:07:25 -0800 I'm not sure why the patch doesn't apply, but I'm sure someone won't like the style and redundant code, so I'll wait for their comment and upload a new patch. 953624 3 alex.christensen 2013-11-22 11:03:35 -0800 This was fixed by peavo in r159688. He did a cleaner fix, too. That's why the patches didn't apply. *** This bug has been marked as a duplicate of bug 124773 *** 217685 2013-11-22 08:01:21 -0800 2013-11-22 10:37:34 -0800 Patch bug-124774-20131122090125.patch text/plain 2605 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTY4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTExLTIyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dpbkNhaXJv XSBCdWlsZCBmaXggYWZ0ZXIgcjE1OTY0NS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNDc3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyVmlldzo6cGFpbnRCb3hEZWNvcmF0aW9ucyk6CisgICAgICAgIEFkZGVk IG5lY2Vzc2FyeSBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpIG1hY3Jvcy4KKwogMjAxMy0x MS0xOCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbQ1NTIEdyaWQgTGF5b3V0XSBJbXByb3ZlIGNvbnRlbnQtc2l6ZWQgdHJhY2sgbGF5b3V0Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCShyZXZpc2lvbiAxNTk2 NzEpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTUxMywxNCArNTEzLDE4IEBAIHZvaWQgUmVuZGVyVmlldzo6cGFpbnRCb3hEZWNv cmF0aW9ucyhQYWkKICAgICAgICAgcm9vdEZpbGxzVmlld3BvcnQgPSByb290Qm94ICYmICFyb290 Qm94LT54KCkgJiYgIXJvb3RCb3gtPnkoKSAmJiByb290Qm94LT53aWR0aCgpID49IHdpZHRoKCkg JiYgcm9vdEJveC0+aGVpZ2h0KCkgPj0gaGVpZ2h0KCk7CiAgICAgICAgIHJvb3RPYnNjdXJlc0Jh Y2tncm91bmQgPSByZW5kZXJlck9ic2N1cmVzQmFja2dyb3VuZChyb290UmVuZGVyZXIpOwogICAg IH0KLQorI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBib29sIGhhc1RpbGVk TWFyZ2luID0gY29tcG9zaXRvcigpLm1haW5GcmFtZUJhY2tpbmdJc1RpbGVkV2l0aE1hcmdpbigp OwotCisjZW5kaWYKICAgICBQYWdlKiBwYWdlID0gZG9jdW1lbnQoKS5wYWdlKCk7CiAgICAgZmxv YXQgcGFnZVNjYWxlRmFjdG9yID0gcGFnZSA/IHBhZ2UtPnBhZ2VTY2FsZUZhY3RvcigpIDogMTsK IAorI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICAvLyBJZiBwYWludGluZyB3 aWxsIGVudGlyZWx5IGZpbGwgdGhlIHZpZXcsIG5vIG5lZWQgdG8gZmlsbCB0aGUgYmFja2dyb3Vu ZC4KICAgICBpZiAoIWhhc1RpbGVkTWFyZ2luICYmIHJvb3RGaWxsc1ZpZXdwb3J0ICYmIHJvb3RP YnNjdXJlc0JhY2tncm91bmQgJiYgcGFnZVNjYWxlRmFjdG9yID49IDEpCisjZWxzZQorICAgIGlm IChyb290RmlsbHNWaWV3cG9ydCAmJiByb290T2JzY3VyZXNCYWNrZ3JvdW5kICYmIHBhZ2VTY2Fs ZUZhY3RvciA+PSAxKQorI2VuZGlmCiAgICAgICAgIHJldHVybjsKIAogICAgIC8vIFRoaXMgY29k ZSB0eXBpY2FsbHkgb25seSBleGVjdXRlcyBpZiB0aGUgcm9vdCBlbGVtZW50J3MgdmlzaWJpbGl0 eSBoYXMgYmVlbiBzZXQgdG8gaGlkZGVuLApAQCAtNTMwLDcgKzUzNCwxMSBAQCB2b2lkIFJlbmRl clZpZXc6OnBhaW50Qm94RGVjb3JhdGlvbnMoUGFpCiAgICAgaWYgKGZyYW1lVmlldygpLmlzVHJh bnNwYXJlbnQoKSkgLy8gRklYTUU6IFRoaXMgbmVlZHMgdG8gYmUgZHluYW1pYy4gV2Ugc2hvdWxk IGJlIGFibGUgdG8gZ28gYmFjayB0byBibGl0dGluZyBpZiB3ZSBldmVyIHN0b3AgYmVpbmcgdHJh bnNwYXJlbnQuCiAgICAgICAgIGZyYW1lVmlldygpLnNldENhbm5vdEJsaXRUb1dpbmRvdygpOyAv LyBUaGUgcGFyZW50IG11c3Qgc2hvdyBiZWhpbmQgdGhlIGNoaWxkLgogICAgIGVsc2UgeworI2lm IFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICAgICAgQ29sb3IgYmFja2dyb3VuZENv bG9yID0gaGFzVGlsZWRNYXJnaW4gPyBmcmFtZVZpZXcoKS5kb2N1bWVudEJhY2tncm91bmRDb2xv cigpIDogZnJhbWVWaWV3KCkuYmFzZUJhY2tncm91bmRDb2xvcigpOworI2Vsc2UKKyAgICAgICAg Q29sb3IgYmFja2dyb3VuZENvbG9yID0gZnJhbWVWaWV3KCkuYmFzZUJhY2tncm91bmRDb2xvcigp OworI2VuZGlmCiAgICAgICAgIGlmIChiYWNrZ3JvdW5kQ29sb3IuYWxwaGEoKSkgewogICAgICAg ICAgICAgQ29tcG9zaXRlT3BlcmF0b3IgcHJldmlvdXNPcGVyYXRvciA9IHBhaW50SW5mby5jb250 ZXh0LT5jb21wb3NpdGVPcGVyYXRpb24oKTsKICAgICAgICAgICAgIHBhaW50SW5mby5jb250ZXh0 LT5zZXRDb21wb3NpdGVPcGVyYXRpb24oQ29tcG9zaXRlQ29weSk7Cg==