124757 2013-11-21 18:50:04 -0800 ASSERT_WITH_SECURITY_IMPLICATION should crash in a distinct way 2013-11-26 19:32:39 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ayao ayao benjamin cmarcelo commit-queue oldest_to_newest 953387 0 ayao 2013-11-21 18:50:04 -0800 ASSERT_WITH_SECURITY_IMPLICATION currently calls CRASH(). There are many other non security related code paths that call CRASH(). ASSERT_WITH_SECURITY_IMPLICATION should crash in a distinct way in order to help screen fuzzing bugs. The attached patch adds a CRASH_WITH_SECURITY_IMPLICATION which is the same as CRASH except it accesses 0xfbadbeef instead of 0xbbadbeef. The same as before, in release builds, ASSERT_WITH_SECURITY_IMPLICATION will do nothing unless it was built with ASAN, which required moving the code around a little, since before it just called ASSERT() when ASAN was not defined. 953392 1 217641 ayao 2013-11-21 18:54:01 -0800 Created attachment 217641 Patch 953395 2 commit-queue 2013-11-21 18:55:58 -0800 Attachment 217641 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Assertions.cpp', u'Source/WTF/wtf/Assertions.h']" exit_code: 1 Source/WTF/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Source/WTF/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Source/WTF/wtf/Assertions.h:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/Assertions.h:279: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 953406 3 217643 ayao 2013-11-21 19:10:05 -0800 Created attachment 217643 Patch 953408 4 ayao 2013-11-21 19:11:19 -0800 I updated the patch to fix the whitespace issues in the ChangeLog. Re: the whitespace issues in Assertions.h, the whitespace I used is exactly the same as was already used for the existing code. 953409 5 commit-queue 2013-11-21 19:11:20 -0800 Attachment 217643 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Assertions.cpp', u'Source/WTF/wtf/Assertions.h']" exit_code: 1 Source/WTF/wtf/Assertions.h:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/Assertions.h:279: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 954418 6 217643 bfulgham 2013-11-26 19:05:20 -0800 Comment on attachment 217643 Patch r=me 954428 7 217643 commit-queue 2013-11-26 19:32:37 -0800 Comment on attachment 217643 Patch Clearing flags on attachment: 217643 Committed r159799: <http://trac.webkit.org/changeset/159799> 954429 8 commit-queue 2013-11-26 19:32:39 -0800 All reviewed patches have been landed. Closing bug. 217641 2013-11-21 18:54:01 -0800 2013-11-21 19:10:03 -0800 Patch bug-124757-20131121185401.patch text/plain 3410 ayao SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTk2NjEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTExLTIxICBEcmV3IFlhbyAgPGF5YW9AYXBw bGUuY29tPgorCisgICAgICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OIHNob3Vs ZCBjcmFzaCBpbiBhIGRpc3RpbmN0IHdheS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNDc1NworCisJQ2hhbmdlIEFTU0VSVF9XSVRIX1NFQ1VSSVRZ X0lNUExJQ0FUSU9OIHRvIGFjY2VzcyBhIGRpZmZlcmVudCBhZGRyZXNzIGZyb20gQ1JBU0goKQor CWluIG9yZGVyIHRvIGhlbHAgc2NyZWVuIGZ1enppbmcgYnVncy4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmNwcDoKKyAg ICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5oOgorCiAyMDEzLTExLTIwICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2luZyBWTUVudHJ5U2NvcGUgdG8gdXBk YXRlIHRoZSBWTSBzdGFjayBsaW1pdC4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwCShyZXZpc2lv biAxNTk2NTkpCisrKyBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzQ2LDYgKzM0NiwyMCBAQCB2b2lkIFdURkNyYXNoKCkKICAgICAoKHZvaWQoKikoKSkw KSgpOwogI2VuZGlmCiB9CisgICAgCit2b2lkIFdURkNyYXNoV2l0aFNlY3VyaXR5SW1wbGljYXRp b24oKQoreworICAgIGlmIChnbG9iYWxIb29rKQorICAgICAgICBnbG9iYWxIb29rKCk7CisgICAg V1RGUmVwb3J0QmFja3RyYWNlKCk7CisgICAgKihpbnQgKikodWludHB0cl90KTB4ZmJhZGJlZWYg PSAwOworICAgIC8vIE1vcmUgcmVsaWFibGUsIGJ1dCBkb2Vzbid0IHNheSBmYmFkYmVlZi4KKyNp ZiBDT01QSUxFUihDTEFORykKKyAgICBfX2J1aWx0aW5fdHJhcCgpOworI2Vsc2UKKyAgICAoKHZv aWQoKikoKSkwKSgpOworI2VuZGlmCit9CiAKICNpZiBIQVZFKFNJR05BTF9IKQogc3RhdGljIE5P X1JFVFVSTiB2b2lkIGR1bXBCYWNrdHJhY2VTaWduYWxIYW5kbGVyKGludCBzaWcpCkluZGV4OiBT b3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYv QXNzZXJ0aW9ucy5oCShyZXZpc2lvbiAxNTk2NTkpCisrKyBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRp b25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTE2OCw2ICsxNjgsMTggQEAgV1RGX0VYUE9SVF9QUklW QVRFIHZvaWQgV1RGQ3Jhc2goKSBOT19SRQogfQogI2VuZGlmCiAKKyNpZm5kZWYgQ1JBU0hfV0lU SF9TRUNVUklUWV9JTVBMSUNBVElPTgorI2RlZmluZSBDUkFTSF9XSVRIX1NFQ1VSSVRZX0lNUExJ Q0FUSU9OKCkgV1RGQ3Jhc2hXaXRoU2VjdXJpdHlJbXBsaWNhdGlvbigpCisjZW5kaWYKKworI2lm ZGVmIF9fY3BsdXNwbHVzCitleHRlcm4gIkMiIHsKKyNlbmRpZgorICAgIFdURl9FWFBPUlRfUFJJ VkFURSB2b2lkIFdURkNyYXNoV2l0aFNlY3VyaXR5SW1wbGljYXRpb24oKSBOT19SRVRVUk5fRFVF X1RPX0NSQVNIOworI2lmZGVmIF9fY3BsdXNwbHVzCit9CisjZW5kaWYKKwogLyogQkFDS1RSQUNF CiAKICAgUHJpbnQgYSBiYWNrdHJhY2UgdG8gdGhlIHNhbWUgbG9jYXRpb24gYXMgQVNTRVJUIG1l c3NhZ2VzLgpAQCAtMjE5LDYgKzIzMSwxNyBAQCBpbmxpbmUgdm9pZCBhc3NlcnRVbnVzZWQoVCYg eCkgeyAodm9pZCl4CiAjZGVmaW5lIEFTU0VSVF9VTlVTRUQodmFyaWFibGUsIGFzc2VydGlvbikg KCh2b2lkKXZhcmlhYmxlKQogI2VuZGlmCiAKKyNpZmRlZiBBRERSRVNTX1NBTklUSVpFUgorI2Rl ZmluZSBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihhc3NlcnRpb24pIFwKKyAgICAo IShhc3NlcnRpb24pID8gXAorICAgICAgICAoV1RGUmVwb3J0QXNzZXJ0aW9uRmFpbHVyZShfX0ZJ TEVfXywgX19MSU5FX18sIFdURl9QUkVUVFlfRlVOQ1RJT04sICNhc3NlcnRpb24pLCBcCisgICAg ICAgICBDUkFTSF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKCkpIDogXAorICAgICAgICAodm9p ZCkwKQorCisjZWxzZQorI2RlZmluZSBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihh c3NlcnRpb24pICgodm9pZCkwKQorI2VuZGlmCisKICNlbHNlCiAKICNkZWZpbmUgQVNTRVJUKGFz c2VydGlvbikgXApAQCAtMjQyLDI4ICsyNjUsMTkgQEAgaW5saW5lIHZvaWQgYXNzZXJ0VW51c2Vk KFQmIHgpIHsgKHZvaWQpeAogCiAjZGVmaW5lIE5PX1JFVFVSTl9EVUVfVE9fQVNTRVJUIE5PX1JF VFVSTl9EVUVfVE9fQ1JBU0gKIAotI2VuZGlmCi0KIC8qIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lN UExJQ0FUSU9OCi0gICAKKyAKICAgIEZhaWx1cmUgb2YgdGhpcyBhc3NlcnRpb24gaW5kaWNhdGVz IGEgcG9zc2libGUgc2VjdXJpdHkgdnVsbmVyYWJpbGl0eS4KICAgIENsYXNzIG9mIHZ1bG5lcmFi aWxpdGllcyB0aGF0IGl0IHRlc3RzIGluY2x1ZGUgYmFkIGNhc3RzLCBvdXQgb2YgYm91bmRzCiAg ICBhY2Nlc3NlcywgdXNlLWFmdGVyLWZyZWVzLCBldGMuIFBsZWFzZSBmaWxlIGEgYnVnIHVzaW5n IHRoZSBzZWN1cml0eQogICAgdGVtcGxhdGUgLSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9lbnRl cl9idWcuY2dpP3Byb2R1Y3Q9U2VjdXJpdHkuCi0KKyAKICovCi0jaWZkZWYgQUREUkVTU19TQU5J VElaRVIKLQogI2RlZmluZSBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihhc3NlcnRp b24pIFwKICAgICAoIShhc3NlcnRpb24pID8gXAogICAgICAgICAoV1RGUmVwb3J0QXNzZXJ0aW9u RmFpbHVyZShfX0ZJTEVfXywgX19MSU5FX18sIFdURl9QUkVUVFlfRlVOQ1RJT04sICNhc3NlcnRp b24pLCBcCi0gICAgICAgICBDUkFTSCgpKSA6IFwKKyAgICAgICAgIENSQVNIX1dJVEhfU0VDVVJJ VFlfSU1QTElDQVRJT04oKSkgOiBcCiAgICAgICAgICh2b2lkKTApCi0KLSNlbHNlCi0KLSNkZWZp bmUgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oYXNzZXJ0aW9uKSBBU1NFUlQoYXNz ZXJ0aW9uKQotCiAjZW5kaWYKIAogLyogQVNTRVJUX1dJVEhfTUVTU0FHRSAqLwo= 217643 2013-11-21 19:10:05 -0800 2013-11-26 19:32:37 -0800 Patch bug-124757-20131121191004.patch text/plain 3424 ayao SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTk2NjEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTExLTIxICBEcmV3IFlhbyAgPGF5YW9AYXBw bGUuY29tPgorCisgICAgICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OIHNob3Vs ZCBjcmFzaCBpbiBhIGRpc3RpbmN0IHdheS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNDc1NworCisgICAgICAgIENoYW5nZSBBU1NFUlRfV0lUSF9T RUNVUklUWV9JTVBMSUNBVElPTiB0byBhY2Nlc3MgYSBkaWZmZXJlbnQgYWRkcmVzcyBmcm9tIENS QVNIKCkKKyAgICAgICAgaW4gb3JkZXIgdG8gaGVscCBzY3JlZW4gZnV6emluZyBidWdzLgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0Fzc2Vy dGlvbnMuY3BwOgorICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisKIDIwMTMtMTEtMjAgIE1h cmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEludHJvZHVjaW5nIFZNRW50 cnlTY29wZSB0byB1cGRhdGUgdGhlIFZNIHN0YWNrIGxpbWl0LgpJbmRleDogU291cmNlL1dURi93 dGYvQXNzZXJ0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvQXNzZXJ0aW9u cy5jcHAJKHJldmlzaW9uIDE1OTY1OSkKKysrIFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zNDYsNiArMzQ2LDIwIEBAIHZvaWQgV1RGQ3Jhc2goKQogICAg ICgodm9pZCgqKSgpKTApKCk7CiAjZW5kaWYKIH0KKyAgICAKK3ZvaWQgV1RGQ3Jhc2hXaXRoU2Vj dXJpdHlJbXBsaWNhdGlvbigpCit7CisgICAgaWYgKGdsb2JhbEhvb2spCisgICAgICAgIGdsb2Jh bEhvb2soKTsKKyAgICBXVEZSZXBvcnRCYWNrdHJhY2UoKTsKKyAgICAqKGludCAqKSh1aW50cHRy X3QpMHhmYmFkYmVlZiA9IDA7CisgICAgLy8gTW9yZSByZWxpYWJsZSwgYnV0IGRvZXNuJ3Qgc2F5 IGZiYWRiZWVmLgorI2lmIENPTVBJTEVSKENMQU5HKQorICAgIF9fYnVpbHRpbl90cmFwKCk7Cisj ZWxzZQorICAgICgodm9pZCgqKSgpKTApKCk7CisjZW5kaWYKK30KIAogI2lmIEhBVkUoU0lHTkFM X0gpCiBzdGF0aWMgTk9fUkVUVVJOIHZvaWQgZHVtcEJhY2t0cmFjZVNpZ25hbEhhbmRsZXIoaW50 IHNpZykKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgJKHJldmlzaW9uIDE1OTY1OSkKKysrIFNvdXJjZS9X VEYvd3RmL0Fzc2VydGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMTY4LDYgKzE2OCwxOCBAQCBX VEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZDcmFzaCgpIE5PX1JFCiB9CiAjZW5kaWYKIAorI2lm bmRlZiBDUkFTSF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OCisjZGVmaW5lIENSQVNIX1dJVEhf U0VDVVJJVFlfSU1QTElDQVRJT04oKSBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0aW9uKCkK KyNlbmRpZgorCisjaWZkZWYgX19jcGx1c3BsdXMKK2V4dGVybiAiQyIgeworI2VuZGlmCisgICAg V1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGQ3Jhc2hXaXRoU2VjdXJpdHlJbXBsaWNhdGlvbigp IE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0g7CisjaWZkZWYgX19jcGx1c3BsdXMKK30KKyNlbmRpZgor CiAvKiBCQUNLVFJBQ0UKIAogICBQcmludCBhIGJhY2t0cmFjZSB0byB0aGUgc2FtZSBsb2NhdGlv biBhcyBBU1NFUlQgbWVzc2FnZXMuCkBAIC0yMTksNiArMjMxLDE3IEBAIGlubGluZSB2b2lkIGFz c2VydFVudXNlZChUJiB4KSB7ICh2b2lkKXgKICNkZWZpbmUgQVNTRVJUX1VOVVNFRCh2YXJpYWJs ZSwgYXNzZXJ0aW9uKSAoKHZvaWQpdmFyaWFibGUpCiAjZW5kaWYKIAorI2lmZGVmIEFERFJFU1Nf U0FOSVRJWkVSCisjZGVmaW5lIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGFzc2Vy dGlvbikgXAorICAgICghKGFzc2VydGlvbikgPyBcCisgICAgICAgIChXVEZSZXBvcnRBc3NlcnRp b25GYWlsdXJlKF9fRklMRV9fLCBfX0xJTkVfXywgV1RGX1BSRVRUWV9GVU5DVElPTiwgI2Fzc2Vy dGlvbiksIFwKKyAgICAgICAgIENSQVNIX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oKSkgOiBc CisgICAgICAgICh2b2lkKTApCisKKyNlbHNlCisjZGVmaW5lIEFTU0VSVF9XSVRIX1NFQ1VSSVRZ X0lNUExJQ0FUSU9OKGFzc2VydGlvbikgKCh2b2lkKTApCisjZW5kaWYKKwogI2Vsc2UKIAogI2Rl ZmluZSBBU1NFUlQoYXNzZXJ0aW9uKSBcCkBAIC0yNDIsMjggKzI2NSwxOSBAQCBpbmxpbmUgdm9p ZCBhc3NlcnRVbnVzZWQoVCYgeCkgeyAodm9pZCl4CiAKICNkZWZpbmUgTk9fUkVUVVJOX0RVRV9U T19BU1NFUlQgTk9fUkVUVVJOX0RVRV9UT19DUkFTSAogCi0jZW5kaWYKLQogLyogQVNTRVJUX1dJ VEhfU0VDVVJJVFlfSU1QTElDQVRJT04KLSAgIAorIAogICAgRmFpbHVyZSBvZiB0aGlzIGFzc2Vy dGlvbiBpbmRpY2F0ZXMgYSBwb3NzaWJsZSBzZWN1cml0eSB2dWxuZXJhYmlsaXR5LgogICAgQ2xh c3Mgb2YgdnVsbmVyYWJpbGl0aWVzIHRoYXQgaXQgdGVzdHMgaW5jbHVkZSBiYWQgY2FzdHMsIG91 dCBvZiBib3VuZHMKICAgIGFjY2Vzc2VzLCB1c2UtYWZ0ZXItZnJlZXMsIGV0Yy4gUGxlYXNlIGZp bGUgYSBidWcgdXNpbmcgdGhlIHNlY3VyaXR5CiAgICB0ZW1wbGF0ZSAtIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL2VudGVyX2J1Zy5jZ2k/cHJvZHVjdD1TZWN1cml0eS4KLQorIAogKi8KLSNpZmRl ZiBBRERSRVNTX1NBTklUSVpFUgotCiAjZGVmaW5lIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJ Q0FUSU9OKGFzc2VydGlvbikgXAogICAgICghKGFzc2VydGlvbikgPyBcCiAgICAgICAgIChXVEZS ZXBvcnRBc3NlcnRpb25GYWlsdXJlKF9fRklMRV9fLCBfX0xJTkVfXywgV1RGX1BSRVRUWV9GVU5D VElPTiwgI2Fzc2VydGlvbiksIFwKLSAgICAgICAgIENSQVNIKCkpIDogXAorICAgICAgICAgQ1JB U0hfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTigpKSA6IFwKICAgICAgICAgKHZvaWQpMCkKLQot I2Vsc2UKLQotI2RlZmluZSBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihhc3NlcnRp b24pIEFTU0VSVChhc3NlcnRpb24pCi0KICNlbmRpZgogCiAvKiBBU1NFUlRfV0lUSF9NRVNTQUdF ICovCg==