124749 2013-11-21 16:34:14 -0800 JSC: Removed unused opcodes from offline assembler 2013-11-21 16:43:49 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 953341 0 msaboff 2013-11-21 16:34:14 -0800 The opcodes peek and pokeq are not currently used by the LLInt and therefore are redundant. The desire to remove these at this time is due to a limitation in size of regular expressions in ruby. For the patch https://bugs.webkit.org/show_bug.cgi?id=124721 - "ARM64: Implement push/pop equivalents in LLInt" I'd like to add two new opcodes. By removing these two opcodes, we can add the opcodes in that patch. 953342 1 217627 msaboff 2013-11-21 16:41:24 -0800 Created attachment 217627 Patch 953343 2 217627 mhahnenberg 2013-11-21 16:42:34 -0800 Comment on attachment 217627 Patch r=me 953344 3 msaboff 2013-11-21 16:43:49 -0800 Committed r159654: <http://trac.webkit.org/changeset/159654> 217627 2013-11-21 16:41:24 -0800 2013-11-21 16:42:34 -0800 Patch 124749.patch text/plain 2308 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5NjUzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTExLTIxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEpTQzogUmVtb3ZlZCB1bnVzZWQgb3Bjb2RlcyBmcm9tIG9mZmxpbmUgYXNzZW1ibGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ3NDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIHRo ZSB1bnVzZWQsIFg4NiBvbmx5IHBlZWtxIGFuZCBwb2tlcS4KKworICAgICAgICAqIG9mZmxpbmVh c20vaW5zdHJ1Y3Rpb25zLnJiOgorICAgICAgICAqIG9mZmxpbmVhc20veDg2LnJiOgorCiAyMDEz LTExLTIxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFJF R1JFU1NJT04oMTU5Mzk1KSBGaXggYnJhbmNoOCjigKYsIEFic29sdXRlQWRkcmVzcywg4oCmKSBp biBBUk02NCBNYWNyb0Fzc2VtYmxlcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxp bmVhc20vaW5zdHJ1Y3Rpb25zLnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9vZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYgkocmV2aXNpb24gMTU5NjUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vaW5zdHJ1Y3Rpb25zLnJiCSh3b3JraW5nIGNvcHkp CkBAIC0yMDYsOCArMjA2LDYgQEAgTUFDUk9fSU5TVFJVQ1RJT05TID0KICAgICAgInRxcyIsCiAg ICAgICJ0cXoiLAogICAgICAidHFueiIsCi0gICAgICJwZWVrcSIsCi0gICAgICJwb2tlcSIsCiAg ICAgICJicWVxIiwKICAgICAgImJxbmVxIiwKICAgICAgImJxYSIsCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94ODYucmIKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL29mZmxpbmVhc20veDg2LnJiCShyZXZpc2lvbiAxNTk2NTIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94ODYucmIJKHdvcmtpbmcgY29weSkKQEAgLTEyODYs MTUgKzEyODYsOSBAQCBjbGFzcyBJbnN0cnVjdGlvbgogICAgICAgICB3aGVuICJwZWVrIgogICAg ICAgICAgICAgc3AgPSBSZWdpc3RlcklELm5ldyhuaWwsICJzcCIpCiAgICAgICAgICAgICAkYXNt LnB1dHMgIm1vdiN7eDg2U3VmZml4KDpwdHIpfSAje29wZXJhbmRzWzBdLnZhbHVlICogeDg2Qnl0 ZXMoOnB0cil9KCN7c3AueDg2T3BlcmFuZCg6cHRyKX0pLCAje29wZXJhbmRzWzFdLng4Nk9wZXJh bmQoOnB0cil9IgotICAgICAgICB3aGVuICJwZWVrcSIKLSAgICAgICAgICAgIHNwID0gUmVnaXN0 ZXJJRC5uZXcobmlsLCAic3AiKQotICAgICAgICAgICAgJGFzbS5wdXRzICJtb3Yje3g4NlN1ZmZp eCg6cXVhZCl9ICN7b3BlcmFuZHNbMF0udmFsdWUgKiB4ODZCeXRlcyg6cXVhZCl9KCN7c3AueDg2 T3BlcmFuZCg6cHRyKX0pLCAje29wZXJhbmRzWzFdLng4Nk9wZXJhbmQoOnF1YWQpfSIKICAgICAg ICAgd2hlbiAicG9rZSIKICAgICAgICAgICAgIHNwID0gUmVnaXN0ZXJJRC5uZXcobmlsLCAic3Ai KQogICAgICAgICAgICAgJGFzbS5wdXRzICJtb3Yje3g4NlN1ZmZpeCg6cHRyKX0gI3tvcGVyYW5k c1swXS54ODZPcGVyYW5kKDpwdHIpfSwgI3tvcGVyYW5kc1sxXS52YWx1ZSAqIHg4NkJ5dGVzKDpw dHIpfSgje3NwLng4Nk9wZXJhbmQoOnB0cil9KSIKLSAgICAgICAgd2hlbiAicG9rZXEiCi0gICAg ICAgICAgICBzcCA9IFJlZ2lzdGVySUQubmV3KG5pbCwgInNwIikKLSAgICAgICAgICAgICRhc20u cHV0cyAibW92I3t4ODZTdWZmaXgoOnF1YWQpfSAje29wZXJhbmRzWzBdLng4Nk9wZXJhbmQoOnF1 YWQpfSwgI3tvcGVyYW5kc1sxXS52YWx1ZSAqIHg4NkJ5dGVzKDpxdWFkKX0oI3tzcC54ODZPcGVy YW5kKDpwdHIpfSkiCiAgICAgICAgIHdoZW4gImNkcWkiCiAgICAgICAgICAgICAkYXNtLnB1dHMg ImNkcSIKICAgICAgICAgd2hlbiAiaWRpdmkiCg==