124746 2013-11-21 14:47:43 -0800 [CSS Regions] Use hasOverflowClip() in RenderRegion 2013-11-22 00:26:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rego rego commit-queue esprehn+autocc glenn hyatt jfernandez kondapallykalyan mihnea WebkitBugTracker oldest_to_newest 953309 0 rego 2013-11-21 14:47:43 -0800 [CSS Regions] Use hasOverflowClip() in RenderRegion 953311 1 217617 rego 2013-11-21 14:49:20 -0800 Created attachment 217617 Patch 953465 2 217617 mihnea 2013-11-22 00:15:37 -0800 Comment on attachment 217617 Patch r=me 953467 3 217617 commit-queue 2013-11-22 00:26:03 -0800 Comment on attachment 217617 Patch Clearing flags on attachment: 217617 Committed r159682: <http://trac.webkit.org/changeset/159682> 953468 4 commit-queue 2013-11-22 00:26:06 -0800 All reviewed patches have been landed. Closing bug. 217617 2013-11-21 14:49:20 -0800 2013-11-22 00:26:03 -0800 Patch bug-124746-20131121235118.patch text/plain 4412 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI0YzM1ODEwOGQ0NTQ2 YzA0NTI3MjIyMWQyZGE2ZjIwNmQwZWE0NC4uZTdlNDFlNzFiYWJkZWU5YjZlMDk4Y2I0YTg1NjI4 NDE2YTE0YzBkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTExLTIxICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgUmVn aW9uc10gVXNlIGhhc092ZXJmbG93Q2xpcCgpIGluIFJlbmRlclJlZ2lvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NzQ2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IHRoZSBzdWdnZXN0 ZWQgRklYTUUgaW4gUmVuZGVyUmVnaW9uIHVzaW5nIGhhc092ZXJmbG93Q2xpcCgpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVn aW9uOjpvdmVyZmxvd1JlY3RGb3JGbG93VGhyZWFkUG9ydGlvbik6IFVzZQorICAgICAgICBoYXNP dmVyZmxvd0NsaXAoKS4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclJlZ2lvbjo6cmVjdEZsb3dQ b3J0aW9uRm9yQm94KTogRGl0dG8uCisKIDIwMTMtMTEtMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIENhbm5vdCBzY3JvbGwgaW4g b3B0aW9uIG1lbnUgd2hlbiBpdCBsYXJnZXIgdGhhbiB0aGUgc2NyZWVuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwCmluZGV4IGE0YTE0ZTVkZDhkMmRmNmExNzAxNmUy ZmY2NjEwN2VmYTRmZThiMGYuLjk1OWFhYzFkNWM4ZjUyMjFiMTQyYjQ0YmU1Mzg5YjAxNjE5YWE5 YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwCkBAIC0xODMs MTIgKzE4Myw4IEBAIExheW91dFJlY3QgUmVuZGVyUmVnaW9uOjpvdmVyZmxvd1JlY3RGb3JGbG93 VGhyZWFkUG9ydGlvbihjb25zdCBMYXlvdXRSZWN0JiBmbG93CiB7CiAgICAgQVNTRVJUKGlzVmFs aWQoKSk7CiAKLSAgICAvLyBGSVhNRTogV291bGQgbGlrZSB0byBqdXN0IHVzZSBoYXNPdmVyZmxv d0NsaXAoKSBidXQgd2UgYXJlbid0IGEgYmxvY2sgeWV0LiBXaGVuIFJlbmRlclJlZ2lvbiBpcyBl bGltaW5hdGVkIGFuZAotICAgIC8vIGZvbGRlZCBpbnRvIFJlbmRlckJsb2NrLCBzd2l0Y2ggdG8g aGFzT3ZlcmZsb3dDbGlwKCkuCi0gICAgYm9vbCBjbGlwWCA9IHN0eWxlKCkub3ZlcmZsb3dYKCkg IT0gT1ZJU0lCTEU7Ci0gICAgYm9vbCBjbGlwWSA9IHN0eWxlKCkub3ZlcmZsb3dZKCkgIT0gT1ZJ U0lCTEU7CiAgICAgYm9vbCBpc0xhc3RSZWdpb25XaXRoUmVnaW9uRnJhZ21lbnRCcmVhayA9IChp c0xhc3RQb3J0aW9uICYmIChzdHlsZSgpLnJlZ2lvbkZyYWdtZW50KCkgPT0gQnJlYWtSZWdpb25G cmFnbWVudCkpOwotICAgIGlmICgoY2xpcFggJiYgY2xpcFkpIHx8IGlzTGFzdFJlZ2lvbldpdGhS ZWdpb25GcmFnbWVudEJyZWFrKQorICAgIGlmIChoYXNPdmVyZmxvd0NsaXAoKSB8fCBpc0xhc3RS ZWdpb25XaXRoUmVnaW9uRnJhZ21lbnRCcmVhaykKICAgICAgICAgcmV0dXJuIGZsb3dUaHJlYWRQ b3J0aW9uUmVjdDsKIAogICAgIExheW91dFJlY3QgZmxvd1RocmVhZE92ZXJmbG93ID0gb3ZlcmZs b3dUeXBlID09IFZpc3VhbE92ZXJmbG93ID8gdmlzdWFsT3ZlcmZsb3dSZWN0Rm9yQm94KG1fZmxv d1RocmVhZCkgOiBsYXlvdXRPdmVyZmxvd1JlY3RGb3JCb3gobV9mbG93VGhyZWFkKTsKQEAgLTE5 OSwxMiArMTk1LDE0IEBAIExheW91dFJlY3QgUmVuZGVyUmVnaW9uOjpvdmVyZmxvd1JlY3RGb3JG bG93VGhyZWFkUG9ydGlvbihjb25zdCBMYXlvdXRSZWN0JiBmbG93CiAgICAgaWYgKG1fZmxvd1Ro cmVhZC0+aXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSkgewogICAgICAgICBMYXlvdXRVbml0IG1p blkgPSBpc0ZpcnN0UG9ydGlvbiA/IChmbG93VGhyZWFkT3ZlcmZsb3cueSgpIC0gb3V0bGluZVNp emUpIDogZmxvd1RocmVhZFBvcnRpb25SZWN0LnkoKTsKICAgICAgICAgTGF5b3V0VW5pdCBtYXhZ ID0gaXNMYXN0UG9ydGlvbiA/IHN0ZDo6bWF4KGZsb3dUaHJlYWRQb3J0aW9uUmVjdC5tYXhZKCks IGZsb3dUaHJlYWRPdmVyZmxvdy5tYXhZKCkpICsgb3V0bGluZVNpemUgOiBmbG93VGhyZWFkUG9y dGlvblJlY3QubWF4WSgpOworICAgICAgICBib29sIGNsaXBYID0gc3R5bGUoKS5vdmVyZmxvd1go KSAhPSBPVklTSUJMRTsKICAgICAgICAgTGF5b3V0VW5pdCBtaW5YID0gY2xpcFggPyBmbG93VGhy ZWFkUG9ydGlvblJlY3QueCgpIDogc3RkOjptaW4oZmxvd1RocmVhZFBvcnRpb25SZWN0LngoKSwg Zmxvd1RocmVhZE92ZXJmbG93LngoKSAtIG91dGxpbmVTaXplKTsKICAgICAgICAgTGF5b3V0VW5p dCBtYXhYID0gY2xpcFggPyBmbG93VGhyZWFkUG9ydGlvblJlY3QubWF4WCgpIDogc3RkOjptYXgo Zmxvd1RocmVhZFBvcnRpb25SZWN0Lm1heFgoKSwgKGZsb3dUaHJlYWRPdmVyZmxvdy5tYXhYKCkg KyBvdXRsaW5lU2l6ZSkpOwogICAgICAgICBjbGlwUmVjdCA9IExheW91dFJlY3QobWluWCwgbWlu WSwgbWF4WCAtIG1pblgsIG1heFkgLSBtaW5ZKTsKICAgICB9IGVsc2UgewogICAgICAgICBMYXlv dXRVbml0IG1pblggPSBpc0ZpcnN0UG9ydGlvbiA/IChmbG93VGhyZWFkT3ZlcmZsb3cueCgpIC0g b3V0bGluZVNpemUpIDogZmxvd1RocmVhZFBvcnRpb25SZWN0LngoKTsKICAgICAgICAgTGF5b3V0 VW5pdCBtYXhYID0gaXNMYXN0UG9ydGlvbiA/IHN0ZDo6bWF4KGZsb3dUaHJlYWRQb3J0aW9uUmVj dC5tYXhYKCksIGZsb3dUaHJlYWRPdmVyZmxvdy5tYXhYKCkpICsgb3V0bGluZVNpemUgOiBmbG93 VGhyZWFkUG9ydGlvblJlY3QubWF4WCgpOworICAgICAgICBib29sIGNsaXBZID0gc3R5bGUoKS5v dmVyZmxvd1koKSAhPSBPVklTSUJMRTsKICAgICAgICAgTGF5b3V0VW5pdCBtaW5ZID0gY2xpcFkg PyBmbG93VGhyZWFkUG9ydGlvblJlY3QueSgpIDogc3RkOjptaW4oZmxvd1RocmVhZFBvcnRpb25S ZWN0LnkoKSwgKGZsb3dUaHJlYWRPdmVyZmxvdy55KCkgLSBvdXRsaW5lU2l6ZSkpOwogICAgICAg ICBMYXlvdXRVbml0IG1heFkgPSBjbGlwWSA/IGZsb3dUaHJlYWRQb3J0aW9uUmVjdC5tYXhZKCkg OiBzdGQ6Om1heChmbG93VGhyZWFkUG9ydGlvblJlY3QueSgpLCAoZmxvd1RocmVhZE92ZXJmbG93 Lm1heFkoKSArIG91dGxpbmVTaXplKSk7CiAgICAgICAgIGNsaXBSZWN0ID0gTGF5b3V0UmVjdCht aW5YLCBtaW5ZLCBtYXhYIC0gbWluWCwgbWF4WSAtIG1pblkpOwpAQCAtNjY1LDEwICs2NjMsOCBA QCBMYXlvdXRSZWN0IFJlbmRlclJlZ2lvbjo6cmVjdEZsb3dQb3J0aW9uRm9yQm94KGNvbnN0IFJl bmRlckJveCogYm94LCBjb25zdCBMYXlvdQogICAgICAgICAgICAgbWFwcGVkUmVjdC5zZXRXaWR0 aChzdGQ6Om1heDxMYXlvdXRVbml0PigwLCBzdGQ6Om1pbjxMYXlvdXRVbml0Pihsb2dpY2FsQm90 dG9tRm9yRmxvd1RocmVhZENvbnRlbnQoKSAtIG1hcHBlZFJlY3QueCgpLCBtYXBwZWRSZWN0Lndp ZHRoKCkpKSk7CiAgICAgfQogCi0gICAgYm9vbCBjbGlwWCA9IHN0eWxlKCkub3ZlcmZsb3dYKCkg IT0gT1ZJU0lCTEU7Ci0gICAgYm9vbCBjbGlwWSA9IHN0eWxlKCkub3ZlcmZsb3dZKCkgIT0gT1ZJ U0lCTEU7CiAgICAgYm9vbCBpc0xhc3RSZWdpb25XaXRoUmVnaW9uRnJhZ21lbnRCcmVhayA9IChp c0xhc3RSZWdpb24oKSAmJiAoc3R5bGUoKS5yZWdpb25GcmFnbWVudCgpID09IEJyZWFrUmVnaW9u RnJhZ21lbnQpKTsKLSAgICBpZiAoKGNsaXBYICYmIGNsaXBZKSB8fCBpc0xhc3RSZWdpb25XaXRo UmVnaW9uRnJhZ21lbnRCcmVhaykKKyAgICBpZiAoaGFzT3ZlcmZsb3dDbGlwKCkgfHwgaXNMYXN0 UmVnaW9uV2l0aFJlZ2lvbkZyYWdtZW50QnJlYWspCiAgICAgICAgIG1hcHBlZFJlY3QuaW50ZXJz ZWN0KGZsb3dUaHJlYWRQb3J0aW9uUmVjdCgpKTsKIAogICAgIHJldHVybiBtYXBwZWRSZWN0Lmlz RW1wdHkoKSA/IG1hcHBlZFJlY3QgOiBtX2Zsb3dUaHJlYWQtPm1hcEZyb21GbG93VGhyZWFkVG9M b2NhbChib3gsIG1hcHBlZFJlY3QpOwo=