124742 2013-11-21 13:09:56 -0800 [EFL][GTK][WK2] Build fix after r159641 2013-11-21 14:26:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124732 1 sergio sergio cgarcia commit-queue gustavo mrobinson ossy oldest_to_newest 953257 0 sergio 2013-11-21 13:09:56 -0800 [EFL][GTK][WK2] Build fix after r159641 953259 1 217604 sergio 2013-11-21 13:12:02 -0800 Created attachment 217604 Patch 953262 2 commit-queue 2013-11-21 13:13:40 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 953264 3 217604 ossy 2013-11-21 13:16:10 -0800 Comment on attachment 217604 Patch It is a trivial buildfix, so it doesn't need owner review, r=me. 953270 4 ossy 2013-11-21 13:32:12 -0800 I tried to commit it manually, but the SVN server is dead again. :( 953289 5 sergio 2013-11-21 13:59:32 -0800 (In reply to comment #4) > I tried to commit it manually, but the SVN server is dead again. :( Ouch. It seems to be working again, though, according to ap on #webkit. 953299 6 217604 ossy 2013-11-21 14:26:13 -0800 Comment on attachment 217604 Patch Clearing flags on attachment: 217604 Committed r159646: <http://trac.webkit.org/changeset/159646> 953300 7 ossy 2013-11-21 14:26:19 -0800 All reviewed patches have been landed. Closing bug. 217604 2013-11-21 13:12:02 -0800 2013-11-21 14:26:13 -0800 Patch bug-124742-20131121181147.patch text/plain 3515 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzA1NjI0NzU5MzIxMTU5 Y2Y5MDQyODBhNTlmMDRkMzg4MWQ3Y2ZmYy4uNDJjNGE1ODA5NmYwZGVmOWQxYTRiNDU3ZTY2NGM2 MWM2OTVhZjI1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTExLTIxICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW0VG TF1bR1RLXVtXSzJdIEJ1aWxkIGZpeCBhZnRlciByMTU5NjQxCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ3NDIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaG91bGQgZmV0Y2ggYWN0aXZlVVJMIGZyb20g cGFnZSBsb2FkIHN0YXRlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlldy5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3VXBkYXRlVVJJKToKKyAgICAgICAgKiBV SVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL2VmbC9XZWJJbnNwZWN0b3JTZXJ2ZXJFZmwuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JTZXJ2ZXI6OmJ1aWxkUGFnZUxpc3QpOgorICAg ICAgICAqIFVJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvZ3RrL1dlYkluc3BlY3RvclNlcnZlckd0 ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclNlcnZlcjo6YnVpbGRQYWdlTGlz dCk6CisKIDIwMTMtMTEtMjEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K IAogICAgICAgICBGZXRjaCBhbGwgcGFnZSBsb2FkaW5nIHJlbGF0ZWQgVVJMcyBmcm9tIHRoZSBw YWdlIGxvYWQgc3RhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlldy5jcHAKaW5kZXggOTgxMGQ4NzExYzE0OGFjMjA2MDE0ZWQ5MjkyZmZiNzAw ZjU1NTRlNi4uN2ExZGI5OTI0MjFjYjZlYzljOWJmYzkzNjAyNjIyY2YzYTk1MmYwZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAK QEAgLTE1ODQsNyArMTU4NCw3IEBAIHZvaWQgd2Via2l0V2ViVmlld1NldEVzdGltYXRlZExvYWRQ cm9ncmVzcyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBkb3VibGUgZXN0aW1hCiAKIHZvaWQgd2Vi a2l0V2ViVmlld1VwZGF0ZVVSSShXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogewotICAgIENTdHJp bmcgYWN0aXZlVVJJID0gZ2V0UGFnZSh3ZWJWaWV3KS0+YWN0aXZlVVJMKCkudXRmOCgpOworICAg IENTdHJpbmcgYWN0aXZlVVJJID0gZ2V0UGFnZSh3ZWJWaWV3KS0+cGFnZUxvYWRTdGF0ZSgpLmFj dGl2ZVVSTCgpLnV0ZjgoKTsKICAgICBpZiAod2ViVmlldy0+cHJpdi0+YWN0aXZlVVJJID09IGFj dGl2ZVVSSSkKICAgICAgICAgcmV0dXJuOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL2VmbC9XZWJJbnNwZWN0b3JTZXJ2ZXJFZmwuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9lZmwvV2ViSW5zcGVjdG9y U2VydmVyRWZsLmNwcAppbmRleCBhM2JhMDE5MzEzNjVlYjQ3M2I2OGI0MDY5NmQxYjhlNDUxYTVk MTJiLi5mZTEzMDgzMGIwMmZkOGVkODU2YzY3YjIyZWNhYmM1OGVmY2JlZmYwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL2VmbC9XZWJJbnNwZWN0 b3JTZXJ2ZXJFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0b3JT ZXJ2ZXIvZWZsL1dlYkluc3BlY3RvclNlcnZlckVmbC5jcHAKQEAgLTkyLDcgKzkyLDcgQEAgdm9p ZCBXZWJJbnNwZWN0b3JTZXJ2ZXI6OmJ1aWxkUGFnZUxpc3QoVmVjdG9yPGNoYXI+JiBkYXRhLCBT dHJpbmcmIGNvbnRlbnRUeXBlKQogICAgICAgICBidWlsZGVyLmFwcGVuZExpdGVyYWwoIiwgXCJ0 aXRsZVwiOiBcIiIpOwogICAgICAgICBidWlsZGVyLmFwcGVuZCh3ZWJQYWdlLT5wYWdlVGl0bGUo KSk7CiAgICAgICAgIGJ1aWxkZXIuYXBwZW5kTGl0ZXJhbCgiXCIsIFwidXJsXCI6IFwiIik7Ci0g ICAgICAgIGJ1aWxkZXIuYXBwZW5kKHdlYlBhZ2UtPmFjdGl2ZVVSTCgpKTsKKyAgICAgICAgYnVp bGRlci5hcHBlbmQod2ViUGFnZS0+cGFnZUxvYWRTdGF0ZSgpLmFjdGl2ZVVSTCgpKTsKICAgICAg ICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCJcIiwgXCJpbnNwZWN0b3JVcmxcIjogXCIiKTsKICAg ICAgICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCIvTWFpbi5odG1sP3BhZ2U9Iik7CiAgICAgICAg IGJ1aWxkZXIuYXBwZW5kTnVtYmVyKGl0LT5rZXkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9ndGsvV2ViSW5zcGVjdG9yU2VydmVyR3RrLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvZ3RrL1dlYkluc3Bl Y3RvclNlcnZlckd0ay5jcHAKaW5kZXggNzEwNTgxZWEwZDk1YmM3MjU1MjBjZTU2MzQ0YmY2ODYz MTRkY2MzMC4uZTEyZWJjZmI0OTVlNTU3MTg5NDY0ZDcyNGVmNzEyODQyMWE5NmNlMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9ndGsvV2ViSW5z cGVjdG9yU2VydmVyR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVj dG9yU2VydmVyL2d0ay9XZWJJbnNwZWN0b3JTZXJ2ZXJHdGsuY3BwCkBAIC0xMDQsNyArMTA0LDcg QEAgdm9pZCBXZWJJbnNwZWN0b3JTZXJ2ZXI6OmJ1aWxkUGFnZUxpc3QoVmVjdG9yPGNoYXI+JiBk YXRhLCBTdHJpbmcmIGNvbnRlbnRUeXBlKQogICAgICAgICBidWlsZGVyLmFwcGVuZExpdGVyYWwo IiwgXCJ0aXRsZVwiOiBcIiIpOwogICAgICAgICBidWlsZGVyLmFwcGVuZCh3ZWJQYWdlLT5wYWdl VGl0bGUoKSk7CiAgICAgICAgIGJ1aWxkZXIuYXBwZW5kTGl0ZXJhbCgiXCIsIFwidXJsXCI6IFwi Iik7Ci0gICAgICAgIGJ1aWxkZXIuYXBwZW5kKHdlYlBhZ2UtPmFjdGl2ZVVSTCgpKTsKKyAgICAg ICAgYnVpbGRlci5hcHBlbmQod2ViUGFnZS0+cGFnZUxvYWRTdGF0ZSgpLmFjdGl2ZVVSTCgpKTsK ICAgICAgICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCJcIiwgXCJpbnNwZWN0b3JVcmxcIjogXCIi KTsKICAgICAgICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCIvTWFpbi5odG1sP3BhZ2U9Iik7CiAg ICAgICAgIGJ1aWxkZXIuYXBwZW5kTnVtYmVyKGl0LT5rZXkpOwo=