124741 2013-11-21 13:09:30 -0800 Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard 2013-11-21 15:41:57 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates psolanki oldest_to_newest 953256 0 dbates 2013-11-21 13:09:30 -0800 Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused when building without feature NETWORK_CFDATA_ARRAY_CALLBACK. 953263 1 dbates 2013-11-21 13:15:54 -0800 (In reply to comment #0) > Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused when building without feature NETWORK_CFDATA_ARRAY_CALLBACK. *building with 953266 2 217606 dbates 2013-11-21 13:16:47 -0800 Created attachment 217606 Patch 953273 3 217606 ap 2013-11-21 13:39:00 -0800 Comment on attachment 217606 Patch It's kind of wrong that USE(NETWORK_CFDATA_ARRAY_CALLBACK) affects the behavior of SharedBuffer::append(const char* data, unsigned length). That has nothing to do with CFArrayRef data chunks! 953319 4 dbates 2013-11-21 15:19:18 -0800 Committed r159650: <http://trac.webkit.org/changeset/159650> 953322 5 psolanki 2013-11-21 15:41:57 -0800 (In reply to comment #3) > (From update of attachment 217606 [details]) > It's kind of wrong that USE(NETWORK_CFDATA_ARRAY_CALLBACK) affects the behavior of SharedBuffer::append(const char* data, unsigned length). That has nothing to do with CFArrayRef data chunks! Yeah, enabling that define also disables the segmented buffer approach that we have in SharedBuffer (which was added in bug 33178). See bug 77715 and r154823 where I made the data array and segments be mutually exclusive. 217606 2013-11-21 13:16:47 -0800 2013-11-21 13:38:59 -0800 Patch bug-124741-20131121131646.patch text/plain 1992 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODJjNTE2ODkwZDUzNWNh NzlmZDJmYTQ3NzgxZGZhYmE2NjVjZTFkNy4uNDkwMmI0ZmM5NDU2ZTI5Zjk3YmFiN2I2Y2FlMTE5 MmUzYTIyZDQwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTExLTIxICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBBZGQgIVVTRShORVRXT1JL X0NGREFUQV9BUlJBWV9DQUxMQkFDSyktZ3VhcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDc0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCAhVVNFKE5FVFdPUktfQ0ZEQVRBX0FSUkFZX0NBTExC QUNLKS1ndWFyZCBhcm91bmQgY29kZSB0aGF0IGlzIHVudXNlZAorICAgICAgICB3aGVuIGJ1aWxk aW5nIHdpdGggZmVhdHVyZSBORVRXT1JLX0NGREFUQV9BUlJBWV9DQUxMQkFDSy4KKworICAgICAg ICBBZGRpdGlvbmFsbHksIGFkZCBhIGRlY2xhcmF0aW9uIGZvciBhbGxvY2F0ZVNlZ21lbnQoKSB3 aXRoIGF0dHJpYnV0ZSBXQVJOX1VOVVNFRF9SRVRVUk4KKyAgICAgICAgdG8gaGF2ZSB0aGUgY29t cGlsZXIgd2FybiB3aGVuIHRoZSByZXR1cm4gdmFsdWUgb2YgdGhpcyBmdW5jdGlvbiBpcyB1bnVz ZWQuIFRvZ2V0aGVyIHdpdGgKKyAgICAgICAgd2FybmluZ3MgdHJlYXRlZCBhcyBlcnJvcnMgdGhp cyBjaGFuZ2Ugd2lsbCBwcmV2ZW50IGEgbWVtb3J5IGxlYWsuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9TaGFyZWRCdWZmZXIuY3BwOgorCisyMDEzLTExLTIxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVz QGFwcGxlLmNvbT4KKwogICAgICAgICBSZW1vdmUgdW51c2VkIGZ1bmN0aW9ucyBmcm9tIFdlYkNv cmUgYW5kIFdlYktpdDIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyNDczOQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFy ZWRCdWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcApp bmRleCBhNWQ5NTViZGMyNzlhYzBhYmUwNGViMWQ2MjI1ZTc4YTBlMzBhY2FiLi4zMGUyNGZiNzI4 YWY1MTRmMjAwZGQ5NzczMWZjMWQ3NDQ0OTE3NzE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1NoYXJlZEJ1ZmZlci5jcHAKQEAgLTM4LDYgKzM4LDcgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUg ewogCisjaWYgIVVTRShORVRXT1JLX0NGREFUQV9BUlJBWV9DQUxMQkFDSykKIHN0YXRpYyBjb25z dCB1bnNpZ25lZCBzZWdtZW50U2l6ZSA9IDB4MTAwMDsKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBz ZWdtZW50UG9zaXRpb25NYXNrID0gMHgwRkZGOwogCkBAIC01MSw2ICs1Miw3IEBAIHN0YXRpYyBp bmxpbmUgdW5zaWduZWQgb2Zmc2V0SW5TZWdtZW50KHVuc2lnbmVkIHBvc2l0aW9uKQogICAgIHJl dHVybiBwb3NpdGlvbiAmIHNlZ21lbnRQb3NpdGlvbk1hc2s7CiB9CiAKK3N0YXRpYyBpbmxpbmUg Y2hhciogYWxsb2NhdGVTZWdtZW50KCkgV0FSTl9VTlVTRURfUkVUVVJOOwogc3RhdGljIGlubGlu ZSBjaGFyKiBhbGxvY2F0ZVNlZ21lbnQoKQogewogICAgIHJldHVybiBzdGF0aWNfY2FzdDxjaGFy Kj4oZmFzdE1hbGxvYyhzZWdtZW50U2l6ZSkpOwpAQCAtNjAsNiArNjIsNyBAQCBzdGF0aWMgaW5s aW5lIHZvaWQgZnJlZVNlZ21lbnQoY2hhciogcCkKIHsKICAgICBmYXN0RnJlZShwKTsKIH0KKyNl bmRpZgogCiBTaGFyZWRCdWZmZXI6OlNoYXJlZEJ1ZmZlcigpCiAgICAgOiBtX3NpemUoMCkK