124739 2013-11-21 13:00:54 -0800 Remove unused functions from WebCore and WebKit2 2013-11-21 15:18:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates andersca sam oldest_to_newest 953249 0 dbates 2013-11-21 13:00:54 -0800 We should remove the following unused functions: In file Source/WebCore/editing/markup.cpp: - isHTMLBlockElement() - ancestorToRetainStructureAndAppearanceWithNoRenderer() In file Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm: - autoreleased(WKURLRequestRef) - autoreleased(WKURLResponseRef) 953250 1 217603 dbates 2013-11-21 13:04:05 -0800 Created attachment 217603 Patch 953318 2 dbates 2013-11-21 15:18:19 -0800 Committed r159649: <http://trac.webkit.org/changeset/159649> 217603 2013-11-21 13:04:05 -0800 2013-11-21 13:35:35 -0800 Patch bug-124739-20131121130404.patch text/plain 4607 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQzZjQ4YWQ0YTc5MDk2 ZmQ1OGVmYzEwMDRkZWMyYTU4MzcwNGJjYy4uODJjNTE2ODkwZDUzNWNhNzlmZDJmYTQ3NzgxZGZh YmE2NjVjZTFkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDEzLTExLTIxICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBSZW1vdmUgdW51c2VkIGZ1 bmN0aW9ucyBmcm9tIFdlYkNvcmUgYW5kIFdlYktpdDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDczOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZWRpdGluZy9tYXJrdXAuY3BwOiBSZW1vdmUgdW51 c2VkIGZ1bmN0aW9ucyBpc0hUTUxCbG9ja0VsZW1lbnQgYW5kCisgICAgICAgIGFuY2VzdG9yVG9S ZXRhaW5TdHJ1Y3R1cmVBbmRBcHBlYXJhbmNlV2l0aE5vUmVuZGVyZXIuCisgICAgICAgICogcmVu ZGVyaW5nL0lubGluZUVsZW1lbnRCb3guY3BwOiBBcHBlbmQgbmV3bGluZSB0byB0aGUgZW5kIG9m IHRoZSBmaWxlLgorCisyMDEzLTExLTIxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNv bT4KKwogICAgICAgICBPbmx5IGdlbmVyYXRlIGlzT2JzZXJ2YWJsZSgpIHdoZW4gSURMIHNwZWNp ZmllcyBHZW5lcmF0ZUlzUmVhY2hhYmxlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjQ3MjkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDk2YzAxNGYyZjVmNTRhNjE1 Nzg5NzdkYWYwZjIzMjU0ZjE4ZjVhZDIuLmI3OWI5NTg0NmRhYzdjYTczMTg0ZWIwYjBjM2RiYWFl ZmUwYTA2ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0xMS0yMSAgRGFuaWVs IEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBmdW5j dGlvbnMgZnJvbSBXZWJDb3JlIGFuZCBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ3MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW51c2VkIGZ1bmN0aW9ucyBhdXRvcmVsZWFz ZWQoe1dLVVJMUmVxdWVzdFJlZiwgV0tVUkxSZXNwb25zZVJlZn0pLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyLm1tOgorCiAyMDEzLTEx LTIwICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgbW9y ZSBpbmZyYXN0cnVjdHVyZSBmb3IgU2VydmVyQ29ubmVjdGlvbiBjb21tdW5pY2F0aW9uIGJldHdl ZW4gV2ViIGFuZCBEYXRhYmFzZSBwcm9jZXNzZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvbWFya3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcApp bmRleCBkMmU3NWMzMGJlMjQxOWRjODUzM2VjNGQ1OGE2NGQzNTlhMzI5N2E2Li42MDYyNGRmY2I3 ZmQ3ZWZiNWIxNmJjNGZlODFiNWYzZTg2ZTM2YmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL21hcmt1cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAu Y3BwCkBAIC00MzAsMTMgKzQzMCw2IEBAIE5vZGUqIFN0eWxlZE1hcmt1cEFjY3VtdWxhdG9yOjp0 cmF2ZXJzZU5vZGVzRm9yU2VyaWFsaXphdGlvbihOb2RlKiBzdGFydE5vZGUsIE5vCiAgICAgcmV0 dXJuIGxhc3RDbG9zZWQ7CiB9CiAKLXN0YXRpYyBib29sIGlzSFRNTEJsb2NrRWxlbWVudChjb25z dCBOb2RlKiBub2RlKQotewotICAgIHJldHVybiBub2RlLT5oYXNUYWdOYW1lKHRkVGFnKQotICAg ICAgICB8fCBub2RlLT5oYXNUYWdOYW1lKHRoVGFnKQotICAgICAgICB8fCBpc05vblRhYmxlQ2Vs bEhUTUxCbG9ja0VsZW1lbnQobm9kZSk7Ci19Ci0KIHN0YXRpYyBOb2RlKiBhbmNlc3RvclRvUmV0 YWluU3RydWN0dXJlQW5kQXBwZWFyYW5jZUZvckJsb2NrKE5vZGUqIGNvbW1vbkFuY2VzdG9yQmxv Y2spCiB7CiAgICAgaWYgKCFjb21tb25BbmNlc3RvckJsb2NrKQpAQCAtNDYxLDEyICs0NTQsNiBA QCBzdGF0aWMgaW5saW5lIE5vZGUqIGFuY2VzdG9yVG9SZXRhaW5TdHJ1Y3R1cmVBbmRBcHBlYXJh bmNlKE5vZGUqIGNvbW1vbkFuY2VzdG9yKQogICAgIHJldHVybiBhbmNlc3RvclRvUmV0YWluU3Ry dWN0dXJlQW5kQXBwZWFyYW5jZUZvckJsb2NrKGVuY2xvc2luZ0Jsb2NrKGNvbW1vbkFuY2VzdG9y KSk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgTm9kZSogYW5jZXN0b3JUb1JldGFpblN0cnVjdHVyZUFu ZEFwcGVhcmFuY2VXaXRoTm9SZW5kZXJlcihOb2RlKiBjb21tb25BbmNlc3RvcikKLXsKLSAgICBO b2RlKiBjb21tb25BbmNlc3RvckJsb2NrID0gZW5jbG9zaW5nTm9kZU9mVHlwZShmaXJzdFBvc2l0 aW9uSW5PckJlZm9yZU5vZGUoY29tbW9uQW5jZXN0b3IpLCBpc0hUTUxCbG9ja0VsZW1lbnQpOwot ICAgIHJldHVybiBhbmNlc3RvclRvUmV0YWluU3RydWN0dXJlQW5kQXBwZWFyYW5jZUZvckJsb2Nr KGNvbW1vbkFuY2VzdG9yQmxvY2spOwotfQotCiBzdGF0aWMgYm9vbCBwcm9wZXJ0eU1pc3NpbmdP ckVxdWFsVG9Ob25lKFN0eWxlUHJvcGVydHlTZXQqIHN0eWxlLCBDU1NQcm9wZXJ0eUlEIHByb3Bl cnR5SUQpCiB7CiAgICAgaWYgKCFzdHlsZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9JbmxpbmVFbGVtZW50Qm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9J bmxpbmVFbGVtZW50Qm94LmNwcAppbmRleCAyMTI2MTI4ZWU5MmQ0OWY3YThiODUyNjc4ZWY2NmU5 NWVhZmU4NzhmLi5jNTEzM2FkZWQxNDI2MjdiMGNhZDY2MDg4NjE4YzZmNDVjNzk3ZmZlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lRWxlbWVudEJveC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUVsZW1lbnRCb3guY3BwCkBAIC0xMDIs NCArMTAyLDQgQEAgYm9vbCBJbmxpbmVFbGVtZW50Qm94Ojpub2RlQXRQb2ludChjb25zdCBIaXRU ZXN0UmVxdWVzdCYgcmVxdWVzdCwgSGl0VGVzdFJlc3VsdCYKICAgICByZXR1cm4gcmVuZGVyZXIo KS5oaXRUZXN0KHJlcXVlc3QsIHJlc3VsdCwgbG9jYXRpb25JbkNvbnRhaW5lciwgY2hpbGRQb2lu dCk7CiB9CiAKLX0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCit9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xs ZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS0Jyb3dzaW5nQ29udGV4 dENvbnRyb2xsZXIubW0KaW5kZXggMDFjOWYzNmQyYjM4NjUzYzUzZjU5MzFkOTJiYjlhMjUxMGEy MGFiMS4uYTk5ZDM5NDM3NDNmMmNlZTdiZTgwMjM4ZjAxZTc0NGIzMTRhYTMzYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRDb250 cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLQnJvd3Np bmdDb250ZXh0Q29udHJvbGxlci5tbQpAQCAtNjQsMTYgKzY0LDYgQEAgc3RhdGljIGlubGluZSBO U1VSTCAqYXV0b3JlbGVhc2VkKFdLVVJMUmVmIHVybCkKICAgICByZXR1cm4gdXJsID8gQ0ZCcmlk Z2luZ1JlbGVhc2UoV0tVUkxDb3B5Q0ZVUkwoa0NGQWxsb2NhdG9yRGVmYXVsdCwgYWRvcHRXSyh1 cmwpLmdldCgpKSkgOiBuaWw7CiB9CiAKLXN0YXRpYyBpbmxpbmUgTlNVUkxSZXF1ZXN0ICphdXRv cmVsZWFzZWQoV0tVUkxSZXF1ZXN0UmVmIHVybFJlcXVlc3QpCi17Ci0gICAgcmV0dXJuIHVybFJl cXVlc3QgPyBDRkJyaWRnaW5nUmVsZWFzZShXS1VSTFJlcXVlc3RDb3B5TlNVUkxSZXF1ZXN0KGFk b3B0V0sodXJsUmVxdWVzdCkuZ2V0KCkpKSA6IG5pbDsKLX0KLQotc3RhdGljIGlubGluZSBOU1VS TFJlc3BvbnNlICphdXRvcmVsZWFzZWQoV0tVUkxSZXNwb25zZVJlZiB1cmxSZXNwb25zZSkKLXsK LSAgICByZXR1cm4gdXJsUmVzcG9uc2UgPyBDRkJyaWRnaW5nUmVsZWFzZShXS1VSTFJlc3BvbnNl Q29weU5TVVJMUmVzcG9uc2UoYWRvcHRXSyh1cmxSZXNwb25zZSkuZ2V0KCkpKSA6IG5pbDsKLX0K LQogTlNTdHJpbmcgKiBjb25zdCBXS0FjdGlvbklzTWFpbkZyYW1lS2V5ID0gQCJXS0FjdGlvbklz TWFpbkZyYW1lS2V5IjsKIE5TU3RyaW5nICogY29uc3QgV0tBY3Rpb25OYXZpZ2F0aW9uVHlwZUtl eSA9IEAiV0tBY3Rpb25OYXZpZ2F0aW9uVHlwZUtleSI7CiBOU1N0cmluZyAqIGNvbnN0IFdLQWN0 aW9uTW91c2VCdXR0b25LZXkgPSBAIldLQWN0aW9uTW91c2VCdXR0b25LZXkiOwo=