124730 2013-11-21 11:38:32 -0800 check-webkit-style is wrong about expected format for std::function variables 2024-03-14 15:04:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson lmoura bburg cgarcia lmoura webkit-bug-importer oldest_to_newest 953199 0 beidson 2013-11-21 11:38:32 -0800 check-webkit-style is wrong about expected format for std::function variables. Seen in the patch(es) attached to https://bugs.webkit.org/show_bug.cgi?id=124698 - Source/WebKit2/Shared/AsyncRequest.h:60: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/Shared/AsyncRequest.h:78: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/Shared/AsyncRequest.h:89: Extra space before ( in function call [whitespace/parens] [4] The lines in question are: static PassRefPtr<AsyncRequest> create(std::function<void (Arguments...)> completionHandler) AsyncRequestImpl(std::function<void (Arguments...)> completionHandler) std::function<void (Arguments...)> m_completionHandler; The style-checker needs to know that when "something that looks like a function decl/def" is inside std::function<> brackets, the space before the paren is expected. 997488 1 llango.u-szeged 2014-04-04 00:03:54 -0700 *** Bug 131202 has been marked as a duplicate of this bug. *** 2019268 2 lmoura 2024-03-06 20:58:08 -0800 Pull request: https://github.com/WebKit/WebKit/pull/25567 2021140 3 ews-feeder 2024-03-14 15:03:03 -0700 Committed 276122@main (b3871d2a862c): <https://commits.webkit.org/276122@main> Reviewed commits have been landed. Closing PR #25567 and removing active labels. 2021142 4 webkit-bug-importer 2024-03-14 15:04:18 -0700 <rdar://problem/124640815>